apol closed this revision.
apol added a comment.
Landed, don't know why this didn't update.
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D19111
To: apol, #dolphin, #frameworks, nicolasfella
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
apol added a comment.
https://commits.kde.org/purpose/a6d93ff28f090dd0086301884a31e0eea0efd845
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D19111
To: apol, #dolphin, #frameworks, nicolasfella
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
nicolasfella accepted this revision.
nicolasfella added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:3
> +find_package(KF5Notifications COMPONENTS)
> +if (NOT KF5KIO_FOUND OR NOT KF5Notifications_FOUND)
> +return()
Maybe move the check
apol updated this revision to Diff 52218.
apol added a comment.
Remove unrelated debug info
REPOSITORY
R495 Purpose Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19111?vs=51940=52218
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19111
AFFECTED FILES
ngraham added inline comments.
INLINE COMMENTS
> menu.cpp:84
> });
> +connect(this, ::finished, this, [this]{ qDebug() << "omgomgomg" <<
> this; });
> }
Is this necessary? If so, maybe it should have a more descriptive string...
REPOSITORY
R495 Purpose Library
REVISION DETAIL
apol created this revision.
apol added reviewers: Dolphin, Frameworks, nicolasfella.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
BUG: 397567
TEST PLAN
Manual testing on dolphin
REPOSITORY
