D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect

[Fabian Vogt]

fvogt abandoned this revision.
fvogt added a comment.


  D22758  got merged

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D21606

To: fvogt
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect

[Aleix Pol Gonzalez]

apol added a comment.


  I need this additionally
  
diff --git a/src/runnermanager.cpp b/src/runnermanager.cpp
index f92830d..6ec0c3c 100644
--- a/src/runnermanager.cpp
+++ b/src/runnermanager.cpp
@@ -345,6 +345,7 @@ public:
 emit q->matchesChanged(context.matches());
 }
 
+teardownRequested = true;
 checkTearDown();
 }
 
@@ -833,6 +834,7 @@ void RunnerManager::reset()
 }
 
 d->context.reset();
+emit queryFinished();
 }
 
 } // Plasma namespace
  
  With this it works quite reliably for me.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D21606

To: fvogt
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect

[David Edmundson]

davidedmundson added a comment.


  https://bugs.kde.org/show_bug.cgi?id=381835

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D21606

To: fvogt
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect

[Fabian Vogt]

fvogt created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  ThreadWeaver Job Decorators don't actually hook into an existing job.
  Instead, they provide the same interface as the job and just pass through
  all calls.
  
  The way the QObjectDecorator is used by KRunner results in no signals actually
  getting emitted, making most of the code pointless.
  
  This patch is just a quick hack to show what would happen if the jobDone 
signal
  worked and is mostly intended to present the issue.

TEST PLAN
  jobDone is called now.

REPOSITORY
  R308 KRunner

BRANCH
  hack

REVISION DETAIL
  https://phabricator.kde.org/D21606

AFFECTED FILES
  src/runnerjobs.cpp

To: fvogt
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns