D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. In D21721#602167 , @aacid wrote: > FWIW this broke artikulate since you changed the expected entry for engine: in KNS.ItemsModel Ah, would've been wy easier to work out what you were talking about if you

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

aacid added a comment. FWIW this broke artikulate since you changed the expected entry for engine: in KNS.ItemsModel REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: aacid, cfeck, davidedmundson,

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R304:140c0d0b7be8: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets) (authored by leinir). CHANGED PRIOR TO

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. Right, unless i hear otherwise, i'm going to push this 13:00 CEST (that is, in three hours). I realise this is short notice, but the patch has also been sitting here since before Akademy. REPOSITORY R304 KNewStuff REVISION DETAIL

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. In D21721#538404 , @cfeck wrote: > I would suggest to commit it either sooner, or after 5.63 is tagged. If you commit on 3rd, there are only two days to test and decide how to improve or revert before tars are made.

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

cfeck added a comment. I would suggest to commit it either sooner, or after 5.63 is tagged. If you commit on 3rd, there are only two days to test and decide how to improve or revert before tars are made. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To:

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir added a comment. Alrighty, quick chat somewhere else, and i'm going to have to call silent agreement on this one - unless i hear things to the contrary, i'm going to merge this next week (that is, 2nd or 3rd of October 2019) so we can get a bit more wide-spread testing done on it

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 66876. leinir added a comment. Ping @Frameworks - new cycle, chunky thing, be good to get it in early :) - Since 5.63 now that 5.62 is out the door REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

ahiemstra added inline comments. INLINE COMMENTS > leinir wrote in Button.qml:112 > Humhum, yes... so it needs to be possible to change enabled from outside, but > it also needs to be locked to disabled if allowedByKiosk is false... i'm > thinking this probably won't be the prettiest thing,

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir requested review of this revision. leinir added a comment. Ping for some of the frameworks peeps... would be great to get this in sooner rather than later :) INLINE COMMENTS > ahiemstra wrote in author.cpp:37 > Suggestion: It might make sense to do this caching at the provider level

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 66529. leinir added a comment. - Fix some whitespace issues REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=66368=66529 BRANCH knsquick-feature-parity-with-kns (branched from master) REVISION DETAIL

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 66368. leinir marked 7 inline comments as done. leinir added a comment. Address comments by @ahiemstra - roleNames to static const and initialiser list (and qcdebug++) - Fix a documentation oops - roleNames to static const - Quick todo for KF6

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. I went over it again and found a few more small things and also added some suggestions. Feel free to apply or ignore the suggestions. Once the other items have been taken care of, I

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 6 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65696. leinir marked 2 inline comments as done. leinir added a comment. - Add a simple cache for CommentsModel instances REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=65689=65696 BRANCH

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 3 inline comments as done. leinir added inline comments. INLINE COMMENTS > broulik wrote in author.h:111 > `ProfilePage`? In principle yes, except we can't change homepage to homePage, until KF6... and then we'd end up with mixed spelling styles, and that just makes me sad ;) >

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65689. leinir marked 3 inline comments as done. leinir added a comment. Address comments by Kai Uwe and David - Use QQmlParserStatus to ensure we don't do unnecessary work - Get rid of all the extraneous data entries (also a couple of other bits)

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

davidedmundson added inline comments. INLINE COMMENTS > author.h:37 > + */ > +class Author : public QObject > +{ Use of QQmlParserStatus would help here. It means we can defer initial resetConnections until all 3 initial properties are set. REPOSITORY R304 KNewStuff REVISION DETAIL

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

broulik added inline comments. INLINE COMMENTS > author.h:111 > + */ > +void setProfilepage(const QString ); > + `ProfilePage`? > commentsmodel.cpp:184 > +default: > +value.setValue(i18nc("The value returned for an unknown role > when requesting data from

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65579. leinir added a comment. - Add a getter for the first provider (usually the default) - Get the default provider, if one is not yet set - Handle the multi-provider scenario REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65506. leinir added a comment. - Also catch the error messages from the non-deprecated error function - Equalize border colour with Breeze REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=65236=65506 BRANCH

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65236. leinir added a comment. - Make sure to import the right version of newstuff REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=65219=65236 BRANCH knsquick-feature-parity-with-kns (branched from master)

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 65219. leinir added a comment. - Whole lot of @since-ing - Adopt Qt-style KF5-version-aligned import versioning REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=64986=65219 BRANCH

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 2 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64986. leinir marked 18 inline comments as done. leinir added a comment. - Fiddle with the downloaditems sheet layout a touch REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=64979=64986 BRANCH

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64979. leinir added a comment. - Switch to using a FileDialog-like property for changedEntries REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=64978=64979 BRANCH knsquick-feature-parity-with-kns (branched

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in atticaprovider.cpp:355 > Fair enough. I do try to make sure to use vectors as much as possible in new > API, but consistency is also a good argument. :) Think i might just pop in a TODO

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64978. leinir added a comment. - Add a kf6 todo item (our api's QListey and should become QVectory) - Adopt a more pleasant comments layout REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=64934=64978 BRANCH

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

ahiemstra added inline comments. INLINE COMMENTS > leinir wrote in atticaprovider.cpp:355 > That'd be good, except the rest of the KNewStuff API is all QList based. > It'll want doing for KF6, but since QList is being deprecated for that > anyway, i'm thinking we'll end up with a general

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64934. leinir added a comment. - Debug-- - Ensure data is actually loaded properly, also from cache - Include the right header - Adapt the Discover comments delegate (and add a nesting indicator) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64855. leinir marked 11 inline comments as done. leinir added a comment. Address comments by @ahiemstra - Add a comment about why Button's configfile isn't aliased - Set the object ownership policy for QuickQuestionListener to cpp -

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 12 inline comments as done. leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in atticaprovider.cpp:355 > Since upstream Qt is starting to discourage usage of QList, maybe use QVector > instead. That'd be good, except the rest of the KNewStuff API is all QList

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. I have probably missed stuff, but here are my initial comments. INLINE COMMENTS > atticaprovider.cpp:355 > + > +QList> getCommentsList(const > Attica::Comment::List ,

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir retitled this revision from "[WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)" to "Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)". leinir edited the summary of this revision. leinir edited the test plan for this revision. leinir added reviewers: