D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. I forgot to link the fix here: D24880 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

meven added a comment. The new bug https://bugs.kde.org/show_bug.cgi?id=413117 mentions this as well : > kio-5.63 makes kdav-19.08.2 fail with HTTP error (400) > > STEPS TO REPRODUCE > Install the mentioned packages. Try to connect to a davical server via https. > > RESULT

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause added a comment. In D24316#552541 , @dfaure wrote: > Can I just ignore the Depth from the custom http headers instead? > > --- i/src/ioslaves/http/http.cpp > +++ w/src/ioslaves/http/http.cpp > @@ -172,7 +172,8 @@ static

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. Can I just ignore the Depth from the custom http headers instead? --- i/src/ioslaves/http/http.cpp +++ w/src/ioslaves/http/http.cpp @@ -172,7 +172,8 @@ static QString sanitizeCustomHTTPHeader(const QString &_header) if

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause added a comment. In D24316#552528 , @dfaure wrote: > I'm on the Applications/19.08 git branch, which shouldn't get broken by a newer KF5 release. > > Your patch works for Content-Type, but the duplicated Depth still leads to "Bad

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. I'm on the Applications/19.08 git branch, which shouldn't get broken by a newer KF5 release. Your patch works for Content-Type, but the duplicated Depth still leads to "Bad request". Where does the second Depth come from? I see one at line 2411, I guess the

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause added a comment. Overall we probably have two options, revert this change (and the corresponding change in KDAV) and defer it to KF6, or harden this code further against duplicates in custom headers. The below might work for Content-Type (no way to test here atm), a similar fix for

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause added a comment. Which version of KDAV do you have? master or some older release? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. `Depth: 1` is duplicated too. I tried adding a contentType.isEmpty() check, but it is actually empty. Needs more debugging REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n,

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. This commit completely breaks the davgroupware resource for me (to access kolab calendars via CALDAV). REPORT requests get a 400 Bad Request error from the server. 2019-10-22T12:35:15 kio_http(12004)/kf5.kio.kio_http HTTPProtocol::sendQuery:

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9713ea02e49e: Consider the usage of WebDAV methods sufficient for assuming WebDAV (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah I see, `the hacks in KDAV::DavManager` is the context :) REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc:

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. Test Plan: ? Did you see this in a specific application? Just to have some context about why/when this occurs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY So far WebDAV only really works when using webdav[s]: URLs, which is an unexpected