D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

This revision was automatically updated to reflect the committed changes. Closed by commit R241:591cc2a16e3e: Treat application/x-ms-dos-executable as executable on all platforms (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n,

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe marked an inline comment as done. guoyunhe added inline comments. INLINE COMMENTS > dfaure wrote in krun.cpp:1101 > should this be in ifdef Q_OS_WIN? > > On windows, *.exe is executed, not opened (with e.g. wine) Yes, I updated this part. REPOSITORY R241 KIO REVISION DETAIL

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe updated this revision to Diff 67761. guoyunhe added a comment. *.exe should be normal executable in Windows REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24463?vs=67458=67761 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krun.cpp:1101 > +return ExecutableFileOpenDialog::OpenOrExecute; > +} else if >

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

GB_2 added inline comments. INLINE COMMENTS > ppeter wrote in executablefileopendialog.cpp:58 > if (mode == OnlyExecute) > connect(executeButton, ...) > else if (mode == OpenAsExecute) > ... > > looks better :) That would be against the common KDE coding style:

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ppeter added inline comments. INLINE COMMENTS > executablefileopendialog.cpp:58 > + > +if (mode == OnlyExecute) { > +connect(executeButton, ::clicked, > [=]{done(ExecuteFile);}); if (mode == OnlyExecute) connect(executeButton, ...) else if (mode == OpenAsExecute) ...

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe edited the summary of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe retitled this revision from "WIP: Treat "application/x-ms-dos-executable" as executable on all platforms" to "Treat "application/x-ms-dos-executable" as executable on all platforms". guoyunhe edited the summary of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe updated this revision to Diff 67444. guoyunhe added a comment. "openAsExecute" parameter for ExecutableFileOpenDialog REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24463?vs=67424=67444 BRANCH master REVISION DETAIL

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a comment. I just realized that this patch might be unfinished. In the pop up, you usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually to be executed by Wine? "Execute" will do nothing because it isn't a native executable for Linux/BSD. REPOSITORY

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ngraham accepted this revision. ngraham added a subscriber: dfaure. ngraham added a comment. This revision is now accepted and ready to land. I suppose that's true. Would be nice to also do that as a follow-up patch. Shipit! @dfaure given the security implications here, maybe we

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a comment. In D24463#543070 , @ngraham wrote: > Maybe can we check to see if WINE is installed or if there's a handler for `application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, won't you see a dialog that

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ngraham added a comment. Maybe can we check to see if WINE is installed or if there's a handler for `application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, won't you see a dialog that gives you the option to execute it when that doesn't work? REPOSITORY R241 KIO

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

broulik added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY Because of Wine, *.exe can be executed in almost all desktop platforms. BUG: 412694 REPOSITORY R241 KIO BRANCH