D24980: Port ssl_cert_errors meta data from KSslError to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d074873f4703: Port ssl_cert_errors meta data from KSslError to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69534&id=69536

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella accepted this revision. REPOSITORY R241 KIO BRANCH pending REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause, nicolasfella Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause updated this revision to Diff 69534. vkrause added a comment. bump the right version numbers, sorry REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69531&id=69534 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella added inline comments. INLINE COMMENTS > ksslinfodialog.h:113 > > -static QList > errorsFromString(const QString > &s); > +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64) > +/** @deprecated since 5.64, use certificateErrorsFromString */ You missed a spot REPOSITORY R241 KIO

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause updated this revision to Diff 69531. vkrause added a comment. bump deprecation version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69526&id=69531 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED FILES src/c

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella added inline comments. INLINE COMMENTS > ksslinfodialog.h:113 > > -static QList > errorsFromString(const QString > &s); > +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64) > +/** @deprecated since 5.64, use certificateErrorsFromString */ Shouldn't this be 65 now? REPOSITORY

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause updated this revision to Diff 69526. vkrause added a comment. rebase to latest master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69514&id=69526 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED FILES src/core/

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause updated this revision to Diff 69514. vkrause added a comment. add comment requested during review REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=68817&id=69514 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED FILES

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

ahmadsamir added inline comments. INLINE COMMENTS > vkrause wrote in jobuidelegate.cpp:365 > sslMetaData is a QMap, ie. value() has no QLatin1String > overload, calling it with a QLatin1String will work but convert to a QString > at runtime (involving a memory allocation), using QStringLiteral

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause added inline comments. INLINE COMMENTS > ahmadsamir wrote in jobuidelegate.cpp:365 > Nitpick, wouldn't QLatin1String be better here? > > c.f. Marc Mutz's talk about QStringLiteral and QLatin1String: > https://youtu.be/Ov7s0GgBbOQ?t=2806 sslMetaData is a QMap, ie. value() has no QLatin1

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

ahmadsamir added inline comments. INLINE COMMENTS > jobuidelegate.cpp:365 > > sslMetaData.value(QStringLiteral("ssl_cipher_bits")).toInt(), > - > KSslInfoDialog::errorsFromString(sslMetaData.value(QStringLiteral("ssl_cert_errors"; > +

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Code looks sane to me and builds. Haven't done any testing though REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause, nicolas

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause added a comment. anyone? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The TCPSlaveBase side of this can be fully ported to QSslError once D24928 is in