D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven added a comment. In D25010#632977 , @kossebau wrote: > In D25010#632835 , @dfaure wrote: > > > Yes, either prefixes or the C++11 way with enum class. > > > I propose to go with prefixes

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added a comment. In D25010#632835 , @dfaure wrote: > Yes, either prefixes or the C++11 way with enum class. I propose to go with prefixes again, for consistency with currrent enum usages in KF/KIO APIs. REPOSITORY R241 KIO

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. Yes, either prefixes or the C++11 way with enum class. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in global.h:320 > This injects generic terms like `Basic`, `User`, `Time`, `Acl`, etc. into the > KIO namespace, with no futher hint that these belong to this very enum, > resulting in

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added inline comments. INLINE COMMENTS > global.h:320 > + */ > +enum StatDetail { > +/// No field returned, useful to check if a file exists This injects generic terms like `Basic`, `User`, `Time`, `Acl`, etc. into the KIO namespace, with no futher hint that these belong to this

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in statjob.h:203 > Ah, was already fixed. 5434ffd0c655b0996e881fec605dc988a672d85c REPOSITORY R241 KIO REVISION

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added a comment. In D25010#626677 , @mlaurent wrote: > Did you test to compile with flags == 5.68.0 ? > I tested it with kdepim and I need to adapt it. > -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054400 is 5.68.0 ? You also

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in statjob.h:203 > This wants to be "5, 69" now, not "5, 68" Ah, was already fixed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: mlaurent, dalbers,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added inline comments. INLINE COMMENTS > statjob.h:203 > + > +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 68) > /** This wants to be "5, 69" now, not "5, 68" REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: mlaurent,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

mlaurent added a comment. Did you test to compile with flags == 5.68.0 ? I tested it with kdepim and I need to adapt it. -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054400 is 5.68.0 ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. @mlaurent compilation is broken because a method got deprecated, and you set -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06 so the use of that method no longer compiles. You can hardly blame other people for deprecating methods, it's a rather natural thing to do at

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

mlaurent added a comment. "/compile/kde5/framework/kde/kdegames/kjumpingcube/game.cpp:582:63: erreur: impossible de convertir « KIO::StatJob::DestinationSide » de «  KIO::StatJob::StatSide » vers « KIO::JobFlags » {aka « QFlags »} 582 | KIO::StatJob* statJob = KIO::stat(url,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. Fixed in https://commits.kde.org/kio/440bec1b3524f168fc04898a09ac51457c79ed3b REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dalbers added a comment. This doesn't seem to compile: [ 26%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o cd /usr/src/kio-git/src/build/src/ioslaves/file && /usr/lib/ccache/bin/c++ -DKCOMPLETION_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054100

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9537bca2b542: [StatJob] Use A QFlag to specify the details returned by StatJob (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=77386=77460

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. Yep, that's what "Accepted" means ;) REPOSITORY R241 KIO BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven added a comment. Ok to merge ? REPOSITORY R241 KIO BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 77386. meven added a comment. Improve comment of StatJob *statDetails REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=77385=77386 BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 77385. meven added a comment. Fix typo, make StatJob::setDetails(KIO::StatDetail detail) build only when build_deprecated(5.69) is set REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=77235=77385 BRANCH

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Huh. Sorry about the delays and the need to update version numbers once more. My last two comments are still not fixed. To see the issues, grep for "direcly" ('t' missing) and "Details

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 77235. meven added a comment. Get code ready for 5.69, I really HOPE that the last time I have to do this, remove a few qDebug(), add some test assertions, make test more reliable REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 75740. meven added a comment. Add an assertion to JobTest::stat()^Ccomment out other tests debug output REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=75567=75740 BRANCH arcpatch-D25010_2 REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 75567. meven marked an inline comment as done. meven added a comment. Make setDetails(KIO::StatDetail detail) compile only when deprecated since 5.68 is enabled REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 75566. meven marked 3 inline comments as done. meven added a comment. Add a test for setDetails(KIO::StatDetails), fix comment, add a KIOCORE_ENABLE_DEPRECATED_SINCE REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > statjob.cpp:97 > + > +void StatJob::setDetails(short int details) > +{ When the declaration is in #if, the definition should be too (with s/ENABLED/BUILD/).

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 75304. meven added a comment. This revision is now accepted and ready to land. Fix implementation having a statDetails function to distinguish from the original function, fix and adapt test, in file_unix when using statx reduce the field retrieved for

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven planned changes to this revision. meven added a comment. I have tried adding unit tests. It showed that the old: ` *stat(const QUrl , KIO::StatJob::StatSide side, short int details, JobFlags flags = DefaultFlags);` Takes over the new : `KIO::stat(const QUrl &, KIO::StatSide,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 71864. meven marked 2 inline comments as done. meven added a comment. Replace use of KIOCORE_ENABLE_DEPRECATED_SINCE by KIOCORE_BUILD_DEPRECATED_SINCE in cpp files REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kossebau wrote in directorysizejob.cpp:137 > More correct would be KIOCORE_BUILD_DEPRECATED_SINCE(5, 65)., not ENABLE here > and in the other cpp files.

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 71703. meven added a comment. Fix Two references to KF 5.65 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=71702=71703 BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 71702. meven added a comment. Fix Two references to KF 5,65 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=71701=71702 BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 71701. meven added a comment. Rebase for kio 5.66 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70669=71701 BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED FILES

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70669. meven marked an inline comment as done. meven added a comment. Fix: | instead of & to build a QFlags REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70543=70669 BRANCH arcpatch-D25010 REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > directorysizejob.cpp:141 > +#endif > +listJob->addMetaData(QStringLiteral("statDetails"), > QString::number(KIO::StatDetail::Basic &

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70543. meven added a comment. Do not forget to get UDS_DEVICE_ID UDS_INODE REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70522=70543 BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added inline comments. INLINE COMMENTS > meven wrote in directorysizejob.cpp:137 > The previous code did (details of 3) I'm confused by what you mean here... and I think I found more problems: Indeed the old code used 3. In your patch, you changed this to 2, in the legacy field for old

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in directorysizejob.cpp:137 > Now that I look at this again, we do NOT want to follow symlinks here. > > This was a bug in the existing code. > > In Dolphin we want to display the size of the

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70522. meven added a comment. Rebasing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70521=70522 BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED FILES

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70521. meven added a comment. Lower the amount of data pulled by directory size job (avoids resolving symlinks notably) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70088=70521 BRANCH arcpatch-D25010_1

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. In D25010#565502 , @meven wrote: > Funny thing is that statx includes always the name, down to syscall we can save at most

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven added a comment. In D25010#565421 , @dfaure wrote: > Hmm, I meant Name is always useful when *listing*. But when *stating*, we don't always need to get the name back. The NoDetails comment is about a stat that really can just

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70088. meven added a comment. Add NoDetails to StatDetail, add StatJob::setDetails\(KIO::StatDetail detail\), small comment update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70051=70088 BRANCH

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. Isn't it simpler to commit as is, so we can just s/ENABLE/BUILD/ in *.cpp files once we add support for EXCLUDE_DEPRECATED_BEFORE_AND_AT? Faster than having to figure out where is the implementation of each method to exclude. REPOSITORY R241 KIO BRANCH

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added a comment. Ah, EXCLUDE_DEPRECATED_BEFORE_AND_AT is not yet available with KIO (compare the TODO next to the ecm_generate_export_header call). So as result also the BUILD macros are not available. Using instead the ENABLE macros in the sources of the library instead does not

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

kossebau added inline comments. INLINE COMMENTS > directorysizejob.cpp:137 > KIO::ListJob *listJob = KIO::listRecursive(url, KIO::HideProgressInfo); > -listJob->addMetaData(QStringLiteral("details"), QStringLiteral("3")); > +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 65) > +// TODO KF6:

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Hmm, I meant Name is always useful when *listing*. But when *stating*, we don't always need to get the name back. The NoDetails comment is about a stat that really can just succeed/fail.

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70051. meven marked 8 inline comments as done. meven added a comment. Typos, rephrase a comment, move FileProtocol::getStatDetails to file.cpp, add a TODO for in file_win.cpp REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. About granularity: I think it's fine. I was about to say that the use case of a recursive listing to calculate directory size only needs type and size, but it actually needs name

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 5 inline comments as done. meven added a comment. friendly ping Is https://phabricator.kde.org/D25010#inline-142132 satisfactory ? I think names are now explicit enough. I still wonder if the granularity level is enough. REPOSITORY R241 KIO REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven added a comment. I feel the code is ready for review toward merging. INLINE COMMENTS > global.h:321 > +/// Filename, access, type, size, linkdest > +StatBasic = 0x1, > +/// uid, gid Naming should be explicit enough now. I still wonder about granularity if I should expose

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 69385. meven marked an inline comment as done. meven added a comment. Add Stat prefix to enum values of KIO::StatDetail REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=69261=69385 BRANCH arcpatch-D25010 REVISION

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 69261. meven added a comment. Move KIO::StatJob::StatDetail(s) to KIO::StatDetail(s), wrapped old details metadata code path with KIOCORE_ENABLE_DEPRECATED_SINCE REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. You could use KIOCORE_ENABLE_DEPRECATED_SINCE(5, 65) to already put in place the trigger for the compat code to disappear when KF6 comes around, like you did in file_unix.cpp. It will also make it easier for the future developer who cleans this up. I mean

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 69181. meven added a comment. Allow retro-compatibility with old details both ways : old kio or old app, update comments to ready patch for KF 5.65 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=69023=69181 BRANCH

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven planned changes to this revision. meven added a comment. I don't expect this to make to KF5.64, will update the @since and all. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 69023. meven added a comment. Use StatDetail to reduce statx mask, support old details metadata in file ioslave, adding metadata statDetails for the new values REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven planned changes to this revision. meven added a comment. In D25010#556237 , @dfaure wrote: > If you change the actual values being sent to kioslaves, then this breaks the "wire protocol". I.e. after upgrading KF5 on a live system,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 69021. meven marked 3 inline comments as done. meven added a comment. Avoid using short and testFlag REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68975=69021 BRANCH arcpatch-D25010 REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. If you change the actual values being sent to kioslaves, then this breaks the "wire protocol". I.e. after upgrading KF5 on a live system, kioslaves (started by kdeinit5 forking

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven retitled this revision from "[StatJob] Use A QFlag to specify the details returned by statJob" to "[StatJob] Use A QFlag to specify the details returned by StatJob". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc:

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven updated this revision to Diff 68975. meven added a comment. Move KIO::StatDefaultDetails to KIO::StatJob::StatDefaultDetails REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68973=68975 BRANCH arcpatch-D25010 REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven added a comment. In D25010#555890 , @kossebau wrote: > Now that is a quick turn-around, +1 for doing the work :) > > No time myself to look at this closely the next days, also not that much into KIO, but here some quick feedback with

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in statjob.h:181 > I wonder if this should not be rather a member of StatJob, instead of being > on generic KIO namespace level. > It feels unbalanced to have the enum being in the class, but a util flag set > not. Actually,

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven updated this revision to Diff 68973. meven added a comment. Fix jobs details argument passing and fix setDetails(int) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68971=68973 BRANCH arcpatch-D25010 REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

kossebau added inline comments. INLINE COMMENTS > jobremotetest.cpp:70 > { > -KIO::Job *job = KIO::stat(url, KIO::StatJob::DestinationSide, 0, > KIO::HideProgressInfo); > +KIO::Job *job = KIO::stat(url, KIO::StatJob::DestinationSide, > KIO::StatJob::Basic, KIO::HideProgressInfo); >

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven updated this revision to Diff 68971. meven marked an inline comment as done. meven added a comment. Wrap setDetails with #if KIOCORE_ENABLE_DEPRECATED_SINCE, use the new API throughout the rest of KIO REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

kossebau added inline comments. INLINE COMMENTS > statjob.h:96 > + > /** > * Selects the level of @p details we want. All deprecated API should be also wrapped in visibility controls., so same #if/#endif also here. Basic structure: if deprecated api should be visible to compiler

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven updated this revision to Diff 68969. meven marked 8 inline comments as done. meven added a comment. Rename StatJob::Detail to StatJob::StatDetail, KIO::DefaultDetails to KIO::StatDefaultDetails, add deprecation doc and macro REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

kossebau added a comment. Now that is a quick turn-around, +1 for doing the work :) No time myself to look at this closely the next days, also not that much into KIO, but here some quick feedback with an API police hat on. Would be also good to have some patches which make use of

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven updated this revision to Diff 68893. meven added a comment. Fix wrong comparison REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68892=68893 BRANCH stat-qflags REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED FILES

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven retitled this revision from "Use A QFlag to specify the details returned by statJob" to "[StatJob] Use A QFlag to specify the details returned by statJob". meven added reviewers: Frameworks, dfaure, kossebau. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To:

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

meven updated this revision to Diff 68892. meven added a comment. Amend commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=68890=68892 BRANCH stat-qflags REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED FILES