D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann abandoned this revision. cullmann added a comment. I have now a working version that handles palette changes, too. https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/79 + usage in Kate https://invent.kde.org/utilities/kate/-/merge_requests/204 We

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. I need to finalize this, people start to complain more and more about this missing on Windows for Kate/etc... ;( REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

vonreth added a comment. In D25119#676781 , @cullmann wrote: > Hmm, I don't think you need a theme chooser, we just need to watch for the palette change signal and then trigger again the theme name setting based on the background palette. >

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. Hmm, I don't think you need a theme chooser, we just need to watch for the palette change signal and then trigger again the theme name setting based on the background palette. That would be enough to detect bright/dark mode. REPOSITORY R266 Breeze Icons

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

brute4s99 added subscribers: nicolasfella, brute4s99. brute4s99 added a comment. +1 to adding the breeze icons support for other OSes. (Thanks @nicolasfella for linking me to this diff). I have hit the same problem with the KDE Connect Windows port. Thank you for working on it!

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

vonreth added a comment. And change those during runtime REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l Cc: aboyer, sars, wrobelda, davidedmundson, broulik, rempt,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

vonreth added a comment. Yea my idea didn't make much sense. Reading your comment I realized that we should probably implement a theme chooser in a kf5 and provide the themes as plugins, that way we could also provide other themes, not just breeze. REPOSITORY R266 Breeze Icons REVISION

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

aboyer added a comment. From my limited understanding of the theming system for KDE applications on Windows, the application needs to expose a drop down menu with a list of themes so that a user can switch to their desired theme. Even if we linked a disabled version of the library and

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

vonreth added a comment. I love it. Could we add a option to the exported target, so that you can basically always link that library with out an effect, until a cmake flag is set? This way we can bring it to all applications and enable it from craft. -DENABLE_BREEZE_BINARY_THEME=ON (or

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. I think exporting some namespaced function or such that will do the setting of the theme and calling it would be ok for me. This is anyways an "opt-in" approach people must decide to use. Hannah, what do you think? REPOSITORY R266 Breeze Icons REVISION DETAIL

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

aboyer added a comment. I've tested this patch since I'd really like to use Kate with the dark theme on Windows. I built Kate on Windows using Craft, added KF5::BreezeIcons as a dependency for the kate-bin target, and set the QIcon theme name in the KateColorSchemeChooser class. This did

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

wrobelda added a comment. @cullmann I will do my best to try and test it with KMyMoney this coming weekend. I'll keep you posted. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l Cc:

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. That depends. If somebody else would test this and we can agree that this is a nicer way to hard-code breeze icons compared to having that code in kiconthemes it would make sense. REPOSITORY R266 Breeze Icons REVISION DETAIL

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

wrobelda added a comment. @cullmann is this still planned to be released? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l Cc: wrobelda, davidedmundson, broulik, rempt,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann updated this revision to Diff 74839. cullmann added a comment. set normal or dark icons based on current palette REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25119?vs=69194=74839 BRANCH arcpatch-D25119 REVISION DETAIL

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. As soon as we use the rcc file for the icons, we set an icon theme name. If you have an icon theme name set, QIcon::fromTheme will do: bool hasUserTheme = QIconLoader::instance()->hasUserTheme(); QIconEngine * const engine = (platformTheme &&

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. Ok, I traced this now a bit. The KIconLoaderPrivate::createIconImage processing seems already not to work for resource based themes on Linux. To try, e.g. use Kate, add the binary resource icon theme to the right location cp

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. In D25119#558092 , @broulik wrote: > In D25119#558084 , @cullmann wrote: > > > Hmm, where does that happen? > > >

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

broulik added a subscriber: davidedmundson. broulik added a comment. In D25119#558084 , @cullmann wrote: > Hmm, where does that happen? https://cgit.kde.org/kiconthemes.git/tree/src/kiconloader.cpp#n888 > And does that work for icons

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. In D25119#558082 , @broulik wrote: > > If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found. > > But why would you need this anyway? At least with `KIconEngine` we colorize the

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

broulik added a comment. > If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found. But why would you need this anyway? At least with `KIconEngine` we colorize the icons dynamically. I don't have to switch to breeze-dark when I use a dark color scheme on

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. This patch will still need some work to make dark mode available. Kate will be able to switch to it via the color theme switcher, as that will just switch over to breeze-dark. Could you elaborate on "Also, our icon loading has kind of evolved and we've

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

rempt added a comment. It sounds like it would be something very useful and easy to use. Right now, we package all icons Krita uses in rc files that are compiled in as well. Also, our icon loading has kind of evolved and we've got a bit of code for switching between dark and light icons

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. This patch by itself will not make the dark mode work, but e.g. Kate will be able to use it as the color theme chooser will set breeze-dark as theme and the icons will be "there". Beside this, it avoids loading 20MB of data, as before the resource file got loaded

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

ndavis added a comment. I'm not sure if my review is really necessary since I lack the technical expertise to know what the right solution is, but +1 to light and dark Breeze icon support on other platforms. REPOSITORY R266 Breeze Icons REVISION DETAIL

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

ngraham added reviewers: ndavis, mart, alex-l. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l Cc: broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. At the moment, the hack in kiconthemes only allows to load one theme. This means you have just "breeze". If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found. REPOSITORY R266 Breeze Icons REVISION DETAIL

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

broulik added a comment. Can you expand on that dark theme issue? We just colorize the same SVGs as needed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt Cc: broulik, rempt, kde-frameworks-devel,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. At the moment this patch will only create the shared lib if we have binary resources configured. One could always create the lib and only compile in the resources if wanted. That would allow e.g. applications like Kate to always link against this on all

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a reviewer: rempt. cullmann added a subscriber: rempt. cullmann added a comment. Perhaps @rempt has some input on this, for the cross-platform aspects. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added reviewers: Frameworks, vonreth, dfaure. cullmann added a comment. Some reviewers. I am not sure this is the "perfect" solution, but it will make deploying applications a lot easier given just linking against this library provides the icons most of them will need. And

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY At the moment, one big problem for non-unices is the deployment of icons Close to all things in KDE stuff relies on