D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

This revision was automatically updated to reflect the committed changes. Closed by commit R304:f1f439cbef94: Give some more pretty feedback in NewStuff::Page while the Engine is loading (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH be-more-friendly-during-initial-load (branched from master) REVISION DETAIL https://phabricator.kde.org/D25173 To: leinir, #knewstuff, #frameworks, ngraham, #vdg Cc:

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir updated this revision to Diff 69399. leinir added a comment. - Merge branch 'master' into be-more-friendly-during-initial-load - Add a bit of @since REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25173?vs=69383=69399 BRANCH

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir added a dependent revision: D25197: Show a "Loading more..." busy indicator when loading view data. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25173 To: leinir, #knewstuff, #frameworks, ngraham, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir added a comment. In D25173#559588 , @ngraham wrote: > I still see "Loading Data" in a passiveNotification as well as in text under the loading indicator. i'm seeing a couple of bits which really probably want to be turned into

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

ngraham added a comment. I still see "Loading Data" in a passiveNotification as well as in text under the loading indicator. Do we really need the passiveNotifications at all? I think we can probably improve the user experience vy removing them entirely. For example instead of "Loading one

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir updated this revision to Diff 69383. leinir added a comment. - Merge branch 'master' into be-more-friendly-during-initial-load - Don't show the passive notification for already shown messages REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

ngraham added a comment. Now you don't need those PassiveNotifications anymore, because otherwise you wind up with duplicate messages: F7745214: loading.png REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25173 To:

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir edited the summary of this revision. leinir edited the test plan for this revision. leinir added reviewers: KNewStuff, Frameworks, ngraham, VDG. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25173 To: leinir, #knewstuff, #frameworks, ngraham, #vdg Cc:

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This adds an isLoading property to KNSQuick::Engine, and that is used to show a busy indicator (with descriptive label)