D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:f1f439cbef94: Give some more pretty feedback in 
NewStuff::Page while the Engine is loading (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25173?vs=69399=69445

REVISION DETAIL
  https://phabricator.kde.org/D25173

AFFECTED FILES
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/Page.qml
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  be-more-friendly-during-initial-load (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25173

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 69399.
leinir added a comment.


  - Merge branch 'master' into be-more-friendly-during-initial-load
  - Add a bit of @since

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25173?vs=69383=69399

BRANCH
  be-more-friendly-during-initial-load (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25173

AFFECTED FILES
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/Page.qml
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

leinir added a dependent revision: D25197: Show a "Loading more..." busy 
indicator when loading view data.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25173

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D25173#559588 , @ngraham wrote:
  
  > I still see "Loading Data" in a passiveNotification as well as in text 
under the loading indicator.
  
  
  i'm seeing a couple of bits which really probably want to be turned into 
something else (but as separate diffs, as i'm not really keen on this ending up 
yet another several-months-long saga):
  
  - Loading data (which should really just be an inline item (probably the 
footer) with a spinner to indicate when the model is fetching more items)
  - Loading one preview (which is basically just debug information and should 
be turned into that)
  
  > Do we really need the passiveNotifications at all? I think we can probably 
improve the user experience vy removing them entirely. For example instead of 
"Loading one preview" we can just show individual loading indicators on the 
previews themselves
  
  i'm afraid we do - as you might gather from that short list above, there's an 
enormous amount of of these bits of information being thrown back from the 
engine, and until we're certain we have captured all of them by some other 
method (and removed the noise), we really can't just get rid of it. (yes, i 
realise how much you dislike[1] them, and i'm quite happy to move towards 
removing them, we just can't do it by just straight up removing them entirely. 
We also can't simply replace it with a dialog box either, because /some/ are 
informational and can be safely ignored, while some are important, and there's 
no straightforward way to tell which is which)
  
  [1] was going to say hate, but it's a terribly strong term, and i feel like 
we probably need to reserve it for things which actually deserve that strength 
;)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25173

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Nathaniel Graham]

ngraham added a comment.


  I still see "Loading Data" in a passiveNotification as well as in text under 
the loading indicator. Do we really need the passiveNotifications at all? I 
think we can probably improve the user experience vy removing them entirely. 
For example instead of "Loading one preview" we can just show individual 
loading indicators on the previews themselves

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25173

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 69383.
leinir added a comment.


  - Merge branch 'master' into be-more-friendly-during-initial-load
  - Don't show the passive notification for already shown messages

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25173?vs=69348=69383

BRANCH
  be-more-friendly-during-initial-load (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25173

AFFECTED FILES
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/Page.qml
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Nathaniel Graham]

ngraham added a comment.


  Now you don't need those PassiveNotifications anymore, because otherwise you 
wind up with duplicate messages:
  
  F7745214: loading.png 

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25173

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.
leinir edited the test plan for this revision.
leinir added reviewers: KNewStuff, Frameworks, ngraham, VDG.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25173

To: leinir, #knewstuff, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This adds an isLoading property to KNSQuick::Engine, and that is used
  to show a busy indicator (with descriptive label) when engine is loading.

REPOSITORY
  R304 KNewStuff

BRANCH
  be-more-friendly-during-initial-load (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25173

AFFECTED FILES
  src/qtquick/qml/Page.qml
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns