kossebau added inline comments.
INLINE COMMENTS
> kconfigloader.cpp:87
> +
> +if (reader.isEndDocument())
> +return false;
This logic is inverted., no? We should be at token document end when
reader.atEnd() turns true. In any case on successful parse this condition is
met here and
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:87471e14b370: QXmlInputSource is deprecated in qt5.15.
Port it to QXmlStreamReader (authored by mlaurent).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
port_QXmlStreamReader (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26890
To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2,
mlaurent updated this revision to Diff 74428.
mlaurent added a comment.
Use QStringRef here too
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26890?vs=74406=74428
BRANCH
port_QXmlStreamReader (branched from master)
REVISION DETAIL
apol added inline comments.
INLINE COMMENTS
> kconfigloader.cpp:125
> for (int i = 0; i < numAttrs; ++i) {
> -QString name = attrs.localName(i).toLower();
> +const QString name = attrs.at(i).name().toString().toLower();
> if (name ==
mlaurent updated this revision to Diff 74406.
mlaurent added a comment.
Use QStringRef::compare
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26890?vs=74349=74406
BRANCH
port_QXmlStreamReader (branched from master)
REVISION DETAIL
mlaurent marked 4 inline comments as done.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D26890
To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
apol added inline comments.
INLINE COMMENTS
> kconfigloader.cpp:77
> +case QXmlStreamReader::Characters:
> +if (!reader.isWhitespace() &&
> !reader.text().toString().trimmed().isEmpty()) {
> +if (!characters(reader.text()))
No need to construct a QString if
mlaurent updated this revision to Diff 74349.
mlaurent added a comment.
We need to open QIODevice. Now all works correctly after rebuilding all
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26890?vs=74348=74349
BRANCH
port_QXmlStreamReader (branched
mlaurent updated this revision to Diff 74348.
mlaurent added a comment.
Trim better calling toString()
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26890?vs=74295=74348
BRANCH
port_QXmlStreamReader (branched from master)
REVISION DETAIL
apol added a comment.
Looks good otherwise, this code is pretty well tested too, so I quite trust
we aren't breaking it horribly.
Trying to compile the rest of KDE Software against this patch would also be
useful.
INLINE COMMENTS
> kconfigloader.cpp:127
> } else if (name
mlaurent edited the test plan for this revision.
mlaurent added a reviewer: dfaure.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D26890
To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
QXmlInputSource is deprecated in qt5.15
REPOSITORY
R237 KConfig
BRANCH
port_QXmlStreamReader (branched from
13 matches
Mail list logo
