D27097: Port from QRegExp to QRegularExpression

dfaure added a comment. Deprecate the attribute, keep the code. There is more KF5-based code out there than the one visible by lxr.kde.org. Some of it not even public. We make the same promise as Qt, preserving SC and BC in major versions. OK for "Invalid PCRE pattern syntax"

D27097: Port from QRegExp to QRegularExpression

ahmadsamir added a comment. Looking at the incremental stuff some more, there are no public methods that mention incremental; the only way is to set the KFind::FindIncremental flag; the only method I could find is in the private API (find_p.h) startNewIncrementalSearch(). So technically

D27097: Port from QRegExp to QRegularExpression

ahmadsamir marked an inline comment as done. ahmadsamir added a comment. In D27097#615648 , @dfaure wrote: > OK for deprecating Incremental. A full revert (at KF6 time) of commit 9ac82e27ad0322e444c16

D27097: Port from QRegExp to QRegularExpression

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. OK for deprecating Incremental. A full revert (at KF6 time) of commit 9ac82e27ad0322e444c16 looks

D27097: Port from QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 74871. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Add test plan section REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27097?vs=74850=74871 BRANCH l-qregularexpression

D27097: Port from QRegExp to QRegularExpression

ahmadsamir added a comment. A couple of notes: - "Incremental" search isn't used by anything in KDE, AFAICS from lxr.kde.org, remove it (in a separate diff)? - Nothing in KDE uses the static KFind::find(... QRegExp..) directly; should we make the new one that takes a

D27097: Port from QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mlaurent, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::setMinimal() by making the regex pattern non-greedy, where possible. Deprecate the