D27544: Fix update scenarios with no explicit downloadlink selected

This revision was automatically updated to reflect the committed changes. Closed by commit R304:f1dcbddf12ea: Fix update scenarios with no explicit downloadlink selected (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27544?vs=77818=77989#toc REPOSITORY R304

D27544: Fix update scenarios with no explicit downloadlink selected

ahiemstra accepted this revision. REPOSITORY R304 KNewStuff BRANCH fix-update (branched from master) REVISION DETAIL https://phabricator.kde.org/D27544 To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, #discover_software_store, ahiemstra Cc: ahiemstra, alexde,

D27544: Fix update scenarios with no explicit downloadlink selected

leinir updated this revision to Diff 77818. leinir marked 4 inline comments as done. leinir added a comment. Address @ahiemstra's comments - thanks! - Turn on C++14 support - Fix some whitespace issues, a leak, and add a warning - Less magic numbers, with the power of enums

D27544: Fix update scenarios with no explicit downloadlink selected

leinir marked 5 inline comments as done. leinir added a comment. Thanks for those, @ahiemstra, good stuff there :) INLINE COMMENTS > ahiemstra wrote in engine.cpp:614 > Code style: & attaches to the name, not the type. (Yes I hate it too). > > There's a few instances of this around. so

D27544: Fix update scenarios with no explicit downloadlink selected

ahiemstra added inline comments. INLINE COMMENTS > engine.cpp:614 > +QString identifiedLink; > +const QString& payloadToIdentify = d->payloadToIdentify[entry]; > +const QStringList& payloads = d->payloads[entry]; Code style: & attaches to the name, not the

D27544: Fix update scenarios with no explicit downloadlink selected

ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. Probably wait for at least one more review from someone smarter and more familiar with this code than I am. :) REPOSITORY R304 KNewStuff BRANCH fix-update (branched from

D27544: Fix update scenarios with no explicit downloadlink selected

leinir updated this revision to Diff 77494. leinir added a comment. - Merge branch 'master' into fix-update - Update @since REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27544?vs=76096=77494 BRANCH fix-update (branched from master) REVISION DETAIL

D27544: Fix update scenarios with no explicit downloadlink selected

leinir added a comment. In D27544#622575 , @alexde wrote: > In D27544#622272 , @ngraham wrote: > > > (...) there has to be a way to (...) label everything properly etc. > > > > > In

D27544: Fix update scenarios with no explicit downloadlink selected

alexde added a comment. In D27544#622272 , @ngraham wrote: > (...) there has to be a way to (...) label everything properly etc. In D27544#622501 , @leinir wrote: > We are at least two

D27544: Fix update scenarios with no explicit downloadlink selected

leinir added a comment. In D27544#622272 , @ngraham wrote: > As an aside, I'm somewhat dissatisfied with the current UX when there are multiple files. :( I converted a friend of mine to Plasma the other day and he was very confused by the

D27544: Fix update scenarios with no explicit downloadlink selected

ngraham added a comment. As an aside, I'm somewhat dissatisfied with the current UX when there are multiple files. :( I converted a friend of mine to Plasma the other day and he was very confused by the multiple items available when he was downloading new stuff using the new GHNS window. I

D27544: Fix update scenarios with no explicit downloadlink selected

leinir added reviewers: ngraham, apol, Discover Software Store. leinir added a comment. Tagging in some Discover peeps, because software management is a thing that is done there and whatnot ;) (also general ping, this really kind of wants to go in soon...) REPOSITORY R304 KNewStuff

D27544: Fix update scenarios with no explicit downloadlink selected

leinir added reviewers: KNewStuff, Frameworks, Plasma. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D27544 To: leinir, #knewstuff, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27544: Fix update scenarios with no explicit downloadlink selected

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY The old downloadwidget's update system would explicitly require a user to pick which download item to use for updating