D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ndavis added a comment. I generally prefer type 1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ndavis, filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. I like #2 the best! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

filipf added a comment. LGTM REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. This version looks great to me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. What do you think of this one? It's slightly less bright than before, but not as much as the first proposal. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. Same. I will try some half-way that works everywhere more consistenly. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. Yeah, to me the third version looks better than the status quo for some wallpapers, but worse for others. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#655680 , @ngraham wrote: > To be honest, I kinda prefer the befores since the afters are significantly darker. Is there a way to preserve the desired level of translucency without causing the background to

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. To be honest, I kinda prefer the befores since the afters are significantly darker. Is there a way to preserve the desired level of translucency without causing the background to darken like that? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#655226 , @ngraham wrote: > It's okay. :) > > This is gonna seem like a really dumb question, but which images are the befores and which are the afters? Not a dumb question! They are all

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. It's okay. :) This is gonna seem like a really dumb question, but which images are the befores and which are the afters? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. niccolove added a dependency: D28627: Adaptive panel opacity. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove reclaimed this revision. niccolove added a comment. This should've been "Changes planned", not "Abandoned". I'm really feeling sorry for all of the emails. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. Heh. That can happen. :) Maybe try again once the adaptive transparency patch has landed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a task: T11925: Breeze Desktop Theme Transparency. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove abandoned this revision. niccolove added a comment. I've tweaked it so many times that I eventually ended up with something that looks almost identical to default without even noticing. I still think there is margin for improvement over the default, but I need to take some more

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. F8248684: Screenshot_20200420_111621.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove updated this revision to Diff 80625. niccolove added a comment. Toned down transparency REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28353?vs=78675=80625 BRANCH contrast_and_transparency (branched from master) REVISION

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. niccolove added a dependency: D27439: Replaced isDock check with !hasDecoration. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. In D28353#637213 , @niccolove wrote: > Heh, you're right here. And I think that... > > > I might have proposed this before, but I think an improvement would be to dynamically change the transparency of the panel and

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#636931 , @ngraham wrote: > It would be helpful to remind people of those details in the Test Plan section in the future. :) I will! Sorry. It applied to me without cache clearing, so I assumed it

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham resigned from this revision. ngraham added a comment. Maybe it was that darned plasma cache! Re-applying the patch and clearing the cache substantially improved the appearance. It would be helpful to remind people of those details in the Test Plan section in the future. :)

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. Cannot reproduce, it looks like what's in the screenshots to me. Just for sure, I also added the dep on Nate's patch as that improves legibility. I totally agree on your points seen what you got, that'd be extreme. With what I'm actually trying to propose (I don't

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack, ngraham Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. niccolove added a dependency: D28317: Adjust default color scheme and titlebar appearance for Tools Area. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. Bug! It should look like this: F8201997: Screenshot_20200327_191850.png Let me check again. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack requested changes to this revision. cblack added a comment. I've changed my mind to agree with @ngraham here—this is too transparent. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack, ngraham Cc:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I see some problems here. To be honest, the level of transparency is way too high. I know aesthetics are subjective, but it just doesn't look good to me. Even with our

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack added a comment. In D28353#636183 , @niccolove wrote: > In D28353#636164 , @cblack wrote: > > > Looks visually appealing to me, with one question: How does this look on low-end hardware

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#636164 , @cblack wrote: > Looks visually appealing to me, with one question: How does this look on low-end hardware where there's compositing but no blur? Before: F8201840:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack accepted this revision as: VDG, cblack. cblack added a comment. This revision is now accepted and ready to land. Looks visually appealing to me, with one question: How does this look on low-end hardware where there's compositing but no blur? REPOSITORY R242 Plasma Framework

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove updated this revision to Diff 78675. niccolove added a comment. Fix breeze dark values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28353?vs=78668=78675 BRANCH contrast_and_transparency (branched from master) REVISION

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added inline comments. INLINE COMMENTS > metadata.desktop.cmake:99 > -contrast=0.2 > -#intensity is disabled, in order to auto adjust to the chosen theme color > -#intensity=2.0 I changed this because: simply put, it doesn't work. I opened a bug about it

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY (gimme a sec to edit with screenshots) REPOSITORY R242 Plasma Framework (Library) BRANCH