D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Noah Davis]

ndavis added a comment.


  I generally prefer type 1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ndavis, filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a comment.


  I like #2 the best!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Filip Fila]

filipf added a comment.


  LGTM

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a comment.


  This version looks great to me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  What do you think of this one? It's slightly less bright than before, but not 
as much as the first proposal.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  Same. I will try some half-way that works everywhere more consistenly.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a comment.


  Yeah, to me the third version looks better than the status quo for some 
wallpapers, but worse for others.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#655680 , @ngraham wrote:
  
  > To be honest, I kinda prefer the befores since the afters are significantly 
darker. Is there a way to preserve the desired level of translucency without 
causing the background to darken like that?
  
  
  Yeah, but it results in very altered colors in wallpapers like Volna. I added 
a second variant to show that. Feedback very welcome!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a comment.


  To be honest, I kinda prefer the befores since the afters are significantly 
darker. Is there a way to preserve the desired level of translucency without 
causing the background to darken like that?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#655226 , @ngraham wrote:
  
  > It's okay. :)
  >
  > This is gonna seem like a really dumb question, but which images are the 
befores and which are the afters?
  
  
  Not a dumb question! They are all before-after, but keep in mind that they 
have the colorscheme change patch applied, so they both look different from 
default. First one is default + your colorscheme patch, second one is defult + 
colorscheme patch + this patch.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a comment.


  It's okay. :)
  
  This is gonna seem like a really dumb question, but which images are the 
befores and which are the afters?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.
niccolove added a dependency: D28627: Adaptive panel opacity.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove reclaimed this revision.
niccolove added a comment.


  This should've been "Changes planned", not "Abandoned". I'm really feeling 
sorry for all of the emails.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove planned changes to this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a comment.


  Heh. That can happen. :)
  
  Maybe try again once the adaptive transparency patch has landed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a task: T11925: Breeze Desktop Theme Transparency.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove abandoned this revision.
niccolove added a comment.


  I've tweaked it so many times that I eventually ended up with something that 
looks almost identical to default without even noticing. I still think there is 
margin for improvement over the default, but I need to take some more time to 
tweak the values again until I get to something I'm again really confident 
proposing.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  F8248684: Screenshot_20200420_111621.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove updated this revision to Diff 80625.
niccolove added a comment.


  Toned down transparency

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28353?vs=78675=80625

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

AFFECTED FILES
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.
niccolove added a dependency: D27439: Replaced isDock check with !hasDecoration.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a comment.


  In D28353#637213 , @niccolove 
wrote:
  
  > Heh, you're right here. And I think that...
  >
  > > I might have proposed this before, but I think an improvement would be to 
dynamically change the transparency of the panel and pop-ups from widgets 
living in it based on the proximity of windows
  >
  > ...I will implement this :-)
  
  
  <3 <3 <3
  
  I think people will really, really like that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#636931 , @ngraham wrote:
  
  > It would be helpful to remind people of those details in the Test Plan 
section in the future. :)
  
  
  I will! Sorry. It applied to me without cache clearing, so I assumed it 
didn't need it, but I guess I had some previous transparent theme in the cache.
  
  > However as you can see from that screenshot, the background color of the 
pop-up still differs from the color of the panel.
  
  It is, but near the panel it gets whiter because of the bug that I'm solving 
in D27439 . I didn't put it as a dependency 
as the bug also affects current Breeze, but I could add it if you think it's 
necessary for this patch.
  
  > And the panel transparency effect is still a bit too pronounced for my 
tastes when a visually striking wallpaper is being covered by windows and only 
the panel is still visible. It results in a significant difference between the 
background colors of the panel and plasma pop-ups that appear on top of 
windows: F8203294: Screenshot_20200328_122908.png 

  
  Heh, you're right here. And I think that...
  
  > I might have proposed this before, but I think an improvement would be to 
dynamically change the transparency of the panel and pop-ups from widgets 
living in it based on the proximity of windows
  
  ...I will implement this :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham resigned from this revision.
ngraham added a comment.


  Maybe it was that darned plasma cache! Re-applying the patch and clearing the 
cache substantially improved the appearance. It would be helpful to remind 
people of those details in the Test Plan section in the future. :)
  
  Looking at it for realziez, I think it's okay. The appearance is indeed 
improved IMO when the wallpaper is visible, especially when the wallpaper is 
very visually striking: F8203301: Screenshot_20200328_123057.png 

  
  However as you can see from that screenshot, the background color of the 
pop-up still differs from the color of the panel.
  
  And the panel transparency effect is still a bit too pronounced for my tastes 
when a visually striking wallpaper is being covered by windows and only the 
panel is still visible. It results in a significant difference between the 
background colors of the panel and plasma pop-ups that appear on top of 
windows: F8203294: Screenshot_20200328_122908.png 

  
  I might have proposed this before, but I think an improvement would be to 
dynamically change the transparency of the panel and pop-ups from widgets 
living in it based on the proximity of windows; when a window is butted up 
against a panel, the background color of that panel as well as all pop-ups of 
widgets living on that panel would become opaque, and when the window moved 
away, un-maximized, or tiled, they would resume being transparent. I think this 
would look //great// and would seem to satisfy everyone: people who want pretty 
transparency when the wallpaper is visible would get it, and people who want 
maximum legibility and visual consistency when the system is being used heavily 
would get that too.
  
  Of course that's a bit more ambitious than what could be done in this patch, 
but I think it's a good way forward. However I won't block this patch in its 
current form as it's no longer the usability regression that I originally and 
mistakenly feared.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  Cannot reproduce, it looks like what's in the screenshots to me. Just for 
sure, I also added the dep on Nate's patch as that improves legibility. I 
totally agree on your points seen what you got, that'd be extreme. With what 
I'm actually trying to propose (I don't know if the problem is on my or your 
side), the change looks like the screenshot I added. I also added screenshots 
with fullscreen windows, as that's important as well. E.g., with the default 
wallpaper, left panel and maximized white window it looks like this, which is 
good enough IMO since master is not perfect either: 
  F8202189: Screenshot_20200327_221948.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.
niccolove added a dependency: D28317: Adjust default color scheme and titlebar 
appearance for Tools Area.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  Bug! It should look like this: 
  F8201997: Screenshot_20200327_191850.png 

  Let me check again.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Carson Black]

cblack requested changes to this revision.
cblack added a comment.


  I've changed my mind to agree with @ngraham here—this is too transparent.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I see some problems here.
  
  To be honest, the level of transparency is way too high. I know aesthetics 
are subjective, but it just doesn't look good to me. Even with our default 
wallpaper, something about it feels off:
  
  F8201901: Screenshot_20200327_113312.png 

  
  F8201902: Screenshot_20200327_113351.png 

  
  In addition, on the usability side, every transparent surface has worse 
contrast than it did before. And while your screenshots look appealing enough 
when there are no windows on the screen or the wallpaper is otherwise visible. 
But that's not really how people use their machines, right? people tend to 
maximize their windows (novice users or those with small screens) or tile 
everything (advanced users) or have a dozen or more un-maximized, un-tiled 
windows in a huge jumble taking up every pixel of the screen (messy users).
  
  The effect produced when a very transparent popup appears over window content 
of the type that any of these users will be looking at just looks really bad to 
me; the background becomes an ugly gray:
  
  F8201876: Screenshot_20200327_112832.png 

  
  F8201884: Screenshot_20200327_112920.png 

  
  F8201862: Screenshot_20200327_112300.png 

  
  Also the pop-up still doesn't match the panel background: F8201861: 
Screenshot_20200327_112208.png . Is there 
another patch I'm missing that implement this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Carson Black]

cblack added a comment.


  In D28353#636183 , @niccolove 
wrote:
  
  > In D28353#636164 , @cblack wrote:
  >
  > > Looks visually appealing to me, with one question: How does this look on 
low-end hardware where there's compositing but no blur?
  >
  >
  > Before:
  >  F8201840: Screenshot_20200327_180214.png 

  > After:
  >  F8201842: Screenshot_20200327_180258.png 

  >
  > It is more grayish, but that will no longer be as soon as D28317 
 lands
  
  
  Looks like a downgrade in legibility, but it wasn't too great before either. 
I wouldn't consider it a blocker.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#636164 , @cblack wrote:
  
  > Looks visually appealing to me, with one question: How does this look on 
low-end hardware where there's compositing but no blur?
  
  
  Before:
  F8201840: Screenshot_20200327_180214.png 

  After:
  F8201842: Screenshot_20200327_180258.png 

  
  It is more grayish, but that will no longer be as soon as D28317 
 lands

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Carson Black]

cblack accepted this revision as: VDG, cblack.
cblack added a comment.
This revision is now accepted and ready to land.


  Looks visually appealing to me, with one question: How does this look on 
low-end hardware where there's compositing but no blur?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Carson Black]

cblack added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove updated this revision to Diff 78675.
niccolove added a comment.


  Fix breeze dark values

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28353?vs=78668=78675

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

AFFECTED FILES
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> metadata.desktop.cmake:99
> -contrast=0.2
> -#intensity is disabled, in order to auto adjust to the chosen theme color
> -#intensity=2.0

I changed this because: simply put, it doesn't work. I opened a bug about it 
https://bugs.kde.org/show_bug.cgi?id=416699. It results in weird colors that 
have nothing to do with the background. If I understood it correctly, it's 
supposed to tweak the value based on the background darkness in order to make 
the background more light in those cases and preserving readability, but that 
does not seem to work either as there are some places in the 'before' 
screenshots that look way too dark, and are instead much more readable with 
this patch.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  (gimme a sec to edit with screenshots)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

AFFECTED FILES
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns