D28488: [Fstab] Ensure uniqueness for all filesystem types

meven added a comment. A consequence of this is the deviceName is used in fstab device description : F8240164: Screenshot_20200415_180517.png Making planner the need for D28590 REPOSITORY R245 Solid

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > I got the impression you liked being lax. Guess only when the shoe is on the > other foot. I do like being lax! I literally gave you a ship it despite your comment being literally wrong. Picking on useless

D28488: [Fstab] Ensure uniqueness for all filesystem types

This revision was automatically updated to reflect the committed changes. Closed by commit R245:e468daf0d100: [Fstab] Ensure uniqueness for all filesystem types (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28488?vs=79067=79126 REVISION

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > sitter wrote in fstabhandling.cpp:131 > The previous comment was factually correct, it never claimed the same source > on the same mount would be differentiated. Your comment on the other hand > does and

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > You let the old comment pass without any further remarks, but now you start > nitpicking? > > From the acessibility viewpoint of the mount, it is unique. The previous comment was factually correct, it never

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix_comment REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > sitter wrote in fstabhandling.cpp:131 > The comment is still wrong. You let the old comment pass without any further remarks, but now you start nitpicking? From the acessibility viewpoint of the mount, it

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > The first mount is no longer visible, it is shadowed by the first one. You > can not read any files from it or write to it. You can not unmount it. The comment is still wrong. REPOSITORY R245 Solid

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. bruns added a comment. In D28488#639942 , @broulik wrote: > Wat. So maybe we need to add a hash of mount options to it? (Though I personally would call that pebkac) +1 INLINE COMMENTS > sitter

D28488: [Fstab] Ensure uniqueness for all filesystem types

broulik added a comment. Wat. So maybe we need to add a hash of mount options to it? (Though I personally would call that pebkac) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel,

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > Of course they are - you can just mount one fs at a path at any time. λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > sitter wrote in fstabhandling.cpp:131 > mountpoints are not unique Of course they are - you can just mount one fs at a path at any time. REPOSITORY R245 Solid REVISION DETAIL

D28488: [Fstab] Ensure uniqueness for all filesystem types

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabhandling.cpp:131 > +// for different users. Make sure it is unique by appending the > +// mountpoint (which is unique). > +return source +

D28488: [Fstab] Ensure uniqueness for all filesystem types

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Fine REPOSITORY R245 Solid BRANCH fix_comment REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel,

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns added a comment. In D28488#639815 , @meven wrote: > Good idea, we should fix this once and for all. > Two points though about udi form : > > 1/ Nfs udi would no be great. > For instance the source for nfs is usually of the form :

D28488: [Fstab] Ensure uniqueness for all filesystem types

meven added a reviewer: sitter. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. Good idea, we should fix this once and for all. Two points though about udi form : 1/ Nfs udi would no be great. For instance the source for nfs is usually of the form :

D28488: [Fstab] Ensure uniqueness for all filesystem types

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix_comment REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28488: [Fstab] Ensure uniqueness for all filesystem types

broulik added a comment. +1 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns created this revision. bruns added reviewers: Frameworks, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Commit a99c6136da2d