D29223: Update Taiwanese holidays

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R175:b1291acbfc09: Update Taiwanese holidays (authored by nhiga, committed by winterz). REPOSITORY R175 KHolidays

D29223: Update Taiwanese holidays

nhiga set the repository for this revision to R175 KHolidays. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, michaelh, ngraham,

D29223: Update Taiwanese holidays

winterz added a comment. all opposed to this patch please speak up soon REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, michaelh, ngraham, bruns, dvasin,

D29223: Update Taiwanese holidays

nhiga added a comment. Officially-recognized days (including 言論自由日) and the dates for 2020 can be found in this document

D29223: Update Taiwanese holidays

nhiga updated this revision to Diff 82085. nhiga added a comment. Added 植樹節. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29223?vs=81833=82085 REVISION DETAIL https://phabricator.kde.org/D29223 AFFECTED FILES holidays/holidays.qrc holidays/plan2/holiday_tw_zh

D29223: Update Taiwanese holidays

cgiboudeaux added a comment. If everything is sorted and both of you agree, please accept one of the reviews and we'll happily push it if necessary. REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel,

D29223: Update Taiwanese holidays

nhiga added a comment. Some historical arrangements of some holidays (e.g. Children's Day between 1998-2010) are currently ignored, but I believe this is less important. REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim,

D29223: Update Taiwanese holidays

nhiga marked 6 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause,

D29223: Update Taiwanese holidays

nhiga updated this revision to Diff 81833. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29223?vs=81321=81833 REVISION DETAIL https://phabricator.kde.org/D29223 AFFECTED FILES holidays/holidays.qrc holidays/plan2/holiday_tw_zh holidays/plan2/holiday_tw_zh-tw To: nhiga,

D29223: Update Taiwanese holidays

weisi added a comment. Thanks! Looks good :) REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns,

D29223: Update Taiwanese holidays

nhiga added a comment. > On the Spring festival 春節 of 2020, the publicholidays.tw page and the official source listed on that page both showed Jan 23 to 29 as the days off. I think both of us can be correct: - I referred to this document by Ministry of the Interior, R. O. C.

D29223: Update Taiwanese holidays

weisi added a comment. I prefer this diff to the changes I took in D29373 . I wish I had seen this diff earlier. Would you also indicate the plan for the festivals specified as "2020" in this diff for future years? For example, could you add the 2021

D29223: Update Taiwanese holidays

nhiga added a comment. @cgiboudeaux Thanks for the heads-up. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh,

D29223: Update Taiwanese holidays

cgiboudeaux added a comment. @nhiga Please have a look at D29372 . REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack,

D29223: Update Taiwanese holidays

nhiga added a comment. In D29223#658229 , @cgiboudeaux wrote: > I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan? The new file name follows the same naming scheme used by the PRC

D29223: Update Taiwanese holidays

cgiboudeaux added a comment. I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel,

D29223: Update Taiwanese holidays

cgiboudeaux added a reviewer: shrapnel. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin,

D29223: Update Taiwanese holidays

nhiga added a comment. Notes: 1. Holidays for indigenous peoples have not been included. Some of them seem to have a fixed date, but for other festivals we know the range but not the exact dates. For example, it is known that 豐年祭(收穫祭) is celebrated between July 1 and September 30

D29223: Update Taiwanese holidays

nhiga created this revision. nhiga added reviewers: winterz, cgiboudeaux. nhiga added projects: KDE PIM, Frameworks. nhiga requested review of this revision. REVISION SUMMARY This patch improves upon @shrapnel 's work on the accuracy of the Taiwanese