smithjd updated this revision to Diff 22107.
smithjd added a comment.
- Merge local and tag file handling.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=21851=22107
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
smithjd marked 14 inline comments as done.
smithjd added inline comments.
INLINE COMMENTS
> dfaure wrote in kio_tags.cpp:64
> - merge with previous line
>
> - can path() really contain '?' ? I thought that wasn't possible (? delimits
> the query).
Yes, the url is non-hierarchical scheme, so
the tag.
1. Updating https://phabricator.kde.org/D8098: Strip down and re-write the
tags KIO slave. #
2. Enter a brief description of the changes included in this update.
3. The first line is used as subject, next lines as comment. #
4. If you intended to create a new revision, use:
5
dfaure added inline comments.
INLINE COMMENTS
> kio_tags.cpp:64
> +QString tag;
> +tag = url.path().section(QLatin1Char('?'), 0, 0);
> +while (tag.startsWith(QDir::separator()))
- merge with previous line
- can path() really contain '?' ? I thought that wasn't possible (? delimits
dfaure requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: dfaure, nicolasfella, ngraham
smithjd updated this revision to Diff 21599.
smithjd added a comment.
- Create a full url instead of only a path.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=21590=21599
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
smithjd updated this revision to Diff 21590.
smithjd added a comment.
- Fix generating previews copies the file to tmp.
- Fix tag navigation display labels in Dolphin.
- Stricter url validation.
1. Updating https://phabricator.kde.org/D8098: Strip down and re-write the
tags KIO slave
smithjd added a comment.
Deep tag copies (to the filesystem and also in the slave) are known to be
broken (1 or more folder deep) because of the preview fix in the first revision.
REPOSITORY
R293 Baloo
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
I have been using this for weeks without any negative effects. I'm giving
this my blessing, but let's wait for others to weigh in.
REPOSITORY
R293 Baloo
BRANCH
master-nestedTags
ngraham added a comment.
Can you add some testing details?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin
Cc: nicolasfella, ngraham
ngraham added a reviewer: Dolphin.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin
Cc: nicolasfella, ngraham
smithjd updated this revision to Diff 20362.
smithjd added a comment.
- Fix tag navigation display labels in Dolphin.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=20320=20362
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
smithjd updated this revision to Diff 20320.
smithjd added a comment.
- Fix generating previews copies the file to tmp.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=20222=20320
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
smithjd added a comment.
Copying/cutting file tags works both from local files and also tagged files.
Breaking tags works, e.g. nested tag foo in bar can be copied or cut to
foobar/barfoo tag path. Cutting and pasting a file folder results in a new tag
on the folder, copying applies the
ngraham added a reviewer: vhanda.
ngraham added a comment.
Oh, I'm a dolt. I was trying to apply this to KIO, not Baloo. Ignore me;
works fine when you're not holding it wrong. :)
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda
smithjd added a comment.
Maybe update your local repo? It is against the most recent commit in master.
It was diff'ed from a non-master branch...
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks
Cc: ngraham
ngraham added a comment.
Fantastic work. I wasn't able to apply it with `arc`, though:
This diff is against commit 9383ea8927579555301eb378c1ce299dde2a2d08, but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state?
smithjd created this revision.
smithjd added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Allow for more operations on tag trees (e.g. rename, copy, delete) and fix
some existing issues.
BUG: 314373
BUG: 340098
BUG: 376229
BUG: 332214
18 matches
Mail list logo
