Re: Figuring out kde-runtime: localization
On Sun, Feb 23, 2014 at 4:59 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 21 de febrer de 2014, a les 13:17:58, Aleix Pol va escriure: Hi, Going through the information we have in kde-runtime [1] we found there are two subdirectories related to localization (localization and l10n) that we couldn't find a correct place to move to. Who is we? Why are you asking the documentation list about this? Can anybody give us a hand and help us figure those out? - localization: has plenty of information regarding different currencies. Yes, used in kcurrencycode.cpp at least (which by the way says see KLocale, which is weird in the kunitconversion framework), I guess you could move it to the kunitconversion framework - l10n: has information about different countries. Yes, the existance of those entry.desktop files is checked by ./kio/src/core/global.cpp ./kconfigwidgets/src/klanguagebutton.cpp ./kxmlgui/src/khelpmenu.cpp ./kde4support/src/kdecore/klocale_kde.cpp If you want to deprecate those files you'll have to fix kio, kconfigwidgets and kxmlgui to use whatever localization system KF5 is planning to use and then move these files to kde4support. Should these go to KI18n? What do those files have to do with translations of strings? Qt? Anybody has plans for those? Cheers, Albert Aleix [1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization I think that those uses were removed already. Can somebody confirm? If everybody agrees, I'll move kde-runtime/l10n to kde4support. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Figuring out kde-runtime: localization
El Divendres, 21 de febrer de 2014, a les 13:17:58, Aleix Pol va escriure: Hi, Going through the information we have in kde-runtime [1] we found there are two subdirectories related to localization (localization and l10n) that we couldn't find a correct place to move to. Who is we? Why are you asking the documentation list about this? Can anybody give us a hand and help us figure those out? - localization: has plenty of information regarding different currencies. Yes, used in kcurrencycode.cpp at least (which by the way says see KLocale, which is weird in the kunitconversion framework), I guess you could move it to the kunitconversion framework - l10n: has information about different countries. Yes, the existance of those entry.desktop files is checked by ./kio/src/core/global.cpp ./kconfigwidgets/src/klanguagebutton.cpp ./kxmlgui/src/khelpmenu.cpp ./kde4support/src/kdecore/klocale_kde.cpp If you want to deprecate those files you'll have to fix kio, kconfigwidgets and kxmlgui to use whatever localization system KF5 is planning to use and then move these files to kde4support. Should these go to KI18n? What do those files have to do with translations of strings? Qt? Anybody has plans for those? Cheers, Albert Aleix [1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Figuring out kde-runtime: localization
On 21 February 2014 13:17, Aleix Pol aleix...@kde.org wrote: Hi, Going through the information we have in kde-runtime [1] we found there are two subdirectories related to localization (localization and l10n) that we couldn't find a correct place to move to. Can anybody give us a hand and help us figure those out? - localization: has plenty of information regarding different currencies. - l10n: has information about different countries. Should these go to KI18n? Qt? Anybody has plans for those? Aleix [1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization The l10n directory holds the locale config files for each country. These files get used by KLocale. The localization directory holds the currency config files used by KLocale and KCurrencyCode, as they couldn't go into l10n/ without messing up existing code, and the long-term plan was to move l10n/ into localization/ as a country/ sub-directory. In KF5 both KLocale and KCurrencyCode are in kde4support and have mostly been replaced by using QLocale. As such both l10n and localization are only required if kde4support is installed and used. I assume the files must now be moved into kde4support? Will we also need to think about what happens with parallel installs with KDE4? As Albert points out, there looks to be a couple of other places the files are used in KF5 code that will need porting to QLocale instead, or if they are only appropriate with KLocale then moving to kde4support. I'll try have a look later today. I have a separate email about locale configuration in Plasma Next that I'll post on the Plasma list a bit later. John. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Figuring out kde-runtime: localization
El Diumenge, 23 de febrer de 2014, a les 17:26:23, John Layt va escriure: On 21 February 2014 13:17, Aleix Pol aleix...@kde.org wrote: Hi, Going through the information we have in kde-runtime [1] we found there are two subdirectories related to localization (localization and l10n) that we couldn't find a correct place to move to. Can anybody give us a hand and help us figure those out? - localization: has plenty of information regarding different currencies. - l10n: has information about different countries. Should these go to KI18n? Qt? Anybody has plans for those? Aleix [1] http://community.kde.org/Frameworks/Epics/New_Runtime_Organization The l10n directory holds the locale config files for each country. These files get used by KLocale. The localization directory holds the currency config files used by KLocale and KCurrencyCode, as they couldn't go into l10n/ without messing up existing code, and the long-term plan was to move l10n/ into localization/ as a country/ sub-directory. In KF5 both KLocale and KCurrencyCode are in kde4support KCurrencyCode is in kunitconversion. Cheers, Albert and have mostly been replaced by using QLocale. As such both l10n and localization are only required if kde4support is installed and used. I assume the files must now be moved into kde4support? Will we also need to think about what happens with parallel installs with KDE4? As Albert points out, there looks to be a couple of other places the files are used in KF5 code that will need porting to QLocale instead, or if they are only appropriate with KLocale then moving to kde4support. I'll try have a look later today. I have a separate email about locale configuration in Plasma Next that I'll post on the Plasma list a bit later. John. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Figuring out kde-runtime: localization
On 23 February 2014 17:31, Albert Astals Cid aa...@kde.org wrote: El Diumenge, 23 de febrer de 2014, a les 17:26:23, John Layt va escriure: In KF5 both KLocale and KCurrencyCode are in kde4support KCurrencyCode is in kunitconversion. Ah, so it is, had missed that :-) So I guess the maintainer for kunitconversion needs to move the data files there? Now, who would that be... :-) I need to see how KCurrencyCode is being used there, and decide whether to keep it public or not. So, looking at the other users of the l10n files. kio/src/core/global.cpp - Uses them to find the default BinaryUnitDialect for the current locale, but all config files have the same default, so get rid of lookup and use same default until Qt adds support. kconfigwidgets/src/klanguagebutton.cpp - loadAllLanguages() loads the list of available languages from the config files, should probably just load the list of Qt languages? Or does it really mean the list of KDE translation languages? Perhaps we need load functions for both options, depending on the use its needed for? - Will we need a K4LanguageButton that has the old behaviour? kxmlgui/src/khelpmenu.cpp - Weird one, if there are any config files installed, then enables the Help/Switch Language menu item, but if you trigger the item it launches KSwitchLanguageDialog which looks for the installed translation languages for the app, which is a completely different thing. - KSwitchLanguageDialogPrivate::applicationLanguageList() needs to be made a KSwitchLanguageDialog static method that KHelpMenu can call to see if more than 1 language is available, and use that in place of the existing check. Once those changes are made, then the l10n files can go to kde4support. John. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
