Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-05-06 Thread Jerome Leclanche
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/ --- (Updated May 6, 2015, 1:19 p.m.) Status -- This change has been

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-05-04 Thread Martin Klapetek
On May 3, 2015, 2:34 p.m., Albert Astals Cid wrote: I'm confused, the title say Remove KAboutData and then goes and changes i18n while breaking it? I mean i18n handling is relatively easy, and we have pretty good documentation at

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-05-03 Thread Albert Astals Cid
On mai. 3, 2015, 12:34 p.m., Albert Astals Cid wrote: I'm confused, the title say Remove KAboutData and then goes and changes i18n while breaking it? I mean i18n handling is relatively easy, and we have pretty good documentation at

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-05-03 Thread Martin Klapetek
On May 3, 2015, 2:34 p.m., Albert Astals Cid wrote: I'm confused, the title say Remove KAboutData and then goes and changes i18n while breaking it? I mean i18n handling is relatively easy, and we have pretty good documentation at

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-05-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/#review79794 --- I'm confused, the title say Remove KAboutData and then goes

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-04-30 Thread Martin Klapetek
On March 2, 2015, 9:06 a.m., Martin Gräßlin wrote: Ship It! Luigi Toscano wrote: Please fix the extracted pot so that it is called file_qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) Luigi Toscano wrote:

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Luigi Toscano
On Mar. 2, 2015, 9:06 a.m., Martin Gräßlin wrote: Ship It! Please fix the extracted pot so that it is called file_qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) - Luigi ---

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Luigi Toscano
On Mar. 2, 2015, 5:21 a.m., Jerome Leclanche wrote: Should we be using ::tr here instead of not translating at all? Jerome Leclanche wrote: Consensus on IRC six days ago was that dropping translation altogether was fine. I can add some ::tr but it's arguable whether some of

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Luigi Toscano
On Mar. 2, 2015, 9:06 a.m., Martin Gräßlin wrote: Ship It! Luigi Toscano wrote: Please fix the extracted pot so that it is called file_qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) Sorry, there is also another

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Luigi Toscano
On Mar. 2, 2015, 9:06 a.m., Martin Gräßlin wrote: Ship It! Luigi Toscano wrote: Please fix the extracted pot so that it is called file_qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) Luigi Toscano wrote:

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Albert Astals Cid
On mar. 2, 2015, 8:06 a.m., Martin Gräßlin wrote: Ship It! Luigi Toscano wrote: Please fix the extracted pot so that it is called file_qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) Luigi Toscano wrote:

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Jerome Leclanche
On March 2, 2015, 8:06 a.m., Martin Gräßlin wrote: Ship It! Luigi Toscano wrote: Please fix the extracted pot so that it is called file_qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) Luigi Toscano wrote:

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Martin Klapetek
On March 2, 2015, 5:21 a.m., Jerome Leclanche wrote: Should we be using ::tr here instead of not translating at all? Jerome Leclanche wrote: Consensus on IRC six days ago was that dropping translation altogether was fine. I can add some ::tr but it's arguable whether some of

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Hrvoje Senjan
On March 2, 2015, 9:06 a.m., Martin Gräßlin wrote: Ship It! Luigi Toscano wrote: Please fix the extracted pot so that it is called file_qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) Luigi Toscano wrote:

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Luigi Toscano
On Mar. 2, 2015, 9:06 a.m., Martin Gräßlin wrote: Ship It! Luigi Toscano wrote: Please fix the extracted pot so that it is called file_qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) Luigi Toscano wrote:

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Hrvoje Senjan
On March 2, 2015, 9:06 a.m., Martin Gräßlin wrote: Ship It! Luigi Toscano wrote: Please fix the extracted pot so that it is called file_qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) Luigi Toscano wrote:

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Albert Astals Cid
On mar. 2, 2015, 8:06 a.m., Martin Gräßlin wrote: Ship It! Luigi Toscano wrote: Please fix the extracted pot so that it is called file_qt.pot. (personally speaking, I would strongly suggest lxde to use ki18n, but that's another discussion) Luigi Toscano wrote:

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Jerome Leclanche
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/ --- (Updated March 2, 2015, 8:02 a.m.) Review request for KDE Frameworks,

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/#review76863 --- Ship it! Ship It! - Martin Gräßlin On March 2, 2015, 9:02

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-01 Thread Jerome Leclanche
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/ --- (Updated March 2, 2015, 3:52 a.m.) Review request for KDE Frameworks,

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-01 Thread Jerome Leclanche
On Feb. 23, 2015, 11:23 a.m., Martin Klapetek wrote: From the docs Currently, the values set here are shown by the About box (see KAboutDialog), used by the bug report dialog (see KBugReport), and by the help shown on command line (see KAboutData::setupCommandLine()). So daemon has

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/#review76855 --- src/runtime/main.cpp

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-01 Thread Jerome Leclanche
On March 2, 2015, 4:21 a.m., Jerome Leclanche wrote: Should we be using ::tr here instead of not translating at all? Consensus on IRC six days ago was that dropping translation altogether was fine. I can add some ::tr but it's arguable whether some of those values should have been translated

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-01 Thread Martin Gräßlin
On March 2, 2015, 5:21 a.m., Jerome Leclanche wrote: Should we be using ::tr here instead of not translating at all? Jerome Leclanche wrote: Consensus on IRC six days ago was that dropping translation altogether was fine. I can add some ::tr but it's arguable whether some of

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-01 Thread Jerome Leclanche
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/ --- (Updated March 2, 2015, 7:11 a.m.) Review request for KDE Frameworks,

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-03-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/#review76862 --- I think you have to bring back (un-delete) the Messages.sh

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-02-23 Thread Jerome Leclanche
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/ --- (Updated Feb. 23, 2015, 10:34 a.m.) Review request for KDE Frameworks,

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-02-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/#review76462 --- From the docs Currently, the values set here are shown by the

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-02-23 Thread Martin Gräßlin
On Feb. 23, 2015, 12:23 p.m., Martin Klapetek wrote: From the docs Currently, the values set here are shown by the About box (see KAboutDialog), used by the bug report dialog (see KBugReport), and by the help shown on command line (see KAboutData::setupCommandLine()). So daemon has

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-02-23 Thread Jerome Leclanche
On Feb. 23, 2015, 11:14 a.m., Jerome Leclanche wrote: That said, you're removing 2 very small dependencies there... See the lxqt issue (especially the last few comments). Plan is to remove more dependencies one way or another, but these two are essentially free - and although they are

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-02-23 Thread Jerome Leclanche
On Feb. 23, 2015, 11:23 a.m., Martin Klapetek wrote: From the docs Currently, the values set here are shown by the About box (see KAboutDialog), used by the bug report dialog (see KBugReport), and by the help shown on command line (see KAboutData::setupCommandLine()). So daemon has

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-02-23 Thread Jerome Leclanche
On Feb. 23, 2015, 11:23 a.m., Martin Klapetek wrote: From the docs Currently, the values set here are shown by the About box (see KAboutDialog), used by the bug report dialog (see KBugReport), and by the help shown on command line (see KAboutData::setupCommandLine()). So daemon has

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-02-23 Thread Jerome Leclanche
On Feb. 23, 2015, 11:23 a.m., Martin Klapetek wrote: From the docs Currently, the values set here are shown by the About box (see KAboutDialog), used by the bug report dialog (see KBugReport), and by the help shown on command line (see KAboutData::setupCommandLine()). So daemon has

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-02-23 Thread Martin Gräßlin
On Feb. 23, 2015, 12:23 p.m., Martin Klapetek wrote: From the docs Currently, the values set here are shown by the About box (see KAboutDialog), used by the bug report dialog (see KBugReport), and by the help shown on command line (see KAboutData::setupCommandLine()). So daemon has

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-02-23 Thread Martin Gräßlin
On Feb. 23, 2015, 12:23 p.m., Martin Klapetek wrote: From the docs Currently, the values set here are shown by the About box (see KAboutDialog), used by the bug report dialog (see KBugReport), and by the help shown on command line (see KAboutData::setupCommandLine()). So daemon has

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-02-23 Thread Martin Klapetek
On Feb. 23, 2015, 12:23 p.m., Martin Klapetek wrote: From the docs Currently, the values set here are shown by the About box (see KAboutDialog), used by the bug report dialog (see KBugReport), and by the help shown on command line (see KAboutData::setupCommandLine()). So daemon has