Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/ --- (Updated Dec. 3, 2016, 8:50 a.m.) Status -- This change has been

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review101225 --- Honestly i don't see anything wrong with the patch but i

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Dec. 1, 2016, 9:43 p.m., Albert Astals Cid wrote: > > src/kstatusnotifieritem.cpp, line 972 > > > > > > maybe move this to the else? > > Anthony Fieroni wrote: > NET::WMFrameExtents is not needed

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Dec. 1, 2016, 11:43 p.m., Albert Astals Cid wrote: > > src/kstatusnotifieritem.cpp, line 972 > > > > > > maybe move this to the else? > > Anthony Fieroni wrote: > NET::WMFrameExtents is not needed

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Dec. 1, 2016, 11:43 p.m., Albert Astals Cid wrote: > > src/kstatusnotifieritem.cpp, line 972 > > > > > > maybe move this to the else? NET::WMFrameExtents is not needed anymore. - Anthony

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review101203 --- src/kstatusnotifieritem.cpp (line 972)

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Ноев. 16, 2016, 8 след обяд, Anthony Fieroni wrote: > > Ping, i'm still using it without issues, it isn't good enough? > > Anthony Fieroni wrote: > Ping? Any problems with to go in ? - Anthony --- This is an automatically

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Ноев. 16, 2016, 8 след обяд, Anthony Fieroni wrote: > > Ping, i'm still using it without issues, it isn't good enough? Ping? - Anthony --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review100891 --- Ping, i'm still using it without issues, it isn't good

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/ --- (Updated Ноев. 12, 2016, 6:43 след обяд) Review request for KDE

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Април 15, 2016, 6:59 преди обяд, Anthony Fieroni wrote: > > So as Thomas says in https://git.reviewboard.kde.org/r/127631/ it's a Qt > > issue, options are: > > 1. leave the code as is (i'm not prefer it, the bug is annoying) > > 2. do it on *right* way storing / restoring the position and

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Април 15, 2016, 6:59 преди обяд, Anthony Fieroni wrote: > > So as Thomas says in https://git.reviewboard.kde.org/r/127631/ it's a Qt > > issue, options are: > > 1. leave the code as is (i'm not prefer it, the bug is annoying) > > 2. do it on *right* way storing / restoring the position and

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review94623 --- So as Thomas says in

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/ --- (Updated Март 31, 2016, 11:23 след обяд) Review request for KDE

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > >

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 10:16 p.m., Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > > This

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 10:16 p.m., Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > > This

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > >

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 10:16 p.m., Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > > This

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > >

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > >

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 10:16 p.m., Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > > This

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > >

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > >

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review93143 --- src/kstatusnotifieritem.cpp (line 933)

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 3, 2016, 11:26 след обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 425 > > > > > > I assume this is the dealbreaker for the failing apps. > > This entire "restore position"

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 3, 2016, 10:57 след обяд, Anthony Fieroni wrote: > > Ping > > Martin Klapetek wrote: > Does not work for Quassel and Konversation, I'd like to know why before I > approve your patch. > > Martin Klapetek wrote: > Ah, interestingly I've never received the replies you made

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 9:57 p.m., Anthony Fieroni wrote: > > Ping > > Martin Klapetek wrote: > Does not work for Quassel and Konversation, I'd like to know why before I > approve your patch. > > Martin Klapetek wrote: > Ah, interestingly I've never received the replies you made above.

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 8:57 p.m., Anthony Fieroni wrote: > > Ping > > Martin Klapetek wrote: > Does not work for Quassel and Konversation, I'd like to know why before I > approve your patch. > > Martin Klapetek wrote: > Ah, interestingly I've never received the replies you made above.

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 9:57 p.m., Anthony Fieroni wrote: > > Ping Does not work for Quassel and Konversation, I'd like to know why before I approve your patch. - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 9:57 p.m., Anthony Fieroni wrote: > > Ping > > Martin Klapetek wrote: > Does not work for Quassel and Konversation, I'd like to know why before I > approve your patch. Ah, interestingly I've never received the replies you made above. Must have ended in some @kde.org

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Feb. 29, 2016, 7:59 p.m., Martin Klapetek wrote: > > This works in 50% of cases for me. I'm not sure if Quassel and Konversation > > are doing something special wrt to restoring position but this doesn't fix > > it. > > Anthony Fieroni wrote: > Can you show simple video? Placement

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review93128 --- Ping - Anthony Fieroni On Фев. 29, 2016, 7:18 преди обяд,

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review92926 --- This works in 50% of cases for me. I'm not sure if Quassel

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review92888 --- just store the widget/window position when hiding the window

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review92878 --- sorry, but I don't understand what this review request is