Re: Review Request 128283: Add checksums tab to the properties dialog

> On July 9, 2016, 1:05 p.m., Ragnar Thomsen wrote: > > Another post-commit suggestion: > > - The "Share" label is not obvious to me. This was also pointed out by > > another user on the [blog post](http://www.aelog.org/checksums-made-easy). > > Something like "Calculated checksums" would

Re: Review Request 128283: Add checksums tab to the properties dialog

> On July 9, 2016, 1:05 p.m., Ragnar Thomsen wrote: > > Another post-commit suggestion: > > - The "Share" label is not obvious to me. This was also pointed out by > > another user on the [blog post](http://www.aelog.org/checksums-made-easy). > > Something like "Calculated checksums" would

Re: Review Request 128283: Add checksums tab to the properties dialog

> On July 9, 2016, 12:38 p.m., Friedrich W. H. Kossebau wrote: > > Post-commit suggestions for improvements: > > The two most usual workflows (checking a checksum, sharing a checksum) here > > both require to make use of a (hidden) context menu and searching the one > > typical action in that

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review97237 --- Another post-commit suggestion: - The "Share" label is not

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review97235 --- Post-commit suggestions for improvements: The two most usual

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated July 8, 2016, 1:51 p.m.) Status -- This change has been

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated July 8, 2016, 12:38 p.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review97178 --- Fix it, then Ship it! src/widgets/kpropertiesdialog.cpp

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated July 3, 2016, 3:27 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96983 --- src/widgets/checksumswidget.ui (line 26)

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 30, 2016, 8:57 a.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96962 --- src/widgets/kpropertiesdialog.cpp (line 2776)

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 29, 2016, 6:06 p.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96960 --- Nice feature addition :) Is there a plan for plugins to this

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 29, 2016, 2:37 p.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 28, 2016, 2:40 p.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

> On June 26, 2016, 12:13 p.m., Luigi Toscano wrote: > > When the verify operation is executed, shouldn't the computed checksum be > > (immediately) shown in the corresponding text box? Makes sense, since it's then already calculated anyway. - Thomas

Re: Review Request 128283: Add checksums tab to the properties dialog

> On June 27, 2016, 12:16 p.m., Thomas Pfeiffer wrote: > > Thank you for implementing the suggestion! > > There are still some issues with it: > > 1. HIG says "Avoid using color as a primary method of communication". A > > red-green blind person would have no tell success apart from failure

Re: Review Request 128283: Add checksums tab to the properties dialog

> On June 27, 2016, 12:16 p.m., Thomas Pfeiffer wrote: > > Thank you for implementing the suggestion! > > There are still some issues with it: > > 1. HIG says "Avoid using color as a primary method of communication". A > > red-green blind person would have no tell success apart from failure

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 27, 2016, 3:46 p.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

> On June 27, 2016, 12:16 p.m., Thomas Pfeiffer wrote: > > Thank you for implementing the suggestion! > > There are still some issues with it: > > 1. HIG says "Avoid using color as a primary method of communication". A > > red-green blind person would have no tell success apart from failure

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96893 --- Thank you for implementing the suggestion! There are still

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96871 --- When the verify operation is executed, shouldn't the

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 26, 2016, 12:03 p.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-06-26 13:04 GMT+02:00 Jaroslaw Staniek : > readAll() is problematic, why to potentially fill all the ram completely, > thus removing cache? > Such approaches can degrade overall plasma's performance. > I see that QCryptographicHash accepts a QIODevice to read data from, I'll

Re: Review Request 128283: Add checksums tab to the properties dialog

readAll() is problematic, why to potentially fill all the ram completely, thus removing cache? Such approaches can degrade overall plasma's performance. Posted from a phone. On Sunday, 26 June 2016, Elvis Angelaccio wrote: > This is an automatically generated

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 26, 2016, 10:34 a.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 25, 2016, 2:52 p.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

> On June 25, 2016, 12:52 p.m., Thomas Pfeiffer wrote: > > First of all: I love the feature as such, as it makes the whole checksum > > comparison story actually usable for average users (although they'd still > > have to be told how to do it because they'd probably not get the idea that > >

Re: Review Request 128283: Add checksums tab to the properties dialog

> On June 25, 2016, 11:35 a.m., Christoph Feck wrote: > > I wished it was for the KIO overwrite dialog ;) > > > > Anyway, reading the file three times without the user asking for the > > checksums is a recipe for disk cache draining. > > > > I suggest to compute all checksums in parallel,

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96862 --- First of all: I love the feature as such, as it makes the

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96859 --- Nice feature, but please only start the calculation when

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96858 --- I wished it was for the KIO overwrite dialog ;) Anyway,