Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Leslie Zhai]

> On 九月 18, 2016, 10:41 a.m., Christoph Feck wrote:
> > I do not understand the bug report you linked to.
> > 
> > After applying rev 2 of this patch, I see that KMessageBox uses a scrollbar 
> > because the message text is really long, and after clicking the Details 
> > button, those are correctly shown.
> > 
> > What is the actual bug you are trying to fix?
> 
> Christoph Feck wrote:
> Sorry, applied repeated() to the wrong string. Now I see the bug.

Hi Christoph,

You are welcome! why say sorry to me ;-)

./tests/kmessageboxtest 14
click 'Details' button, detailsGroup is *NOT* able to show correctly!
I will try to fix as Anthony suggested!

Regards,
Leslie Zhai


- Leslie


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99246
---


On 九月 18, 2016, 10 a.m., Leslie Zhai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> ---
> 
> (Updated 九月 18, 2016, 10 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366569
> https://bugs.kde.org/show_bug.cgi?id=366569
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Hi David,
> 
> K3B use KMessageBox::detailedSorry to show message for not support protocol 
> such as add files from samba, but KMessageBox::detailedSorry hide some part 
> of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is 
> better to show it directly by default!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -
> 
>   tests/kmessageboxtest.cpp 8ea2848 
> 
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
> 
> 
> Testing
> ---
> 
> add case 26 in the patch, for long (> 512) details:
> 
> kwidgetsaddons/build/tests/kmessageboxtest 26
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Christoph Feck]

> On Sept. 18, 2016, 4:41 a.m., Christoph Feck wrote:
> > I do not understand the bug report you linked to.
> > 
> > After applying rev 2 of this patch, I see that KMessageBox uses a scrollbar 
> > because the message text is really long, and after clicking the Details 
> > button, those are correctly shown.
> > 
> > What is the actual bug you are trying to fix?

Sorry, applied repeated() to the wrong string. Now I see the bug.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99246
---


On Sept. 18, 2016, 4 a.m., Leslie Zhai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> ---
> 
> (Updated Sept. 18, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366569
> https://bugs.kde.org/show_bug.cgi?id=366569
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Hi David,
> 
> K3B use KMessageBox::detailedSorry to show message for not support protocol 
> such as add files from samba, but KMessageBox::detailedSorry hide some part 
> of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is 
> better to show it directly by default!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -
> 
>   tests/kmessageboxtest.cpp 8ea2848 
> 
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
> 
> 
> Testing
> ---
> 
> add case 26 in the patch, for long (> 512) details:
> 
> kwidgetsaddons/build/tests/kmessageboxtest 26
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99246
---



I do not understand the bug report you linked to.

After applying rev 2 of this patch, I see that KMessageBox uses a scrollbar 
because the message text is really long, and after clicking the Details button, 
those are correctly shown.

What is the actual bug you are trying to fix?

- Christoph Feck


On Sept. 18, 2016, 4 a.m., Leslie Zhai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> ---
> 
> (Updated Sept. 18, 2016, 4 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366569
> https://bugs.kde.org/show_bug.cgi?id=366569
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Hi David,
> 
> K3B use KMessageBox::detailedSorry to show message for not support protocol 
> such as add files from samba, but KMessageBox::detailedSorry hide some part 
> of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is 
> better to show it directly by default!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -
> 
>   tests/kmessageboxtest.cpp 8ea2848 
> 
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
> 
> 
> Testing
> ---
> 
> add case 26 in the patch, for long (> 512) details:
> 
> kwidgetsaddons/build/tests/kmessageboxtest 26
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Leslie Zhai]

> On 九月 15, 2016, 9:41 p.m., Kai Uwe Broulik wrote:
> > tests/kmessageboxtest.cpp, line 232
> > 
> >
> > QString QString::repeated(int times) const
> > 
> > Returns a copy of this string repeated the specified number of times.
> 
> Anthony Fieroni wrote:
> Fix it here 
> https://api.kde.org/frameworks/kwidgetsaddons/html/kmessagebox_8cpp_source.html#l00200

Hi Anthony,

Thanks for your hint, I will try to fix it ;-)

Regards,
Leslie Zhai


- Leslie


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99217
---


On 九月 18, 2016, 10 a.m., Leslie Zhai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> ---
> 
> (Updated 九月 18, 2016, 10 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366569
> https://bugs.kde.org/show_bug.cgi?id=366569
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Hi David,
> 
> K3B use KMessageBox::detailedSorry to show message for not support protocol 
> such as add files from samba, but KMessageBox::detailedSorry hide some part 
> of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is 
> better to show it directly by default!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -
> 
>   tests/kmessageboxtest.cpp 8ea2848 
> 
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
> 
> 
> Testing
> ---
> 
> add case 26 in the patch, for long (> 512) details:
> 
> kwidgetsaddons/build/tests/kmessageboxtest 26
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Leslie Zhai]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/
---

(Updated 九月 18, 2016, 10 a.m.)


Review request for KDE Frameworks and David Faure.


Changes
---

Hide the detailed group by default, and use repeated as textcase.


Bugs: 366569
https://bugs.kde.org/show_bug.cgi?id=366569


Repository: kwidgetsaddons


Description
---

Hi David,

K3B use KMessageBox::detailedSorry to show message for not support protocol 
such as add files from samba, but KMessageBox::detailedSorry hide some part of 
detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to 
show it directly by default!

Regards,
Leslie Zhai


Diffs (updated)
-

  tests/kmessageboxtest.cpp 8ea2848 

Diff: https://git.reviewboard.kde.org/r/128768/diff/


Testing
---

add case 26 in the patch, for long (> 512) details:

kwidgetsaddons/build/tests/kmessageboxtest 26


Thanks,

Leslie Zhai

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Anthony Fieroni]

> On Sept. 15, 2016, 4:41 p.m., Kai Uwe Broulik wrote:
> > tests/kmessageboxtest.cpp, line 232
> > 
> >
> > QString QString::repeated(int times) const
> > 
> > Returns a copy of this string repeated the specified number of times.

Fix it here 
https://api.kde.org/frameworks/kwidgetsaddons/html/kmessagebox_8cpp_source.html#l00200


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99217
---


On Sept. 15, 2016, 1:52 p.m., Leslie Zhai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> ---
> 
> (Updated Sept. 15, 2016, 1:52 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366569
> https://bugs.kde.org/show_bug.cgi?id=366569
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Hi David,
> 
> K3B use KMessageBox::detailedSorry to show message for not support protocol 
> such as add files from samba, but KMessageBox::detailedSorry hide some part 
> of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is 
> better to show it directly by default!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -
> 
>   src/kmessagebox.cpp 194ffae 
>   tests/kmessageboxtest.cpp 8ea2848 
> 
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
> 
> 
> Testing
> ---
> 
> add case 26 in the patch, for long (> 512) details:
> 
> kwidgetsaddons/build/tests/kmessageboxtest 26
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99217
---



-1

The details group is hidden by default for a reason and shouldn't contain vital 
information. It shouldn't be cut off, though, but properly collapsed and all. 
Or do I misunderstood what this patch is about?


tests/kmessageboxtest.cpp (line 232)


QString QString::repeated(int times) const

Returns a copy of this string repeated the specified number of times.


- Kai Uwe Broulik


On Sept. 15, 2016, 10:52 vorm., Leslie Zhai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> ---
> 
> (Updated Sept. 15, 2016, 10:52 vorm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366569
> https://bugs.kde.org/show_bug.cgi?id=366569
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Hi David,
> 
> K3B use KMessageBox::detailedSorry to show message for not support protocol 
> such as add files from samba, but KMessageBox::detailedSorry hide some part 
> of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is 
> better to show it directly by default!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -
> 
>   src/kmessagebox.cpp 194ffae 
>   tests/kmessageboxtest.cpp 8ea2848 
> 
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
> 
> 
> Testing
> ---
> 
> add case 26 in the patch, for long (> 512) details:
> 
> kwidgetsaddons/build/tests/kmessageboxtest 26
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Leslie Zhai]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/
---

(Updated Sept. 15, 2016, 10:52 a.m.)


Review request for KDE Frameworks and David Faure.


Bugs: 366569
https://bugs.kde.org/show_bug.cgi?id=366569


Repository: kwidgetsaddons


Description
---

Hi David,

K3B use KMessageBox::detailedSorry to show message for not support protocol 
such as add files from samba, but KMessageBox::detailedSorry hide some part of 
detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to 
show it directly by default!

Regards,
Leslie Zhai


Diffs
-

  src/kmessagebox.cpp 194ffae 
  tests/kmessageboxtest.cpp 8ea2848 

Diff: https://git.reviewboard.kde.org/r/128768/diff/


Testing
---

add case 26 in the patch, for long (> 512) details:

kwidgetsaddons/build/tests/kmessageboxtest 26


Thanks,

Leslie Zhai