reviewboard.kde.org/r/128073/#comment64993>
what's the point of having setDpms method around if the implementation is
ifdefed?
src/doctor/doctor.cpp (lines 144 - 155)
<https://git.reviewboard.kde.org/r/128073/#comment64994>
same here - the method is pointless
- Martin Gräßli
> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation
> > why we don't want this.
>
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with
> non-L
> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation
> > why we don't want this.
>
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with
> non-L
> On June 1, 2016, 10:13 a.m., Martin Gräßlin wrote:
> > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation
> > why we don't want this.
>
> Pino Toscano wrote:
> Nowhere there is discussed (only briefly mentioned) about support with
> non-L
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127387/#review93639
---
Ship it!
Ship It!
- Martin Gräßlin
On March 16, 2016
161)
<https://git.reviewboard.kde.org/r/127387/#comment63831>
QStringLiteral
- Martin Gräßlin
On March 16, 2016, 2:54 p.m., Sebastian Kügler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
isit:
> https://git.reviewboard.kde.org/r/126381/
> ---
>
> (Updated Dec. 17, 2015, 7:53 p.m.)
>
>
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
>
>
> Repository: libkscreen
>
>
> Descri
.reviewboard.kde.org/r/126381/#comment61439>
that's what Bill Gates said :-P
- Martin Gräßlin
On Dec. 17, 2015, 7:53 p.m., Sebastian Kügler wrote:
>
> ---
> This is a
some commented code.
backends/kwayland/waylandconfig.cpp (line 203)
<https://git.reviewboard.kde.org/r/126381/#comment61460>
this as context object?
backends/kwayland/waylandoutput.cpp (line 103)
<https://git.reviewboard.kde.org/r/126381/#comment61461>
this, [this]
- Ma
report would be
to add an autotest for it, though. @Kai: could that be achieved?
- Martin Gräßlin
On Sept. 11, 2015, 12:19 p.m., Xuetian Weng wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
marked as submitted.
Review request for Solid and Kai Uwe Broulik.
Changes
---
Submitted with commit 3321b9d2c78c64e6e7c9be4f7f14cb2776bc2e71 by Martin
Gräßlin to branch master.
Repository: powerdevil
Description
---
An AbstractDpmsHelper is introduced with a concrete subclass
* watched screen go off
* enabled again, looked at debug output to verify it was triggered by
powerdevil.
It's currently only tested with Qt 5.4. At least for idle integration I had the
problem that things somehow stopped working with 5.5. So this needs additional
testing.
Thanks,
Martin
impossible without Wayland.
Nevertheless: thanks for the approach to fixing the issue.
- Martin Gräßlin
On March 25, 2013, 4:23 p.m., Oliver Henshaw wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
that things somehow stopped working with 5.5. So this needs additional
testing.
Thanks,
Martin Gräßlin
___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
and inhibits suspend to
ensure the lock screen is in place before the system goes to sleep state).
- Martin Gräßlin
On July 19, 2015, 11:22 a.m., Eric Koegel wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
marked as submitted.
Review request for Solid and Kai Uwe Broulik.
Changes
---
Submitted with commit 3b56856d66f392bf18343f3b45f35da40813509f by Martin
Gräßlin to branch master.
Repository: powerdevil
Description
---
KJob::exec is dangerous and caused freezes on my system. Thus
marked as submitted.
Review request for Plasma and Solid.
Changes
---
Submitted with commit cc89ab71b572473f84d94868fc82993073992a12 by Martin
Gräßlin to branch master.
Repository: powerdevil
Description
---
The DPMS action is implemented in a very x11 specific way calling into
xcb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/#review79375
---
On April 23, 2015, 1:05 p.m., Martin Gräßlin wrote
: is
there a way to easily verify whether the module loaded completely?
Thanks,
Martin Gräßlin
___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
/powerdevilupowerbackend.cpp
87b9cc7b7db1b6a6f5b31263cd3832715c497328
Diff: https://git.reviewboard.kde.org/r/123475/diff/
Testing
---
kded5 no longer freezes. But I'm not sure whether the init gets finished: is
there a way to easily verify whether the module loaded completely?
Thanks,
Martin Gräßlin
don't trust Qt :-P
- Martin Gräßlin
On April 18, 2015, 6:34 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123418
://git.reviewboard.kde.org/r/122414/#comment52126
I doubt that the two xcb_flush are needed. The XFlush seem wrong to me,
too, and might only have been needed for the XSetErrorHandler calls.
Please try without the xcb_flushs.
- Martin Gräßlin
On Feb. 3, 2015, 10:18 p.m., Kai Uwe Broulik
://git.reviewboard.kde.org/r/121386/#comment51639
According to the commit message you still use XSync, but this is a sync
implementation. Maybe split out into a helper method and use it instead of
XSync?
- Martin Gräßlin
On Jan. 20, 2015, 7:44 p.m., Kai Uwe Broulik wrote
the code look
(nullptr, C++ style casts, etc) welcome.
Using KWin's xcbutils.h would significantly improve this. Maybe I should start
thinking of how we can split that out into a dedicated repo.
- Martin Gräßlin
On Jan. 20, 2015, 7:44 p.m., Kai Uwe Broulik wrote
no longer needed.
- Martin Gräßlin
On Jan. 18, 2015, 5:05 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122128
://git.reviewboard.kde.org/r/121386/#comment51599
do not use get_screen_resources: it blocks, see
https://bugreports.qt.io/browse/QTBUG-40207 and
https://bugs.kde.org/show_bug.cgi?id=329979#c17
- Martin Gräßlin
On Jan. 19, 2015, 10:30 p.m., Kai Uwe Broulik wrote
cd103c6d8da47be210b954e324bec3fc3fae5467
Diff: https://git.reviewboard.kde.org/r/121530/diff/
Testing
---
it compiles. I'm not familiar enough with powerdevil to know whether this is
correct.
Thanks,
Martin Gräßlin
___
Kde-hardware-devel mailing
://git.reviewboard.kde.org/r/121798/#comment50850
just wondering: why don't you make KWinScreenHelperEffect multiple inherit
from QObject and QAbstractNativeEventFilter?
overall looks good to me from X11 perspective.
- Martin Gräßlin
On Jan. 5, 2015, 10:27 a.m., Kai Uwe Broulik wrote
:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121857/
---
(Updated Jan. 5, 2015, 1:20 p.m.)
Review request for Solid and Martin Gräßlin.
Repository: powerdevil
Description
/kwineffect.cpp
https://git.reviewboard.kde.org/r/121798/#comment50846
the type xcb_atom_t looks wrong to me. It should just be a uint32_t IIRC
- Martin Gräßlin
On Jan. 3, 2015, 1:14 p.m., Kai Uwe Broulik wrote:
---
This is an automatically
/diff/
Testing
---
it compiles. I'm not familiar enough with powerdevil to know whether this is
correct.
Thanks,
Martin Gräßlin
___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
---
On Dec. 15, 2014, 11:45 a.m., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121530/
---
(Updated Dec. 15
is as obvious as xcb_randr_foo_bar_cookie_t cookie
- Martin Gräßlin
On Dec. 7, 2014, 10:36 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121386
implementation in KWin's xcbutils.h
- Martin Gräßlin
On Dec. 7, 2014, 10:36 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121386
On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote:
autotests/testqscreenbackend.cpp, line 66
https://git.reviewboard.kde.org/r/119822/diff/1/?file=306029#file306029line66
If we don't have a config even though we correctly configured the
backend, should not we fail? a QSKIP might be
On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote:
autotests/testqscreenbackend.cpp, line 90
https://git.reviewboard.kde.org/r/119822/diff/1/?file=306029#file306029line90
Q_FOREACH
or instead of using Qt macros one could use what the language provides: for
(const KScreen::Output *op
On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote:
Besides the nitpits, here is a concern I have.
KScreen is a library that should be used only by components of the shell
(kwin, plasma, kscreen), the idea is to have a library that manipulates
lowlevel stuff directly so we can control
37 matches
Mail list logo
