Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated Sept. 22, 2016, 6:41 p.m.) Review request for Telepathy and

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated Sept. 22, 2016, 6:41 p.m.) Review request for Telepathy,

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

> On Sept. 21, 2016, 9:19 a.m., Martin Klapetek wrote: > > > Use c++11 for loops instead of Q_FOREACH for new code. > > > > Please don't do that, it's slow. See > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ for > > more details. > > > > That said, I still don't

Re: Review Request 123485: ktp-kded-module status handler multiple account presence

> On Sept. 21, 2016, 9:23 a.m., Martin Klapetek wrote: > > > Use c++11 for loops instead of Q_FOREACH for new code. > > > > Please don't do that, it's slow. See > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ for > > more details. Q_FOREACH is going away, and we

Re: Review Request 128979: [ktp-common-internals] [otr-proxy] Fixed incorrect check of adaptee method existance (ChannelProxyInterfaceOTRAdaptor at this time)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128979/ --- (Updated Sept. 22, 2016, 12:25 p.m.) Status -- This change has been

Re: Review Request 128976: [Contact List Applet] Drop custom compact representation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128976/ --- (Updated Sept. 22, 2016, 7:25 a.m.) Status -- This change has been