Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated Sept. 22, 2016, 6:41 p.m.) Review request for Telepathy and Martin Klapetek. Changes --- 1) Fix terminating players can crash the kded module if TelepathyMPRIS wasn't able to complete rostering the player. 2) Revert use QDBusServiceWatcher's serviceOwnerChanged signal, which in QT 5.7 can no longer watch all ownership change events. 3) Active player selection tweaking. 4) Make Debug more informative and simpler. 5) Comment changes. Repository: ktp-kded-module Description --- New features: -Much improved multiple player handling; a number of service availability bugs were fixed. -Ignore tracks with inadequate metadata -Separator for empty metadata info fields with (currently) hidden config Diffs (updated) - telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 Diff: https://git.reviewboard.kde.org/r/123504/diff/ Testing --- Compile, run. Thanks, James Smith
Re: Review Request 123485: ktp-kded-module status handler multiple account presence
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/ --- (Updated Sept. 22, 2016, 6:41 p.m.) Review request for Telepathy, Dominik Cermak, David Edmundson, Lucas Betschart, and Martin Klapetek. Changes --- 1) Cache the last PluginQueue presence and status message values. Bugs: 293443, 334542, 337881, 340201, and 340781 http://bugs.kde.org/show_bug.cgi?id=293443 http://bugs.kde.org/show_bug.cgi?id=334542 http://bugs.kde.org/show_bug.cgi?id=337881 http://bugs.kde.org/show_bug.cgi?id=340201 http://bugs.kde.org/show_bug.cgi?id=340781 Repository: ktp-kded-module Description --- New classes: -AccountStatusHelper, a multiple-account-presence QDBusAbstractInterface replacement for AutoConnect. -PluginQueue, a QDBusAbstractInterface for presence and status message plugins. -Presence / Status Message Inserter classes, for queuing presences and status messages. New properties: -TelepathyKDEDModulePlugin: KTp::PluginQueue pluginState(). New methods: -TelepathyKDEDModulePlugin: virtual pluginInit(bool), method setPluginState(KTp::PluginQueue), method configureEnabled(bool). New features: -Newly enabled and online account presence changes to offline or account requested presence depending on network connection state and autoconnect property. -Offline global presence will override per-account presences temporarily. -PluginQueue globs presence change events. -StatusHandler dynamically disables and enables plugin queues if there are online accounts. -StatusHandler and TelepathyKDEDModulePlugin no longer require GlobalPresence. Various other cleanups, documentation, and improvements. Diffs (updated) - CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 account-status-helper.h PRE-CREATION account-status-helper.cpp PRE-CREATION autoaway.h 5e2a56100b56e6d21bc649f9032c8bece9031452 autoaway.cpp 4881c71afab2be2468c3c883523d2844865e6247 autoconnect.h 0f3ab137cf67cce9c7467144a45d1706ec9cc007 autoconnect.cpp 99512b265e0e6ae34f83263ffa6337741db652ea config/telepathy-kded-config.cpp 4ed6a16cc8f489794a08a3c031d7a8ec7b010b2d config/telepathy-kded-config.ui 2b80dfa34381af2e9206384a31c025f9b914854a org.kde.Telepathy.AccountStatusHelper.xml PRE-CREATION org.kde.Telepathy.PluginQueue.xml PRE-CREATION screensaveraway.h 92344e891ccde16d53771c3e279d845f4d800b2d screensaveraway.cpp f226564a5bf7b396965b5ae21f81d93b7edc3ef8 status-handler-plugin-queue.h PRE-CREATION status-handler-plugin-queue.cpp PRE-CREATION status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc telepathy-kded-module-plugin.h 4c161696a706e82059a7eb314773c3644fe26bd7 telepathy-kded-module-plugin.cpp daf73c66947bc946097de7a8e8a1518555131145 telepathy-module.h 17ef4cef27b90cbced6c66846ed82cb5c36fb532 telepathy-module.cpp b74053bc1817d773a4fe37769e42f4013ced5425 telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 telepathy-status-inserter.h PRE-CREATION telepathy-status-inserter.cpp PRE-CREATION tests/CMakeLists.txt 7ec77495417a6790060ea5ea7126c46399dff755 Diff: https://git.reviewboard.kde.org/r/123485/diff/ Testing --- Compile, run. Thanks, James Smith
Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence
> On Sept. 21, 2016, 9:19 a.m., Martin Klapetek wrote: > > > Use c++11 for loops instead of Q_FOREACH for new code. > > > > Please don't do that, it's slow. See > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ for > > more details. > > > > That said, I still don't agree with this patch. > > Alexandr Akulich wrote: > qAsConst? Q_FOREACH is going away, and we iterate over a really small number of values anyway. Also, everything looks already const or is unshared, so there's no actual need for qAsConst(). - James --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/#review99369 --- On Sept. 17, 2016, 4:03 p.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123504/ > --- > > (Updated Sept. 17, 2016, 4:03 p.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Repository: ktp-kded-module > > > Description > --- > > New features: > -Much improved multiple player handling; a number of service availability > bugs were fixed. > -Ignore tracks with inadequate metadata > -Separator for empty metadata info fields with (currently) hidden config > > > Diffs > - > > telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 > telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 > > Diff: https://git.reviewboard.kde.org/r/123504/diff/ > > > Testing > --- > > Compile, run. > > > Thanks, > > James Smith > >
Re: Review Request 123485: ktp-kded-module status handler multiple account presence
> On Sept. 21, 2016, 9:23 a.m., Martin Klapetek wrote: > > > Use c++11 for loops instead of Q_FOREACH for new code. > > > > Please don't do that, it's slow. See > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ for > > more details. Q_FOREACH is going away, and we iterate over a very small number of either const or unshared values. So need for qAsConst() here either. - James --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123485/#review99370 --- On Sept. 17, 2016, 4:03 p.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123485/ > --- > > (Updated Sept. 17, 2016, 4:03 p.m.) > > > Review request for Telepathy, Dominik Cermak, David Edmundson, Lucas > Betschart, and Martin Klapetek. > > > Bugs: 293443, 334542, 337881, 340201, and 340781 > http://bugs.kde.org/show_bug.cgi?id=293443 > http://bugs.kde.org/show_bug.cgi?id=334542 > http://bugs.kde.org/show_bug.cgi?id=337881 > http://bugs.kde.org/show_bug.cgi?id=340201 > http://bugs.kde.org/show_bug.cgi?id=340781 > > > Repository: ktp-kded-module > > > Description > --- > > New classes: > -AccountStatusHelper, a multiple-account-presence QDBusAbstractInterface > replacement for AutoConnect. > -PluginQueue, a QDBusAbstractInterface for presence and status message > plugins. > -Presence / Status Message Inserter classes, for queuing presences and status > messages. > > New properties: > -TelepathyKDEDModulePlugin: KTp::PluginQueue pluginState(). > > New methods: > -TelepathyKDEDModulePlugin: virtual pluginInit(bool), method > setPluginState(KTp::PluginQueue), method configureEnabled(bool). > > New features: > -Newly enabled and online account presence changes to offline or account > requested presence depending on network connection state and autoconnect > property. > -Offline global presence will override per-account presences temporarily. > -PluginQueue globs presence change events. > -StatusHandler dynamically disables and enables plugin queues if there are > online accounts. > -StatusHandler and TelepathyKDEDModulePlugin no longer require GlobalPresence. > > Various other cleanups, documentation, and improvements. > > > Diffs > - > > CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 > account-status-helper.h PRE-CREATION > account-status-helper.cpp PRE-CREATION > autoaway.h 5e2a56100b56e6d21bc649f9032c8bece9031452 > autoaway.cpp 4881c71afab2be2468c3c883523d2844865e6247 > autoconnect.h 0f3ab137cf67cce9c7467144a45d1706ec9cc007 > autoconnect.cpp 99512b265e0e6ae34f83263ffa6337741db652ea > config/telepathy-kded-config.cpp 4ed6a16cc8f489794a08a3c031d7a8ec7b010b2d > config/telepathy-kded-config.ui 2b80dfa34381af2e9206384a31c025f9b914854a > org.kde.Telepathy.AccountStatusHelper.xml PRE-CREATION > org.kde.Telepathy.PluginQueue.xml PRE-CREATION > screensaveraway.h 92344e891ccde16d53771c3e279d845f4d800b2d > screensaveraway.cpp f226564a5bf7b396965b5ae21f81d93b7edc3ef8 > status-handler-plugin-queue.h PRE-CREATION > status-handler-plugin-queue.cpp PRE-CREATION > status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff > status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc > telepathy-kded-module-plugin.h 4c161696a706e82059a7eb314773c3644fe26bd7 > telepathy-kded-module-plugin.cpp daf73c66947bc946097de7a8e8a1518555131145 > telepathy-module.h 17ef4cef27b90cbced6c66846ed82cb5c36fb532 > telepathy-module.cpp b74053bc1817d773a4fe37769e42f4013ced5425 > telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 > telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 > telepathy-status-inserter.h PRE-CREATION > telepathy-status-inserter.cpp PRE-CREATION > tests/CMakeLists.txt 7ec77495417a6790060ea5ea7126c46399dff755 > > Diff: https://git.reviewboard.kde.org/r/123485/diff/ > > > Testing > --- > > Compile, run. > > > Thanks, > > James Smith > >
Re: Review Request 128979: [ktp-common-internals] [otr-proxy] Fixed incorrect check of adaptee method existance (ChannelProxyInterfaceOTRAdaptor at this time)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128979/ --- (Updated Sept. 22, 2016, 12:25 p.m.) Status -- This change has been marked as submitted. Review request for Telepathy. Repository: ktp-common-internals Description --- Fixed incorrect check of adaptee method existance See also: https://git.reviewboard.kde.org/r/128844 I have no idea how I missed this at the first time. Diffs - otr-proxy/KTpProxy/svc-channel-proxy.cpp db5d474 Diff: https://git.reviewboard.kde.org/r/128979/diff/ Testing --- Compiles with less warnings Thanks, Alexandr Akulich
Re: Review Request 128976: [Contact List Applet] Drop custom compact representation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128976/ --- (Updated Sept. 22, 2016, 7:25 a.m.) Status -- This change has been marked as submitted. Review request for Telepathy, Aleix Pol Gonzalez and David Edmundson. Changes --- Submitted with commit 2da2d251e26be335afd4df1877aaf503c24518dd by Kai Uwe Broulik to branch master. Repository: ktp-desktop-applets Description --- All it did was show an icon with a MouseArea, we can just set the plasmoid.icon instead Diffs - contactlist/org.kde.ktp-contactlist/contents/ui/Presence.qml 575d97f contactlist/org.kde.ktp-contactlist/contents/ui/main.qml 43b8c8e Diff: https://git.reviewboard.kde.org/r/128976/diff/ Testing --- I now get proper hover effect on the tray icon and it still works because DefaultCompactRepresentation is also just an IconItem Thanks, Kai Uwe Broulik
