Re: Review Request 126378: remove kactivities on windows

2017-03-17 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/126378/diff/ Testing --- Windows. Thanks, Patrick Spendrin

Re: Review Request 127123: Update information on windows.kde.org index page.

2016-03-11 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127123/#review93417 --- Ship it! Ship It! - Patrick Spendrin On März 6, 2016

Re: Review Request 126375: Remove kdelibs4support from the generator plugins

2016-01-30 Thread Patrick Spendrin
marked as submitted. Review request for kdewin and Okular. Changes --- Submitted with commit 37d562310266a85b21896cbe8ab333f0e7f680d5 by Aleix Pol on behalf of Patrick Spendrin to branch frameworks. Repository: okular Description --- This removes kdelibs4support for all generators

[kde-windows] [Bug 357240] emerging KCoreAddons fails by CMake Internal Error on Win 8.1 x64

2015-12-28 Thread Patrick Spendrin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357240 Patrick Spendrin <ps...@gmx.de> changed: What|Removed |Added CC||ps...@gmx.de

Re: Review Request 126379: Windows string fixes

2015-12-28 Thread Patrick Spendrin
marked as submitted. Review request for kdewin and Okular. Changes --- Submitted with commit d0ecab47368288ec00318dccb6dfcd9fc79a8e8b by Patrick Spendrin to branch frameworks. Repository: okular Description --- This patch changes multiline QStringLiterals to QString::fromLatin1

Re: Review Request 126415: simple windows fixes

2015-12-28 Thread Patrick Spendrin
24954ae5a6f27247b92355c923528f5c6311f446 Diff: https://git.reviewboard.kde.org/r/126415/diff/ Testing --- Windows. Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 126415: simple windows fixes

2015-12-28 Thread Patrick Spendrin
this place empty wasn't allowed by the preprocessor. source code is utf8, so likely this needs to be utf8 here as well. Diffs - src/lib/core/controller.cpp 24954ae5a6f27247b92355c923528f5c6311f446 Diff: https://git.reviewboard.kde.org/r/126415/diff/ Testing --- Windows. Thanks, Patrick

[kde-windows] [Bug 357117] Changed ActivePerl version

2015-12-26 Thread Patrick Spendrin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357117 Patrick Spendrin <ps...@gmx.de> changed: What|Removed |Added CC||ps...@

Re: Review Request 126379: Windows string fixes

2015-12-26 Thread Patrick Spendrin
/latexrenderer.cpp 8e42a9f88a8aa4ff73b544bf41642d59ca86474a ui/pageview.cpp 13727e4647781cd9222956cae2c9e3fbc1a42324 Diff: https://git.reviewboard.kde.org/r/126379/diff/ Testing --- Windows. Thanks, Patrick Spendrin ___ Kde-windows mailing list

Re: Review Request 126378: remove kactivities on windows

2015-12-16 Thread Patrick Spendrin
al on Windows/Mac. I'll try to get a comment from ivan first... - Patrick --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126378/#review89610 -------

Re: Review Request 126375: Remove kdelibs4support from the generator plugins

2015-12-16 Thread Patrick Spendrin
ard.kde.org/r/126375/#review89607 --- On Dez. 16, 2015, 12:41 vorm., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 126375: Remove kdelibs4support from the generator plugins

2015-12-15 Thread Patrick Spendrin
/tiff/generator_tiff.cpp cf4f2762a506a07288bb6fb1169ddbceb5a5eccb ui/guiutils.cpp 379d1e625e7b77a870ed04258a3fe1de3aadeb91 ui/pagepainter.cpp 0c8443cc93c0d81e0cf92a7f5bd9ac3c79a0fb3a Diff: https://git.reviewboard.kde.org/r/126375/diff/ Testing --- Windows. Thanks, Patrick Spendrin

Review Request 126378: remove kactivities on windows

2015-12-15 Thread Patrick Spendrin
/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d Diff: https://git.reviewboard.kde.org/r/126378/diff/ Testing --- Windows. Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 126378: remove kactivities on windows

2015-12-15 Thread Patrick Spendrin
on windows, I can of course also change this review... - Patrick Spendrin On Dez. 16, 2015, 1:16 vorm., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 126379: Windows string fixes

2015-12-15 Thread Patrick Spendrin
8e42a9f88a8aa4ff73b544bf41642d59ca86474a ui/pageview.cpp 13727e4647781cd9222956cae2c9e3fbc1a42324 Diff: https://git.reviewboard.kde.org/r/126379/diff/ Testing --- Windows. Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org

Re: QStandardPaths Patch

2015-10-13 Thread Patrick Spendrin
PPolHy95l9/jIjAQeDLi7Ey3V+RwqY1UXrOuqVqqC DYDp/NkPXsgx2HAMopNb0qRcpj7GBmOcgC7TkYrFHqSiKtXEQfzAOPrTklYhsaD/ eihYIY+6EpGbDhwWRwnE =ZEVq -END PGP SIGNATURE- From c6524a252fc362abe5b8412dcabec499ff092143 Mon Sep 17 00:00:00 2001 From: Patrick Spendrin <ps...@gmx.de> Date: Tue, 29 Sep 2015 15:47:09 +0200 Subject: [PATCH] WIP:

Re: Review Request 125580: Make qt-libs/poppler compile with MSVC 2015.

2015-10-12 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125580/#review86693 --- Ship it! Ship It! - Patrick Spendrin On Okt. 11, 2015, 4

Re: Review Request 125580: Make qt-libs/poppler compile with MSVC 2015.

2015-10-10 Thread Patrick Spendrin
is should go into the default buildsystem as if(MSVC) add_definitions(-DWIN32_LEAN_AND_MEAN) endif() I think. - Patrick Spendrin On Okt. 10, 2015, 9:13 vorm., Gleb Popov wrote: > > --- > This is an automatically gener

Re: Review Request 125580: Make qt-libs/poppler compile with MSVC 2015.

2015-10-10 Thread Patrick Spendrin
Toscano (pinotree) as the patch needs to get upstream to poppler. - Patrick Spendrin On Okt. 10, 2015, 9:13 vorm., Gleb Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: KCM's and Plasma-desktop

2015-10-09 Thread Patrick Spendrin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 09.10.2015 um 13:30 schrieb Vishesh Handa: > On Mon, Oct 5, 2015 at 5:20 PM, Hannah von Reth > wrote: >> Baloo could be useful. > > Baloo is only for linux. Windows has its own search solution far > superior to ours. Well, I

Re: Review Request 125401: implement windows usermetadata

2015-09-28 Thread Patrick Spendrin
marked as submitted. Review request for Baloo and kdewin. Changes --- Submitted with commit da334383058cc72af032b811c6dda21d7b879f6d by Patrick R. Spendrin on behalf of Patrick Spendrin to branch master. Repository: kfilemetadata Description --- I implemented all the functions

Re: Review Request 125401: implement windows usermetadata

2015-09-27 Thread Patrick Spendrin
for other platforms Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 125401: implement windows usermetadata

2015-09-26 Thread Patrick Spendrin
17af92dd5744ed061eedc3c2834 > > Diff: https://git.reviewboard.kde.org/r/125401/diff/ > > > Testing > --- > > On Windows; since most of the code is ifdeffed anyway, it shouldn't matter > for other platforms > > > Thanks, > > Patrick Spendrin > > ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 125401: implement windows usermetadata

2015-09-25 Thread Patrick Spendrin
/usermetadata.cpp 28967287d67d3e15a548a4e3fda614568dc932a3 src/xattr_p.h 80ea4c7767e5017af92dd5744ed061eedc3c2834 Diff: https://git.reviewboard.kde.org/r/125401/diff/ Testing --- On Windows; since most of the code is ifdeffed anyway, it shouldn't matter for other platforms Thanks, Patrick

Review Request 124911: replace noexcept by Q_DECL_NOEXCEPT

2015-08-25 Thread Patrick Spendrin
Description --- This makes it possible to build kdevplatform with msvc2013 Diffs - plugins/outlineview/outlinenode.h fef935ac7d11a6e29190ae8330835a3fcf1b934d Diff: https://git.reviewboard.kde.org/r/124911/diff/ Testing --- msvc2013 Thanks, Patrick Spendrin

Re: Review Request 124881: Disable building GSL tests on MSVC

2015-08-25 Thread Patrick Spendrin
? Maybe we can also update gsl (if it hasn't happened yet). - Patrick Spendrin On Aug. 22, 2015, 3:43 nachm., Michael Abrahams wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124881

Re: Review Request 124847: add COMMON_HEADER option and multiple header functionality

2015-08-25 Thread Patrick Spendrin
marked as submitted. Review request for Build System, Extra Cmake Modules, kdewin, and Allen Winter. Changes --- Submitted with commit 8ef3f474e3a6def47dce36b54fbdce2d98c79342 by Patrick Spendrin to branch master. Repository: extra-cmake-modules Description --- This adds a new

Review Request 124847: add COMMON_HEADER option and multiple header functionality

2015-08-20 Thread Patrick Spendrin
1db623b7349d72ff3e90dcb274d9a0c8cba8dab0 Diff: https://git.reviewboard.kde.org/r/124847/diff/ Testing --- Windows and Linux Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 124818: Fix update-mime-database crash.

2015-08-19 Thread Patrick Spendrin
the crash on x64 though, so maybe you can describe it a bit more? - Patrick Spendrin On Aug. 19, 2015, 1:42 nachm., arrowdodger arrowdodger wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Removal help needed

2015-08-12 Thread Patrick Spendrin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 11.08.2015 um 11:58 schrieb Anne Wilson: Hi. I have KDE installed on an older laptop which has just been upgraded from Windows 7 to Windows 10. The KDE apps are no longer used on that laptop (they are 2 years old), so I wanted to remove

Re: Review Request 117829: do not raise unknown signal on windows

2015-02-04 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/117829/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 122177: some minor fixes for windows

2015-01-20 Thread Patrick Spendrin
Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120481: Do not skip searching for X11 and Wayland modules on Windows

2014-10-17 Thread Patrick Spendrin
not against it. - Patrick Spendrin On Okt. 16, 2014, 6:48 nachm., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120481

Re: Review Request 120365: export functions that are needed in the other dlls

2014-09-25 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/120365/diff/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120366: variable length arrays can't be static on windows

2014-09-25 Thread Patrick Spendrin
- parser/parser.y 56e9b9a6b0ccb1d32e6eafcb5b6fde4283cf4293 Diff: https://git.reviewboard.kde.org/r/120366/diff/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman

Re: Review Request 120364: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin
043d347f32caead63f9df009cac0985b2343bc8e rails/export.h 4b6260282df53726d4b3b60b17dc5237a61dd5dc Diff: https://git.reviewboard.kde.org/r/120364/diff/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org

Review Request 120367: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/120367/diff/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 120368: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin
/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120365: export functions that are needed in the other dlls

2014-09-25 Thread Patrick Spendrin
56e9b9a6b0ccb1d32e6eafcb5b6fde4283cf4293 Diff: https://git.reviewboard.kde.org/r/120365/diff/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 120364: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin
ca61e6116172d9ad2ca8db378fc76e5c2551039d rails/CMakeLists.txt 043d347f32caead63f9df009cac0985b2343bc8e rails/export.h 4b6260282df53726d4b3b60b17dc5237a61dd5dc Diff: https://git.reviewboard.kde.org/r/120364/diff/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin

Re: Review Request 120367: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin
duchain/tests/CMakeLists.txt 524466d985a4fe0c80e4c1315c34258eb3cd976e Diff: https://git.reviewboard.kde.org/r/120367/diff/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https

Re: Review Request 120368: replace export headers w. generate_export_headers

2014-09-25 Thread Patrick Spendrin
0d462223f81aacf2f920503d7c064c338b16c05e Diff: https://git.reviewboard.kde.org/r/120368/diff/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 120324: Simplify CMake code for DTD generation (WIN32/non-WIN32)

2014-09-25 Thread Patrick Spendrin
On Sept. 22, 2014, 10:53 nachm., Luigi Toscano wrote: Re-reading the code and the comments, the core of the problem is described later, in another part which should be touched by the patch. The comment says: # WARNING: this has severe limitations on the windows platform since the

Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-07 Thread Patrick Spendrin
Description --- on windows static arrays can only be initialized with a const Diffs - src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7 Diff: https://git.reviewboard.kde.org/r/120096/diff/ Testing --- windows Thanks, Patrick Spendrin

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-23 Thread Patrick Spendrin
/118852/#comment42406 Did you try out whether removing the Flags calls did change something? - Patrick Spendrin On June 21, 2014, 12:20 a.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Plasma-desktop on non Xorg (X11/Wayland) windowing systems?

2014-06-11 Thread Patrick Spendrin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 11.06.2014 12:25, schrieb Marco Martin: On Wednesday 11 June 2014, Martin Gräßlin wrote: Hi all! The review request [1] raised the question whether it makes sense that we have any support for building without X11 support. Right now the

Review Request 118147: fix running ECMKDEModules test

2014-05-15 Thread Patrick Spendrin
, and kdewin. Repository: extra-cmake-modules Description --- fix running ECMKDEModules test Diffs - tests/ExecuteKDEModules/CMakeLists.txt e149ec7af0f85cf3b4a0e3501fc23befad6403b9 Diff: https://git.reviewboard.kde.org/r/118147/diff/ Testing --- windows Thanks, Patrick

Re: Review Request 118119: remove unneeded header

2014-05-15 Thread Patrick Spendrin
--- mingw windows Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick Spendrin
-framework Description --- remove unneeded file which collides with kf5plasma exports Diffs - autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 Diff: https://git.reviewboard.kde.org/r/118153/diff/ Testing --- mingw Thanks, Patrick Spendrin

Review Request 118155: adapt to ecm_add_tests so that tests can be found

2014-05-15 Thread Patrick Spendrin
-framework Description --- adapt to ecm_add_tests so that tests can be found Diffs - autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 Diff: https://git.reviewboard.kde.org/r/118155/diff/ Testing --- mingw Thanks, Patrick Spendrin

Re: Review Request 118147: fix running ECMKDEModules test

2014-05-15 Thread Patrick Spendrin
: https://git.reviewboard.kde.org/r/118147/diff/ Testing --- windows Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/118153/diff/ Testing --- mingw Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 118115: adapt to ecm_add_test

2014-05-13 Thread Patrick Spendrin
) 43 - indenttest (Failed) 44 - commands_test (Failed) 45 - scripting_test (SEGFAULT) 46 - bug313759 (Failed) 51 - keys (Failed) If some of these now fail on Linux too, please tell me. Thanks, Patrick Spendrin ___ Kde

Review Request 118119: remove unneeded header

2014-05-13 Thread Patrick Spendrin
-framework Description --- remove unneeded header Diffs - src/plasma/theme.cpp aed5b98609d8502f05ca8b8404d92efd4eedf8d4 Diff: https://git.reviewboard.kde.org/r/118119/diff/ Testing --- mingw windows Thanks, Patrick Spendrin

Re: Review Request 118085: adapt to ecm_add_tests

2014-05-12 Thread Patrick Spendrin
Diff: https://git.reviewboard.kde.org/r/118085/diff/ Testing --- windows gcc, not all tests pass, and I can't say if that is due to my change (it shouldn't be) Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https

Review Request 118085: adapt to ecm_add_tests

2014-05-11 Thread Patrick Spendrin
tests pass, and I can't say if that is due to my change (it shouldn't be) Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 118026: Fix KF5_ADD_KDEINIT_EXECUTABLE on Windows

2014-05-07 Thread Patrick Spendrin
required us to use the current setup. If it becomes a problem, we have to modify it anyway. - Patrick Spendrin On May 6, 2014, 8:29 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117962: forward declare specialisation

2014-05-06 Thread Patrick Spendrin
after instantiation. Diffs - src/lib/util/kuser.h 7b14ab2b2b31fcc3c624bba6068df6ad80b779fe Diff: https://git.reviewboard.kde.org/r/117962/diff/ Testing --- mingw gcc, *nix and msvc still required Thanks, Patrick Spendrin ___ Kde-windows

Re: Review Request 117961: remove several warnings on mingw

2014-05-06 Thread Patrick Spendrin
, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

KF5 on Windows IRC meeting tonight

2014-05-06 Thread Patrick Spendrin
Hi everybody, for those interested, there will be a kf5 meeting on #kde-windows on freenode tonight at 20:00 UTC (22:00 CEST). Some topics can be gathered on the wiki page: http://techbase.kde.org/Projects/KDE_on_Windows/kf5/meetingnotes-2014-05-06 sorry for the short notice, regards, Patrick

Re: Review Request 117965: use the correct global variables

2014-05-04 Thread Patrick Spendrin
and import static libraries and plugins end up in the lib subdir of the build directory. Diffs - kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 Diff: https://git.reviewboard.kde.org/r/117965/diff/ Testing --- windows Thanks, Patrick Spendrin

Re: Review Request 117961: remove several warnings on mingw

2014-05-03 Thread Patrick Spendrin
--- On May 2, 2014, 9:16 p.m., Patrick Spendrin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117961/ --- (Updated May 2

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/#review57180 --- On May 2, 2014, 10:53 p.m., Patrick Spendrin wrote: --- This is an automatically

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
in the lib subdir of the build directory. Diffs - kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 Diff: https://git.reviewboard.kde.org/r/117965/diff/ Testing --- windows Thanks, Patrick Spendrin ___ Kde

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
On May 3, 2014, 10:10 a.m., Alex Merry wrote: kde-modules/KDECMakeSettings.cmake, lines 170-176 https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170 Now the comment doesn't match the code - which is correct? Patrick Spendrin wrote: The fix here

Re: Review Request 117967: use different syntax to run the target in question instead of an executable in the path

2014-05-03 Thread Patrick Spendrin
/ Testing --- windows Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
subdir of the build directory. Diffs (updated) - kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 Diff: https://git.reviewboard.kde.org/r/117965/diff/ Testing --- windows Thanks, Patrick Spendrin ___ Kde

Re: Review Request 117845: rename test as another exists with the same name

2014-05-02 Thread Patrick Spendrin
. Repository: baloo Description --- rename test as another exists with the same name Diffs - src/file/tests/CMakeLists.txt 52662c1515b07a79126d387241f192c3d46dab30 Diff: https://git.reviewboard.kde.org/r/117845/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin

Re: Review Request 117845: rename test as another exists with the same name

2014-05-02 Thread Patrick Spendrin
/ Testing --- msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117961: remove several warnings on mingw

2014-05-02 Thread Patrick Spendrin
src/lib/util/kuser_win.cpp 2018a129f3ef9911df0c3f071d1617cac3026168 Diff: https://git.reviewboard.kde.org/r/117961/diff/ Testing --- mingw only, needs testing on *nix and on msvc Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde

Review Request 117962: forward declare specialisation

2014-05-02 Thread Patrick Spendrin
7b14ab2b2b31fcc3c624bba6068df6ad80b779fe Diff: https://git.reviewboard.kde.org/r/117962/diff/ Testing --- mingw gcc, *nix and msvc still required Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117965: use the correct global variables

2014-05-02 Thread Patrick Spendrin
, and kdewin. Repository: extra-cmake-modules Description --- use the correct global variables Diffs - kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 Diff: https://git.reviewboard.kde.org/r/117965/diff/ Testing --- windows Thanks, Patrick

Re: Review Request 117851: fix finding the dummy extractor

2014-04-29 Thread Patrick Spendrin
/fileindexingjob/CMakeLists.txt 3fc5b2b03ecfcec9cffa2510a00b7b161ebbf94a src/file/autotest/fileindexingjob/fileindexingjobtest.cpp 8a0ca84f74f622990766d737ee6a1b108dca9068 Diff: https://git.reviewboard.kde.org/r/117851/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin

Review Request 117825: exclude check for extended attributes for Windows

2014-04-28 Thread Patrick Spendrin
--- at the moment, extended attributes are not supported on windows. The headers do not exist as well, so the check fails all the time. Diffs - ConfigureChecks.cmake 34db1e4 Diff: https://git.reviewboard.kde.org/r/117825/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin

Review Request 117826: check that the directories are actually really removed

2014-04-28 Thread Patrick Spendrin
, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117827: malloc_trim is a gnu extension

2014-04-28 Thread Patrick Spendrin
/117827/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117828: prevent ex/import in exported classes used in tests

2014-04-28 Thread Patrick Spendrin
/autotests/CMakeLists.txt 95a0916 src/file/search/autotest/CMakeLists.txt eb058d2 src/file/tests/CMakeLists.txt 102c981 Diff: https://git.reviewboard.kde.org/r/117828/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde

Review Request 117829: do not raise unknown signal on windows

2014-04-28 Thread Patrick Spendrin
Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Patrick Spendrin
msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Patrick Spendrin
/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Patrick Spendrin
/#review56737 --- On April 28, 2014, 9:58 a.m., Patrick Spendrin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117830

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Patrick Spendrin
--- On April 28, 2014, 10:05 a.m., Patrick Spendrin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117832

Re: Review Request 117828: prevent ex/import in exported classes used in tests

2014-04-28 Thread Patrick Spendrin
msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117830: disable extended attributes support on windows

2014-04-28 Thread Patrick Spendrin
/xattrdetector.cpp 9bff838 Diff: https://git.reviewboard.kde.org/r/117830/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117827: malloc_trim is a gnu extension

2014-04-28 Thread Patrick Spendrin
on it. Diffs - src/xapian/xapiandatabase.cpp 0478139 Diff: https://git.reviewboard.kde.org/r/117827/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman

Re: Review Request 117825: exclude check for extended attributes for Windows

2014-04-28 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/117825/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117826: check that the directories are actually really removed

2014-04-28 Thread Patrick Spendrin
: https://git.reviewboard.kde.org/r/117826/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117846: make filesearchstoretest a console application

2014-04-28 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/117846/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 117845: make filesearchstoretest a console application

2014-04-28 Thread Patrick Spendrin
--- msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Patrick Spendrin
/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a Diff: https://git.reviewboard.kde.org/r/117845/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Patrick Spendrin
7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a Diff: https://git.reviewboard.kde.org/r/117845/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117846: make filesearchstoretest a console application

2014-04-28 Thread Patrick Spendrin
/file/search/autotest/CMakeLists.txt 836ef2bfb29562aa36d8ebca8678932e5f01e0f3 Diff: https://git.reviewboard.kde.org/r/117846/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https

Re: Review Request 117845: rename test as another exists with the same name

2014-04-28 Thread Patrick Spendrin
. Repository: baloo Description --- rename test as another exists with the same name Diffs - src/file/tests/CMakeLists.txt 4f186483a9644d7b8de84335929cda16ceff71f3 Diff: https://git.reviewboard.kde.org/r/117845/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin

Re: Review Request 117851: fix finding the dummy extractor

2014-04-28 Thread Patrick Spendrin
3fc5b2b03ecfcec9cffa2510a00b7b161ebbf94a src/file/autotest/fileindexingjob/fileindexingjobtest.cpp 8a0ca84f74f622990766d737ee6a1b108dca9068 Diff: https://git.reviewboard.kde.org/r/117851/diff/ Testing (updated) --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

2014-04-28 Thread Patrick Spendrin
/autotest/fileindexerconfigutils.h ab52f3b Diff: https://git.reviewboard.kde.org/r/117832/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-24 Thread Patrick Spendrin
is QStandardPaths with QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I think %APPDATA%. KF5 based KDE software won't work otherwise since it can't find the data. I think the better way of fixing this is patching Qt, but for now this works. Patrick Spendrin wrote: Can

Re: Review Request 117649: gcrypt: Fix VERSION variable in generated gcrypt.h

2014-04-19 Thread Patrick Spendrin
though. I have to say though that for gcrypt we will have to maintain the cmake stuff ourselves anyway, so no need to be shy here: just commit it. - Patrick Spendrin On April 19, 2014, 7:24 p.m., Nicolás Alvarez wrote

Re: Review Request 117646: Drop support for Windows CE on gcrypt

2014-04-19 Thread Patrick Spendrin
. - Patrick Spendrin On April 19, 2014, 7:24 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117646

[kde-windows] [Bug 330827] When I start kde on cygwin64, kded4 seems like go to infinity loop and KDE stucks. If i remove kded, all OK, but all servcies are disabled

2014-02-09 Thread Patrick Spendrin
https://bugs.kde.org/show_bug.cgi?id=330827 Patrick Spendrin ps...@gmx.de changed: What|Removed |Added CC||ps...@gmx.de --- Comment #2

Re: Where is konsole?

2014-01-24 Thread Patrick Spendrin
Am 23.01.2014 14:08, schrieb Yuri Samoilenko: Because Konsole is just way to display a terminal window, and not the terminal itself. Konsole itself only sends and receives the information from the terminal, which means on Windows, Konsole actually wraps those nice black shitty

  1   2   3   4   5   6   7   >