Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114964/ --- Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114964/#review47190 --- src/backends/python2/CMakeLists.txt

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Albert Astals Cid
On Jan. 11, 2014, 2:52 p.m., Albert Astals Cid wrote: src/backends/python2/CMakeLists.txt, line 15 https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15 Shouldn't this go into the kdewin include files then? Andrius da Costa Ribas wrote: kdewin does

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Andrius da Costa Ribas
On Jan. 11, 2014, 2:52 p.m., Albert Astals Cid wrote: src/backends/python2/CMakeLists.txt, line 15 https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15 Shouldn't this go into the kdewin include files then? Andrius da Costa Ribas wrote: kdewin does

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Albert Astals Cid
On Jan. 11, 2014, 2:52 p.m., Albert Astals Cid wrote: src/backends/python2/CMakeLists.txt, line 15 https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15 Shouldn't this go into the kdewin include files then? Andrius da Costa Ribas wrote: kdewin does

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Andrius da Costa Ribas
On Jan. 11, 2014, 2:52 p.m., Albert Astals Cid wrote: src/backends/python2/CMakeLists.txt, line 15 https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15 Shouldn't this go into the kdewin include files then? Andrius da Costa Ribas wrote: kdewin does

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Alexander Rieder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114964/#review47227 --- Ship it! looks save enough. Go ahead and commit. -

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114964/#review47228 --- This review has been submitted with commit