Re: Calligra fails on MSVC

2021-03-08 Thread Andrius da Costa Ribas
I can't check it right now, but we shouldn't be linking to a plugin (calligra_shape_spreadsheet target having calligrasheetspart in target_link_libraries). Other libs are SHARED instead of MODULE. -- Em seg., 8 de mar. de 2021 às 06:01, Dag escreveu: > Hi, > I don't have windows to test on so

Re: A new tier1 for icontheme.rcc handling

2018-01-20 Thread Andrius da Costa Ribas
+1 for the name kiconsupport as Ben suggested. Em 19 de jan de 2018 21:49, "Ben Cooksley" escreveu: On Thu, Jan 18, 2018 at 8:45 PM, Hannah von Reth wrote: > Hi everyone. Hi Hannah, > > Only some few of you will be aware of KIconThemes ability to load

Re: Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

2017-02-04 Thread Andrius da Costa Ribas
problem on MSVC 2015 (missing generated "maininterface.h" for "lib/indexerconfig.cpp"). No further testing done. Thanks, Andrius da Costa Ribas

Re: Review Request 115192: Fix building 32bit target on 64bit machine

2016-09-15 Thread Andrius da Costa Ribas
--- Tested using MSVC 2010, 32bit target, with ${CMAKE_SYSTEM_PROCESSOR}=AMD64 (it's a x86_64 processor) Thanks, Andrius da Costa Ribas

Re: Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

2016-05-12 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127728/#review95441 --- ping? - Andrius da Costa Ribas On Abril 23, 2016, 4:44

Re: Review Request 127727: There is no QT_LSTAT on Windows, use QT_STAT and follow symlink (if needed), only on Windows, instead.

2016-04-24 Thread Andrius da Costa Ribas
marked as submitted. Review request for Baloo and kdewin. Changes --- Submitted with commit 0475e40d65036cb46f84740f4195d239030f13f1 by Andrius da Costa Ribas to branch master. Repository: baloo Description --- This fixes compilation on Windows, where QT_LSTAT is not available

Re: Review Request 127726: Fix EXPORT usage.

2016-04-24 Thread Andrius da Costa Ribas
marked as submitted. Review request for Baloo and kdewin. Changes --- Submitted with commit 07e3fe88f35eae9c5fdbbc408b9d222a060f9641 by Andrius da Costa Ribas to branch master. Repository: baloo Description --- The export macro should not be used in the namespace declaration

Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

2016-04-23 Thread Andrius da Costa Ribas
- Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127729/#review94797 --- On Abril 23, 2016, 11:54 p.m., Andrius

Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

2016-04-23 Thread Andrius da Costa Ribas
() as is also included and it defines a 'max' macro. Diffs - src/lib/util/kuser.h 3c9ff00 Diff: https://git.reviewboard.kde.org/r/127729/diff/ Testing --- Okular is buildable on MSVC after this patch. No further testing done. Thanks, Andrius da Costa Ribas

Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

2016-04-23 Thread Andrius da Costa Ribas
3c9ff00 Diff: https://git.reviewboard.kde.org/r/127729/diff/ Testing --- Okular is buildable on MSVC after this patch. No further testing done. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org

Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

2016-04-23 Thread Andrius da Costa Ribas
dexerconfig.cpp"). No further testing done. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127726: Fix EXPORT usage.

2016-04-23 Thread Andrius da Costa Ribas
--- The export macro should not be used in the namespace declaration. Diffs - src/engine/global.h aba5495 Diff: https://git.reviewboard.kde.org/r/127726/diff/ Testing --- Fixes compiling error on MSVC 2015. No further testing done. Thanks, Andrius da Costa Ribas

Review Request 127727: There is no QT_LSTAT on Windows, use QT_STAT and follow symlink (if needed), only on Windows, instead.

2016-04-23 Thread Andrius da Costa Ribas
--- This fixes compilation on Windows, where QT_LSTAT is not available. Diffs - src/engine/idutils.h 7c4f898 Diff: https://git.reviewboard.kde.org/r/127727/diff/ Testing --- Fixes compiling error on MSVC 2015. No further testing done. Thanks, Andrius da Costa Ribas

Re: Review Request 127714: Enable ICO and EXE thumbnails again.

2016-04-23 Thread Andrius da Costa Ribas
marked as submitted. Review request for KDE Frameworks and kdewin. Changes --- Submitted with commit fe9116847d6f2e36c1ec04e2af0cfac2553336fd by Andrius da Costa Ribas to branch master. Repository: kio-extras Description --- These had been disabled when moving into frameworks

Re: Review Request 127709: Fix exports and avoid using sources already linked on tests.

2016-04-23 Thread Andrius da Costa Ribas
marked as submitted. Review request for Dolphin and kdewin. Changes --- Submitted with commit c6d4cae26343b3f9f390374b70668fde428853f0 by Andrius da Costa Ribas to branch master. Repository: dolphin Description --- Rework from scratch on Review Request - 123270 Diffs

Re: Review Request 127715: Remove KMess

2016-04-23 Thread Andrius da Costa Ribas
. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127715: Remove KMess

2016-04-22 Thread Andrius da Costa Ribas
--- There is neither KMess nor Windows Live Messenger anymore. Diffs - portage/kdeapps/kmess/kmess.py 4e3fcf4 Diff: https://git.reviewboard.kde.org/r/127715/diff/ Testing --- not applicable. Thanks, Andrius da Costa Ribas ___ Kde-windows

Re: Review Request 127714: Enable ICO and EXE thumbnails again.

2016-04-22 Thread Andrius da Costa Ribas
-9f7163b7433f__dolphin_wresico2.png Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 127714: Enable ICO and EXE thumbnails again.

2016-04-22 Thread Andrius da Costa Ribas
MSVC 2015 64bit. Also, faked a non-win32 setup to ensure the icoutils version is also working (with wrestool binary from (**aaargh!!**) cygwin). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org

Re: Review Request 114476: Fix MSBuild of glib

2016-04-22 Thread Andrius da Costa Ribas
for MSVC. For Intel Compiler, I'm figuring out a way to correctly determine the value in "/PlatformToolset=..." according to compiler version. Also the dependency libffi-src needs some fixes first. Thanks, Andrius da Costa Ribas ___ K

Review Request 127709: Fix exports and avoid using sources already linked on tests.

2016-04-22 Thread Andrius da Costa Ribas
--- I'm currently unable to run ctest, but this fixes all inconsistent linkage errors and warnings on Windows (MSVC 2015 64-bit). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 123270: Fix exports and avoid using sources already linked on tests.

2016-04-22 Thread Andrius da Costa Ribas
ase() Totals: 6 passed, 35 failed, 0 skipped, 0 blacklisted ***** Finished testing of KFileItemModelTest * Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 127672: declare s_pulseActive outside HAVE_PULSEAUDIO ifdef

2016-04-17 Thread Andrius da Costa Ribas
marked as submitted. Review request for kdewin and Phonon. Changes --- Submitted with commit 92adeaf2851a1f94ea3b3cdfdf3e6b27394d2a53 by Andrius da Costa Ribas to branch master. Repository: phonon Description --- s_pulseActive is used inside PulseSupport::isUsable but is declared

Review Request 127672: declare s_pulseActive outside HAVE_PULSEAUDIO ifdef

2016-04-17 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/127672/diff/ Testing --- It builds on windows after this patch, no further testing done. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: [kde-windows] [Bug 357240] New: emerging KCoreAddons fails by CMake Internal Error on Win 8.1 x64

2016-01-29 Thread Andrius da Costa Ribas
I've got those too, is there any known solution? 2015-12-28 1:39 GMT-02:00 Shunsuke Shimizu via KDE Bugzilla < bugzilla_nore...@kde.org>: > https://bugs.kde.org/show_bug.cgi?id=357240 > > Bug ID: 357240 >Summary: emerging KCoreAddons fails by CMake Internal Error on >

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-23 Thread Andrius da Costa Ribas
I'm not sure if I understood the issue. If we need to pass the -I parameters to vc_compile_for_all_implementations, then something like https://git.reviewboard.kde.org/r/115110/diff/1/ might work. Em 23/05/2015 09:07, Aleix Pol aleix...@kde.org escreveu: On Sat, May 23, 2015 at 11:51 AM,

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-19 Thread Andrius da Costa Ribas
On Nov. 10, 2014, 9:41 p.m., David Faure wrote: lib/konq/src/konq_historyentry.h, line 57 https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57 const ref, no? Andrius da Costa Ribas wrote: before I try to fix the pending issues: what are we going

Re: Review Request 121079: Fix building dolphin tests on MSVC

2015-04-19 Thread Andrius da Costa Ribas
-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/#review75951 --- On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e

Re: Review Request 121079: Fix building dolphin tests on MSVC

2015-04-19 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/121079/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Re: Review Request 115110: Modify vc-based macros to allow passing flags.

2015-04-16 Thread Andrius da Costa Ribas
. Diffs - CMakeLists.txt 62f8e79 krita/image/CMakeLists.txt eefaf61 libs/pigment/CMakeLists.txt 0073377 Diff: https://git.reviewboard.kde.org/r/115110/diff/ Testing --- Tested building on both MSVC and MinGW Thanks, Andrius da Costa Ribas

Review Request 123270: Fix exports and avoid using sources already linked on tests.

2015-04-05 Thread Andrius da Costa Ribas
. () q:\dolphin\src\tests\kfileitemmodeltest.cpp(1731) : failure location PASS : KFileItemModelTest::cleanupTestCase() Totals: 6 passed, 35 failed, 0 skipped, 0 blacklisted * Finished testing of KFileItemModelTest * Thanks, Andrius da Costa Ribas

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-04 Thread Andrius da Costa Ribas
--- On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080

Re: Review Request 115110: Modify vc-based macros to allow passing flags.

2015-04-04 Thread Andrius da Costa Ribas
On Out. 15, 2014, 4:31 p.m., Boudewijn Rempt wrote: I'm sorry for the late reply, this just slipped past me somehow. I guess it isn't needed for my own builds... Is it still necessary for you, or should we discard this patch? Andrius da Costa Ribas wrote: It's quite a while

Re: Review Request 120648: Encode the URIs which end up in DTD files

2015-04-03 Thread Andrius da Costa Ribas
On Abril 3, 2015, 3:35 p.m., Andrius da Costa Ribas wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/120648/diff/2/?file=320785#file320785line20 It's already committed (but there's been a long time since I hadn't build anything), but now I see

Re: Review Request 120648: Encode the URIs which end up in DTD files

2015-04-03 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/120648/#comment53670 I've tried changing this to: execute_process(COMMAND perl -MURI::Escape -e print uri_escape_utf8(\${escaped_uri}\, \^A-Za-z0-9\\-\\._~\\/:\); (...) it works here, but I'm not sure if it'd be the proper fix. - Andrius da Costa Ribas

Re: Review Request 120648: Encode the URIs which end up in DTD files

2015-04-03 Thread Andrius da Costa Ribas
/customization/dtd/kdedbx45.dtd:102: warning: failed to load external ///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd %DocBookDTD; - Andrius da Costa Ribas On Fev. 28, 2015, 10:02 p.m., Luigi Toscano

Re: Review Request 121077: Check before using -Wno-deprecated-declarations.

2015-02-12 Thread Andrius da Costa Ribas
--- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows

Re: Review Request 121081: QT_WA

2015-02-12 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/121081/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Re: Review Request 121992: Add Battery energyFull and energyFullDesign

2015-01-11 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/121992/#comment51337 Your patch doesn't contain the implementation of these in winbattery.cpp - Andrius da Costa Ribas On Jan. 11, 2015, 4:41 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e

Re: Review Request 120878: Remove unused header

2015-01-10 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120878: Remove unused header

2015-01-09 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/#review73573 --- On Out. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote

Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

2014-12-06 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/121075/diff/ Testing --- It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Re: Kate / KDevelop Sprint

2014-11-30 Thread Andrius da Costa Ribas
As of now kf5-kate builds fine on windows (plugin loading in kf5 still needs some love, though, so lots of functionality are missing in kate UI, as well as in other apps). KF5 modularity is indeed a step towards single-app installers, by reducing the dependency bloatwarehell, and Kate is indeed a

Re: Review Request 121078: Fix exports.

2014-11-21 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70681 --- On Nov. 20, 2014, 3:29 a.m., Andrius da Costa Ribas wrote

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Andrius da Costa Ribas
: https://git.reviewboard.kde.org/r/121083/diff/ Testing --- Builds with msvc 2013 64bit Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Andrius da Costa Ribas
b8877a0 liboxygen/CMakeLists.txt 69b7bd2 Diff: https://git.reviewboard.kde.org/r/121083/diff/ Testing --- Builds with msvc 2013 64bit Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Andrius da Costa Ribas
--- On Nov. 21, 2014, 10:47 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083

Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-19 Thread Andrius da Costa Ribas
and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 121078: Fix exports.

2014-11-19 Thread Andrius da Costa Ribas
(missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-09 Thread Andrius da Costa Ribas
/ Testing --- Builds with msvc 2013 64bit Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

2014-11-08 Thread Andrius da Costa Ribas
builds after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https

Review Request 121076: Do not require KF5::Su on Windows

2014-11-08 Thread Andrius da Costa Ribas
/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-windows

Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-08 Thread Andrius da Costa Ribas
Diff: https://git.reviewboard.kde.org/r/121076/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 121077: Check before using -Wno-deprecated-declarations.

2014-11-08 Thread Andrius da Costa Ribas
today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 121078: Fix exports.

2014-11-08 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/121078/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 121079: Fix building dolphin tests on MSVC

2014-11-08 Thread Andrius da Costa Ribas
this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo

Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-11-08 Thread Andrius da Costa Ribas
(MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https

Review Request 121081: QT_WA

2014-11-08 Thread Andrius da Costa Ribas
other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation

2014-10-29 Thread Andrius da Costa Ribas
.***Not Run 0.00 sec 50% tests passed, 5 tests failed out of 10 Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 120816: Add Pushover Notification option

2014-10-28 Thread Andrius da Costa Ribas
/diff/ Testing --- Tested using my phone. File Attachments pushover.jpg https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/b159a680-e496-496d-b78c-97559bf02911__pushover.jpg Thanks, Andrius da Costa Ribas

Review Request 120877: Convert switch statements to if/else due to MSVC limitation

2014-10-28 Thread Andrius da Costa Ribas
RelWithDebInfo/SH-NOTFOUND.exe Deployment/SH-NOTFOUND Deployment/SH-NOTFOUND.exe Development/SH-NOTFOUND Development/SH-NOTFOUND.exe Unable to find executable: SH-NOTFOUND 10/10 Test #10: i18ndcheck .***Not Run 0.00 sec 50% tests passed, 5 tests failed out of 10 Thanks, Andrius da

Review Request 120816: Add Pushover Notification option

2014-10-26 Thread Andrius da Costa Ribas
pushover.jpg https://git.reviewboard.kde.org/media/uploaded/files/2014/10/26/b159a680-e496-496d-b78c-97559bf02911__pushover.jpg Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115110: Modify vc-based macros to allow passing flags.

2014-10-15 Thread Andrius da Costa Ribas
. 19, 2014, 3:42 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115110/ --- (Updated Jan. 19

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

2014-04-26 Thread Andrius da Costa Ribas
). This is not allowed in a case-insensitive filesystem, causing the install step to fail on Windows. Diffs - src/kjsembed/CMakeLists.txt e0ab74c Diff: https://git.reviewboard.kde.org/r/117012/diff/ Testing --- Tested using MSVC 2013 Thanks, Andrius da Costa Ribas

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-04-24 Thread Andrius da Costa Ribas
Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-23 Thread Andrius da Costa Ribas
? Anyhow I'd be fine with that, especially if you can find any documentation of this outside of kde (to explain the reasoning in the Qt change request). Andrius da Costa Ribas wrote: As far as I can see: 1 - Most GNU apps and libs ported from *nix to Windows use $PREFIX/bin

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-20 Thread Andrius da Costa Ribas
On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: Until now we had no problems with the data installed to bin/../share and this setup would make it impossible to have multiple independent kde setups on one system. Alexander Richardson wrote: I know. The problem is

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

2014-04-20 Thread Andrius da Costa Ribas
/r/117012/diff/ Testing --- Tested using MSVC 2013 Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-04-14 Thread Andrius da Costa Ribas
by next weekend. - Andrius da Costa Ribas On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012

Re: The future of KDE Development on Windows

2014-04-07 Thread Andrius da Costa Ribas
Hello, Sticking to the items pointed by Aleix, in my humble opinion: - We want KDE on Windows to keep being a distribution? Should it be a development platform or a site to download installers? *We are both a distribution (installer) and a development platform (emerge) and I think we should keep

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-03-30 Thread Andrius da Costa Ribas
--- On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/ --- (Updated March

Re: Review Request 115114: Rename lst1 and lst2 variables

2014-03-23 Thread Andrius da Costa Ribas
/kpttaskstatusview.cpp be9f1a4 plan/libs/ui/kptviewbase.cpp 2fae0cf plan/workpackage/taskworkpackageview.cpp 95446b6 Diff: https://git.reviewboard.kde.org/r/115114/diff/ Testing --- Tested using MSVC and MinGW. Thanks, Andrius da Costa Ribas

Re: Review Request 115116: Disable KoM2MMLForumulaTool also on MinGW

2014-03-23 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/115116/diff/ Testing --- Builds on both MinGW and MSVC. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Updating DocBookXML to 4.5 for KF5

2014-03-23 Thread Andrius da Costa Ribas
Hello, Since KDocTools framework bumped supported DocBookXml version to 4.5 I'm not sure on how to update the files created in ( http://quickgit.kde.org/?p=emerge.gita=commith=9317bbe942d995b279c0587f7ae2b83e2bb0a849 ) As far as I can see, those entries would be needed inside catalog/group:

Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Andrius da Costa Ribas
MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde

Qt5 modules dev branch

2014-03-05 Thread Andrius da Costa Ribas
Hi, According to http://community.kde.org/Frameworks/Building they're using stable branch of qt modules. Also I'm getting some errors in dev branch (for e.g. QtDeclarative) which are not happening on stable. May I change those modules to stable in our qt5 branch? Is there some specific reason to

Fwd: [Kde-cvs-announce] [REMINDER] KDE SC 4.13 is Frozen, KDE/4.13 branches created, Beta 1 tag next week

2014-02-26 Thread Andrius da Costa Ribas
So are we going to skip 4.12, and start a 4.13 branch on emerge instead? -- Andrius -- Forwarded message -- From: Albert Astals Cid aa...@kde.org Date: 2014-02-26 21:36 GMT-03:00 Subject: [Kde-cvs-announce] [REMINDER] KDE SC 4.13 is Frozen, KDE/4.13 branches created, Beta 1 tag

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

2014-02-05 Thread Andrius da Costa Ribas
On Feb. 6, 2014, 1:14 a.m., Alexander Richardson wrote: src/kwindowsystem.cpp, line 342 https://git.reviewboard.kde.org/r/115459/diff/2-3/?file=242085#file242085line342 The non-MSVC macro has a return statement, I think this one needs it as well Why is this conditioned to

Re: KDE 4.12 Windows release getting close

2014-01-30 Thread Andrius da Costa Ribas
Hello all, Last build on the build server is from Jan-8, so, just to track what is still listed as a failed in there: * kde/kdeartwork (mingw-w32 only) - looks simple to fix, however maybe a better approach is to skip kdesavers as they need some adaptation to really work as screensavers on

Re: Review Request 115113: Static libs must come first in linkage order

2014-01-23 Thread Andrius da Costa Ribas
8342552 krita/image/CMakeLists.txt eefaf61 Diff: https://git.reviewboard.kde.org/r/115113/diff/ Testing --- Tested building using MinGW and MSVC. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https

Re: Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

2014-01-23 Thread Andrius da Costa Ribas
/unistd.h 82a9ab4 Diff: https://git.reviewboard.kde.org/r/115108/diff/ Testing --- Tested building on both MSVC and MinGW. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 115107: Link tests to kritaimage instead of using directly its sources

2014-01-23 Thread Andrius da Costa Ribas
targets in this CMake file, since kis_tile_data is not exported. Diffs - krita/image/tiles3/tests/CMakeLists.txt 5339543 Diff: https://git.reviewboard.kde.org/r/115107/diff/ Testing --- Builds on both MinGW and MSVC. Thanks, Andrius da Costa Ribas

Re: Review Request 115109: _isnan is present only in MSVC's cfloat, for MinGW we still use std::isnan

2014-01-22 Thread Andrius da Costa Ribas
/kis_paintop.cc 304317a Diff: https://git.reviewboard.kde.org/r/115109/diff/ Testing --- Tested building on MSVC and MinGW Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

2014-01-22 Thread Andrius da Costa Ribas
submitted, should I discard this one? - Andrius da Costa Ribas On Jan. 19, 2014, 3:42 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115108

Re: Review Request 115184: Fix build on MSVC x64

2014-01-21 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115184/#review47907 --- where is it previously defined? - Andrius da Costa Ribas

Review Request 115192: Fix building 32bit target on 64bit machine

2014-01-21 Thread Andrius da Costa Ribas
(it's a x86_64 processor) Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

2014-01-18 Thread Andrius da Costa Ribas
building on both MSVC and MinGW. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 115107: Link tests to kritaimage instead of using directly its sources

2014-01-18 Thread Andrius da Costa Ribas
/tiles3/tests/CMakeLists.txt 5339543 Diff: https://git.reviewboard.kde.org/r/115107/diff/ Testing --- Builds on both MinGW and MSVC. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman

Review Request 115114: Rename lst1 and lst2 variables

2014-01-18 Thread Andrius da Costa Ribas
/taskworkpackageview.cpp 95446b6 Diff: https://git.reviewboard.kde.org/r/115114/diff/ Testing --- Tested using MSVC and MinGW. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 115109: _isnan is present only in MSVC's cfloat, for MinGW we still use std::isnan

2014-01-18 Thread Andrius da Costa Ribas
building on MSVC and MinGW Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Re: Review Request 114986: Fix usage of KDE4_ENABLE_EXCEPTIONS

2014-01-17 Thread Andrius da Costa Ribas
. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 114984: Fix build on MinGW with newer Windows SDK's strsafe.h

2014-01-12 Thread Andrius da Costa Ribas
work fine. No errors when building with MSVC either. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Andrius da Costa Ribas
/114964/diff/ Testing --- Python backend builds and run fine from a clean MSVC build. MinGW build was already okay, as per http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt Thanks, Andrius da Costa Ribas

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Andrius da Costa Ribas
On Jan. 11, 2014, 2:52 p.m., Albert Astals Cid wrote: src/backends/python2/CMakeLists.txt, line 15 https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15 Shouldn't this go into the kdewin include files then? Andrius da Costa Ribas wrote: kdewin does

Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend

2014-01-11 Thread Andrius da Costa Ribas
On Jan. 11, 2014, 2:52 p.m., Albert Astals Cid wrote: src/backends/python2/CMakeLists.txt, line 15 https://git.reviewboard.kde.org/r/114964/diff/1/?file=233720#file233720line15 Shouldn't this go into the kdewin include files then? Andrius da Costa Ribas wrote: kdewin does

Review Request 114476: Fix MSBuild of glib

2013-12-15 Thread Andrius da Costa Ribas
in /PlatformToolset=... according to compiler version. Also the dependency libffi-src needs some fixes first. Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

Patch for freetype recipe

2013-11-09 Thread Andrius da Costa Ribas
Hi, Freetype recipe doesn't install one header that is used on poppler's FindFreetype cmake. This patch fixes it, however my ssh keys are in the old computer and I'm not with it right now, so I'm asking if someone could kindly push this attached patch into emerge meanwhile. -- Andrius

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/#review43272 --- ping? may I ship it? - Andrius da Costa Ribas On Aug. 17

Concerns about deprecating KFileDialog

2013-08-23 Thread Andrius da Costa Ribas
that can't be done with native Windows dialog. As far as I can see there is no such option when using QFileDialog, so Windows users will lose the power of the kioslaves :( Was this considered when it was decided to deprecate KFileDialog? Cheers, Andrius da Costa Ribas

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-17 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png Thanks, Andrius da Costa Ribas ___ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows

  1   2   3   >