Re: [OS-BUILD PATCH] scsi: sd: Add "probe_type" module parameter to allow synchronous probing

2023-06-28 Thread Ewan D. Milne (via Email Bridge)
From: Ewan D. Milne on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2504#note_1450075205 Uh... [emilne@emilne kernel-ark.forked]$ git rebase kernel-ark/os-build Current branch bz2140017 is up to date. [emilne@emilne kernel-ark.forked]$ git push -u -f origin bz2140017

Re: [OS-BUILD PATCH] scsi: sd: Add "probe_type" module parameter to allow synchronous probing

2023-06-23 Thread Ewan D. Milne (via Email Bridge)
From: Ewan D. Milne on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2504#note_1444144843 We have never *guaranteed* consistent names across reboots, It just happens that this almost always works unless the device fails to respond, which we can't fix anyway. However,

Re: [OS-BUILD PATCH] scsi: sd: Add "probe_type" module parameter to allow synchronous probing

2023-06-23 Thread Tomas Henzl (via Email Bridge)
From: Tomas Henzl on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2504#note_1443883980 This patch makes the ordering less random but doesn't guarantee ordering stable between reboots not even for local disks in all cases. The user should use persistent names. I fear that

Re: [OS-BUILD PATCH] scsi: sd: Add "probe_type" module parameter to allow synchronous probing

2023-06-21 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2504#note_1440757633 > What I would like to avoid is RH coming up with its own scheme which was not what other vendors adopt. This is my main concern. I don't want to carry a patch forever. As for

Re: [OS-BUILD PATCH] scsi: sd: Add "probe_type" module parameter to allow synchronous probing

2023-06-21 Thread Ewan D. Milne (via Email Bridge)
From: Ewan D. Milne on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2504#note_1440687749 I'm happy to change it to however we would like the process to work, if we want. At LSF/MM Martin Petersen said that Oracle had some device labeling changes w/udev so that customer

Re: [OS-BUILD PATCH] scsi: sd: Add "probe_type" module parameter to allow synchronous probing

2023-06-20 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2504#note_1438705806 I actually don't think it needs the CONFIG_RHEL_DIFFERENCES ifdef, as the code path requires a module parameter to invoke, and I will just drop the patch all together for Fedora

Re: [OS-BUILD PATCH] scsi: sd: Add "probe_type" module parameter to allow synchronous probing

2023-06-20 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2504#note_1438601446 hi @e-milne, for starters, i would recommend wrapping this with "#ifdef CONFIG_RHEL_DIFFERENCES", so @jmflinuxtx can easily remove it for fedora systems. is there a path forward on

Re: [OS-BUILD PATCH] scsi: sd: Add "probe_type" module parameter to allow synchronous probing

2023-06-16 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2504#note_1434692481 Has this been submitted upstream at all? What was the discussion on it? ___ kernel mailing list -- kernel@lists.fedoraproject.org To

[OS-BUILD PATCH] scsi: sd: Add "probe_type" module parameter to allow synchronous probing

2023-06-15 Thread Ewan D. Milne (via Email Bridge)
From: Ewan D. Milne scsi: sd: Add "probe_type" module parameter to allow synchronous probing Setting probe_type="sync" will force synchronous probing in the driver core, which forces the ordering of minor device number assignments when SCSI disk devices are probed, for compatibility with prior