[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
Thanks team Canonical for this \o/ -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: Fix Released Status in thermald package in Ubuntu: Fix Released Status in thermald source package in Jammy: Fix Released Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
** Changed in: oem-priority Status: New => Fix Released -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: Fix Released Status in thermald package in Ubuntu: Fix Released Status in thermald source package in Jammy: Fix Released Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
@Chris, Sure, this's my regular processes but didn't collect the logs. I will update the logs about this test cases. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Fix Committed Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
I see that all the individual bugs have been verified, but has the test plan documented on *this* bug been carried out? That is: [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Fix Committed Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
Verified against thermald-2.4.9-1ubuntu0.3, ~~~ LP#2018275, LP#2018236, LP#2012260, LP#2007579, LP#1989044, LP#1981087 ~~~ -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Fix Committed Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
** Tags removed: verification-needed verification-needed-jammy ** Tags added: verification-done verification-done-jammy -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Fix Committed Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
** Tags added: originate-from-2012475 somerville -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Fix Committed Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
Hello koba, or anyone else affected, Accepted thermald into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/2.4.9-1ubuntu0.3 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-jammy. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: thermald (Ubuntu Jammy) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-jammy -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Fix Committed Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
Thanks. I have uploaded thermald 2.4.9-1ubuntu0.3 jammy with a small change and unsubscribed ~ubuntu-sponsors. I added "Cherry-pick following fixes from thermald 2.5.1 and 2.5.2 (LP: #1995606)" to d/changelog since this bug was not referenced. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: In Progress Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
+202307051456, @Raof, @Lucas v3: because the patch, 0004-Fixed-enumeration-of-cpu-thermal-sensors.patch, can't verify on the proper machine, pull it out from patches. ** Patch added: "thermald_jammy_2.4.9-1ubuntu0.3.v3.debdiff" https://bugs.launchpad.net/ubuntu/+source/thermald/+bug/1995606/+attachment/5683967/+files/thermald_jammy_2.4.9-1ubuntu0.3.v3.debdiff -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: In Progress Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
Relaying communication from off-Launchpad: Since we have no way to test it, 0004-Fixed-enumeration-of-cpu-thermal-sensors.patch should be dropped, and apart from that this is now acceptable. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: In Progress Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
FWIW the packaging changes look good to me. But I'd like raof (or someone with more knowledge about this) to check koba's reply before uploading the package. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: In Progress Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
** Changed in: thermald (Ubuntu Jammy) Status: New => In Progress -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: In Progress Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
** Changed in: thermald (Ubuntu Jammy) Status: Incomplete => New -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: New Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
** Patch added: "thermald_jammy_2.4.9-1ubuntu0.3.v2.debdiff" https://bugs.launchpad.net/ubuntu/+source/thermald/+bug/1995606/+attachment/5682352/+files/thermald_jammy_2.4.9-1ubuntu0.3.v2.debdiff -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
@Raof * Replied 1st, please check Ref. https://bugs.launchpad.net/ubuntu/+source/thermald/+bug/2018275/comments/2 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
Waiting for another debdiff to address the points raised in previous comments. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
In addition to the things identified above: * I've added a question on https://bugs.launchpad.net/ubuntu/+source/thermald/+bug/2018275 about what that's actually fixing. * debian/patches/0004-Fixed-enumeration-of-cpu-thermal-sensors.patch: this looks reasonable, but I'd like to make sure that were testing on at least one system that should hit this fix (if I understand it correctly, it should apply to anything having > 4 cores, which should be easy to arrange) Otherwise this looks reasonable, thanks! -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
One more thing: - There's a trailing whitespace at line 22 on d/changelog. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
Thank you for your patience. I believe Chris should be the one doing the review here, but I'd like to mention that it would be great if you could add DEP-3 headers to each patch: https://dep-team.pages.debian.net/deps/dep3/ This helps us better document and understand where each patch came from. Moreover, your debdiff is unnecessarily adding a ".pc" directory, which is generated by quilt. Please remove it. Your d/changelog entry has a typo: s/doesnt/doesn't/ You have two patches numbered 0015-... in d/changelog, but only one actual 0015-... patch. Finally, I don't see an answer to Chris' question regarding 0013-Ensure- there-is-one-trips-element-per-zone.patch. Thanks! -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
@Raof, as per request, modified the changelog please help to review. ** Patch added: "thermald_jammy_2.4.9-1ubuntu0.3.debdiff" https://bugs.launchpad.net/ubuntu/+source/thermald/+bug/1995606/+attachment/5681109/+files/thermald_jammy_2.4.9-1ubuntu0.3.debdiff -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
@Lukas, im working on this and will upload the next, thanks -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
Chris reviewed your proposed debdiff almost 2 months ago, are you planning to address the comments? I am re-checking this because it is in our general sponsorship queue. If you do not need sponsorship for this upload, please, unsubscribe ~ubuntu-sponsors. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
Hi there! Sorry for the delay in getting to this. Some review: *) It'd be easier to review if debian/changelog mentioned each of the patches and what they do. For example, rather than having the changelog entry: * Support ITMTv2 for Raptor Lake (LP: #2007579) you could have the changelog entries: * debian/patches/0003-Parse-ITMT-Table.patch: * debian/patches/0006-Install-ITMT-target.patch: * debian/patches/0018-Process-ITMT-v2.patch: - Support ITMTv2 for Raptor Lake (LP: #2007579) Since you know why you selected the patches you've added, this means I don't need to try and reverse-engineer what bug each of the patches is trying to address. *) 0015-Ensure-there-is-one-trips-element-per-zone.patch: Why is this patch here? It looks to me like it's patching code that we don't build? Overall this looks like it's mostly there; it's not entirely clear to me what *all* the patches are for, but it looks like they're (mostly) sensible patches. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
** Changed in: thermald (Ubuntu Jammy) Assignee: (unassigned) => koba (kobako) -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
The attachment "thermald_Jammy_2.4.9-1ubuntu0.3.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
@Raof, i have modified the patches, only picked the necessary and drop the part of refactoring. * drop these two commits, ~~~ * Dropped, Remove /dev/cpu/*/msr access for TCC * part of refactoring and keep the required, Separate Adaptive engine and GDDV ~~~ Would you please review it first. thanks ** Patch added: "thermald_Jammy_2.4.9-1ubuntu0.3.debdiff" https://bugs.launchpad.net/ubuntu/+source/thermald/+bug/1995606/+attachment/5665259/+files/thermald_Jammy_2.4.9-1ubuntu0.3.debdiff -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1995606] Re: Upgrade thermald to 2.5.1 for Jammy (22.04)
** Tags added: originate-from-2015192 sutton ** Tags added: originate-from-2015208 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/1995606 Title: Upgrade thermald to 2.5.1 for Jammy (22.04) Status in OEM Priority Project: New Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: Incomplete Bug description: [Justification] The purpose of this bug is that prevent the regression in the future. The automatic test scripts are better for the future SRU and is still on the planning. [Test case] For these CPU series, RPL/ADL/TGL/CML/CFL/KBL, the following tests will be run on machines in the CI lab: 1. Run stress-ng, and observe the temperature/frequency/power with s-tui - Temperatures should stay just below trip values - Power/performance profiles should stay roughly the same between old thermald and new thermald (unless specifically expected eg: to fix premature/insufficient throttling) 2. check if thermald could read rules from /dev/acpi_thermal_rel and generate the xml file on /etc/thermald/ correctly. - this depends on if acpi_thermal_rel exist. - if the machine suppots acpi_thermal_rel, the "thermal-conf.xml.auto" could be landed in etc/thermald/. - if not, the user-defined xml could be created, then jump to (3). - run thermald with --loglevel=debug, and compare the log with xml.auto file. check if the configuration could be parsed correctly. 3. check if theramd-conf.xml and thermal-cpu-cdev-order.xml can be loaded correctly. - run thermald with --loglevel=debug, and compare the log with xml files. - if parsed correctly, the configurations from XML files would appear in the log. 4. Run unit tests, the scripts are under test folder, using emul_temp to simulate the High temperatue and check thermald would throttle CPU through the related cooling device. - rapl.sh - intel_pstate.sh - powerclamp.sh - processor.sh 5. check if the power/frequency would be throttled once the temperature reach the trip-points of thermal zone. 6. check if system would be throttled even the temperature is under the trip-points. [ Where problems could occur ] since the PL1 min/max is introduced, there may have some cases that don't check the minimum of PL1 then make PL1 to smaller and smaller and throttle the CPU. this may cause machines run like the old behavior that doesn't have PL1 min/max. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1995606/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
