Re: [PATCH v2 09/13] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set

2022-08-01 Thread Guilherme G. Piccoli
On 19/07/2022 19:04, Arjan van de Ven wrote: > On 7/19/2022 2:00 PM, Guilherme G. Piccoli wrote: >> On 19/07/2022 17:48, Arjan van de Ven wrote: >>> [...] >>> I would totally support an approach where instead of pr_info, there's a >>> tracepoint >>> for these events (and that shouldnt' need to be

Re: [PATCH v2 09/13] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set

2022-07-19 Thread Guilherme G. Piccoli
On 19/07/2022 17:33, Arjan van de Ven wrote: > On 7/19/2022 12:53 PM, Guilherme G. Piccoli wrote: >> Currently we have a debug infrastructure in the notifiers file, but >> it's very simple/limited. Extend it by: >> >> (a) Showing all registered/unregistered notifiers' callback names; > > > I'm no

[PATCH v2 09/13] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set

2022-07-19 Thread Guilherme G. Piccoli
Currently we have a debug infrastructure in the notifiers file, but it's very simple/limited. Extend it by: (a) Showing all registered/unregistered notifiers' callback names; (b) Adding a dynamic debug tuning to allow showing called notifiers' function names. Notice that this should be guarded as

Re: [PATCH v2 09/13] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set

2022-07-19 Thread Arjan van de Ven
On 7/19/2022 12:53 PM, Guilherme G. Piccoli wrote: Currently we have a debug infrastructure in the notifiers file, but it's very simple/limited. Extend it by: (a) Showing all registered/unregistered notifiers' callback names; I'm not yet convinced that this is the right direction. The origina

Re: [PATCH v2 09/13] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set

2022-07-19 Thread Arjan van de Ven
On 7/19/2022 2:00 PM, Guilherme G. Piccoli wrote: On 19/07/2022 17:48, Arjan van de Ven wrote: [...] I would totally support an approach where instead of pr_info, there's a tracepoint for these events (and that shouldnt' need to be conditional on a config option) that's not what the patch does

Re: [PATCH v2 09/13] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set

2022-07-19 Thread Arjan van de Ven
On 7/19/2022 1:44 PM, Guilherme G. Piccoli wrote: On 19/07/2022 17:33, Arjan van de Ven wrote: On 7/19/2022 12:53 PM, Guilherme G. Piccoli wrote: Currently we have a debug infrastructure in the notifiers file, but it's very simple/limited. Extend it by: (a) Showing all registered/unregistered

Re: [PATCH v2 09/13] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set

2022-07-19 Thread Guilherme G. Piccoli
On 19/07/2022 17:48, Arjan van de Ven wrote: > [...] > I would totally support an approach where instead of pr_info, there's a > tracepoint > for these events (and that shouldnt' need to be conditional on a config > option) > > that's not what the patch does though. This is a good idea Arjan! W