Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-08-19 Thread Guilherme G. Piccoli
On 17/08/2022 19:19, Borislav Petkov wrote: > On Wed, Aug 17, 2022 at 07:09:26PM -0300, Guilherme G. Piccoli wrote: >> Again - a matter of a trade-off, a good compromise must be agreed by all >> parties (kdump maintainers are usually extremely afraid of taking risks >> to not break kdump). > >

Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-08-19 Thread Guilherme G. Piccoli
On 17/08/2022 14:31, Borislav Petkov wrote: > [...] > > How does the fact that kdump is loaded, obviate the need to print > information about the errors? > > Are you suggesting that people who have the whole vmcore would be able > to piece together the error information? > Hi Boris, thanks for

Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-08-19 Thread Guilherme G. Piccoli
On 17/08/2022 19:00, Borislav Petkov wrote: > On Wed, Aug 17, 2022 at 06:56:11PM -0300, Guilherme G. Piccoli wrote: >> But do you agree that currently, in case of a kdump, that information >> *is not collected*, with our without my patch? > > If for some reason that panic notifier does not get

Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-08-19 Thread Guilherme G. Piccoli
On 17/08/2022 18:46, Borislav Petkov wrote: > On Wed, Aug 17, 2022 at 06:39:07PM -0300, Guilherme G. Piccoli wrote: >> Sorry for the confusion, let me try to be a bit more clear: > > I think you're missing the point. Lemme try again: > > You *absolutely* must log those errors because they're

Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-08-19 Thread Guilherme G. Piccoli
On 17/08/2022 18:02, Borislav Petkov wrote: > On Wed, Aug 17, 2022 at 05:28:34PM -0300, Guilherme G. Piccoli wrote: >> My understanding is the same as yours, i.e., this is not possible to >> collect from vmcore, it requires register reading. But again: if you >> kdump your machine today, you won't

Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-08-19 Thread Guilherme G. Piccoli
On 17/08/2022 16:34, Borislav Petkov wrote: > [...] > > What is "the failure risk for kdump"? > > Some of the notifiers which run before kdump might fail and thus prevent > the machine from kdumping? > Exactly; some notifiers could break the machine and prevent a successful kdump. The EDAC one

Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-08-17 Thread Guilherme G. Piccoli
On 16/08/2022 15:44, Dinh Nguyen wrote: > [...] >> V2: >> - new patch, based on the discussion in [0]. >> [0] >> https://lore.kernel.org/lkml/62a63fc2-346f-f375-043a-fa2138527...@igalia.com/ >> > > Acked-by: Dinh Nguyen Thanks a lot Dinh! There is something I'm asking for maintainers on

Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-08-17 Thread Dinh Nguyen
On 7/19/22 14:53, Guilherme G. Piccoli wrote: The altera_edac panic notifier performs some data collection with regards errors detected; such code relies in the regmap layer to perform reads/writes, so the code is abstracted and there is some risk level to execute that, since the panic path

Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-08-15 Thread Guilherme G. Piccoli
On 19/07/2022 16:53, Guilherme G. Piccoli wrote: > The altera_edac panic notifier performs some data collection with > regards errors detected; such code relies in the regmap layer to > perform reads/writes, so the code is abstracted and there is some > risk level to execute that, since the panic

[PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-07-20 Thread Guilherme G. Piccoli
The altera_edac panic notifier performs some data collection with regards errors detected; such code relies in the regmap layer to perform reads/writes, so the code is abstracted and there is some risk level to execute that, since the panic path runs in atomic context, with interrupts/preemption