Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-09 Thread Eric DeVolder
On 11/9/22 15:31, Borislav Petkov wrote: On Wed, Nov 09, 2022 at 09:48:33AM -0600, Eric DeVolder wrote: ... which then defaults HOTPLUG_CPU to on and thus this code/ifdef in question. defconfig can sometimes lag reality. In this case, the majority of machines have SMP=y because the

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-09 Thread Borislav Petkov
On Wed, Nov 09, 2022 at 09:48:33AM -0600, Eric DeVolder wrote: > ... > which then defaults HOTPLUG_CPU to on and thus this code/ifdef in question. defconfig can sometimes lag reality. In this case, the majority of machines have SMP=y because the majority of machines out there are, well,

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-09 Thread Eric DeVolder
On 11/2/22 04:26, Borislav Petkov wrote: On Tue, Nov 01, 2022 at 10:45:00AM -0500, Eric DeVolder wrote: As I'm re-reading that message, I suspect now the preference is to just to strike this ifdiffery line in this file and have the code always present? If the preference is actually for

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-02 Thread Borislav Petkov
On Wed, Nov 02, 2022 at 01:57:14PM -0500, Eric DeVolder wrote: > But I sense I missing your point? No no, you're spot on. So moving that into the kernel and making it more robust is always a good thing. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-02 Thread Eric DeVolder
On 11/2/22 13:49, Borislav Petkov wrote: On Wed, Nov 02, 2022 at 11:54:08AM -0500, Eric DeVolder wrote: Technically the answer is no; cpu hotplug events are independent of memory hotplug events, but both are written into the elfcorehdr, so in reality yes... The elfcorehdr contains a single

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-02 Thread Borislav Petkov
On Wed, Nov 02, 2022 at 11:54:08AM -0500, Eric DeVolder wrote: > Technically the answer is no; cpu hotplug events are independent of memory > hotplug events, but both are written into the elfcorehdr, so in reality > yes... The elfcorehdr contains a single list of Phdrs describing CPUs and > crash

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-02 Thread Eric DeVolder
On 11/2/22 11:19, Borislav Petkov wrote: On Wed, Nov 02, 2022 at 09:55:06AM -0500, Eric DeVolder wrote: "But on a plain simple laptop or workstation which has CPU hotplug, would it make sense for the crash ranges to get updated too when CPUs are offlined? Yes, it does. Why?

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-02 Thread Borislav Petkov
On Wed, Nov 02, 2022 at 09:55:06AM -0500, Eric DeVolder wrote: > > "But on a plain simple laptop or workstation which has CPU hotplug, > > would it make sense for the crash ranges to get updated too when CPUs > > are offlined? > > Yes, it does. Why? -- Regards/Gruss, Boris.

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-02 Thread Eric DeVolder
On 11/2/22 04:26, Borislav Petkov wrote: On Tue, Nov 01, 2022 at 10:45:00AM -0500, Eric DeVolder wrote: As I'm re-reading that message, I suspect now the preference is to just to strike this ifdiffery line in this file and have the code always present? If the preference is actually for

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-02 Thread Borislav Petkov
On Tue, Nov 01, 2022 at 10:45:00AM -0500, Eric DeVolder wrote: > As I'm re-reading that message, I suspect now the preference is to just to > strike this ifdiffery line in this file and have the code always present? > > If the preference is actually for CRASH_HOTPLUG, then let me know. Well, it

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-11-01 Thread Eric DeVolder
On 10/31/22 16:04, Borislav Petkov wrote: On Mon, Oct 31, 2022 at 03:36:04PM -0400, Eric DeVolder wrote: +#if defined(CONFIG_HOTPLUG_CPU) || defined(CONFIG_MEMORY_HOTPLUG) What happened to that here: https://lore.kernel.org/r/y1e85gqb3kzlx...@zn.tnic ? When I was evaluating the

Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-10-31 Thread Borislav Petkov
On Mon, Oct 31, 2022 at 03:36:04PM -0400, Eric DeVolder wrote: > +#if defined(CONFIG_HOTPLUG_CPU) || defined(CONFIG_MEMORY_HOTPLUG) What happened to that here: https://lore.kernel.org/r/y1e85gqb3kzlx...@zn.tnic ? -- Regards/Gruss, Boris.

[PATCH v13 7/7] x86/crash: add x86 crash hotplug support

2022-10-31 Thread Eric DeVolder
When CPU or memory is hot un/plugged, the crash elfcorehdr, which describes the CPUs and memory in the system, must also be updated. A new elfcorehdr is generated from the available CPUs and memory into a buffer, and then installed over the top of the existing elfcorehdr. The segment containing