Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Mark Roszko
I'll add that you can request access to at least view the kicad Defects it finds here: https://scan.coverity.com/projects/3606?tab=overview On Mon, Apr 13, 2015 at 6:49 PM, Mario Luzeiro wrote: > Hi Mark, > yeah , you are right, that one maybe was a very specific situation. I was > thinking som

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Mark Roszko
>In that case where can we have a look in the Coverity documentation? They do not provide a list or documentation on what they may throw. Perhaps in they do in commercial version but not in the open source version. >Is that something I can run / test myself? No, we are only allowed 2 submiss

Re: [Kicad-developers] Fwd: Documentation update

2015-04-13 Thread Nick Østergaard
Great. Den 13/04/2015 22.57 skrev "Brian Sidebotham" : > I sync'd with Marco's repo so that's now reflected in my repo. > > I just need to do the po update stuff I think and then I'll do a pull > request to get the repo's aligned. > > Best Regards, > > Brian. > > On 12 April 2015 at 23:12, Nick Øs

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Mario Luzeiro
Hi Mark, yeah , you are right, that one maybe was a very specific situation. I was thinking something more easy and general like "you should initialize your vars". In that case where can we have a look in the Coverity documentation? Is that something I can run / test myself? Regards, Mario L

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Wayne Stambaugh
Thank you Mark! Coverity should not become a substitute for competent design and careful coding. There have been a lot of false positives so they should be marked as such. The same thing goes for compiler warnings. They are just that, a warning that you may have done something you did not inten

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Mark Roszko
>So perhaps some one can summarize this changes need There's hundreds of ways and "reasons" why Coverity could have thrown the "use after free" error that Brian is fixing. There is no one size fits all solution. ___ Mailing list: https://launchpad.net/~

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Mário Luzeiro
Hi Cirilo, Sure, I know code analysis is good. Things like variable initialization is something generally understood by everyone as a good coding practices and easy to understand. In other way, things like Brian did are very much complicated to understand (at least for me ) Example This: std::v

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Cirilo Bernardo
Hi Mario, The Coverity analysis tool is not so bad; even without customizing it so much there are very few cases where it wants you to do something trivial to make it happy. It seems to be very good for catching all kinds of bugs and dead code as well. So you don't code to make Coverity happy, yo

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Mário Luzeiro
Hi Brian, I was about to test it but I didn't since first I was trying to fix here an issue in my branch... I will later do it. I notice you (people here) start to perform code analysis with some tool (Coverity?) I don't have any experience in using or develop with a code analysis in mind, but

Re: [Kicad-developers] vrml_exporter vs 3d-viewer pcbboard polygon generation

2015-04-13 Thread Cirilo Bernardo
The 3D Viewer and VRML exporter evolved separately (with the VRML exporter borrowing code from the 3D viewer at times). When the VRML export was rewritten a few years ago, the OpenGL canvas was still in its very early stages of development. If I haven't forgotten too much, the 3D Viewer makes use o

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Brian Sidebotham
I just tested with VRML 1 and VRML 2 and stuff has appeared not to break, so I just committed this change. I opted for the boost::shared_ptr as we're not yet C++11 and there is quite a bit of standard container work going on. Best Regards, Brian. On 11 April 2015 at 00:04, Brian Sidebotham wr

Re: [Kicad-developers] Fwd: Documentation update

2015-04-13 Thread Brian Sidebotham
I sync'd with Marco's repo so that's now reflected in my repo. I just need to do the po update stuff I think and then I'll do a pull request to get the repo's aligned. Best Regards, Brian. On 12 April 2015 at 23:12, Nick Østergaard wrote: > I have now done this. > > 2015-04-11 13:48 GMT+02:00

[Kicad-developers] Latest trackpad action tests on OSX-r5595

2015-04-13 Thread Bob Gustafson
Application: kicad Version: (2015-04-12 BZR 5595)-product Release build wxWidgets: Version 3.0.2 (debug,UTF-8,compiler with C++ ABI 1002,GCC 4.2.1,STL containers,compatible with 2.8) Platform: Mac OS X (Darwin 14.1.0 x86_64), 64 bit, Little endian, wxMac Boost version: 1.54.0 USE_WX_GRA

Re: [Kicad-developers] Remove holes and bottleneck in 3d-viewer

2015-04-13 Thread jp charras
Le 13/04/2015 17:04, Mário Luzeiro a écrit : > Thank you for the explanation, I am starting to better understand it > now. > > Could that be done some other way? > > I was trying to understand how GAL is rendering the zones and it > first draws "the polygon it self" and then the beautiful rounded

Re: [Kicad-developers] Remove holes and bottleneck in 3d-viewer

2015-04-13 Thread Mário Luzeiro
Thank you for the explanation, I am starting to better understand it now. Could that be done some other way? I was trying to understand how GAL is rendering the zones and it first draws "the polygon it self" and then the beautiful rounded outlines. (The corner interpolation is visually implemen

Re: [Kicad-developers] Remove holes and bottleneck in 3d-viewer

2015-04-13 Thread jp charras
Le 13/04/2015 15:27, Mário Luzeiro a écrit : > Hi Jean-Pierre, > > As we know, one of the bottleneck in 3d-viewer is while exporting the > pcbboard to polygons and then remove the holes from the fill zones. > I was trying to understand the process of that and in the sources and see if > we have

[Kicad-developers] Remove holes and bottleneck in 3d-viewer

2015-04-13 Thread Mário Luzeiro
Hi Jean-Pierre, As we know, one of the bottleneck in 3d-viewer is while exporting the pcbboard to polygons and then remove the holes from the fill zones. I was trying to understand the process of that and in the sources and see if we have room for improvement. "// Draw copper zones. Not

Re: [Kicad-developers] FreeCAD 0.15

2015-04-13 Thread Nick Østergaard
2015-04-13 11:58 GMT+02:00 Murat Ursavaş : > > Hi Mario, > >> Hi Murat, >> >>> I'm not sure this could be known, but as far as I'm following this group >>> no one mentioned something about this topic. >> >> 3D-viewer is not the primary focus of development and use of the kicad and >> I understand a

[Kicad-developers] vrml_exporter vs 3d-viewer pcbboard polygon generation

2015-04-13 Thread Mário Luzeiro
Hello Cirilo, Lorenzo, Jean-Pierre, I was trying to understand a bit more how the pcbboard is converted into polygons. I found that vrml_exporter is doing it in a very different (but similar!) way as 3d-viewer (boost based implementation). The vrml_exporter based is implementation on gluTess wh

Re: [Kicad-developers] FreeCAD 0.15

2015-04-13 Thread Murat Ursavaş
Hi Mario, Hi Murat, I'm not sure this could be known, but as far as I'm following this group no one mentioned something about this topic. 3D-viewer is not the primary focus of development and use of the kicad and I understand and agree :) So that is why is not much mention here. I know, bu