[Kicad-developers] PANEL_PREV_3D_B

2017-02-18 Thread Chris Pavlina
In panel_prev_model.h, there is this line: #define PANEL_PREV_3D_B PANEL_PREV_3D After this, "PANEL_PREV_3D_B" is used in the code in place of "PANEL_PREV_3D". ...WHY? Really...why?? I don't see any explanation for this bizarre substitution. It's performed by the preprocessor, so should be

[Kicad-developers] Pushed new component selector

2017-02-18 Thread Chris Pavlina
I just pushed the revamped component selector. Thanks to Tomasz for the kiface-compatible footprint preview pane! The following changes are added in this revision: - Most obviously: add footprint preview to the eeschema component selector. Currently, this only works if the symbol has a value

Re: [Kicad-developers] [PATCH] hiding nets from ratsnest

2017-02-18 Thread Wayne Stambaugh
On 2/16/2017 9:20 AM, Maciej Sumiński wrote: > Hi Julius, > > Thank you for the patch, but at the moment I am not sure we can push it. > We would like to have the feature you implemented, but there is a new > connectivity algorithm on the way, which may be much different compared > to what we

Re: [Kicad-developers] Component selector

2017-02-18 Thread Wayne Stambaugh
On 2/18/2017 4:49 PM, Chris Pavlina wrote: > On Mon, Feb 13, 2017 at 07:08:43PM -0500, Chris Pavlina wrote: >> On Mon, Feb 13, 2017 at 06:57:07PM -0500, Wayne Stambaugh wrote: >>> Chris, >>> >>> I had a chance to review the new footprint selector. I like it so far >>> although it does seem a bit

Re: [Kicad-developers] [PATCH] kicad: tree_project_frame: fixup drawframe style

2017-02-18 Thread Clemens Koller
Thank you... I'll manage on my own, what's merged, then. I do test my stuff on Linux/X11/XFCE for now. Testing for Win7 is possible on request. Clemens On 2017-02-18 23:09, Chris Pavlina wrote: > On Sat, Feb 18, 2017 at 11:04:57PM +0100, Nick Østergaard wrote: >> Well, one thing is ofc to

Re: [Kicad-developers] [PATCH] kicad: tree_project_frame: fixup drawframe style

2017-02-18 Thread Chris Pavlina
On Sat, Feb 18, 2017 at 11:04:57PM +0100, Nick Østergaard wrote: > Well, one thing is ofc to bring down the burden to make a comitter > understand your patch. This is a small patch and probably easy to > comprehend, for some people. > > But I don't really understand what problem this patch tries

Re: [Kicad-developers] [PATCH] kicad: tree_project_frame: fixup drawframe style

2017-02-18 Thread Nick Østergaard
Well, one thing is ofc to bring down the burden to make a comitter understand your patch. This is a small patch and probably easy to comprehend, for some people. But I don't really understand what problem this patch tries to fix, this means that I can't not really help testing it on a potentially

Re: [Kicad-developers] Component selector

2017-02-18 Thread Chris Pavlina
On Mon, Feb 13, 2017 at 07:08:43PM -0500, Chris Pavlina wrote: > On Mon, Feb 13, 2017 at 06:57:07PM -0500, Wayne Stambaugh wrote: > > Chris, > > > > I had a chance to review the new footprint selector. I like it so far > > although it does seem a bit cramped with both preview window. I'm not >

Re: [Kicad-developers] [PATCH] kicad: tree_project_frame: fixup drawframe style

2017-02-18 Thread Clemens Koller
Hello mergers! I don't see my patch in master. It was neither merged nor commented. How long are devs expect to wait until it's okay to bump it? How can we make sure that no patches get lost on the way... especially when they are so subtle. Regards, Clemens On 2017-02-08 22:13, Clemens Koller

[Kicad-developers] [PATCH] pcb_calculator: remove old/unused/lost files.

2017-02-18 Thread Clemens Koller
Hi! It might make sense to remove some old icons / unused pictures... Greets, Clemens >From bed683580f4f3b5f0e534790decc97af3a91612e Mon Sep 17 00:00:00 2001 From: Clemens Koller Date: Sat, 18 Feb 2017 22:12:17 +0100 Subject: pcb_calculator: remove old/unused/lost files. diff

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

2017-02-18 Thread Jon Evans
Hi all, Attached is a follow-up patch to the COLOR4D change above -- I reverted from using wxColourPickerCtrl back to wxBitmapButton in the eeschema color config, because I finally got my Windows 10 testing environment set up, and found out that for some reason wxColourPickerCtrl looks really

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

2017-02-18 Thread Nick Østergaard
I have noticed that Alejandro's branch does not have a clearance distance to a keepout zone, which the old filling algorithm has. I am not sure what is really desired, but this could potentially break old designs, although I like the new way where the zone goes to the keepout edge. 2017-02-17

Re: [Kicad-developers] [RFC] Future of GitHub libraries

2017-02-18 Thread Clemens Koller
Hello, Jon! Thank you for your feedback, I fully agree with you. Just let me correct my own sentence: > On Sat, Feb 18, 2017 at 8:31 AM, Clemens Koller > wrote: > Nobody should need to mess with an scm tool on a daily basis when doing > electronics

Re: [Kicad-developers] [RFC] Future of GitHub libraries

2017-02-18 Thread Miron Iancu
Hello. Maybe you might be interested in the opinion of a newbie user and contributor. My experience: - worked mostly with Altium and Eagle for my hobby projects; - I earn my living as a project manager for a large multinational business software vendor, with +20 years PM experience. I have

Re: [Kicad-developers] [RFC] Future of GitHub libraries

2017-02-18 Thread Ingo Kletti
To add my 2 cents from a user perspective: Am Samstag, 18. Februar 2017, 09:57:55 schrieb Jon Evans: > [...] > > At my workplace, we use Git to store electronics designs and > symbol/footprint libraries. When I did the classroom installs for our students last fall I had to hack the

Re: [Kicad-developers] [RFC] Future of GitHub libraries

2017-02-18 Thread Jon Evans
Hi Clemens, just wanted to give another perspective that goes against your last line -- Just wanted to say that some of us are very happy to use SCM daily. At my workplace, we use Git to store electronics designs and symbol/footprint libraries. It started with the electronics people who also do

Re: [Kicad-developers] [RFC] Future of GitHub libraries

2017-02-18 Thread Clemens Koller
Hi, Andy! On 2017-02-17 19:51, Andy Peters wrote: >> On Feb 17, 2017, at 8:31 AM, Clemens Koller wrote: >> And: In the long-term we might also think about using git for project and >> design management and versioning. (We could even store undo's and redo's in >> git?) > >