Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread Oliver Walters
Looks like module text fields should be culled from the selection in ::SanitizeSelection if the parent module is also selected. On 11 May 2017 04:15, "Joakim Asplund" wrote: > On Sat, May 6, 2017 at 9:21 AM, Oliver Walters < > oliver.henry.walt...@gmail.com> wrote: >> >> a)

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread Joakim Asplund
On Sat, May 6, 2017 at 9:21 AM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > > a) PCBNEW > > Selecting part of a MODULE (right to left) will select both the entire > module and also any parts of the module that you touched (lines, pads, > etc). Then, when you move the module, the

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread Oliver Walters
JP, Sorry, the code for ::ClosestPointTo "used to" have a variable called near. I had since removed it. Never mind :) On Wed, May 10, 2017 at 11:47 PM, jp charras wrote: > Le 10/05/2017 à 15:29, Oliver Walters a écrit : > > JP, > > > > I think that the code "wxPoint

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread jp charras
Le 10/05/2017 à 15:29, Oliver Walters a écrit : > JP, > > I think that the code "wxPoint near" should also be changed to "wxPoint > nearpt" ('near' also seems > to be a somewhat-reserved keyword) > Sure, "far" and "near" must be avoided on Windows, they look like they are still reserved

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread Wayne Stambaugh
Brian, Welcome back! It's good to hear from you after such a long absence. Cheers, Wayne On 5/10/2017 6:18 AM, Brian Sidebotham wrote: > I've been away from the coal face for so long. I've just been catching > up with the list and can't wait to compile the latest! > > Good work to all who've

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread jp charras
Le 10/05/2017 à 14:56, Wayne Stambaugh a écrit : > Windows builds on mingw using gcc 6.3.0 are broken. Here is the > compiler error: > > C:/msys64/home/wstambaugh/src/kicad-trunk/common/base_struct.cpp: In > member function 'bool EDA_RECT::IntersectsCircleEdge(const wxPoint&, > int, int) const':

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread Oliver Walters
JP, I think that the code "wxPoint near" should also be changed to "wxPoint nearpt" ('near' also seems to be a somewhat-reserved keyword) On Wed, May 10, 2017 at 11:23 PM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > Looks like JP has already fixed this :) > > On Wed, May 10, 2017

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread Oliver Walters
Looks like JP has already fixed this :) On Wed, May 10, 2017 at 10:56 PM, Wayne Stambaugh wrote: > Windows builds on mingw using gcc 6.3.0 are broken. Here is the > compiler error: > > C:/msys64/home/wstambaugh/src/kicad-trunk/common/base_struct.cpp: In > member function

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread Wayne Stambaugh
Windows builds on mingw using gcc 6.3.0 are broken. Here is the compiler error: C:/msys64/home/wstambaugh/src/kicad-trunk/common/base_struct.cpp: In member function 'bool EDA_RECT::IntersectsCircleEdge(const wxPoint&, int, int) const':

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread Brian Sidebotham
I've been away from the coal face for so long. I've just been catching up with the list and can't wait to compile the latest! Good work to all who've been doing some amazing work recently! Hopefully I'll be able to start contributing again soon. :) Brian. On 10 May 2017 at 10:41, Maciej

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread Maciej Sumiński
Hi Oliver, Thank you very much for your effort, I have just pushed your patches to the master branch. Regards, Orson On 05/09/2017 09:32 AM, Oliver Walters wrote: > Two more patches for this set (attached) > > 0017 - Slight fix for arc segment hit test (line width was not accounted > for) >