Re: [Kicad-developers] [feature] Simpler edition of custom pads

2017-10-19 Thread Oliver Walters
> > I forgot to mention, it's now possible to draw graphical polygons (not > zones) both in pcbnew and in the footprint editor. But Christmas isn't for another two months!! On Fri, Oct 20, 2017 at 8:36 AM, Tomasz Wlostowski < tomasz.wlostow...@cern.ch> wrote: > Dear all, > > I've just pushed a

[Kicad-developers] [PATCH] Regression fix for pcbnew track cleanup

2017-10-19 Thread Seth Hillbrand
​This ​patch fixes a regression in commit 5c0edbaba (wow, that was a ways back). Currently, pcbnew will cleanup duplicate tracks by deleting both tracks, rather than just one of the duplicates. This patch ensures only one of the two tracks will be deleted. Fixes: https://bugs.launchpad.net/kicad

[Kicad-developers] [feature] Simpler edition of custom pads

2017-10-19 Thread Tomasz Wlostowski
Dear all, I've just pushed a set of patches that simplifies drawing and editing custom pad shapes: - Now you can draw a number of graphic primitives in the footprint editor, select them together and R-click->Create Pad From Selected Shapes) to convert them to a custom-shaped pad. - ... and the o

Re: [Kicad-developers] Datasheet confusion

2017-10-19 Thread Wayne Stambaugh
Looks good to me. If there are no major objections I will merge this patch. On 10/19/2017 11:53 AM, Kristoffer Ödmark wrote: > I tested the GetAssociatedDocument, works much better and has more > features so i took the freedom of updating the dialog windows to use > that instead of the wxLaunchDe

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

2017-10-19 Thread jp charras
Le 19/10/2017 à 17:26, Maciej Sumiński a écrit : > On 10/19/2017 05:20 PM, jp charras wrote: >> Le 19/10/2017 à 16:59, Maciej Sumiński a écrit : >>> On 10/19/2017 04:32 PM, jp charras wrote: >>> [snip] Hi Orson, Could you have a look into this patch? It fixes the issue when a ch

Re: [Kicad-developers] Datasheet confusion

2017-10-19 Thread Kristoffer Ödmark
I tested the GetAssociatedDocument, works much better and has more features so i took the freedom of updating the dialog windows to use that instead of the wxLaunchDefaultBrowser as well attaching patch :) - Kristoffer On 10/19/2017 02:07 PM, Wayne Stambaugh wrote: On 10/19/2017 7:09 AM, Kri

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

2017-10-19 Thread Maciej Sumiński
On 10/19/2017 05:20 PM, jp charras wrote: > Le 19/10/2017 à 16:59, Maciej Sumiński a écrit : >> On 10/19/2017 04:32 PM, jp charras wrote: >> [snip] >>> Hi Orson, >>> >>> Could you have a look into this patch? >>> It fixes the issue when a change is committed with a item belonging a >>> footprint.

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

2017-10-19 Thread jp charras
Le 19/10/2017 à 16:59, Maciej Sumiński a écrit : > On 10/19/2017 04:32 PM, jp charras wrote: > [snip] >> Hi Orson, >> >> Could you have a look into this patch? >> It fixes the issue when a change is committed with a item belonging a >> footprint. >> >> But I do not have very good knowledge of COMM

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

2017-10-19 Thread Maciej Sumiński
On 10/19/2017 04:32 PM, jp charras wrote: [snip] > Hi Orson, > > Could you have a look into this patch? > It fixes the issue when a change is committed with a item belonging a > footprint. > > But I do not have very good knowledge of COMMIT classes. Hi Jean-Pierre, Thank you for looking into t

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

2017-10-19 Thread jp charras
Le 19/10/2017 à 12:55, Maciej Sumiński a écrit : > On 10/19/2017 11:31 AM, jp charras wrote: >> Le 18/10/2017 à 16:57, Oliver Walters a écrit : >>> JP, >>> >>> Fantastic, you have worked your magic! That works much better in pcbnew >>> now, the undo/redo is >>> working well. >>> >>> However, I sti

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

2017-10-19 Thread jp charras
Le 19/10/2017 à 13:00, jp charras a écrit : > Le 19/10/2017 à 12:55, Maciej Sumiński a écrit : >> On 10/19/2017 11:31 AM, jp charras wrote: >>> Le 18/10/2017 à 16:57, Oliver Walters a écrit : JP, Fantastic, you have worked your magic! That works much better in pcbnew now, the u

Re: [Kicad-developers] New fix for bug 1663173

2017-10-19 Thread Wayne Stambaugh
Hi Jean-Samuel, I committed your code to the master branch. Thank you for your contribution to KiCad. Cheers, Wayne On 10/19/2017 4:30 AM, Jean-Samuel Reynaud wrote: > Hi, > > Sorry, corrected patch attached. > > Regards > Le 18/10/2017 à 19:31, Wayne Stambaugh a écrit : >> Hi Jean-Samuel, >

Re: [Kicad-developers] Datasheet confusion

2017-10-19 Thread Wayne Stambaugh
On 10/19/2017 7:09 AM, Kristoffer Ödmark wrote: > Yes indeed it breaks that, I would argue that having an "invisible" > field opened when using the context field is the source of the > confusion. So I am aware it breaks the context menu for old schematics > but think it is necessary anyway. I'm O

Re: [Kicad-developers] Datasheet confusion

2017-10-19 Thread Kristoffer Ödmark
Yes indeed it breaks that, I would argue that having an "invisible" field opened when using the context field is the source of the confusion. So I am aware it breaks the context menu for old schematics but think it is necessary anyway. I can of course use GetAssociatedDocument instead. On Oct 19,

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

2017-10-19 Thread jp charras
Le 19/10/2017 à 12:55, Maciej Sumiński a écrit : > On 10/19/2017 11:31 AM, jp charras wrote: >> Le 18/10/2017 à 16:57, Oliver Walters a écrit : >>> JP, >>> >>> Fantastic, you have worked your magic! That works much better in pcbnew >>> now, the undo/redo is >>> working well. >>> >>> However, I sti

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

2017-10-19 Thread Maciej Sumiński
On 10/19/2017 11:31 AM, jp charras wrote: > Le 18/10/2017 à 16:57, Oliver Walters a écrit : >> JP, >> >> Fantastic, you have worked your magic! That works much better in pcbnew now, >> the undo/redo is >> working well. >> >> However, I still see that undo/redo for zone editing is broken in modedit

Re: [Kicad-developers] Datasheet confusion

2017-10-19 Thread jp charras
Le 18/10/2017 à 20:20, Kristoffer Ödmark a écrit : > Glad to hear it, I fixed a patch up that will highlight the differences a bit > better than I explain it. > > Basically it will fill the field from the properties if the field is empty > when adding components to > the schematic. > > It will

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

2017-10-19 Thread jp charras
Le 18/10/2017 à 16:57, Oliver Walters a écrit : > JP, > > Fantastic, you have worked your magic! That works much better in pcbnew now, > the undo/redo is > working well. > > However, I still see that undo/redo for zone editing is broken in modedit. > > Oliver > Yes, because when an item belon

Re: [Kicad-developers] New fix for bug 1663173

2017-10-19 Thread Jean-Samuel Reynaud
Hi, Sorry, corrected patch attached. Regards Le 18/10/2017 à 19:31, Wayne Stambaugh a écrit : > Hi Jean-Samuel, > > There are a few coding policy violations in your patch. > > if( outline.OutlineCount() > 0) { > > should be: > > if( outline.OutlineCount() > 0 ) > { > > This occurs several ti