Re: [Kicad-developers] bug in numeric_evaluator?

2018-03-12 Thread Jon Evans
+Michael This looks like "clever" code so I can't tell if this is a bug or not without running through a bunch of test cases which I'm not going to do right now. Do you see any issues with the operation of the code, Mark, or just the warning? -Jon On Mon, Mar 12, 2018 at 9:28 PM, Mark Roszko

[Kicad-developers] bug in numeric_evaluator?

2018-03-12 Thread Mark Roszko
Not sure where to even begin looking at libeval since it looks scary but MSVC complains: D:\kicad-source-mirror\common\libeval\numeric_evaluator.cpp(216): warning C4805: '==': unsafe mix of type 'char' and type 'bool' in operation which is: auto ch = clToken.input[clToken.pos]; do {

Re: [Kicad-developers] Pushed change

2018-03-12 Thread Kevin Cozens
On 2018-03-12 05:03 PM, Jeff Young wrote: Well, my build is still running so I can’t confirm the fixes yet, but since I already broke the build for some I went ahead and pushed “fixes”. My build with latest hash code of f32f14dc8 completed without error. -- Cheers! Kevin.

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Mark Roszko
nick, use the attached patched on kicad :3 Under vcpkg, wxwidgets is put into a unix like dependency tree meanwhile the wxwidgets script assumes crazy prefixed distributed by wx scheme. With this it'll at least find the right path. If you are using VS2017, here's a sample CMakeSettings.Json

Re: [Kicad-developers] Volunteer

2018-03-12 Thread Jon Evans
That's a good point, I think we should all try to be better about assigning ourselves to things on launchpad so that people don't accidentally work on the same thing! Jon On Mon, Mar 12, 2018, 19:48 hauptmech wrote: > Thanks, at first glance it looked like the work there

Re: [Kicad-developers] Volunteer

2018-03-12 Thread hauptmech
Thanks, at first glance it looked like the work there was fast and furious with devs working on bugs without formally grabbing the assignment, so I was afraid of stepping on toes. On 13/03/18 11:59, Nick Østergaard wrote: If you have a hard time to find a bug worth looking at, you could

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Mark Roszko
The findwxwidgets script in kicad is screwy, it can't even find wxwidgets in msys2 if I invoke Msys2 via a secondary terminal/application (i.e. using msys2 as a toolchain rather than shell directly). On Mon, Mar 12, 2018 at 7:02 PM, Nick Østergaard wrote: > I can't make cmake

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Nick Østergaard
I can't make cmake find wxwidgets from vcpkg. I think Thomas Figueroa also uses vcpkg, but he built wxwidgets himself to overcome this. So I think something is missing for wxwidgets in vcpkg, or something else is not quite right in that corner. 2018-03-12 23:36 GMT+01:00 Mark Roszko

Re: [Kicad-developers] Volunteer

2018-03-12 Thread Nick Østergaard
If you have a hard time to find a bug worth looking at, you could probably have a look at https://launchpad.net/kicad/+milestone/5.0.0-rc2 and pick one where no one is assigned. 2018-03-12 23:38 GMT+01:00 Jeff Young : > I threw one your way, but it would also be handy to know

Re: [Kicad-developers] Volunteer

2018-03-12 Thread hauptmech
Linux (Arch, though Ubuntu LTS is always on a partition nearby). I have the other platforms on my desk but don't have a kicad build set up on them, nor do I know much about their build/wx related quirks. On 13/03/18 11:38, Jeff Young wrote: I threw one your way, but it would also be handy to

Re: [Kicad-developers] Volunteer

2018-03-12 Thread Jeff Young
I threw one your way, but it would also be handy to know what platform you’re on, as some of them are platform-specific. Cheers, Jeff. > On 12 Mar 2018, at 22:07, hauptmech wrote: > > I'm able to do some work on v5-rc bugs. I'm reasonably familiar with all > corners of

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Mark Roszko
Wayne, Long term there is good news, VCPKG exists. https://github.com/ Microsoft/vcpkg right now its separate but eventually it'll be part of VS. (But it works now). It's like msysbut for MSVC and it builds packages locally and puts them in a central store. I think most of Kicad's

[Kicad-developers] Volunteer

2018-03-12 Thread hauptmech
I'm able to do some work on v5-rc bugs. I'm reasonably familiar with all corners of the code. Bugs where the desired results are clear from the bug discussion are probably best. Just assign them to me on launchpad and I'll get to work. ___ Mailing list:

Re: [Kicad-developers] Git noob question

2018-03-12 Thread Nick Østergaard
2018-03-12 21:02 GMT+01:00 Kevin Cozens : > On 2018-03-11 11:52 AM, Nick Østergaard wrote: > >> That sounds a bit risky. Using the stash and popping can make you lose >> your local changes if you decide to abort a potential merge conflict. IIRC. >> Commiting changes are generally

Re: [Kicad-developers] Pushed change

2018-03-12 Thread Nick Østergaard
It looks like it just passed the build here, http://ci.kicad-pcb.org/job/linux-kicad-full-gcc-head/3072/ 2018-03-12 22:03 GMT+01:00 Jeff Young : > Well, my build is still running so I can’t confirm the fixes yet, but > since I already broke the build for some I went ahead and

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Wayne Stambaugh
On 03/12/2018 04:45 PM, Simon Richter wrote: > Hi, > > On 12.03.2018 16:39, Tomasz Wlostowski wrote: > >> Would someone be so kind to upload all build dependencies for Kicad >> compiled for VS in a binary form? > > I have them as artifacts in Jenkins[1], and the runtime is also > available on

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Simon Richter
Hi, On 12.03.2018 21:50, Tomasz Wlostowski wrote: > Would you be able to provide all dependencies for Kicad MSVC builds in > form of a zip archive (+CMake.exe)? I've told Jenkins to pack all the artifacts together, for some reason they ended up in the root of the download server. I'll move them

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Wayne Stambaugh
Tom, I would prefer KiCad not be in the business of providing dependency binaries. I can't stop anyone from providing them but I would rather developers focus on kicad development rather than our dependencies as much as possible. The whole point of removing all of the dependency build code from

[Kicad-developers] Jenkins build is back to normal : kicad-qa #3761

2018-03-12 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help

Re: [Kicad-developers] Pushed change

2018-03-12 Thread Jeff Young
Well, my build is still running so I can’t confirm the fixes yet, but since I already broke the build for some I went ahead and pushed “fixes”. We’ll see if they actually are shortly. ;) > On 12 Mar 2018, at 20:33, Kevin Cozens wrote: > > On 2018-03-12 03:19 PM, Jeff Young

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Tomasz Wlostowski
On 12/03/18 21:41, Simon Richter wrote: > Hi, > > On 12.03.2018 19:10, Wayne Stambaugh wrote: > >> As long as we don't have to add msvs specific fixes to the kicad source >> then I don't have any issues with this but I think this falls under the >> category be careful what you wish for. > >

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Simon Richter
Hi, On 12.03.2018 16:39, Tomasz Wlostowski wrote: > Would someone be so kind to upload all build dependencies for Kicad > compiled for VS in a binary form? I have them as artifacts in Jenkins[1], and the runtime is also available on the download server[2]. The only thing that is missing is

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Simon Richter
Hi, On 12.03.2018 19:10, Wayne Stambaugh wrote: > As long as we don't have to add msvs specific fixes to the kicad source > then I don't have any issues with this but I think this falls under the > category be careful what you wish for. There is one major issue for building with Visual Studio:

Re: [Kicad-developers] Pushed change

2018-03-12 Thread Kevin Cozens
On 2018-03-12 03:19 PM, Jeff Young wrote: I just pushed a change which removes a bunch of unnecessary boilerplate. But it occurs to me that maybe it’s necessary with pickier compilers? Anyway, if someone could try it on Windows and/or Unix that would be great. Oops. Something broke. I'm

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Tomasz Wlostowski
On 12/03/18 19:10, Wayne Stambaugh wrote: > The context switching build > issue will most likely have to be fixed yet again if we choose to go > down this path. Wayne, One of the things that Windows does remarkably well is binary compatibility. We can just provide pre-built libcontext binaries

Re: [Kicad-developers] Pushed change

2018-03-12 Thread Jeff Young
Cool. I’ll fix it up. Cheers, Jeff. > On 12 Mar 2018, at 20:07, jp charras wrote: > > Le 12/03/2018 à 20:53, Jeff Young a écrit : >> Hi JP, >> >>> On 12 Mar 2018, at 19:40, jp charras wrote: >>> >>> Le 12/03/2018 à 20:19, Jeff Young a écrit :

Re: [Kicad-developers] Pushed change

2018-03-12 Thread jp charras
Le 12/03/2018 à 20:53, Jeff Young a écrit : > Hi JP, > >> On 12 Mar 2018, at 19:40, jp charras wrote: >> >> Le 12/03/2018 à 20:19, Jeff Young a écrit : >>> Hi folks, >>> >>> I just pushed a change which removes a bunch of unnecessary boilerplate. >>> >>> But it occurs to

Re: [Kicad-developers] Git noob question

2018-03-12 Thread Kevin Cozens
On 2018-03-11 11:52 AM, Nick Østergaard wrote: That sounds a bit risky. Using the stash and popping can make you lose your local changes if you decide to abort a potential merge conflict. IIRC. Commiting changes are generally safer. Or you could use git stash apply instead. The risk of lose

[Kicad-developers] Build failed in Jenkins: kicad-qa #3760

2018-03-12 Thread Miguel Angel Ajo
See Changes: [jeff] Translatable strings must be ASCII7 for translation tools. -- Started by an SCM change Building remotely on debian8 (clang gcc linux) in workspace

Re: [Kicad-developers] Pushed change

2018-03-12 Thread Jeff Young
Hi JP, > On 12 Mar 2018, at 19:40, jp charras wrote: > > Le 12/03/2018 à 20:19, Jeff Young a écrit : >> Hi folks, >> >> I just pushed a change which removes a bunch of unnecessary boilerplate. >> >> But it occurs to me that maybe it’s necessary with pickier compilers?

Re: [Kicad-developers] Pushed change

2018-03-12 Thread jp charras
Le 12/03/2018 à 20:19, Jeff Young a écrit : > Hi folks, > > I just pushed a change which removes a bunch of unnecessary boilerplate. > > But it occurs to me that maybe it’s necessary with pickier compilers? > Anyway, if someone could try it on Windows and/or Unix that would be great. > >

[Kicad-developers] Build failed in Jenkins: kicad-qa #3759

2018-03-12 Thread Miguel Angel Ajo
See Changes: [jeff] The _() macro affords some nullptr safety over a naked immediate. -- Started by an SCM change Building remotely on debian8 (clang gcc linux) in workspace

[Kicad-developers] Pushed change

2018-03-12 Thread Jeff Young
Hi folks, I just pushed a change which removes a bunch of unnecessary boilerplate. But it occurs to me that maybe it’s necessary with pickier compilers? Anyway, if someone could try it on Windows and/or Unix that would be great. Cheers, Jeff. ___

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Wayne Stambaugh
On 3/12/2018 1:24 PM, Tomasz Wlostowski wrote: > On 12/03/18 17:36, Wayne Stambaugh wrote: >> No doubt I'm out of touch. :) It's been at least 10 years since I used >> msvs. It's great that they have decided to support open source >> development tools. > > Hi Wayne, > > I hadn't used MSVC for

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Wayne Stambaugh
Thanks for the information everyone. Maybe some day when I have a few spare seconds and am feeling motivated, I will take a look at it. Wayne On 3/12/2018 12:46 PM, Jon Evans wrote: > The free version is actually very complete for many use > cases: https://www.visualstudio.com/vs/compare/ > >

Re: [Kicad-developers] Multi-thread crash

2018-03-12 Thread Seth Hillbrand
Hi Jeff- The underscore is a macro to call wxGetTranslation(). There's some null checking there but more importantly, it returns a wxString that will be valid regardless of the the contents. If you cast a wxString with no data to a C string, you still get the valid pointer to the data segment

[Kicad-developers] Multi-thread crash

2018-03-12 Thread Jeff Young
I’ve had a couple of crashes while clicking in a window when CvPcb was loading footprints. Both were because a format string of the form L"blah, blah, %s" was NULL. Is there some protection that _( "…" ) gives us over using an immediate value? (When I use those instead, it doesn’t crash.)

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Tomasz Wlostowski
On 12/03/18 17:36, Wayne Stambaugh wrote: > No doubt I'm out of touch. :) It's been at least 10 years since I used > msvs. It's great that they have decided to support open source > development tools. Hi Wayne, I hadn't used MSVC for a while until a few months ago where I had to develop a

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Jon Evans
The free version is actually very complete for many use cases: https://www.visualstudio.com/vs/compare/ On Mon, Mar 12, 2018 at 12:36 PM, Wayne Stambaugh wrote: > No doubt I'm out of touch. :) It's been at least 10 years since I used > msvs. It's great that they have

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Wayne Stambaugh
No doubt I'm out of touch. :) It's been at least 10 years since I used msvs. It's great that they have decided to support open source development tools. I'm may to to check it out when I get a chance. I'm guessing they have a minimal free version available or have they stopped offering that?

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Tomasz Wlostowski
On 12/03/18 16:36, Mark Roszko wrote: > Way out of touch now Wayne ;) > > VS can open CMake projects directly without generator. Also supports > GDB.MINGWand even ships with Clang. MS even patched all their > VC++ headers to be compatible with Clang. Would someone be so kind to upload

Re: [Kicad-developers] Building with visual studio? looking for a tutorial.

2018-03-12 Thread Mark Roszko
Way out of touch now Wayne ;) VS can open CMake projects directly without generator. Also supports GDB.MINGWand even ships with Clang. MS even patched all their VC++ headers to be compatible with Clang. I haven't tried this yet though, but in theory it should be possible to run

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

2018-03-12 Thread Wayne Stambaugh
On 3/12/2018 10:40 AM, Steven A. Falco wrote: > On 03/12/2018 10:23 AM, Jon Evans wrote: >> I have seen multiple users who run nightlies think they have RC2 because >> they read "5.0.0-rc2" and stop reading after that :-) >> Maybe we should switch the tag back to "5.0-dev" between RC releases? >>

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

2018-03-12 Thread Steven A. Falco
On 03/12/2018 10:23 AM, Jon Evans wrote: > I have seen multiple users who run nightlies think they have RC2 because they > read "5.0.0-rc2" and stop reading after that :-) > Maybe we should switch the tag back to "5.0-dev" between RC releases? > I think all of us developers are going to look up

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

2018-03-12 Thread Wayne Stambaugh
On 3/12/2018 10:23 AM, Jon Evans wrote: > I have seen multiple users who run nightlies think they have RC2 because > they read "5.0.0-rc2" and stop reading after that :-) > Maybe we should switch the tag back to "5.0-dev" between RC releases? > I think all of us developers are going to look up the

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

2018-03-12 Thread Jon Evans
I have seen multiple users who run nightlies think they have RC2 because they read "5.0.0-rc2" and stop reading after that :-) Maybe we should switch the tag back to "5.0-dev" between RC releases? I think all of us developers are going to look up the git hash anyway to know exactly when a given

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

2018-03-12 Thread Wayne Stambaugh
The version string should look like 5.0.0-rc2-dev-176-g53c9143b6 or 5.0.0-rc2-dev. The latter only happens if KiCad is built from a source archive or git isn't available to generate the full version sting. Wayne On 3/12/2018 10:02 AM, Rene Pöschl wrote: > Hello > > It seems at least some

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

2018-03-12 Thread Jon Evans
Yes, the version string was bumped to 5.0.0-rc2-dev Maybe it would be less confusing to have it be "5.0.0-pre-rc2-dev" ? On Mon, Mar 12, 2018 at 10:02 AM, Rene Pöschl wrote: > Hello > > It seems at least some packages of current nightlies report themselves as > version

[Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

2018-03-12 Thread Rene Pöschl
Hello It seems at least some packages of current nightlies report themselves as version 5.0.0-rc2. (The arch package seems to be one of them.) Is it on purpose that every nightly between tagging rc1 and tagging rc2 is reported as rc2? (I assumed only the one commit tagged would be called

Re: [Kicad-developers] [RFC] Dynamic text in schematic and board.

2018-03-12 Thread Russell Oliver
Hi JP, Not much really, but would extend the idea to the PCB text and to other parameters. The user in the forum requested the ability to dynamically display pad netnames on the silkscreen for example. I think this would be done as Including the ability to automatically silkscreen project names,

Re: [Kicad-developers] [RFC] Dynamic text in schematic and board.

2018-03-12 Thread jp charras
Le 12/03/2018 à 01:03, Jon Evans a écrit : > I think there are perhaps two different features here: > > 1) an easy way to create a text item that displays an object property (in > schematic or layout).  In > the eventual properties editor, I'm imagining some kind of "show/hide" > checkbox that