Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

Seth, I was thinking about Seth's macos opengl touch tapping patch but I now realize that your patch is only relevant to the legacy canvas. In any event, I merged your patch. Keep up the great work! Thanks, Wayne On 12/15/2017 12:34 PM, Seth Hillbrand wrote: > Wayne- > > Just one.  They are

Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

Wayne- Just one. They are both the same patch (I resent one for Jeff). It should be ready for merging, provided no one has objections. -S On Fri, Dec 15, 2017 at 9:27 AM, Wayne Stambaugh wrote: > I'm I safe in assuming that both of these patches are ready to be merged

Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

I'm I safe in assuming that both of these patches are ready to be merged or is more testing required? On 12/15/2017 12:19 PM, Jeff Young wrote: > Hi Seth, > > Yep, works fine for tap and double-tap on OSX. > > Cheers, > Jeff. > >> On 15 Dec 2017, at 16:29, Seth Hillbrand

Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

Hi Seth, Yep, works fine for tap and double-tap on OSX. Cheers, Jeff. > On 15 Dec 2017, at 16:29, Seth Hillbrand wrote: > > Hi Jeff- > > Here is the patch from the original e-mail. > > Best- > Seth > > On Fri, Dec 15, 2017 at 3:35 AM, Jeff Young

Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

Hi Jeff- Here is the patch from the original e-mail. Best- Seth On Fri, Dec 15, 2017 at 3:35 AM, Jeff Young wrote: > Where can I find the patch (it wasn’t linked to either bug report > mentioned)? > > I want to make sure it doesn’t break trackpad double-tapping. > > Speaking

Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

Where can I find the patch (it wasn’t linked to either bug report mentioned)? I want to make sure it doesn’t break trackpad double-tapping. Speaking of which, tapping in general is broken in GAL (see https://bugs.launchpad.net/kicad/+bug/1737010). I submitted a patch with that bug; any chance

Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

Thanks Chris and Orson for testing. As long as everyone is OK with the approach, I'm happy to build a second patch to extend this to the GAL canvas. Does anyone have objections to how this functions in legacy for now? Best- Seth On Mon, Dec 11, 2017 at 5:02 AM, Maciej Sumiński

Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

I tested the patch on Linux and it works as advertised. Well done, we need the same thing for GAL too. Cheers, Orson On 12/06/2017 07:05 PM, Seth Hillbrand wrote: > ​The attached patch fixes https://bugs.launchpad.net/kicad/+bug/1154020 > > The current double-click handler in draw_panel​ gets

Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

Every once in a while, someone submits a fix for a bug that I didn't even remember existed, but that makes me want to hug them when it's fixed. On Wed, Dec 06, 2017 at 06:05:58PM +, Seth Hillbrand wrote: > ​The attached patch fixes https://bugs.launchpad.net/kicad/+bug/1154020 > > The

[Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

​The attached patch fixes https://bugs.launchpad.net/kicad/+bug/1154020 The current double-click handler in draw_panel​ gets overridden by the disambiguation menu, preventing double-clicks from being properly handled. This patch introduces a delay between the mouse up and handling the