Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

I pushed both patches to the master branch. Jon, thank you for your contribution to KiCad. Cheers, Orson On 01/17/2018 05:54 PM, Maciej Sumiński wrote: > I have just tested the patch on a Windows virtual machine where KiCad > normally crashed and it seems that the fallback mechanism works as it

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

I have just tested the patch on a Windows virtual machine where KiCad normally crashed and it seems that the fallback mechanism works as it should. Chris, if you have time, please check it on you hardware too, if not - I will just push the patch to the master branch. I vaguely recall that Linux

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

An alternative approach attached. Perhaps the two patches could be combined for extra safety. Cheers, Orson On 01/16/2018 08:15 PM, Maciej Suminski wrote: > For me - not entirely, but definitely it is better than the current > implementation. If you run KiCad for the first time and select

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

For me - not entirely, but definitely it is better than the current implementation. If you run KiCad for the first time and select 'Enable hardware acceleration' on a machine that does not support OpenGL, it switches to Cairo (correctly). Then, when you turn off KiCad, it will save OpenGL as the

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

Sorry I disappeared for a while. I'm building on the machine where I experienced the bug right now. On Tue, Jan 16, 2018 at 04:26:16PM +, Jon Evans wrote: > Wayne/Orson, I'm not sure Chris will have time to review this, could you > please take a look? > > Thanks, > Jon > > On Thu, Jan 11,

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

I have already read the patch, and IMHO it has a chance to fix the problem. Right now I am building KiCad on an ultraslow virtual machine that does not support OpenGL 2.1, so stay tuned! Cheers, Orson On 01/16/2018 05:26 PM, Jon Evans wrote: > Wayne/Orson, I'm not sure Chris will have time to

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

Wayne/Orson, I'm not sure Chris will have time to review this, could you please take a look? Thanks, Jon On Thu, Jan 11, 2018 at 11:02 PM, Jon Evans wrote: > Updated patch attached (missed initializers in the original) > > On Wed, Jan 10, 2018 at 11:40 PM, Jon Evans

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

Updated patch attached (missed initializers in the original) On Wed, Jan 10, 2018 at 11:40 PM, Jon Evans wrote: > Hopefully this fixes: > https://bugs.launchpad.net/kicad/+bug/1741787 > although I don't currently have a good way of reproducing the crash. > > Chris, if you

[Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

Hopefully this fixes: https://bugs.launchpad.net/kicad/+bug/1741787 although I don't currently have a good way of reproducing the crash. Chris, if you can give it a try on your crashing machine that would be greatly appreciated. Thanks -Jon From 764a1cd4f222ef4a7ee08d495d89642950653061 Mon Sep