Subject: Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer
I'll add that you can request access to at least view the kicad
Defects it finds here:
https://scan.coverity.com/projects/3606?tab=overview
On Mon, Apr 13, 2015 at 6:49 PM, Mario Luzeiro mrluze...@ua.pt wrote:
Hi Mark,
yeah , you
03:49
To: Mário Luzeiro
Cc: Cirilo Bernardo; KiCad Developers
Subject: Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer
In that case where can we have a look in the Coverity documentation?
They do not provide a list or documentation on what they may throw.
Perhaps in they do in commercial
It's worth looking at the documentation for the smart pointer used:
http://www.boost.org/doc/libs/1_57_0/libs/smart_ptr/shared_ptr.htm
The last thing I want to do is make your life harder by confusing you,
so please carry on asking questions if it still doesn't make sense for
you. The 3D
So perhaps some one can summarize this changes need
There's hundreds of ways and reasons why Coverity could have thrown
the use after free error that Brian is fixing. There is no one size
fits all solution.
___
Mailing list:
From: Cirilo Bernardo [cirilo.berna...@gmail.com]
Sent: 13 April 2015 23:36
To: Mário Luzeiro
Cc: Brian Sidebotham; KiCad Developers
Subject: Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer
Hi Mario,
The Coverity analysis tool is not so bad; even without
Sidebotham [brian.sidebot...@gmail.com]
Sent: 13 April 2015 23:00
To: KiCad Developers
Subject: Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer
I just tested with VRML 1 and VRML 2 and stuff has appeared not to
break, so I just committed this change.
I opted for the boost::shared_ptr
Thank you Mark! Coverity should not become a substitute for competent
design and careful coding. There have been a lot of false positives so
they should be marked as such. The same thing goes for compiler
warnings. They are just that, a warning that you may have done
something you did not
I just tested with VRML 1 and VRML 2 and stuff has appeared not to
break, so I just committed this change.
I opted for the boost::shared_ptr as we're not yet C++11 and there is
quite a bit of standard container work going on.
Best Regards,
Brian.
On 11 April 2015 at 00:04, Brian Sidebotham
] S3D Mesh Smart Pointer
I just tested with VRML 1 and VRML 2 and stuff has appeared not to
break, so I just committed this change.
I opted for the boost::shared_ptr as we're not yet C++11 and there is
quite a bit of standard container work going on.
Best Regards,
Brian.
On 11 April 2015
I'll add that you can request access to at least view the kicad
Defects it finds here:
https://scan.coverity.com/projects/3606?tab=overview
On Mon, Apr 13, 2015 at 6:49 PM, Mario Luzeiro mrluze...@ua.pt wrote:
Hi Mark,
yeah , you are right, that one maybe was a very specific situation. I was
In that case where can we have a look in the Coverity documentation?
They do not provide a list or documentation on what they may throw.
Perhaps in they do in commercial version but not in the open source
version.
Is that something I can run / test myself?
No, we are only allowed 2
Hi Mark,
yeah , you are right, that one maybe was a very specific situation. I was
thinking something more easy and general like you should initialize your vars.
In that case where can we have a look in the Coverity documentation?
Is that something I can run / test myself?
Regards,
Mario
Hi Guys,
Could someone who has access to both vrml1 and vrml2 models please
test the attached patch which uses a smart pointer rather than
S3D_MESH* to get rid of some coverity issues and feedback whether it
makes your computer explode, or carry on working normally?
Alternatively, could someone
13 matches
Mail list logo
