Re: [Kicad-developers] [PATCH] Type refactoring - needs *extensive* testing

2012-05-10 Thread Lorenzo Marcantonio
On Wed, May 09, 2012 at 07:42:04PM -0400, Wayne Stambaugh wrote: 1) It is fine for folks to test but there are too many changes at least for me to review and commit at one time. For committing purposes I would prefer this be broken into four separate patches. One each for the EDA_COLOR_T,

Re: [Kicad-developers] [PATCH] Type refactoring - needs *extensive* testing

2012-05-10 Thread Dick Hollenbeck
On 05/09/2012 06:42 PM, Wayne Stambaugh wrote: Lorenzo, I like a lot of the work you did here and I appreciate your efforts and enthusiasm. I have a few comments about this patch. 1) It is fine for folks to test but there are too many changes at least for me to review and commit at one

Re: [Kicad-developers] [PATCH] Type refactoring - needs *extensive* testing

2012-05-10 Thread Dick Hollenbeck
On 05/10/2012 12:05 PM, Dick Hollenbeck wrote: On 05/09/2012 06:42 PM, Wayne Stambaugh wrote: Lorenzo, I like a lot of the work you did here and I appreciate your efforts and enthusiasm. I have a few comments about this patch. 1) It is fine for folks to test but there are too many changes

Re: [Kicad-developers] [PATCH] Type refactoring - needs *extensive* testing

2012-05-10 Thread Lorenzo Marcantonio
On Thu, May 10, 2012 at 12:05:28PM -0500, Dick Hollenbeck wrote: spaces and tabs, in particular. bzr will handle the end of line just fine, as needed, per platform. I got a *lot* of file with CRLF, expecially those generated by form builder. No problem in converting them, I only wanted to

Re: [Kicad-developers] [PATCH] Type refactoring - needs *extensive* testing

2012-05-09 Thread Miguel Angel Ajo Pelayo
Good work :D,and also fast! ;) 2012/5/9 Lorenzo Marcantonio l.marcanto...@logossrl.com The witch hunt gave its fruits. The patch is a biggie, now I'm testing it but obviously some bug could have crept it (aka the 'shit happens' principle). This would contribute to the C++-ification of kicad

Re: [Kicad-developers] [PATCH] Type refactoring - needs *extensive* testing

2012-05-09 Thread Lorenzo Marcantonio
On Wed, May 09, 2012 at 01:52:52PM +0200, Miguel Angel Ajo Pelayo wrote: Good work :D,and also fast! ;) I want you to understand the needs extensive testing thing... it's not production ready but I posted it to accelerate the bug feedback XD -- Lorenzo Marcantonio Logos Srl

Re: [Kicad-developers] [PATCH] Type refactoring - needs *extensive* testing

2012-05-09 Thread Miguel Angel Ajo Pelayo
It's fully understood, but for a first patch it was fast anyway! I cannot allocate any more time for testing it right now, but wanted to say: I like it :D 2012/5/9 Lorenzo Marcantonio l.marcanto...@logossrl.com On Wed, May 09, 2012 at 01:52:52PM +0200, Miguel Angel Ajo Pelayo wrote: Good