Re: [Kicad-developers] Zone keepouts within modules

2018-03-26 Thread Ladislav Laska
Hi! > Regarding thread merged, I am seeing this on > 'https://lists.launchpad.net/kicad-developers/'. Maybe has to do with > launchpad itself. Yes. The first message you sent seems to reference the messages from the previous thread "3D search paths and environment variables". This usually

Re: [Kicad-developers] Zone keepouts within modules

2018-03-26 Thread Simon Santesteban
Ok, thank you. I hope 5.0 is released soon. Regarding thread merged, I am seeing this on 'https://lists.launchpad.net/kicad-developers/'. Maybe has to do with launchpad itself. Regards, Simon On 25/03/2018 1:14, Jon Evans wrote: Hi Simon, I haven't had a chance to review and test your

Re: [Kicad-developers] Zone keepouts within modules

2018-03-24 Thread Jon Evans
Hi Simon, I haven't had a chance to review and test your updated patch yet, and I suspect the other devs are also busy trying to get 5.0 out the door. But there are still a lot of code style issues that need to be fixed (indentation needs to be spaces and you use tabs for one example, and there

Re: [Kicad-developers] Zone keepouts within modules

2018-03-23 Thread Simon Santesteban
I am looking into adding zone keepout edition in inner layers, in the module editor, but first I would like to confirm that my previous work is ok. Do you know how a patch is validated? Do I need to do anything else? Also, I noticed that this thread ('Zone keepouts within modules') has been

Re: [Kicad-developers] Zone keepouts within modules

2018-03-19 Thread Simon Santesteban
Hi Jon, Oh yes I missed some of the code style policy... I have attached an updated patch. Regards, Simon El 19/03/2018 a las 21:07, Jon Evans escribió: Hi Simon, Thanks for the updated patch, I was able to give it a quick try and it so far I haven't found any issues (I edited a

Re: [Kicad-developers] Zone keepouts within modules

2018-03-19 Thread Jon Evans
Hi Simon, Thanks for the updated patch, I was able to give it a quick try and it so far I haven't found any issues (I edited a footprint to create a keepout, and then saw that it correctly caused DRC warnings) I noticed a number of coding style policy issues with your patch though; these would

Re: [Kicad-developers] Zone keepouts within modules

2018-03-19 Thread Simon Santesteban
I think I have it updated correctly now. There was a conflict in pcbnew/menubar_footprint_editor.cpp See patch attached. Simon El 19/03/2018 a las 15:28, Jon Evans escribió: Hi Simon, Thanks for sharing your work! This sounds like a neat feature and I'd like to test it and give feedback.

Re: [Kicad-developers] Zone keepouts within modules

2018-03-19 Thread Simon Santesteban
Oh, I didn't know about it. I saw in the links you sent that there were some issues with rotation and undo/redo. This was also my main struggle. Hopefully I had it working, at least the basic stuff. Simon El 19/03/2018 a las 18:16, Rene Pöschl escribió: On 19/03/18 13:02, Simon

Re: [Kicad-developers] Zone keepouts within modules

2018-03-19 Thread Rene Pöschl
On 19/03/18 13:02, Simon Santesteban wrote: Hi everyone, I am a new developer in kicad community. I have been working on adding zones to modules, so I would like to share this work. Find attached a patch to have this functionality. Regards, Simon

Re: [Kicad-developers] Zone keepouts within modules

2018-03-19 Thread Jon Evans
Hi Simon, Thanks for sharing your work! This sounds like a neat feature and I'd like to test it and give feedback. Unfortunately your patch does not apply against current master, and it looks like it is based on an old enough point that I couldn't fix the merge issues manually. Could you please

[Kicad-developers] Zone keepouts within modules

2018-03-19 Thread Simon Santesteban
Hi everyone, I am a new developer in kicad community. I have been working on adding zones to modules, so I would like to share this work. Find attached a patch to have this functionality. Regards, Simon From c4781992a8d4cd17e4a4592fea3bdaf3ec25e31f Mon Sep 17 00:00:00 2001 From: Simon