Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

Windows has always been sucky dealing with scrollwheel focus, on most program you have to click before you can scroll. On Tue, Jan 31, 2017 at 2:50 PM, Diogo Condeço wrote: > Just a side note... This is working 100% in macos... The focus is working > just fine... on 3D

Re: [Kicad-developers] [PATCH] Reorder eeschema toolbar a bit

Okay, just pushed this to both branches. On Sat, Jan 28, 2017 at 04:26:06PM -0500, Wayne Stambaugh wrote: > On 1/28/2017 3:56 PM, Chris Pavlina wrote: > > Hi, > > > > A number of users have been confused by the fact that the order of > > toolbar buttons in eeschema no longer corresponds to the

Re: [Kicad-developers] Eeschema one_field_edit dialog setselection patch

Excellent. Looks good and workse well here - just pushed it. Thank you for your contribution. On Tue, Jan 31, 2017 at 08:46:52PM +, Diogo Condeço wrote: > Hopefully both problems are corrected in this patch... > > Sorry for the code formatting but I'm not that used to this particular >

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

Just a side note... This is working 100% in macos... The focus is working just fine... on 3D preview it zooms in and out... On Tue, Jan 31, 2017 at 8:03 PM, Wayne Stambaugh wrote: > Better but there is still a problem on windows. Once an edit control > has the mouse event

Re: [Kicad-developers] Eeschema one_field_edit dialog setselection patch

Hi, On 31.01.2017 20:13, Chris Pavlina wrote: > /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp: In member > function ‘virtual bool DIALOG_EDIT_ONE_FIELD::TransferDataToWindow()’: > /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp:174:42: > warning: comparison

Re: [Kicad-developers] Eeschema one_field_edit dialog setselection patch

Hopefully both problems are corrected in this patch... Sorry for the code formatting but I'm not that used to this particular format... and sometimes I'll give an extra space... I will try to be more careful next time. Thanks, Diogo On Tue, Jan 31, 2017 at 7:30 PM, Wayne Stambaugh

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

I added the "base-devel" package to the list of packages required to build kicad on windows using msys2. Thank you for letting me know. On 1/30/2017 9:33 AM, Kristoffer Ödmark wrote: > Thank you for the help everyone! > > The missing component was the "base-devel" package, worth noting is that

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

Better but there is still a problem on windows. Once an edit control has the mouse event focus, you can no longer use the mouse wheel to zoom the model preview pane. Left button clicking or double-clicking in the 3D model preview pane makes no difference. On windows it's pretty typical albeit

Re: [Kicad-developers] Eeschema one_field_edit dialog setselection patch

Diogo, Please pay attention to you code formatting. I saw: if ( ... ) instead of: if( ... ) more than once in your patch. Thanks, Wayne On 1/31/2017 2:13 PM, Chris Pavlina wrote: > /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp: In member > function ‘virtual bool

Re: [Kicad-developers] Eeschema one_field_edit dialog setselection patch

/home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp: In member function ‘virtual bool DIALOG_EDIT_ONE_FIELD::TransferDataToWindow()’: /home/cmp/git/kicad/eeschema/dialogs/dialog_edit_one_field.cpp:174:42: warning: comparison between signed and unsigned integer expressions

[Kicad-developers] Eeschema one_field_edit dialog setselection patch

Hi all, This patch selects the text in the dialog. For references the text selected is either the number or the ? (for unannotated symbols). For the other cases the entire text is selected. This has been tested in windows (

Re: [Kicad-developers] [PATCH] Add exchange footprints to GAL

On 1/31/2017 10:32 AM, John Beard wrote: > Hi, > > The attached patches add the "exchange footprints" command to the GAL edit > tool. > > This is 1 out of 3 parts of > https://bugs.launchpad.net/kicad/+bug/1541460. I'm not sure how to put > this as a commit comment exactly. I changed the

Re: [Kicad-developers] PATCH: remove Ohm sign from multiplier bitmap

Hello! I'am currently redoing the images to get used to patching again. The borders are off a bit as well and white is grey... Hold on. Regards, Clemens On 2017-01-31 17:16, Kevin Bortis wrote: > On Fri, Jan 27, 2017 at 1:14 PM jp charras wrote: >> >> Le 27/01/2017 à

Re: [Kicad-developers] PATCH: remove Ohm sign from multiplier bitmap

On Fri, Jan 27, 2017 at 1:14 PM jp charras wrote: > > Le 27/01/2017 à 13:02, Jean-Noël AVILA a écrit : > > Le 27/01/2017 à 12:50, jp charras a écrit : > >> Le 27/01/2017 à 12:26, Chris Pavlina a écrit : > >>> I noticed the artifacts in the code too, but didn't see anything

Re: [Kicad-developers] [PATCH] Add exchange footprints to GAL

On 1/31/2017 10:55 AM, Chris Pavlina wrote: > On Tue, Jan 31, 2017 at 10:45:42AM -0500, Wayne Stambaugh wrote: >> On 1/31/2017 10:36 AM, Chris Pavlina wrote: >>> On Tue, Jan 31, 2017 at 11:32:40PM +0800, John Beard wrote: Hi, The attached patches add the "exchange footprints"

Re: [Kicad-developers] [PATCH] Add exchange footprints to GAL

On Tue, Jan 31, 2017 at 10:45:42AM -0500, Wayne Stambaugh wrote: > On 1/31/2017 10:36 AM, Chris Pavlina wrote: > > On Tue, Jan 31, 2017 at 11:32:40PM +0800, John Beard wrote: > >> Hi, > >> > >> The attached patches add the "exchange footprints" command to the GAL edit > >> tool. > >> > >> This is

Re: [Kicad-developers] [PATCH] Add exchange footprints to GAL

On Tue, Jan 31, 2017 at 11:32:40PM +0800, John Beard wrote: > Hi, > > The attached patches add the "exchange footprints" command to the GAL edit > tool. > > This is 1 out of 3 parts of > https://bugs.launchpad.net/kicad/+bug/1541460. I'm not sure how to put > this as a commit comment exactly.

[Kicad-developers] [PATCH] Add exchange footprints to GAL

Hi, The attached patches add the "exchange footprints" command to the GAL edit tool. This is 1 out of 3 parts of https://bugs.launchpad.net/kicad/+bug/1541460. I'm not sure how to put this as a commit comment exactly. This is implemented as two segments: * Put the dialog/exchange FP code into

Re: [Kicad-developers] Add a cmake option for legacy canvas

I think it's worth revisiting this. I know we're not ready to remove legacy yet, but we're getting close. Starting to factor it out into a switchable build option is a good way to make sure the transition is smooth and help find anything that is still missing. Obviously the default build option

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

Welcome to the joys of cross platform development. :) On 1/31/2017 1:18 AM, Kristoffer Ödmark wrote: > I will look into it, the difference in behavior between the oses is very > strange. > > -Kristoffer > > On Jan 31, 2017 2:30 AM, "Wayne Stambaugh"

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

The real motivation for doing this was the functionality of the scrollwheel. Which I got for free in the spinctrldouble, only in linux though. But since the implementation of spinctrls was horrible on other os, I stuck with the textctrl and instead catch the mouse events and also the

Re: [Kicad-developers] Current state of ActionPlugin

Dear All, A quick update on this feature. I use it since it's committed and it look to work as expected. I advance on my side to provide a undo/redo feature. You will find attached a patch for that. For the moment it's a request for comments. It successfully undo/redo multiples actions

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

Yeah I was actually looking into doing something like this. It actually seems easier than getting the spinctrl do to what I want on multiple platforms. I agree that on windows, the patch is an regression if it doesnt update the view instantly. -Kristoffer On 2017-01-31 10:01, Mário Luzeiro

Re: [Kicad-developers] [PATCH] Changed the 3d model previewer to use spinboxes

Just and idea: What about, somehow, this could be implemented with a second pair of widgets? i.e: keep the line entries as before, and somehow, catching the scroll mouse events on that line entry.. and may add arrow buttons on the side, to work as a spinbox? :S My 2 cents, Mario Luzeiro