Re: [Kicad-developers] [RFC] BOM Editor

2017-02-13 Thread Martin Schreiber
On Tuesday 14 February 2017 07:20:23 Oliver Walters wrote: > Hi all, > > I have been working on a BOM exporter built into KiCad (in addition to the > external BOM script functionality that already exists). > > It's not ready yet to be merged but I am showing the progress here to get > any input

Re: [Kicad-developers] [RFC] BOM Editor

2017-02-13 Thread Nick Østergaard
Without having seen a patch, but I think you should replace the BOM csv exporter in pcbnew's fabrication outputs. What does the cell colors mean? I see empty cell for the datasheet, where one is red the rest of the empty ones are yellow'ish. Is this some of the group stuff? How does the group

Re: [Kicad-developers] [RFC] BOM Editor

2017-02-13 Thread Cirilo Bernardo
That looks very nice. My personal preference for managing BOM would be to have an external stand-alone tool to manage everything so that changes can be made without being disruptive to kicad. Many users have created their own tools and each tool has its own following depending on how people like

Re: [Kicad-developers] [RFC] BOM Editor

2017-02-13 Thread Marco Ciampa
On Tue, Feb 14, 2017 at 05:20:23PM +1100, Oliver Walters wrote: > So, thoughts? One from a non-dev: very nice, very good work! -- Marco Ciampa I know a joke about UDP, but you might not get it. GNU/Linux User #78271 FSFE fellow #364

[Kicad-developers] [RFC] BOM Editor

2017-02-13 Thread Oliver Walters
Hi all, I have been working on a BOM exporter built into KiCad (in addition to the external BOM script functionality that already exists). It's not ready yet to be merged but I am showing the progress here to get any input and in case anyone else is working on a similar feature. Here's a

Re: [Kicad-developers] Component selector

2017-02-13 Thread Chris Pavlina
On Mon, Feb 13, 2017 at 06:57:07PM -0500, Wayne Stambaugh wrote: > Chris, > > I had a chance to review the new footprint selector. I like it so far > although it does seem a bit cramped with both preview window. I'm not > sure there is much you can do about that. I'm fine with you pushing >

Re: [Kicad-developers] Component selector

2017-02-13 Thread Wayne Stambaugh
Chris, I had a chance to review the new footprint selector. I like it so far although it does seem a bit cramped with both preview window. I'm not sure there is much you can do about that. I'm fine with you pushing what you have done so far. I do have one comment. It it necessary to open the

Re: [Kicad-developers] [PATCH] fix "zones ignored in ratsnest" bug (GAL)

2017-02-13 Thread Maciej Suminski
Hi Julius, Thank you very much, I am really grateful for your help. I have just committed your patch, well done! Regards, Orson On 02/12/2017 06:20 PM, Julius Schmidt wrote: > This patch fixes a problem with GAL where zones are ignored in ratsnest > calculation. > The problem is that calling

Re: [Kicad-developers] [PATCH] Prevent segfault when aOutline has no vertices.

2017-02-13 Thread Chris Pavlina
Thank you both. I pushed the fixed patch, crediting hauptmech as the original author and leaving Clemens' signoff. On Mon, Feb 13, 2017 at 10:07:56PM +0100, Clemens Koller wrote: > Well... > > I had a look at this for my very own training pleasure and updated the patch > from Hauptmechto to

Re: [Kicad-developers] rename of kiface to so

2017-02-13 Thread Cirilo Bernardo
If my memory's not too bad, these objects are loaded using hard-coded paths. They are not objects which are automatically resolved and loaded by the linker-loader. This makes any versioning trivial - so long as we *do* provide some version numbers so that the files have different names, kicad can

Re: [Kicad-developers] [PATCH] Prevent segfault when aOutline has no vertices.

2017-02-13 Thread Clemens Koller
Well... I had a look at this for my very own training pleasure and updated the patch from Hauptmechto to suit the coding style AFAICT. (attached) Regards, Clemens On 2017-02-13 21:09, hauptmech wrote: > Thanks for the heads up Chris. > > Respectfully to the developers, I don't have time. If

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-13 Thread Simon Wells
well i don't actually know what needs to be done, i just sent a chunk to pass onto dick, i am not fussed if the whole commit is attributed to dick On 14 February 2017 at 09:32, Wayne Stambaugh wrote: > Simon, > > This isn't going to work as patch that I can commit because

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-13 Thread Wayne Stambaugh
Simon, This isn't going to work as patch that I can commit because the proper credit cannot be attributed to the correct author. I will commit Dick's original patch this evening so you can send me patch for the osx fix which will be attributed to you as the commit author. I don't really want to

Re: [Kicad-developers] [PATCH] Prevent segfault when aOutline has no vertices.

2017-02-13 Thread hauptmech
Thanks for the heads up Chris. Respectfully to the developers, I don't have time. If this does not match your coding style then consider it bug report. -Hauptmech On 14/02/17 04:00, Chris Pavlina wrote: Thank you for your contribution. We're generally pretty strict about the coding style

Re: [Kicad-developers] Differential pair DRC Errors

2017-02-13 Thread Tomasz Wlostowski
On 13.02.2017 17:26, Jon Evans wrote: > I verified using Novak's test case on the Launchpad bug report. DRC > error is generated if the distance between the tracks is exactly equal > to the clearance. > If you increase the spacing by the minimum distance recognized by the > software's precision,

Re: [Kicad-developers] Differential pair DRC Errors

2017-02-13 Thread Jon Evans
I verified using Novak's test case on the Launchpad bug report. DRC error is generated if the distance between the tracks is exactly equal to the clearance. If you increase the spacing by the minimum distance recognized by the software's precision, the DRC passes. So, I think it's an issue of DRC

Re: [Kicad-developers] Differential pair DRC Errors

2017-02-13 Thread Andy Peters
> On Feb 13, 2017, at 2:06 AM, Clemens Koller wrote: > > Hello! > > If the global minimum mandatory clearance/spacing (pitch) of a design (due to > manufacturing limitations) is set (& activated) it should complain when some > other settings are violating that. I purposely

Re: [Kicad-developers] [PATCH] Prevent segfault when aOutline has no vertices.

2017-02-13 Thread Wayne Stambaugh
Hi hauptmech, I've been informed that my terseness could be mistaken for lack of appreciation for your efforts. I apologize if the that was your impression because that was not my intent. I am extremely busy at the moment so I am trying to keep my responses as short as possible and the amount

Re: [Kicad-developers] patch to fix Bug #1626278

2017-02-13 Thread Chris Pavlina
Merged. Thank you. On Thu, Feb 09, 2017 at 08:26:48PM +, Mário Luzeiro wrote: > There is no propose to use mm_alloc at this moment so I changed it to the > regular malloc. > (This also should make the Raspberry PI users happier and use KiCad! :O ) > > Mario

Re: [Kicad-developers] [PATCH] Prevent segfault when aOutline has no vertices.

2017-02-13 Thread Chris Pavlina
Thank you for your contribution. We're generally pretty strict about the coding style for new code; it can be found at Documentation/development/coding-style-policy.md in the source tree. If you don't see what the problem is, pay particular attention to spacing around parentheses, and to the

Re: [Kicad-developers] rename of kiface to so

2017-02-13 Thread Chris Pavlina
rpath? Load by absolute path based on compile prefix? Relative (../lib/foo based on the current exe path)? Seems to me standard library versioning isn't the right way to handle this anyway, since these aren't *libraries* per se but just object bundles. On Mon, Feb 13, 2017 at 09:35:59AM -0500,

Re: [Kicad-developers] rename of kiface to so

2017-02-13 Thread Wayne Stambaugh
When multiple versions of kicad are installed in different install paths, library versioning has to be correct or it's possible that the wrong kiface gets linked. I'm thinking more of users or developers who build and install from source rather than packaged installs. On linux, I could install

Re: [Kicad-developers] rename of kiface to so

2017-02-13 Thread Chris Pavlina
Can you explain why you think installing them as .so to /usr/lib changes in any way our responsibility for library versioning vs installing them as .kiface to /usr/bin? They still get installed with the whole package, reinstalled on upgrade, uninstalled on package removal, etc... On Mon, Feb 13,

Re: [Kicad-developers] rename of kiface to so

2017-02-13 Thread Wayne Stambaugh
I'm not opposed to this but once we head down this path, we will forever be responsible for library versioning and any implications it has with regard to multiple installed versions of kicad. I'm not sure we are ready to open that can of worms just yet. Keep in mind that .kifaces are not generic

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-13 Thread Simon Wells
Error copying file "_pcbnew.kiface" to "_pcbnew.so". attached is dicks patch with my changes On 14 February 2017 at 03:15, Wayne Stambaugh wrote: > On 2/12/2017 5:15 PM, Bernhard Stegmaier wrote: >> >>> On 12 Feb 2017, at 22:18, Wayne Stambaugh

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-13 Thread Wayne Stambaugh
On 2/12/2017 5:15 PM, Bernhard Stegmaier wrote: > >> On 12 Feb 2017, at 22:18, Wayne Stambaugh wrote: >> >> On 2/12/2017 5:37 AM, Simon Wells wrote: >>> i am stuck on the below as i do not understand whats trying to be >>> achieved doing this >>> >>> # For phase 1, copy

Re: [Kicad-developers] [PATCH] Prevent segfault when aOutline has no vertices.

2017-02-13 Thread Wayne Stambaugh
Please fix you coding policy violations so this patch can be merged. On 2/13/2017 6:30 AM, hauptmech wrote: > When attempting to read a pcad file exported from Altium, kicad was > segfaulting because it was trying to access an empty array. This patch > fixes that. > > The reason the array was

[Kicad-developers] [PATCH] Prevent segfault when aOutline has no vertices.

2017-02-13 Thread hauptmech
When attempting to read a pcad file exported from Altium, kicad was segfaulting because it was trying to access an empty array. This patch fixes that. The reason the array was empty was the the board outline in the pcad file was composed of only arcs and the plugin only processes lines in

Re: [Kicad-developers] .SWEET file suggestion

2017-02-13 Thread Clemens Koller
Hi! Just some cents from my side - hopefully not OT: - Add some draw scaling factor (i.e. 0.1 .. 10) to the schematic pages. It happens to me regularly that I am drawing on A3 size paper to get more schematic real-estate and then print it to A4. My tool is missing scaling... and I am not

Re: [Kicad-developers] .SWEET file suggestion

2017-02-13 Thread Oliver Walters
Here is a good example of where such a feature would be very well received: https://forum.kicad.info/t/component-occupies-entire-page-newbie/5272/22 On Thu, Jan 5, 2017 at 12:10 AM, Chris Pavlina wrote: > I second this suggestion. Numerous people have been proposing

Re: [Kicad-developers] Differential pair DRC Errors

2017-02-13 Thread Clemens Koller
Hello! If the global minimum mandatory clearance/spacing (pitch) of a design (due to manufacturing limitations) is set (& activated) it should complain when some other settings are violating that. It could be assisting if the user gets a clear warning when the differential pair dimensions

Re: [Kicad-developers] {PATCH] Icon tweaks

2017-02-13 Thread Fabrizio Tappero
thanks a lot John, this is certainly a step up! cheers Fabrizio On Sun, Feb 12, 2017 at 6:54 PM, John Beard wrote: > Hi Fabrizio, > > The changes are on the tip of this branch: > > https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/icons > > I have