Re: [Kicad-developers] DRC Markers and dirty bit

[Jeff Young]

Interestingly there was already a createUndoRecord flag, which only the marker 
code passes false for.  I considered leaning on that,  but it just smelled too 
much like a side-effect, so I added a second flag.

> On 9 Apr 2018, at 17:29, Wayne Stambaugh  wrote:
> 
> I agree that the modify status of the board should not change if the
> marker objects are not saved to the board file.  I'm not sure what the
> best solution would be but your suggestion is one possible solution.  It
> might be easier to check if the modify state is cleared before adding
> the DRC Markers and then clearing afterwards.  I can't think of any
> other board objects where this case would apply.  Modifying
> BOARD_COMMIT::push() may be more work than necessary.
> 
> On 4/6/2018 5:47 AM, Jeff Young wrote:
>> Adding a DRC Marker sets the file’s dirty bit.  Yet we don’t save these in 
>> the file, do we?
>> 
>> Maybe we need a flag to BOARD_COMMIT::push() which says whether or not to 
>> call OnModify()?
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New Footprint libs and wizard issues

[Jeff Young]

I looked at the commit and I’m starting to remember why I didn’t: there’s also 
a bug in wxWidgets where if you start typing into a grid cell it will open the 
editor, but the first keystroke never goes through the validator.  So I fixed 
that too, but between that one and the issue commented in the code you already 
saw (where the Mac version looks at the original character rather than the one 
in the event) left me feeling a little uneasy about 5.0.

> On 9 Apr 2018, at 17:12, jp charras  wrote:
> 
> Le 09/04/2018 à 18:03, Jeff Young a écrit :
>> FWIW, this is already fixed in 6.0.  See the last routine in this file:
>> 
>> https://git.launchpad.net/~jeyjey/kicad/tree/common/validators.cpp?h=6.0
>> 
> 
> Perhaps you could commit this fix to the current V5.
> It does not look like risky.
> 
> 
> -- 
> Jean-Pierre CHARRAS
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] DRC Markers and dirty bit

[Wayne Stambaugh]

I agree that the modify status of the board should not change if the
marker objects are not saved to the board file.  I'm not sure what the
best solution would be but your suggestion is one possible solution.  It
might be easier to check if the modify state is cleared before adding
the DRC Markers and then clearing afterwards.  I can't think of any
other board objects where this case would apply.  Modifying
BOARD_COMMIT::push() may be more work than necessary.

On 4/6/2018 5:47 AM, Jeff Young wrote:
> Adding a DRC Marker sets the file’s dirty bit.  Yet we don’t save these in 
> the file, do we?
> 
> Maybe we need a flag to BOARD_COMMIT::push() which says whether or not to 
> call OnModify()?
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New Footprint libs and wizard issues

[jp charras]

Le 09/04/2018 à 18:03, Jeff Young a écrit :
> FWIW, this is already fixed in 6.0.  See the last routine in this file:
> 
> https://git.launchpad.net/~jeyjey/kicad/tree/common/validators.cpp?h=6.0
> 

Perhaps you could commit this fix to the current V5.
It does not look like risky.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New Footprint libs and wizard issues

[Jeff Young]

FWIW, this is already fixed in 6.0.  See the last routine in this file:

https://git.launchpad.net/~jeyjey/kicad/tree/common/validators.cpp?h=6.0

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New Footprint libs and wizard issues

[Kevin Cozens]

On 2018-04-09 10:21 AM, jp charras wrote:

It has an issue: if I try to enter a lowercase char, it is converted to the 
corresponding uppercase
char (as expected), but the cursor moves to the beginning of the text after the 
char is inserted.


The simplest solution is to do the conversion from lowercase letters to 
uppercase after the input field loses focus.


--
Cheers!

Kevin.

http://www.ve3syb.ca/| "Nerds make the shiny things that
https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
 | that's why we're powerful"
Owner of Elecraft K2 #2172   |
#include   | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New Footprint libs and wizard issues

[Kevin Cozens]

On 2018-04-07 06:42 PM, kristoffer Ödmark wrote:

Agreed, hereis a patch for that :)

- Kristoffer

On 2018-04-06 17:18, Kevin Cozens wrote:

[snip]
I added MYSYSMOD as a custom path ages ago. What I find odd about the 
dialog boxes that let you add paths is that they won't accept lower case 


Thanks for the patch, kristoffer. I haven't tested it yet. I did notice a 
couple of things when I had a look at the patch file. In one comment you had 
the word "lovercase" instead of "lowercase". The other is about code style. 
I don't know what the code style is for KiCad but it appears to me that you 
used tabs when indenting lines where the rest of the code is using spaces.


--
Cheers!

Kevin.

http://www.ve3syb.ca/| "Nerds make the shiny things that
https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
 | that's why we're powerful"
Owner of Elecraft K2 #2172   |
#include   | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

[Jeff Young]

Hi Thomas,

It’s a bit of a mess.  The 3D viewer isn’t a separate application, and so 
shouldn’t really have its own menus at all, and certainly not a File menu.  But 
for 5.0, it is what it is, and we need somewhere to put the other two export 
options.

Eeschema is different because it is (sort of) an Application, and its Export to 
Clipboard exports the document instead of the selection (the later being the 
normal Copy action).

So I’d still say Edit menu, but I agree that it’s not clear-cut.

Cheers,
Jeff.


> On 9 Apr 2018, at 13:31, Thomas Pointhuber  wrote:
> 
> Hi Jeff,
> 
> I would still place the clipboard option into the file menu. Preferably
> below the Export Entry because it would be more logical to find. The
> current location of the clipboard item is because Eeschema also located
> this menu item in the exports menu and I simpily tried for consistency.
> 
> Regards, Thomas
> 
> 
> Am 2018-04-06 um 16:12 schrieb Jeff Young:
>> Hi Thomas,
>> 
>> I don’t think I’d nest the two export options just for the sake of 
>> consistency.  Nested menus are harder to use, and should only be resorted to 
>> when necessary (either when room on the menu is an issue, or when 
>> progressive disclosure is desired).
>> 
>> Copy 3D Image goes to the clipboard, and therefore must stay on the Edit 
>> menu (although it could be shortened to just Copy).
>> 
>> The Preferences & View menu stuff looks good.  I agree that we should get 
>> rid of all the menu options that are in the Display Options dialog.
>> 
>> Cheers,
>> Jeff.
>> 
>> 
>>> On 4 Apr 2018, at 13:34, Thomas Pointhuber  wrote:
>>> 
>>> Hi,
>>> 
>>> some time ago there were adjustments to have a common design of the
>>> menubar in all applications. This initial patch does some basic
>>> adjustions of the 3D-Viewer in this direction, but things like
>>> displaying Hotkeys was not added.
>>> 
>>> 
>>> One question regarding improvements based on that patch would be:
>>> 
>>> There exists now a "Display Options" Dialog. In my point of view this
>>> would allow us to remove quite a few submenus. What do you think about
>>> that? Currently you need to cause a resize event to get the view updated
>>> (https://bugs.launchpad.net/kicad/+bug/1612419), which means using the
>>> Dialog requires the same number of events for an action and thus the
>>> submenu does not even provide better efficiency.
>>> 
>>> 
>>> Patch can also be found on GitHub:
>>> https://github.com/pointhi/kicad-source-mirror/tree/3d_viewer_menu
>>> 
>>> 
>>> Regards, Thomas
>>> 
>>> <0001-Adjust-Menubar-of-3D-Viewer-to-common-style.patch>___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
> 
> 


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New Footprint libs and wizard issues

[Kristoffer Ödmark]

Thank you JP!

I will have a look when I get home, It was not happening on linux, and I 
do not currently have a windows computer anywhere, but maybe I can force 
the cursor to the end some other way.


 -Kristoffer

On 2018-04-09 16:21, jp charras wrote:

Le 08/04/2018 à 00:42, kristoffer Ödmark a écrit :

Agreed, hereis a patch for that :)


Hi kristoffer,
I tested your patch (about lowercase) on W7.

It has an issue: if I try to enter a lowercase char, it is converted to the 
corresponding uppercase
char (as expected), but the cursor moves to the beginning of the text after the 
char is inserted.



- Kristoffer

On 2018-04-06 17:18, Kevin Cozens wrote:

On 2018-04-06 06:30 AM, kristoffer Ödmark wrote:

Attached is a patch that adds support for custom environment paths. Previously 
the wizard would
only accept KISYSMOD, KIPRJMOD and the github one.


I added MYSYSMOD as a custom path ages ago. What I find odd about the dialog 
boxes that let you
add paths is that they won't accept lower case letters in the name of the 
environment variable. If
you type a lowercase letter nothing happens on the screen. If it doesn't want 
lowercase it should
force what you entered to uppercase when you are done entering the variable 
name.






___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New Footprint libs and wizard issues

[jp charras]

Le 08/04/2018 à 00:42, kristoffer Ödmark a écrit :
> Agreed, hereis a patch for that :)

Hi kristoffer,
I tested your patch (about lowercase) on W7.

It has an issue: if I try to enter a lowercase char, it is converted to the 
corresponding uppercase
char (as expected), but the cursor moves to the beginning of the text after the 
char is inserted.

> 
> - Kristoffer
> 
> On 2018-04-06 17:18, Kevin Cozens wrote:
>> On 2018-04-06 06:30 AM, kristoffer Ödmark wrote:
>>> Attached is a patch that adds support for custom environment paths. 
>>> Previously the wizard would
>>> only accept KISYSMOD, KIPRJMOD and the github one.
>>
>> I added MYSYSMOD as a custom path ages ago. What I find odd about the dialog 
>> boxes that let you
>> add paths is that they won't accept lower case letters in the name of the 
>> environment variable. If
>> you type a lowercase letter nothing happens on the screen. If it doesn't 
>> want lowercase it should
>> force what you entered to uppercase when you are done entering the variable 
>> name.
>>


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] New Footprint libs and wizard issues

[Kristoffer Ödmark]

I know its not the most elegant solution, but it is actually quite 
convenient. Just checking so that this tiny improvement isnt lost :)


 -Kristoffer

On 2018-04-08 00:42, kristoffer Ödmark wrote:

Agreed, hereis a patch for that :)

- Kristoffer

On 2018-04-06 17:18, Kevin Cozens wrote:

On 2018-04-06 06:30 AM, kristoffer Ödmark wrote:
Attached is a patch that adds support for custom environment paths. 
Previously the wizard would only accept KISYSMOD, KIPRJMOD and the 
github one.


I added MYSYSMOD as a custom path ages ago. What I find odd about the 
dialog boxes that let you add paths is that they won't accept lower 
case letters in the name of the environment variable. If you type a 
lowercase letter nothing happens on the screen. If it doesn't want 
lowercase it should force what you entered to uppercase when you are 
done entering the variable name.






___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

[Thomas Pointhuber]

Hi Jeff,

I would still place the clipboard option into the file menu. Preferably
below the Export Entry because it would be more logical to find. The
current location of the clipboard item is because Eeschema also located
this menu item in the exports menu and I simpily tried for consistency.

Regards, Thomas


Am 2018-04-06 um 16:12 schrieb Jeff Young:
> Hi Thomas,
>
> I don’t think I’d nest the two export options just for the sake of 
> consistency.  Nested menus are harder to use, and should only be resorted to 
> when necessary (either when room on the menu is an issue, or when progressive 
> disclosure is desired).
>
> Copy 3D Image goes to the clipboard, and therefore must stay on the Edit menu 
> (although it could be shortened to just Copy).
>
> The Preferences & View menu stuff looks good.  I agree that we should get rid 
> of all the menu options that are in the Display Options dialog.
>
> Cheers,
> Jeff.
>
>
>> On 4 Apr 2018, at 13:34, Thomas Pointhuber  wrote:
>>
>> Hi,
>>
>> some time ago there were adjustments to have a common design of the
>> menubar in all applications. This initial patch does some basic
>> adjustions of the 3D-Viewer in this direction, but things like
>> displaying Hotkeys was not added.
>>
>>
>> One question regarding improvements based on that patch would be:
>>
>> There exists now a "Display Options" Dialog. In my point of view this
>> would allow us to remove quite a few submenus. What do you think about
>> that? Currently you need to cause a resize event to get the view updated
>> (https://bugs.launchpad.net/kicad/+bug/1612419), which means using the
>> Dialog requires the same number of events for an action and thus the
>> submenu does not even provide better efficiency.
>>
>>
>> Patch can also be found on GitHub:
>> https://github.com/pointhi/kicad-source-mirror/tree/3d_viewer_menu
>>
>>
>> Regards, Thomas
>>
>> <0001-Adjust-Menubar-of-3D-Viewer-to-common-style.patch>___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp




signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Changes to router

[Tomasz Wlostowski]

On 09/04/18 12:56, Jeff Young wrote:
> I just merged two changes to the router
> for https://bugs.launchpad.net/kicad/+bug/1737349 and 
> https://bugs.launchpad.net/kicad/+bug/1548129.
>  If someone familiar with that code (esp Tom) gets a chance to review
> them that would be great.
> 
Hi Jeff,

The patches look OK to me. Thanks for fixing this!

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Changes to router

[Jeff Young]

I just merged two changes to the router for 
https://bugs.launchpad.net/kicad/+bug/1737349 
 and 
https://bugs.launchpad.net/kicad/+bug/1548129 
.  If someone familiar with that 
code (esp Tom) gets a chance to review them that would be great.

Cheers,
Jeff.___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp