Re: [Kicad-developers] [PATCH] Fix MacOS coroutine segfault

2017-02-23 Thread Maciej Sumiński
Hi Chris, Would you give more details about the problem? Boost version, backtrace? Regards, Orson On 02/23/2017 02:23 AM, Chris Pavlina wrote: > Hi, > > pcbnew is segfaulting on launch on my MacOS Sierra build, due to a null > dereference in the coroutine code: > > coroutine.h > 408static

Re: [Kicad-developers] [PATCH] Change reporter message of footprint missmatch to warning on netlist-import

2017-02-23 Thread Maciej Sumiński
Hi Marco, Good catch, I have just committed your patch. Thank you for your contribution. Regards, Orson On 02/22/2017 02:30 PM, Marco Sterbik wrote: > Hi, > > this patch just fixes a small thing that may irritate beginners to the > program (at least in a recent training some people were a bit c

Re: [Kicad-developers] [PATCH] Fix grid sizes in GAL modedit

2017-02-23 Thread Maciej Sumiński
Thank you John, your patch has just been committed. Cheers, Orson On 02/23/2017 03:15 PM, John Beard wrote: > Hi, > > The COMMON_TOOLS GAL tool wasn't registered in modedit, so the grid > setting didn't work. > > Here's a patch. This fixes lp:1667264, possibly the tersest bug report > ever, wit

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-24 Thread Maciej Sumiński
e know if this looks better. > > Best, > Jon > > On Thu, Feb 23, 2017 at 4:17 AM, Maciej Sumiński > wrote: > >> Hi Jon, >> >> I really like the generic approach in the zoom methods. This part I >> would merge instantly, but there is an issue with cac

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-24 Thread Maciej Sumiński
The previous mail had incorrect patch, please check this one. On 02/24/2017 10:16 AM, Maciej Sumiński wrote: > Hi Jon, > > The current version looks much better to me. From what I see there is no > actual bounding box caching, as GetBoundingBox() always calls > ComputeBoundingB

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-24 Thread Maciej Sumiński
things like BOARD. >> >> If there is no good way to implement caching, I guess another way would >> be to implement caching at the sites that use the BOARD bounding box >> heavily (autorouter etc) >> >> -Jon >> >> On Fri, Feb 24, 2017 at 9:22 AM, Wayne Stamb

Re: [Kicad-developers] [PATCH] Add cancel interactive tool to GAL

2017-02-24 Thread Maciej Sumiński
Hi John, I am really happy to see that your patching spree has not stopped. I have just committed your patch. Thank you for adding missing GAL features. Cheers, Orson On 02/24/2017 06:18 AM, John Beard wrote: > Hi, > > This adds a new action to the common ACTIONS tools: cancelInteractive. > >

Re: [Kicad-developers] [PATCH] Draw zone hatching in GAL

2017-02-27 Thread Maciej Sumiński
Hi John, Thank you for the patch, I have just merged it. Cheers, Orson On 02/26/2017 09:11 AM, John Beard wrote: > Hi, > > Here's a patch to draw the zone hatching in GAL. > > The hatching is already contained within the ZONE_CONTAINER objects, > so this patch just regenerates the hatching at

Re: [Kicad-developers] [PATCH] Undo/redo points for zone fill actions (GAL)

2017-02-27 Thread Maciej Sumiński
Hi, This one has been merged too, thank you once again. Cheers, Orson On 02/26/2017 06:40 PM, John Beard wrote: > Hi, > > Sorry, that patch had a dependency on a previous commit in my patch stack. > > Here's an updated one. PCB_EDITOR_CONTROL now inherits PCB_TOOL, not > TOOL_INTERACTIVE, so i

Re: [Kicad-developers] Change behaviour of selectCopper and selectNet feature

2017-02-27 Thread Maciej Sumiński
Hi Thomas, I see your point, but before we merge your patch, we need to address the other problem first. I would like to see a bug report, but I guess this behavior is hard to trigger without applying your patch first. BTW. are the rendering glitches visible in the linked video occurring in KiCad

Re: [Kicad-developers] New addition to the lead developer team.

2017-02-28 Thread Maciej Sumiński
Great! KiCad demands high quality work force, congratulations Tom! Cheers, Orson On 02/27/2017 10:52 PM, Wayne Stambaugh wrote: > I have just given product and stable branch commit privileges to Tomasz > Wlostowski. Please join me in congratulating him for his promotion to > the lead development

[Kicad-developers] SCH_LEGACY_PLUGIN buffering

2017-02-28 Thread Maciej Sumiński
Hi Wayne, Would you have a look at the attached patches? I do not want to introduce changes to the schematic plugins code without your approval. The first one removes multiple chunks of code that regenerate properties basing on the PART_LIB field values. Instead, a PROPERTIES object is maintained

Re: [Kicad-developers] SCH_LEGACY_PLUGIN buffering

2017-02-28 Thread Maciej Sumiński
One more patch to make the change complete. On 02/28/2017 10:37 AM, Maciej Sumiński wrote: > Hi Wayne, > > Would you have a look at the attached patches? I do not want to > introduce changes to the schematic plugins code without your approval. > > The first one removes multi

Re: [Kicad-developers] SCH_LEGACY_PLUGIN buffering

2017-02-28 Thread Maciej Sumiński
On 02/28/2017 03:01 PM, Wayne Stambaugh wrote: > On 2/28/2017 4:37 AM, Maciej Sumiński wrote: >> Hi Wayne, >> >> Would you have a look at the attached patches? I do not want to >> introduce changes to the schematic plugins code without your approval. >> >> T

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-28 Thread Maciej Sumiński
prove performance for >> some edge case operations (i.e. "zoom to fit screen" would be instantaneous >> if nothing has modified the board since the last time the bbox was cached, >> even on large boards) >> >> -Jon >> >> On Fri, Feb 24, 2017 at 11:

Re: [Kicad-developers] [PATCH] Fix zoom controls in footprint viewer

2017-03-01 Thread Maciej Sumiński
Thank you Jon, I have just pushed your patch. Regards, Orson On 03/01/2017 03:59 AM, Jon Evans wrote: > This got overlooked in common_tools refactor > > -Jon > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-d

Re: [Kicad-developers] [PATCH] Fix layer color swatches in Linux

2017-03-01 Thread Maciej Sumiński
Hi John, Thank you for the patches. I have tested them on Linux and Windows, and everything works as expected. I think the layer widget looks even better now, good job! Cheers, Orson On 03/01/2017 01:11 AM, John Beard wrote: > Hi Wayne, > > On Wed, Mar 1, 2017 at 2:06 AM, Wayne Stambaugh wrote

Re: [Kicad-developers] SCH_LEGACY_PLUGIN buffering

2017-03-01 Thread Maciej Sumiński
On 02/28/2017 05:20 PM, Wayne Stambaugh wrote: [snip] Regarding the second patch: I am looking for a way to store temporary changes to libraries. Libraries are linked to files, and now the binding is even stronger, as files are reloaded upon a change [1]. It means that once

Re: [Kicad-developers] [PATCH] eeschema pspice netlist exporter alternative list.

2017-03-01 Thread Maciej Sumiński
Hi Martin, I am sorry it has taken me so long to respond. Your patch looks reasonable, so I have just pushed it. Thank you for your contribution. Regards, Orson On 02/22/2017 03:24 AM, Martin Stoilov wrote: > Hello all, > > Ngspice requires four nodes for a MOSFET component - nd ng ns nb, but >

Re: [Kicad-developers] [PATCH] Fix MacOS coroutine segfault

2017-03-01 Thread Maciej Sumiński
bug/1658249 >> >> On 24 February 2017 at 00:38, Chris Pavlina wrote: >>> Backtrace attached. Boost is 1.63.0. >>> >>> On Thu, Feb 23, 2017 at 11:36:02AM +0100, Maciej Sumiński wrote: >>>> Hi Chris, >>>> >>>> Would you giv

Re: [Kicad-developers] [PATCH] Add WithAlpha method to COLOR4D

2017-03-02 Thread Maciej Sumiński
Hi John, Thank you for the patch, I have just committed it. Cheers, Orson On 03/02/2017 06:52 AM, John Beard wrote: > Hi, > > Here's a patch to add a new method to COLOR4D: WithAlpha. This means > you can do this: > > const COLOR4D color = getSomeColor(); //could be an argument or static

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-03-03 Thread Maciej Sumiński
om <mailto:stambau...@gmail.com>> >> > > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com> >> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>>>> wrote: >> > > >> > > O

Re: [Kicad-developers] [PATCH] Make all layers slightly semitransparent as before

2017-03-07 Thread Maciej Sumiński
Hi Jose, Good catch. Thank you for the patch, I have just committed it. Regards, Orson On 03/07/2017 06:59 AM, José Ignacio Romero wrote: > When colors were changed to COLOR4D, the original semi-transparent > colors were lost, making things hard to see in multilayer boards > without hitting { ma

Re: [Kicad-developers] [PATCH] Fix crash when switching from dragging to routine (PNS router)

2017-03-07 Thread Maciej Sumiński
Hi Julius, I apologize it has taken me so long to reply. In fact, your patch made me investigate the problem, as I felt preventing track dragging is a cure for the symptoms, but not for the cause. Recently I have made a few changes to the code, and now PNS should not crash anymore. If this is not

Re: [Kicad-developers] [PATCH] Fix crash when switching from dragging to routine (PNS router)

2017-03-07 Thread Maciej Sumiński
entirely sure which changes you are referring to. > > My patch also does not prevent track dragging, it just breaks the > *routing* coroutine out of its loop, which I would think you have to do > one way or another to avoid this bug. > > On Tue, 7 Mar 2017, Maciej Sumiński

Re: [Kicad-developers] [PATCH] Open polylines in OpenGL GAL

2017-03-07 Thread Maciej Sumiński
Hi John, Thank you for fixing the problem. I have just committed your patch. Cheers, Orson On 03/07/2017 01:11 PM, John Beard wrote: > Hi, > > Attached patch fixes polylines in GAL: they were drawn always closed > in OpenGL and always open in Cairo. > > I think the code could stand a refactor

Re: [Kicad-developers] [PATCH] [RFC] Get rid of boost::context

2017-03-07 Thread Maciej Sumiński
Brief testing with Win7 x86_64 gives positive results. I really hope this is the end of the boost::context nightmare. Cheers, Orson On 03/07/2017 02:36 PM, Tomasz Wlostowski wrote: > Hi, > > The attached patch removes boost::context dependency by introducing a > single-file libcontext that autom

Re: [Kicad-developers] [PATCH] [RFC] Get rid of boost::context

2017-03-07 Thread Maciej Sumiński
017 9:32 AM, Chris Pavlina wrote: >>> How thoroughly? I can build it on macOS and poke around a bit, but I >>> don't have time to spend a day doing layout with it right now. >>> >>> >>> On Tue, Mar 07, 2017 at 09:23:30AM -0500, Wayne Stambaugh wrote: >

Re: [Kicad-developers] [PATCH] [RFC] Get rid of boost::context

2017-03-07 Thread Maciej Sumiński
Thank you Chris, now it should build fine on OSX as well. I really love compilers screaming so much about such minor things. Regards, Orson On 03/07/2017 04:51 PM, Chris Pavlina wrote: > On Tue, Mar 07, 2017 at 04:35:44PM +0100, Maciej Sumiński wrote: >> I use Linux+clang (3.9) and

Re: [Kicad-developers] [PATCH] [RFC] Get rid of boost::context

2017-03-07 Thread Maciej Sumiński
f you look at what std::deque was trying > to do...I don't see any way for the compiler to resolve this with the > implementation of std::deque it was using ;) > > Thanks for the quick fix. > > On Tue, Mar 07, 2017 at 05:24:14PM +0100, Maciej Sumiński wrote: >> Than

Re: [Kicad-developers] [PATCH] Add setting to have GAL draw axes on the grid

2017-03-08 Thread Maciej Sumiński
Hi Jon, Thank you for the patch, I have just pushed it to the master branch. Now it is also used in the module editor, which previously used a ORIGIN_VIEWITEM. Regards, Orson On 03/08/2017 03:34 AM, Jon Evans wrote: > Hi all, > > This patch adds the ability for GAL to draw axes when drawing the

Re: [Kicad-developers] [PATCH] Fix shadowed variable

2017-03-10 Thread Maciej Sumiński
Hi John, Thank you for the patch, I have just merged it. Cheers, Orson On 03/09/2017 08:00 PM, John Beard wrote: > Hi, > > Here's a very simple patch to silence a warning in python_scripting.cpp. > > Cheers, > > John > > > > ___ > Mailing list: h

Re: [Kicad-developers] [PATCH] Add method to GAL for drawing arc segments

2017-03-10 Thread Maciej Sumiński
Hi Jon, Thank you for the patch, I have just pushed it to the master branch. Regards, Orson On 03/09/2017 03:47 AM, Jon Evans wrote: > This new GAL API is needed for drawing outlined arc segments (like > DrawSegment() does for straight segments) because the current API DrawArc() > treats filled

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-10 Thread Maciej Sumiński
Hi John, All I can say is: it looks really cool! I would like to merge, but before I do so, would you consider the attached fixup patch? If so, I simply update the existing set of patches and merge everything. Changes: - Changed std::vector<> to const std::vector<>& in PREVIEW::SetConstantGlyphHe

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-10 Thread Maciej Sumiński
"Measure distance" sounds fine to me. > > Cheers, > > John > > On Fri, Mar 10, 2017 at 9:59 PM, Maciej Sumiński > wrote: >> Hi John, >> >> All I can say is: it looks really cool! I would like to merge, but >> before I do so, would you conside

Re: [Kicad-developers] Fixing libcommon

2017-03-22 Thread Maciej Sumiński
On 03/20/2017 02:36 PM, Wayne Stambaugh wrote: > On 3/18/2017 10:18 AM, Maciej Suminski wrote: >> In order to remove the hardcoded values from WORKSHEET_VIEWITEM, I >> started moving code that used to be compiled multiple times to separate >> units. This is also a basic way to solve the internal un

Re: [Kicad-developers] [PATCH] Allow always-on GAL cursor

2017-03-22 Thread Maciej Sumiński
Hi John, Thank you for fixing the issue. I have just committed your patches, well done! Cheers, Orson On 03/20/2017 04:19 PM, John Beard wrote: > Hi, > > Here's a patch set to allow always-on cursors in GAL, which some > people like for checking alignment and so on. Fixes lp:1673633. > > The n

Re: [Kicad-developers] [PATCH] Angle snap of ruler tool

2017-03-22 Thread Maciej Sumiński
Hi John, Nice, I have just pushed the patch. Thank you for your contribution! Cheers, Orson On 03/20/2017 06:44 PM, John Beard wrote: > HI, > > Here's a small patch building on the two-point geometry manager to > allow use of that manager's angle snapping function. > > This was mentioned as a

Re: [Kicad-developers] [PATCH/RFC] Middle click actions in Pcbnew GAL

2017-03-22 Thread Maciej Sumiński
Hi, I agree clicking with the middle mouse button is not particularly easy but doable. I would not mind assigning a function to the button, but we need choose carefully, since it is likely to stay for a long time. I am sure that changing the behavior later will cause a rage coming from users that

Re: [Kicad-developers] [PATCH] Refactor LAYER_ID to be the one and only layer definition

2017-03-22 Thread Maciej Sumiński
I have briefly tested the patch, no issues found. I have no objections to the changes, but I will leave the final decision to Wayne. Regards, Orson On 03/22/2017 03:51 AM, Jon Evans wrote: > Hi Wayne, new patch attached. > > Thanks, > Jon > > On Tue, Mar 21, 2017 at 9:28 AM, Wayne Stambaugh >

Re: [Kicad-developers] [PATCH] Refill zones after editing properties

2017-03-22 Thread Maciej Sumiński
Hi John, I have just pushed your patch, thank you very much! Cheers, Orson On 03/21/2017 05:30 PM, John Beard wrote: > Hi, > > After editing zone properties in any canvas, the zone is not refilled, > leading to stale display of the zone if a geometric property like the > anti-pad clearance is c

Re: [Kicad-developers] [PATCH] Finish GAL zone tool

2017-03-22 Thread Maciej Sumiński
Hi John, I am very grateful for the patches. It is a well-thought refactor, I like the introduced changes. Your patches have just been committed, thanks again! Cheers, Orson On 03/22/2017 02:05 PM, John Beard wrote: > Hi, > > Here's a patch set to add the final pieces of the GAL zone tool: clos

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

2017-03-23 Thread Maciej Sumiński
Finally I had some time to test the branch and I could not find any problems, hence I would like to merge it. Let me know if there are any objections. @Nick: Could you give more details? I placed keepout zones and refilled zones for all demo boards, and every time I get exactly the same zones (dif

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

2017-03-23 Thread Maciej Sumiński
I have done this already, no worries. Regards, Orson On 03/23/2017 09:26 AM, Alejandro Garcia Montoro wrote: > Do the patches apply cleanly? It is possible that they need a slight rebase > since the latest changes on the GAL zone. > > Let me check it. > > 2017-03-23 9:1

Re: [Kicad-developers] [PATCH] common.h tidyups

2017-03-23 Thread Maciej Sumiński
Hi John, Thank you for the patches. I have committed: 0001 OPENGL_GAL: Init currentTarget 0003 Rework zone creation in GAL (committed yesterday) I had a look at other changes, and they appear to be a sensible common.h clean-up. All patches received the Orson Approves™ badge, but I leave the f

Re: [Kicad-developers] OpenGL fallback and video compat test

2017-03-24 Thread Maciej Sumiński
On 03/24/2017 01:11 AM, Chris Pavlina wrote: > Hi, > > I've been thinking about my intent to make KiCad fall back cleanly to > Cairo when OpenGL isn't available. From what I can see, there are > certain situations where trying to use OpenGL causes crashes that appear > very hard to prevent. > > I

Re: [Kicad-developers] [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

2017-03-24 Thread Maciej Sumiński
/2017 09:19 AM, Maciej Sumiński wrote: > Finally I had some time to test the branch and I could not find any > problems, hence I would like to merge it. Let me know if there are any > objections. > > @Nick: > Could you give more details? I placed keepout zones and refilled zo

Re: [Kicad-developers] [PATCH] Add layer-selecting via actions to GAL

2017-03-28 Thread Maciej Sumiński
Hi John, I confirmed with Tom, and you applied AddLayerPair() correctly. I have just pushed your changes to the repository, thank you for your contribution! Cheers, Orson On 03/22/2017 11:31 PM, John Beard wrote: > Hi, > > These patches add the "Select Layer and Add (Through|Blind) Via" > actio

Re: [Kicad-developers] [PATCH] GAL coverity fixes: uninitialised members

2017-03-30 Thread Maciej Sumiński
Hi John, I have just committed the patch, thank you for the fixes! Cheers, Orson On 03/30/2017 10:20 AM, John Beard wrote: > Hi, > > Quick patch to init some GAL class members. > > I think most (all?) of these would /eventually/ get set correctly in a > way Coverity doesn't see, but it's good

Re: [Kicad-developers] [PATCH] CW/CCW rotation in GAL

2017-03-30 Thread Maciej Sumiński
Hi John, Good catch, I have committed both patches. I guess it has not been noticed, as most people do not really pay attention to rotation direction, it is only up to 3 hotkey presses to get any of the 90* multiples. Anyway, it is surely better to perform what is written on the label. Cheers, O

Re: [Kicad-developers] Symbol library editor UI refactor

2017-03-31 Thread Maciej Sumiński
oval, but it should not be a huge change. What I need now is a few >> brave testers, as I would like to merge the code as soon as I fix the >> problematic commit. >> >> Regards, >> Orson >> >> 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/libe

Re: [Kicad-developers] [PATCH] Ruler tool asserts when mirrored text is visible

2017-03-31 Thread Maciej Sumiński
Hi John, It is quite an elegant solution. I have just pushed your patch, thank you once again. Cheers, Orson On 03/30/2017 10:17 AM, John Beard wrote: > Hi Orson, > > I hit exactly the same thig with the arc assistant, so I made a little > function: GAL::ResetTextAttributes(), next to GAL::SetT

Re: [Kicad-developers] Symbol library editor UI refactor

2017-04-03 Thread Maciej Sumiński
ast moving target, so it has taken me plenty of time >>>>> to rebase the branch. Actually there is a completely new approach >>>>> inside, I hope it will be more robust. >>>>> >>>>> I still need to replace the head commit, as it has n

Re: [Kicad-developers] Symbol library editor UI refactor

2017-04-03 Thread Maciej Sumiński
I still need to replace the head commit, as it has not got Wayne's >>>> approval, but it should not be a huge change. What I need now is a few >>>> brave testers, as I would like to merge the code as soon as I fix the >>>> problematic commit. >>>

Re: [Kicad-developers] Symbol library editor UI refactor

2017-04-03 Thread Maciej Sumiński
Hi Jean-Pierre, Thank you for the remark, I will have a look at the problem. In such case I am not going to push the changes yet. Regards, Orson On 04/03/2017 10:24 AM, jp charras wrote: > Le 03/04/2017 à 09:42, Maciej Sumiński a écrit : >> Hi Wayne, >> >> Does it mean

Re: [Kicad-developers] Bugs in hotkey assignments - cannot differentiate NumPad hotkeys.

2017-04-20 Thread Maciej Sumiński
Hi Clemens, We would really appreciate if bug reports were kept on the bug tracker. I am afraid this report will be lost after a few days of mailing list traffic, unless someone fixes the problem right now. Regards, Orson On 04/19/2017 10:49 PM, Clemens Koller wrote: > Hi, there! > > I am start

Re: [Kicad-developers] Something new and old

2017-04-24 Thread Maciej Sumiński
Hi Heikki, The new connectivity algorithm is now in the testing phase, and is likely to be published/merged very soon and your tools would be a great complement for the algorithm. Could we have a look at your code, even if you think it is not finished yet? Perhaps we could help a bit, if necessary

Re: [Kicad-developers] Simple build fix for OpenSuSE 42.2

2017-05-02 Thread Maciej Sumiński
Hi Mathias, Thank you for the patch, I have just committed it. Regards, Orson On 04/29/2017 09:35 PM, Mathias Grimmberger wrote: > > Hi everybody, > > > Currently KiCad doesn't build on OpenSuSE 42.2 because kicad-ogltest > fails to compile. > > The reason seems to be that wxWidgets was buil

Re: [Kicad-developers] Eagle XML parsing moved to common

2017-05-08 Thread Maciej Sumiński
Hi Alejandro, I am really sorry it has taken me so long to review the patch. I have tested it and it seems to work correctly, so now it is merged. I like the refactor changes, good job! I am also aware of the branch containing initial work on Eagle schematic import, but it has to wait to be more

Re: [Kicad-developers] Eagle XML parsing moved to common

2017-05-08 Thread Maciej Sumiński
which > fixed an issue with free text rotation angles. Did that fixed get > rolled into the eagle common code? > > Cheers, > > Wayne > > On 5/8/2017 5:09 AM, Maciej Sumiński wrote: >> Hi Alejandro, >> >> I am really sorry it has taken me so long to re

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-08 Thread Maciej Sumiński
Hi Oliver, I took your set of patches for a test drive. I am glad that you thought about the subtractive mode in the selection tool, it really fits there. Regarding different selection modes - I like the idea, but I think the two modes should be more distinct, changing the selection direction migh

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-05-08 Thread Maciej Sumiński
Hi Kristoffer, It is a neat feature. Your application is a good application, but I think it would really shine in the footprint editor. Unfortunately, it crashes when I tried to copy and paste a bunch of pads. Could you check it? IMHO it would be better to keep standard Ctrl+C and Ctrl+V hot keys

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-09 Thread Maciej Sumiński
gt; >>>> Is assigning what is essentially the last remaining modifier key worth >>>> it for this? >>>> >>>> On 8 May 2017 23:55, "Nick Østergaard" >>> <mailto:oe.n...@gmail.com>> wrote: >>>> >>>> 20

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-09 Thread Maciej Sumiński
it will still be required that the users adjust to the new >>>>> style, manuals updated, etc. >>>>> >>>>> Is assigning what is essentially the last remaining modifier key worth >>>>> it for this? >>>>> >>>>> On 8 May 201

Re: [Kicad-developers] [FEATURE] Partial selection in pcbnew

2017-05-10 Thread Maciej Sumiński
AD tools where the >>>>> direction of selection is the standard approach. Whatever function is >>>>> chosen, it will still be required that the users adjust to the new >>>>> style, manuals updated, etc. >>>>> >>>>> Is ass

Re: [Kicad-developers] 3D Mouse (Spacenavigator) support

2017-05-16 Thread Maciej Sumiński
Hi Jost, I think support for the SpaceNavigator would be welcome, but the final decision belongs to Wayne. If you decide to develop support for the SpaceNavigator, please do not make spacenav library a dependency for KiCad. Regards, Orson On 05/15/2017 07:10 PM, mrkenhoff wrote: > Hello everyone

Re: [Kicad-developers] [PATCH] Speed improvement for Duplicate functionality

2017-06-12 Thread Maciej Sumiński
Hi Oliver, I apologize for late answer, I was away from keyboard for the last 3 weeks and now I am crawling through my mailbox. Well done, your changes resolve the issue correctly, so thank you for investigating the problem. I have just committed the patch with some minor changes (removed doxygen

Re: [Kicad-developers] Better organizing of Python plugins using subdirectories

2017-06-12 Thread Maciej Sumiński
Speaking of Python scripts path - I wonder whether we should move it to $XDG_DATA_HOME/kicad/plugins, as we already try to conform to XDG base directory specification for configuration files. I suppose we would have to keep ~/.kicad_plugins path during the transition process or automatically move

Re: [Kicad-developers] [Feature] Position Relative to

2017-06-12 Thread Maciej Sumiński
Hi Russell, I am sorry for such long delay. I have finally got to review your patch and I pushed it with another commit containing minor fixes. Thank you for your contribution to KiCad. Regards, Orson On 06/02/2017 02:50 PM, Russell Oliver wrote: > Hi All, > > Just wondering if anyone else has

Re: [Kicad-developers] latest news on v5?

2017-06-12 Thread Maciej Sumiński
Hi Kristoffer, I am sure bug fixes would be more than welcome. We still have a thing or two to finish, then we will switch to feature freeze when we focus on patching bugs. The less problems to amend, the sooner we will have a new release. Regards, Orson On 06/05/2017 01:28 PM, Kristoffer Ödmark

Re: [Kicad-developers] [PATCH] Speed improvement for Duplicate functionality

2017-06-13 Thread Maciej Sumiński
ver Walters wrote: > Thanks Maciej, > > Any guess as to why the SELECT / UNSELECT of multiple objects takes a very > long time? I was unable to solve this problem. > > Cheers, > > Oliver > > On Mon, Jun 12, 2017 at 7:29 PM, Maciej Sumiński > wrote: > >> Hi

Re: [Kicad-developers] Proposal to change "Copy" to "Duplicate"

2017-06-15 Thread Maciej Sumiński
Hi Fabrizio, I am also in favor of the proposed change. This is a better description for the action and it is consistent with pcbnew duplicate operation. Regards, Orson On 06/15/2017 10:17 AM, Fabrizio Tappero wrote: > hello, > inside the schematic editor, this is the right click menu when a gro

Re: [Kicad-developers] [RFC] new connectivity algorithm - testers needed

2017-06-23 Thread Maciej Sumiński
Hi, After a long testing period, it is time to commit the new connectivity algorithm. We have neither received any new bug reports, nor we could find any defects ourselves. Effectively it means: - long awaited stitching vias are at your service - ratsnest calculations should be much faster - rats

Re: [Kicad-developers] Pcbnew Python Interface breakage?

2017-06-26 Thread Maciej Sumiński
Hi Maurice, This is due to the recent commit that enables iterators for DLISTs. We have forgotten that such change impacts the Python interface. I propose to keep the old interface, otherwise we will face many reports when a script works correctly with the stable release, but not with nightlies.

Re: [Kicad-developers] Pcbnew Python Interface breakage?

2017-06-26 Thread Maciej Sumiński
ff --git a/pcbnew/swig/module.i b/pcbnew/swig/module.i > correct? > > I see there is a block comment before @line 45 > /* > %extend MODULE > ... > > Applying the patch I cannot make any plugins running > but if I de-comment that block it works... > > > Thx > Mau

Re: [Kicad-developers] Pcbnew Python Interface breakage?

2017-06-26 Thread Maciej Sumiński
rototypes are: > PLUGIN::FootprintEnumerate(wxArrayString &,wxString const > &,PROPERTIES const *) > > PLUGIN::FootprintEnumerate(wxArrayString &,wxString const &) > > ​ > > On 26 June 2017 at 17:30, Maciej Sumiński wrote: > >> Great, thank you both

Re: [Kicad-developers] Hard-coded hotkeys in pcbnew/tools/selection_tool.cpp

2017-06-27 Thread Maciej Sumiński
Hi hauptmech, I agree this has to be fixed, yet I doubt it is located on someone's list. If noone steps in, then most likely I will do it at one point in the future. Regards, Orson On 06/27/2017 01:29 PM, hauptmech wrote: > @Jon Evans maybe, > > I spent an embarrasing amount of time trying to a

Re: [Kicad-developers] Pcbnew Python Interface breakage?

2017-06-27 Thread Maciej Sumiński
On 06/27/2017 04:49 PM, Kaspar Emanuel wrote: > On 27 June 2017 at 07:56, Maciej Sumiński wrote: > > PLUGIN::FootprintEnumerate() signature has changed [1] and now instead >> of returning wxArrayString, it takes one as a reference and fills it out. >> > Thanks Orson, lo

Re: [Kicad-developers] [RFC] 3D models repository

2017-06-30 Thread Maciej Sumiński
Hi Wayne, Why do you say the parser would choke on the license comment? I have a lot of parts with the license text put in the 'License' field and they seem to work correctly. Cheers, Orson On 06/28/2017 04:42 PM, Wayne Stambaugh wrote: > Javier, > > Thank you for the clarification. Adding the

Re: [Kicad-developers] [PATCH] Remove hardcoded hotkeys that have a context menu to fall back on.

2017-06-30 Thread Maciej Sumiński
Hi hauptmech, Thank you for the patch. I have committed the part where you enable custom hotkeys for the select actions, and I did the same for the router actions (instead of disabling them). Regards, Orson On 06/30/2017 10:19 AM, hauptmech wrote: > Fixed blocked Lock/Unlock hotkey. > Add hotkey

Re: [Kicad-developers] Copy/Paste/Cut defaults to ctrl + c, v, x as most other software.

2017-07-03 Thread Maciej Sumiński
Hi Kristoffer, Thank you very much, I have just pushed your patch. I was really close to implementing it myself, so I am glad you have done it. Other related changes I would like to introduce (open for discussion): - Proper naming for copy/duplicate operation (addressed by Fabrizio's patch, I wi

Re: [Kicad-developers] Copy/Paste/Cut defaults to ctrl + c, v, x as most other software.

2017-07-03 Thread Maciej Sumiński
is one. I would it really appreciate if you could > apply my patch including Weyne comments. Please mind that the same > patch includes some copy icon fixes too. > > Cheers > Fabrizio > > > On Mon, Jul 3, 2017 at 4:51 PM, Maciej Sumiński > wrote: >> Hi Kristoffe

Re: [Kicad-developers] [PATCH] renamed eeschema right click menu "copy" into "duplicate" and some more

2017-07-03 Thread Maciej Sumiński
For the record, the patch is merged. I kept the old hot key for duplication (as requested), but if I were to decide - I would go for CTRL+D. Alternatively, I would change pcbnew to use C for duplicate, just make the hot keys coherent. Cheers, Orson On 06/23/2017 08:00 PM, Wayne Stambaugh wrote: >

Re: [Kicad-developers] [PATCH] Avoid an infinite loop in PNS

2017-07-10 Thread Maciej Sumiński
Hi Jean-Samuel, Just for the record: your patch has been merged. Thank you very much for fixing the bug. Regards, Orson On 07/06/2017 10:47 AM, Jean-Samuel Reynaud wrote: > Hi All, > > Following bug 1702485, please find attached a patch to fix this infinite > loop. > > Bug report containt all

Re: [Kicad-developers] Improving SCM behaviour of kicad_pcb

2017-07-10 Thread Maciej Sumiński
I think there is a lot of code that assumes consecutive net numbering. Instead, we could simply save net names instead of net numbers and let KiCad use net codes as convenient. One significant problem is it would cause the .kicad_pcb file format change, making it completely unreadable by the curren

Re: [Kicad-developers] [PATCH] More aggressive sheet-selection

2017-07-12 Thread Maciej Sumiński
Hi Kristoffer, I apologize for such a long delay. Finally I had to time to look at the patch. I tried it out with a few boards, but I could not really notice a difference. I read the code and I think I understand what are you trying to do, but are you sure it is the right way to go? Hierarchical s

Re: [Kicad-developers] LOCALE_IO sucks

2017-07-18 Thread Maciej Sumiński
Hi Chris, If your main goal is to reduce the time required to load the libraries (awesome!) then keep in mind the I/O benchmarks [1] executed by John Beard some time ago. Cheers, Orson 1. https://lists.launchpad.net/kicad-developers/msg27899.html On 07/18/2017 03:47 PM, Chris Pavlina wrote: > Y

Re: [Kicad-developers] [RFC] New color selector for GAL canvas, and more easy support of opacity.

2017-07-19 Thread Maciej Sumiński
Hi Jean-Pierre, Thank you, the new color picker looks very nice. I noticed is there is a typo in the right sizer ('RGB Values' vs 'HS Values'), and I am getting an assert when opening the dialog. Both problems are fixed in the attached patch. I do not want to be a complainer, but I would consider

Re: [Kicad-developers] [RFC] New color selector for GAL canvas, and more easy support of opacity.

2017-07-19 Thread Maciej Sumiński
Hi Gaurav, We currently do, but there is no way to set opacity using the standard wxWidgets dialog. Regards, Orson On 07/19/2017 10:21 AM, Gaurav Juvekar wrote: > Hi all, > > I haven't actually seen how it looks, but can't we use > http://docs.wxwidgets.org/3.1/classwx_colour_dialog.html direc

Re: [Kicad-developers] [PATCH] Partial selection for VIA class

2017-07-19 Thread Maciej Sumiński
Hi Oliver, Thank you for the patch, I have just committed your changes. Regards, Orson On 07/03/2017 12:38 PM, Oliver Walters wrote: > In line with my previous work on partial object selection, I have attached > a small patch for partial selection on VIA object. > > Regards, > Oliver > > > >

Re: [Kicad-developers] [patch] move exactly tool refactoring

2017-07-19 Thread Maciej Sumiński
Hi Robert, I have just committed your patch with some minor changes on top. Thank you for your contribution to KiCad. Regards, Orson On 06/22/2017 10:22 PM, Robbert Lagerweij wrote: > Hi all, > > > While writing the documentation for the new origin selection feature in the > move exactly tool

Re: [Kicad-developers] [RFC] New color selector for GAL canvas, and more easy support of opacity.

2017-07-19 Thread Maciej Sumiński
Hi Jean-Pierre, On 07/19/2017 11:41 AM, jp charras wrote: [snip] > I committed you patch and added a few minor refinements in dialog. > One can now select a color by clicking on the HS map. Thank you for implementing it so quickly, it works great! > About the vertical 'Value' slider versus spin

Re: [Kicad-developers] Cursor behavior (was: Via tool in Pcbnew.)

2017-07-20 Thread Maciej Sumiński
Hi Lorenzo, On 07/20/2017 12:04 PM, Lorenzo Marcantonio wrote: [snip] > However before junking it *please* implement everything on the new one > (like the cursor behaviour which is way more useful to measure than the > new tool in the GAL view) What do you exactly mean regarding the cursor behavi

Re: [Kicad-developers] Cursor behavior

2017-07-20 Thread Maciej Sumiński
On 07/20/2017 12:37 PM, Lorenzo Marcantonio wrote: > On Thu, Jul 20, 2017 at 12:14:40PM +0200, Maciej Sumiński wrote: >> What do you exactly mean regarding the cursor behavior? > > For example the cursor moving on the grid and using space to take > measurement is way faster. AFA

Re: [Kicad-developers] Via tool in Pcbnew.

2017-07-20 Thread Maciej Sumiński
Hi hauptmech, On 07/20/2017 12:31 PM, hauptmech wrote: > > I'm with Heikki. I've been using the GAL canvas for a complex project. I > don't really have time to learn the nuances of the interactive router; I > found that highlight collisions kept it from doing stuff I did not want > in tight layou

Re: [Kicad-developers] Cursor behavior

2017-07-20 Thread Maciej Sumiński
Hi Jean-Pierre, On 07/20/2017 01:44 PM, jp charras wrote: [snip] > > AFAIK, for me "old" issues related to the cursor and grid are fixed. > > AFAIK, when moving a single footprint, the anchor point is either one of its > pads or the footprint origin, the nearest candidate point from mouse cursor

Re: [Kicad-developers] Generating the _xpm files uside by icons in eeschema.

2017-07-24 Thread Maciej Sumiński
Hi Kristoffer, You need to add entries to bitmaps_png/CMakeLists.txt and include/bitmaps.h. After that you need to build KiCad with a Cmake option -DMAINTAIN_PNGS=ON. You will need Inkscape for file format conversion. Regards, Orson On 07/24/2017 09:40 PM, Kristoffer Ödmark wrote: > Hello! > >

Re: [Kicad-developers] Speed improvements for SELECT / DESELECT in GAL

2017-07-25 Thread Maciej Sumiński
Hi Oliver, Thank you very much, I have just pushed your patch. Cheers, Orson On 07/24/2017 04:25 PM, Oliver Walters wrote: > When I was working on speed improvements for DUPLICATE action in GAL, I > also discovered that the select / deselect functions were very slow. > > Ref: https://lists.laun

Re: [Kicad-developers] Netclass and clearance

2017-07-26 Thread Maciej Sumiński
Hi hauptmech, I am sure there are many users who would benefit from the suggested DRC improvements, so I would say it is an interesting idea. There is a plan to upgrade it, but I am afraid you will have you board finished before this happens. It is not entirely clear to me what do you propose. At

Re: [Kicad-developers] Move point on pcbnew

2017-07-27 Thread Maciej Sumiński
Hi Andrey, It should be fixed now, please check. Regards, Orson On 05/24/2017 09:03 AM, Andrey Kuznetsov wrote: > I was about to explode, but then noticed that if I select the whole > footprint then the MOVE (press M) snaps to the closest point, either center > of footprint or center of pad. >

<    1   2   3   4   5   6   7   8   9   10   >