Re: [Kicad-developers] How to read custom pad polygon data in swig?

2018-08-27 Thread Seth Hillbrand
Hi Andrew- At the moment, SWIG doesn't support the nested classes used for SHAPE_LINE_CHAIN by default [1]. So the polygon data will not be accessible without someone devoting some time to SWIG-ing the classes. Best- Seth [1] http://www.swig.org/Doc1.3/SWIGPlus.html#SWIGPlus_nested_classes

Re: [Kicad-developers] [PATCH] Modify style of the action plugin panel to follow common style, fix Assert

2018-08-27 Thread Seth Hillbrand
Good catch! Thanks. Patch pushed. Best- Seth Am Mo., 27. Aug. 2018 um 04:45 Uhr schrieb Thomas Pointhuber < thomas.pointhu...@gmx.at>: > Hi, > > I modified panel_pcbnew_action_plugins_base to follow the default style > of the table with button up/down. Furthermore, I found out the code >

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-26 Thread Seth Hillbrand
d are about bazaar. > But I would guess commit has to be manually merged. I attached approved > revision of the patch here. > > On Thu, Aug 23, 2018 at 1:50 PM Seth Hillbrand wrote: > >> >> >> Am Do., 23. Aug. 2018 um 12:38 Uhr schrieb Andrew Lutsenko < >>

Re: [Kicad-developers] Tesselation Ideas

2018-08-24 Thread Seth Hillbrand
://code.launchpad.net/~sethh/kicad/+git/kicad/+merge/353697 Thanks- Seth Am Do., 19. Juli 2018 um 09:23 Uhr schrieb Seth Hillbrand < s...@hillbrand.org>: > > > Am Do., 19. Juli 2018 um 00:49 Uhr schrieb Tomasz Wlostowski < > tomasz.wlostow...@cern.ch>: > >> On 19/

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-23 Thread Seth Hillbrand
easier during review. > No, I'd prefer not to split the conversation. However, you can make a branch on launchpad and then make a merge proposal. That should be the same workflow and keeps information on our primary platform. (see attached screenshot for details on where this button is hidden) -

[Kicad-developers] Proposal document for Track Refining

2018-08-22 Thread Seth Hillbrand
Hi All- I'm spec-ing out the requirements for version 6 work on track refinements and would like feedback/suggestions. The document outlining details is at [1]. Overview is that track refinement should allow the user to apply reversible operations to their tracks. Right now, I have included

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-22 Thread Seth Hillbrand
; wrote: > >> Hi Seth, >> >> That makes sense. I will keep working on this feature and will ping this >> thread again once user configuration is implemented. >> >> Thanks, >> Andrew >> >> On Fri, Aug 17, 2018 at 10:03 AM Seth Hillbrand >

Re: [Kicad-developers] Designer Encountering KiCad 5

2018-08-22 Thread Seth Hillbrand
ace snap is enabled, the mouse snaps to the trace. > > Dave said that the following workaround methods are not what professionals > would easy to use software (paraphrasing): > 1. deleting the kink and redrawing it > 2. changing grid size > > On Wed, Aug 22, 2018 at 9:26 AM, Seth Hillb

[Kicad-developers] Designer Encountering KiCad 5

2018-08-22 Thread Seth Hillbrand
Hi All- Dave Jones from eevblog recently hosted a live webcast [1] of him trying out KiCad v5. For those who don't know him, Dave was a professional EE with Altium for a number of years before moving to eevblog full-time. As such, it's an interesting play-by-play of an experienced Altium user

Re: [Kicad-developers] [patch] bring (back) the autoplacer to GAL

2018-08-21 Thread Seth Hillbrand
Same here on Linux. All errors relating to incomplete CN_EDGE definition in the pcbnew_wrap.cxx. -Seth Am Di., 21. Aug. 2018 um 13:47 Uhr schrieb Nick Østergaard < oe.n...@gmail.com>: > If you just push it to a local branch somwhere I can easily trigger a > windows build. > Den tir. 21. aug.

Re: [Kicad-developers] [PATCH] Add documentation for KICAD_USE_OCC

2018-08-20 Thread Seth Hillbrand
Hi Nick- Thanks for this! Looks good. Patch pushed. Best- Seth Am Sa., 4. Aug. 2018 um 15:49 Uhr schrieb Nick Østergaard : > Hello > > Attached is a patch to update the dev-docs about the new option ot use > OCC instead of OCE > > Regards > Nick Østergaard >

Re: [Kicad-developers] German sub translation for appdata.xml

2018-08-20 Thread Seth Hillbrand
Thanks Carsten! It's nice to standardize this and hopefully we can solicit other translations. I've pushed this patch. BTW, thanks for pushing 5.0.0+dfsg1-2. Hope you had a relaxing vacation! Best- Seth Am So., 19. Aug. 2018 um 10:47 Uhr schrieb Carsten Schoenert < c.schoen...@t-online.de>:

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-17 Thread Seth Hillbrand
be able to see that icon didn't load > without the error too. > > Andrew > > On Thu, Aug 16, 2018 at 10:22 PM Seth Hillbrand > wrote: > >> Hi Andrew- >> >> I like the idea. Aside from minor formatting (headers get 1 space >> between function defs, need

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-16 Thread Seth Hillbrand
Hi Andrew- I like the idea. Aside from minor formatting (headers get 1 space between function defs, need a space before the if block), the patch looks good. However, I wouldn't want everything showing on my toolbar (speaking as someone who has 10 plugins installed, 5 of which get regular use).

Re: [Kicad-developers] Need help with menus and dialog modifications

2018-08-16 Thread Seth Hillbrand
Hi David- We're not generally wxWidgets support. If you are having a specific issue, there are a few people on the list who can probably help you debug it. But these sound like some pretty basic questions about working with wxWidgets. There are a number of good tutorials at

Re: [Kicad-developers] MSW directory performance patch

2018-08-14 Thread Seth Hillbrand
ping the files in > > the directory, and we have to do that uniformly across save, load, and > > check-cache. > > > > But it could be done. > > > > Cheers, > > Jeff. > > > > > >> On 13 Aug 2018, at 18:06, Seth Hillbrand >> <mailto:s...@hillb

[Kicad-developers] MSW directory performance patch

2018-08-13 Thread Seth Hillbrand
Hi Jeff and others- Is there anything that would prevent us from merging f6f1c1e94 into the 5.0.1 branch? I was talking with an engineer on Twitter[1] about some performance issues they were having assigning footprints in cvpcb using MSW. It sounded like it might be addressed by that work. -S

Re: [Kicad-developers] C++ standard lib expertise requested

2018-08-09 Thread Seth Hillbrand
OK, here's a stab at decoding. Better guesses, welcome This is std::function, which stores a bound function call. It is a bound function call to a POINT_EDITOR class function that takes a TOOL_EVENT as a parameter and returns an int. It is 16 bytes inside the function, so second instruction.

Re: [Kicad-developers] Filling Zones with the Kicad 5 python API

2018-08-08 Thread Seth Hillbrand
ing standing in the way of us supporting > Native Kicad 5 uploads. :) > > We'll take a stab at adding it to the python SWIG. > > -Laen > > On Wed, Aug 8, 2018 at 12:25 PM Seth Hillbrand wrote: > >> Hi Laen- >> >> Unfortunately, zone filling was f

Re: [Kicad-developers] Filling Zones with the Kicad 5 python API

2018-08-08 Thread Seth Hillbrand
Hi Laen- Unfortunately, zone filling was factored out into a second file in Dec 2017 and it looks like you are the first person to note that the python SWIG includes did not update with it. So, at the moment, KiCad v5 doesn't have a zone fill command in python. I'll see about updating that for

Re: [Kicad-developers] Question on Connectivity Algo

2018-08-07 Thread Seth Hillbrand
. > > > On 7 Aug 2018, at 19:35, jp charras wrote: > > Le 07/08/2018 à 20:14, Seth Hillbrand a écrit : > > Hi Jeff- > > Am Di., 7. Aug. 2018 um 08:07 Uhr schrieb Jeff Young <mailto:j...@rokeby.ie >>: > >When building zone connectivity, we go through th

Re: [Kicad-developers] Question on Connectivity Algo

2018-08-07 Thread Seth Hillbrand
Hi Jeff- Am Di., 7. Aug. 2018 um 08:07 Uhr schrieb Jeff Young : > When building zone connectivity, we go through the following two routines: > > bool ContainsPoint( const VECTOR2I p ) const > { > auto zone = static_cast ( Parent() ); > return m_cachedPoly->ContainsPoint( p,

Re: [Kicad-developers] [PATCH] Add Insert hotkey to add a zone/segment corner

2018-08-07 Thread Seth Hillbrand
unsafe to call from a > global context but are defended implicitly by not providing a hotkey > or menu item when the action isn't ready to get called. > > Cheers, > > John > > On Wed, Aug 1, 2018 at 6:23 PM, Seth Hillbrand wrote: > > Hi John- > > > >

Re: [Kicad-developers] RTree implementation

2018-08-06 Thread Seth Hillbrand
Am Mo., 6. Aug. 2018 um 14:18 Uhr schrieb Tomasz Wlostowski < tomasz.wlostow...@cern.ch>: > On 06/08/18 18:35, Seth Hillbrand wrote: > > > > There's another 32-bit RTree issue that is showing its face > > (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=905221

Re: [Kicad-developers] RTree implementation

2018-08-06 Thread Seth Hillbrand
Am Mo., 6. Aug. 2018 um 10:29 Uhr schrieb Wayne Stambaugh < stambau...@gmail.com>: > Seth, > > On 8/6/2018 1:11 PM, Seth Hillbrand wrote: > > Am Mo., 6. Aug. 2018 um 09:57 Uhr schrieb Wayne Stambaugh > > mailto:stambau...@gmail.com>>: > > > > S

Re: [Kicad-developers] RTree implementation

2018-08-06 Thread Seth Hillbrand
Am Mo., 6. Aug. 2018 um 09:57 Uhr schrieb Wayne Stambaugh < stambau...@gmail.com>: > Simon, > > On 8/6/2018 12:46 PM, Simon Richter wrote: > > Hi, > > > > On 06.08.2018 18:35, Seth Hillbrand wrote: > > > >> What are people's opinions on adding an ad

[Kicad-developers] RTree implementation

2018-08-06 Thread Seth Hillbrand
Hi Devs- There's another 32-bit RTree issue that is showing its face ( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=905221). The last one ( https://bugs.launchpad.net/kicad/+bug/1774316), we hacked around for v5 but as this seems to be a recurring theme, I'd like to address it with some

[Kicad-developers] Debian packaging issue

2018-08-06 Thread Seth Hillbrand
Hi Carsten- I don't know if you follow the bug tracker but there's a debian packaging issue that was reported there (https://bugs.launchpad.net/kicad/+bug/1785630) that would be good to get your input on. At least, I think it's a packaging issue. Please correct me if I'm wrong. -Seth

[Kicad-developers] PCB West Attendees?

2018-08-03 Thread Seth Hillbrand
Hi All- If anyone is planning on heading to PCB West this year and would like to meet up and talk KiCad, let me know. I'll be there for the weekend prior through Tuesday 9/11. Best- Seth ___ Mailing list: https://launchpad.net/~kicad-developers Post

Re: [Kicad-developers] Warning regarding global wxStrings and thread-safety

2018-08-02 Thread Seth Hillbrand
Hi Jeff- Good find. I note here (http://docs.wxwidgets.org/3.0/classwx_string.html) that the use of wxString is explicitly discouraged: "While the use of wxString is unavoidable in wxWidgets program, you are encouraged to use the standard string classes std::string or std::wstring in your

Re: [Kicad-developers] KiCad v5 build warning

2018-08-02 Thread Seth Hillbrand
t; > If we like it in the 5.0 builds I propose we set it as default on on > the 5.0 branch now. > > Nick > Den man. 23. jul. 2018 kl. 05.48 skrev Seth Hillbrand >: > > > > Hi Devs- > > > > Quick heads up for those of us packaging KiCad for our distros: &g

Re: [Kicad-developers] [PATCH] Add Insert hotkey to add a zone/segment corner

2018-08-01 Thread Seth Hillbrand
Hi John- I get a segfault when trying to use the hotkey to insert a point on a zone when it is not selected. -Seth Am Di., 24. Juli 2018 um 10:00 Uhr schrieb John Beard < john.j.be...@gmail.com>: > This patch adds a hotkey for adding a corner to a zone or segment. > This is an action I have

Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-31 Thread Seth Hillbrand
Am Di., 31. Juli 2018 um 14:35 Uhr schrieb Andrew Lutsenko < anlutse...@gmail.com>: > Removing or renaming operator<< does not work because it is used by boost > test suite in qa/geometry/test_fillet.cpp > > But I found an easier solution. There is no need to have friend > declaration in VECTOR2

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-31 Thread Seth Hillbrand
Mark- Looks good. I committed your patch with minor modifications. Thank you for your contribution to KiCad. Best- Seth Am Di., 31. Juli 2018 um 04:35 Uhr schrieb : > Hello Seth, > > I think I fixed all the problems you mention in the attached patch. > > - Why are you storing unknown

Re: [Kicad-developers] wxFormBuilder documentation

2018-07-31 Thread Seth Hillbrand
It would be a good idea to update the standard version. The current link points to a fork that is not maintained. I suggest we standardize to 3.8.0 ( https://github.com/wxFormBuilder/wxFormBuilder/releases/tag/v3.8.0) -S Am Di., 31. Juli 2018 um 11:18 Uhr schrieb Jeff Young : > While wxFB

Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-31 Thread Seth Hillbrand
Am Di., 31. Juli 2018 um 07:31 Uhr schrieb Wayne Stambaugh < stambau...@gmail.com>: > On 7/31/2018 8:33 AM, Carsten Schoenert wrote: > > Am 31.07.18 um 17:50 schrieb Andrew Lutsenko: > > ... > >> Can swig on the qa machine be updated? Or better yet can you upgrade to > >> debian 9? Debian 9 has

Re: [Kicad-developers] Strange crashes

2018-07-31 Thread Seth Hillbrand
DKICAD_VERSION_EXTRA=2.fc28 > -DwxWidgets_CONFIG_EXECUTABLE=/usr/bin/wx-config . > > > > wx-config reports its version as: > > > > saf$ /usr/bin/wx-config --version-full > > 3.0.4.0 > > > > Please let me know any other info you need to help track this down. > >

Re: [Kicad-developers] wxFormBuilder documentation

2018-07-31 Thread Seth Hillbrand
I agree with Simon here. wxFormBuilder isn't perfect but it solves many of the tedious issues. I'd prefer to keep it. -S On Tue, Jul 31, 2018, 8:11 AM Simon Richter wrote: > Hi, > > On 31.07.2018 16:19, Wayne Stambaugh wrote: > > >> From Wayne's email of the 7th Feb 2017, "After the next

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-30 Thread Seth Hillbrand
​Good catch! Thanks John. Best- Seth​ Am Do., 26. Juli 2018 um 08:16 Uhr schrieb John Beard < john.j.be...@gmail.com>: > Hi, > > The SVGs for Catalan and Chinese did not match the XPM constant names, > so there were linking errors. > > I'm not sure how this hasn't been causing breakages since

Re: [Kicad-developers] Strange crashes

2018-07-30 Thread Seth Hillbrand
Hi Steve- The assert is not triggering for me using Debian. However, I note that this is a wxWidgets assertion, which should be disabled for release builds. Since you did the packaging for Fedora, do you have a build log? Alternatively, do you see this assertion when running a local build? -S

Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-30 Thread Seth Hillbrand
y planned? > > Regards, > Andrew > > On Mon, Jul 30, 2018 at 8:53 AM Seth Hillbrand wrote: > >> This compiles cleanly and does not appear to have negative side effects >> so I pushed it. I made a small change to the boilerplate in math.i. >> >> Keep in

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-30 Thread Seth Hillbrand
` to create and attach your patches. Best- Seth Am Mo., 23. Juli 2018 um 09:23 Uhr schrieb Seth Hillbrand < s...@hillbrand.org>: > Thanks Mark, I'll be able to test this out next week. > > -S > > Am Mo., 23. Juli 2018 um 01:52 Uhr schrieb : > >> Hello Seth, >> >

Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-30 Thread Seth Hillbrand
This compiles cleanly and does not appear to have negative side effects so I pushed it. I made a small change to the boilerplate in math.i. Keep in mind that the SWIG-based interface will (hopefully) be retired soon in favor of a fully-abstracted KiCad scripting language. But since that goal is

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-23 Thread Seth Hillbrand
Thanks Mark, I'll be able to test this out next week. -S Am Mo., 23. Juli 2018 um 01:52 Uhr schrieb : > Hello Seth, > > As requested an example eagle project using variants. > > regards > > Mark. > ___ Mailing list:

Re: [Kicad-developers] Windows Builds

2018-07-22 Thread Seth Hillbrand
es are now part of the installers > and they are absolutely massive. (4GB uncompressed) > > the installed files look fine to me though? The kiface files would be > hundreds of megs themselves if they had debug symbols but they are at > "normal" levels. > On Sun, Jul 22, 2018 at 11:16

[Kicad-developers] KiCad v5 build warning

2018-07-22 Thread Seth Hillbrand
​Hi Devs- ​ ​Quick heads up for those of us packaging KiCad for our distros: KICAD_SCRIPTING_ACTION_MENU is OFF by default. You may need to explicitly ​enable it in your builds. -S ___ Mailing list: https://launchpad.net/~kicad-developers Post to

[Kicad-developers] Windows Builds

2018-07-22 Thread Seth Hillbrand
​Hi Devs- I'm seeing some reports (lp:1783037) that indicate the Windows build may be compiled CMAKE_BUILD_TYPE=RelWithDebInfo instead of Release. Can anyone confirm this? Is there a reason to do this for Windows? -Seth ___ Mailing list:

Re: [Kicad-developers] Could someone run a test on GTK for me?

2018-07-21 Thread Seth Hillbrand
Hi Jeff- minWidth = 30 layersWidth = 0 Breakpoints set on the last line of each routine. Best- Seth Am Sa., 21. Juli 2018 um 09:56 Uhr schrieb Jeff Young : > Set two breakpoints: > >- one near the end of ZONE_SETTINGS::SetupLayersList() >- and one near the end of

Re: [Kicad-developers] Build failure?

2018-07-20 Thread Seth Hillbrand
; Cheers, > > Jeff. > > On 20 Jul 2018, at 19:25, Seth Hillbrand wrote: > > Hi Jeff- > > I get a build failure here (Linux): > > In file included from > /home/seth/code/kicad/kicad-launchpad/eeschema/fields_grid_table.cpp:34:0: > /home/seth/code/kicad/kicad-launchpad/in

Re: [Kicad-developers] Build failure?

2018-07-20 Thread Seth Hillbrand
Hi Jeff- I get a build failure here (Linux): In file included from /home/seth/code/kicad/kicad-launchpad/eeschema/fields_grid_table.cpp:34:0: /home/seth/code/kicad/kicad-launchpad/include/widgets/grid_text_button_helpers.h:51:5: error: ‘wxComboCtrl’ does not name a type wxComboCtrl* Combo()

Re: [Kicad-developers] [PATCH 1 / 2] Add check to use std::optional

2018-07-19 Thread Seth Hillbrand
Hi Thomas- Thank you for the contribution! Right now KiCad only uses C++11. But once we move up to C++17, we will want to minimize code paths so that everyone sees the same result. Otherwise we risk introducing bugs that _really_ hard to track down. In other words, replacing boost:: with

Re: [Kicad-developers] Tesselation Ideas

2018-07-19 Thread Seth Hillbrand
Am Do., 19. Juli 2018 um 00:49 Uhr schrieb Tomasz Wlostowski < tomasz.wlostow...@cern.ch>: > On 19/07/18 06:15, Seth Hillbrand wrote: > > ​Hi All- > > > > Our current triangulation caching is based on the poly2tri codebase and > > has a number of constraints.

Re: [Kicad-developers] Branches

2018-07-19 Thread Seth Hillbrand
I'd be in favor of this but if we're going to focus exclusively on v5.1 GTK3 migration, can we push the current state, warts and all to the master? We have a bunch of bugs tagged to 5.1 but only one is GTK3-related. I suspect we have a number of things to work on here but without bug assignment,

Re: [Kicad-developers] kicad version and install location

2018-07-18 Thread Seth Hillbrand
It's a good idea but it's coming after we've already tagged v5. Are we thinking of a patch on the packaging? I don't quite follow the proposal for how this gets implemented. For debian, we could place a patch in the build package. I assume that there is something similar for rpms but I'd be

[Kicad-developers] Tesselation Ideas

2018-07-18 Thread Seth Hillbrand
​Hi All- Our current triangulation caching is based on the poly2tri codebase and has a number of constraints. Most notably, it does not allow touching holes, holes on the boundary or duplicate vertices. In these cases, we do not cache the triangulation and instead use the OpenGL single-thread

[Kicad-developers] Janitor commits missing

2018-07-17 Thread Seth Hillbrand
​Hi Orson- I'm seeing Jeff's cherry-picked commits being processed by Janitor but they seem to be missing the reference to the commit that previous Janitor log messages had. Is this intentional in how Janitor handles cherry-picks? -S​ ___ Mailing

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-17 Thread Seth Hillbrand
Hi Mark- Thank you for your contribution. It would be helpful to evaluating the patch if you could provide an example Eagle project that uses the variants feature. Best- Seth Am Mo., 16. Juli 2018 um 23:49 Uhr schrieb : > From: Mark van Doesburg > > Here is a patch that copies all attributes

Re: [Kicad-developers] Reminder

2018-07-17 Thread Seth Hillbrand
Hi Wayne- Just so I'm clear on how you'd like this to work: We have a commit that affects 5.0.x, 5.1 and 6. We could do 1) git checkout master 2) git commit (get back) 3) git checkout 5.1 4) git cherry-pick 5) compile/test 6) git checkout 5.0 7) git cherry-pick 8) compile/test 9) git push

Re: [Kicad-developers] 5.1 UI feedback

2018-07-16 Thread Seth Hillbrand
Right, but that will be beyond the scope of 5.1 as it involves new features. You can see the proposed v6 ERC/DRC roadmap here https://docs.google.com/document/d/1qvCH9aHwCzp5qtKTna4jJXuloNU0b96gAxAHSKPuXpU/edit?usp=sharing Feel free to suggest where you feel it could be improved. Am Mo., 16.

Re: [Kicad-developers] Version 5 source update

2018-07-16 Thread Seth Hillbrand
Should we just tag v5.0.1 right now then and ignore 5.0.0? Is there any reason not to do that? Am Mo., 16. Juli 2018 um 11:55 Uhr schrieb Wayne Stambaugh < stambau...@gmail.com>: > Hey Carsten, > > On 7/16/2018 2:46 PM, Carsten Schoenert wrote: > > Hello Wayne, > > > > Am 16.07.18 um 20:20

Re: [Kicad-developers] 5.1 branch

2018-07-16 Thread Seth Hillbrand
No time like the present! -S Am Mo., 16. Juli 2018 um 08:49 Uhr schrieb Maciej Sumiński < maciej.sumin...@cern.ch>: > I have the script ready to run. It will just change all KiCad bug > statuses from 'Fix Committed' to 'Fix Release'. I assume there are no > bugs that are marked as 'Fix

Re: [Kicad-developers] Update footprint and get some weird DRC fails

2018-07-14 Thread Seth Hillbrand
Am Sa., 14. Juli 2018 um 18:26 Uhr schrieb Andy Peters : > > > On Jul 14, 2018, at 3:33 PM, Seth Hillbrand wrote: > > > > Hi Andy- > > > > You don't provide enough information to help you here. You'll need to > show a larger image of your board with oth

Re: [Kicad-developers] PCB NC Solder Jumpers in the Std Library

2018-07-11 Thread Seth Hillbrand
Hi Steven- If you would like to create your own jumper pads that don't fail DRC, you have a couple of options. 1) Create a graphic polygon on the copper layer of the footprint (see attached image). To do this, you need to create the graphic polygon in the footprint editor and then edit it to

Re: [Kicad-developers] macos rc3

2018-07-06 Thread Seth Hillbrand
Adam, this is excellent! Thanks for the _significant_ work you've put into making this release. It's really looking smooth. Can you post a link to where we should submit issues related to the Mac build? Do you want them in the standard bug tracker or over at github? Best- Seth Am Fr., 6.

Re: [Kicad-developers] Jenkins e-mails?

2018-06-29 Thread Seth Hillbrand
:132) >> at com.sun.proxy.$Proxy88.execute(Unknown Source) >> at >> hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1146) >> at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) >> at hudson.scm.SCM.ch

[Kicad-developers] Jenkins e-mails?

2018-06-28 Thread Seth Hillbrand
​Hi Nick- I notice that the dev list is not receiving notices of build failures from Jenkins. But the build logs (e.g. http://ci.kicad-pcb.org/job/kicad-qa/4320/console) show that Jenkins is trying to send e-mails. Was this disabled on purpose? If so, is there a way to get specifically added

Re: [Kicad-developers] [PATCH v2] Rewrite test for valid characters in names

2018-06-28 Thread Seth Hillbrand
That makes sense, thanks. Can you do a git format-patch for this change? We'll look at moving the higher loops to std::replace_copy_if during v5.1 -S ​ Am Do., 28. Juni 2018 um 11:34 Uhr schrieb Simon Richter < simon.rich...@hogyros.de>: > Hi Seth, > > On 06/28/2018 07:56 PM,

Re: [Kicad-developers] [PATCH] V5 upgrade documentation

2018-06-28 Thread Seth Hillbrand
​Bother. po4a fixed this back in 2016 ( https://github.com/mquinson/po4a/commit/86f79e5d341ffcb62da9812101304c3dbb420cc6). It looks like our doc server is running 0.47 (the fix didn't get released until 0.49) -S Am Do., 28. Juni 2018 um 12:39 Uhr schrieb Wayne Stambaugh <

Re: [Kicad-developers] gcc-specific OpenMP extension in connectivity_algo.cpp:351

2018-06-28 Thread Seth Hillbrand
​Thanks, JP was just mentioning that in https://bugs.launchpad.net/kicad/+bug/1778454 The shared declaration was unintentional, so I've removed it. As an aside, does anyone know the right gcc flag to get these warnings? Mine ​is very happy to overlook this but apparently other versions are not.

Re: [Kicad-developers] [PATCH v2] Rewrite test for valid characters in names

2018-06-28 Thread Seth Hillbrand
​Understood. What's the impact of the array assignment now? ​ ​-S​ Am Do., 28. Juni 2018 um 10:01 Uhr schrieb Simon Richter < simon.rich...@hogyros.de>: > > The ternary operator decays array arguments to pointers, so they can no > longer be assigned to array references. > --- >

Re: [Kicad-developers] [PATCH] Rewrite test for valid characters in names

2018-06-28 Thread Seth Hillbrand
​Hi Simon- I agree that the assignment is non-standard and probably should be updated. However, if we're going to re-write this, would you be up for doing it with std:: algorithms? -S​ Am Do., 28. Juni 2018 um 09:24 Uhr schrieb Simon Richter < simon.rich...@hogyros.de>: > > The ternary

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-25 Thread Seth Hillbrand
​Hi Wayne- I would view this patch more as defensive coding than trying to fix others' errors. The alternatives are to refuse to parse the file or (as we currently do) parse as written and encounter errors in display and routing. JP's approach provides a clear and predictable response to a

Re: [Kicad-developers] [PATCH] Fix overbar drawing for non-italic text

2018-06-23 Thread Seth Hillbrand
​This patch looks good to me. I tried it and it looks better than without on my machines. -S​ Am Sa., 23. Juni 2018 um 11:44 Uhr schrieb Maciej Suminski < maciej.sumin...@cern.ch>: > +1 for the patch. The change seems sensible just by looking at the raw > diff and the presented images justify

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-23 Thread Seth Hillbrand
ormed pad (like any malformed > item) need a fix when > > reading the file, because it this king of issue can create problems, > even crashes. > > > > Of course, the GAL draw issue needs also to be fixed: it must show the > hole, even for malformed pads. > > > >>

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Seth Hillbrand
avior is different from 4.0 > GAL and legacy, so this is a regression. > > Andrzej > > W dniu 2018-06-22 o 21:44, Seth Hillbrand pisze: > > Ah. This is not an error in the board. This is just an NPTH. If you > click on it in GAL, you will see it. > > I think th

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Seth Hillbrand
you can see them in legacy mode. > > Andrzej > > W dniu 2018-06-22 o 20:06, Seth Hillbrand pisze: > > Andrzej- > > I just tested this, editing a file to remove the layers from a pad and > KiCad automatically adds the pad back to all copper layers. I see the pad &g

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Seth Hillbrand
s those holes visible. > > Andrzej > > W dniu 2018-06-22 o 17:46, Seth Hillbrand pisze: > > ​Andrzej- > > Can you explain the issue that this patch addresses? I read the commit > message but it looks like malformed pads (GetLayerSet().any() == 0) are no > longer hidde

Re: [Kicad-developers] [PATCH] GAL: Draw hole even if pad has no layer

2018-06-22 Thread Seth Hillbrand
​Andrzej- Can you explain the issue that this patch addresses? I read the commit message but it looks like malformed pads (GetLayerSet().any() == 0) are no longer hidden. This seems counter-intuitive but maybe I'm just not seeing the problem. Thanks! Seth​ Am Fr., 22. Juni 2018 um 03:57 Uhr

Re: [Kicad-developers] How to help users handle updating from version 4 to version 5 with regards to fp-lib-table handling?

2018-06-21 Thread Seth Hillbrand
Adam, I've often seen applications use the background image of the DMG to convey important information that they want the user to see during installation. ​ -S​ Am Do., 21. Juni 2018 um 19:52 Uhr schrieb Adam Wolf < adamw...@feelslikeburning.com>: > I am pretty concerned about this. There is

[Kicad-developers] Bug Tracker Milestone

2018-06-21 Thread Seth Hillbrand
​Hi Devs- Can we get a v5.1 milestone on the bug tracker? I'd like to start separating the items we are planning for the point release from the the v6 release. That way we can begin to discuss which belong where. It would probably be useful to also have a 5.0.1 milestone that we can assign

Re: [Kicad-developers] Can we get a WTF tag in the bug tracker?

2018-06-16 Thread Seth Hillbrand
Hi Simon- Perhaps you know this already, but a good way to figure bits out is to use 'git blame'. This will tell you the last person who modified each line. A quick check in with the person listed may be an easy way to find out, which you can then turn into a comment. -Seth On Sat, Jun 16,

Re: [Kicad-developers] [PATCH] Handle STEP export properly on MacOS when launched from standalone pcbnew.

2018-06-15 Thread Seth Hillbrand
am not sure. > > > Specifically, the relative paths are already in KiCad source at least > > > 2 other time. I am not sure why kicad2step got added the way it did. > > > I was not involved. > > > > > > Removing all of the symlinked subbundles is actually part of

Re: [Kicad-developers] [PATCH] Handle STEP export properly on MacOS when launched from standalone pcbnew.

2018-06-14 Thread Seth Hillbrand
​Hi Adam- Is there a reason why the kicad2step is installed in the KiCad base application rather than the pcbnew application? I didn't look into this in depth but I wonder if we can avoid code dealing with a specific packaging scenario? Alternatively, we might put a variable in CMAKE defining

[Kicad-developers] Janitor needs a kick

2018-06-12 Thread Seth Hillbrand
I don't think it was my formatting but the last two patches to master seem to have stuck the Janitor in a loop. Anyone have time to reset it? Seth ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

[Kicad-developers] Untranslated strings

2018-06-11 Thread Seth Hillbrand
​Hi Devs- We're in string freeze but I've run across a couple of strings that are wxT() instead of _()​. Example: cvpcb/display_footprints_frame.cpp:435. I have a preference for converting these to _(), even at this stage as worst-case is that they remain untranslated as they are now. Does

Re: [Kicad-developers] [Patch] Bug 1584977: Open project folder in host OS

2018-06-11 Thread Seth Hillbrand
​Hi Ashutosh- Thank you for your contribution. We are currently in feature-freeze for the upcoming v5.0 release. If you post your patch to ​the associated bug report, we'll have a chance to evaluate and merge it after v5 is released. Thanks! -Seth Am Mo., 11. Juni 2018 um 03:36 Uhr schrieb

Re: [Kicad-developers] [PATCH] Add missing header

2018-06-08 Thread Seth Hillbrand
​Applied, thanks!​ Am Fr., 8. Juni 2018 um 17:12 Uhr schrieb Simon Richter < simon.rich...@hogyros.de>: > --- > eeschema/sch_component.cpp | 1 + > 1 file changed, 1 insertion(+) > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post

Re: [Kicad-developers] [PATCH]fix library cache issue

2018-06-08 Thread Seth Hillbrand
​Hi Damien- ​Library name is frequently NULL. This will segfault in your implementation. -S Am Fr., 8. Juni 2018 um 13:04 Uhr schrieb Damien Espitallier < damien.espitall...@gmail.com>: > Hi, > > I found a bug with the library browser. > > Step to reproduce: > - open Kicad > - open PCBNew

Re: [Kicad-developers] Help finding routing option

2018-06-07 Thread Seth Hillbrand
class Value (I > have just realized that the former should be called "Select Track/Via > Size). Grepping for ID_POPUP_PCB_SELECT_USE_NETCLASS_VALUES will get you > the interesting bits. > > Cheers, > Orson > > On 06/07/2018 05:19 AM, Seth Hillbrand wrote: > > ​Hi All

Re: [Kicad-developers] Error importing the wxPython API!

2018-06-06 Thread Seth Hillbrand
​Hi Reece- You probably have a compiled .pyc module hanging around that refers to your old installation. You can just delete all pyc files on your system and this will fix it. Python will re-compile as needed. -S​ Am Mi., 6. Juni 2018 um 20:27 Uhr schrieb Reece R. Pollack : > Hey folks,

[Kicad-developers] Help finding routing option

2018-06-06 Thread Seth Hillbrand
​Hi All- Could someone let me know if I'm mistaken here? Some years ago, I recall being able to set an option while routing that allowed new tracks to pick up their netclass values rather than the ​global track width setting. I've searched (I think) the options as well as had a look through the

Re: [Kicad-developers] eeschema GAL renderer (with old tools)

2018-06-04 Thread Seth Hillbrand
​Hi Tom- Would you like feedback on any of this? If so, what's most useful for you? Github issue tracker? Merge requests? Or just posts to the dev list? Best- Seth​ Am Mo., 4. Juni 2018 um 05:22 Uhr schrieb Tomasz Wlostowski < tomasz.wlostow...@cern.ch>: > On 04/06/18 13:42, jp charras

Re: [Kicad-developers] eeschema GAL renderer (with old tools)

2018-06-04 Thread Seth Hillbrand
​Wayne- I think that checkout -b created a new branch based on the branch you were in. You probably want `git checkout tom-eeschema-gal`. -S​ Am Mo., 4. Juni 2018 um 12:01 Uhr schrieb Wayne Stambaugh < stambau...@gmail.com>: > On 6/4/2018 2:58 PM, Tomasz Wlostowski wrote: > > On 04/06/18

Re: [Kicad-developers] [PATCH] Large board speed

2018-06-02 Thread Seth Hillbrand
> >>> On Sat, Jun 2, 2018 at 12:17 AM, Wayne Stambaugh >>> <mailto:stambau...@gmail.com>> wrote: > >>> > >>> On 6/1/2018 3:58 PM, Tomasz Wlostowski wrote: > >>> > On 01/06/18 20:23, Seth Hillbrand wrote: > >>&g

Re: [Kicad-developers] [PATCH] Large board speed

2018-06-01 Thread Seth Hillbrand
regression from v4. I don't think that this is a "do we fix?" issue but rather a "how do we fix?" one. -S Am Fr., 1. Juni 2018 um 10:57 Uhr schrieb Simon Richter < simon.rich...@hogyros.de>: > Hi, > > On 01.06.2018 06:36, Seth Hillbrand wrote: > > > Do

Re: [Kicad-developers] [PATCH] Large board speed

2018-05-31 Thread Seth Hillbrand
Do people have concerns with the risk exposure for this patch or would anyone like some additional time to evaluate? -S Am Di., 29. Mai 2018 um 15:40 Uhr schrieb Seth Hillbrand < seth.hillbr...@gmail.com>: > ​Examples always work better than words. :) > > Here is a

Re: [Kicad-developers] Recent change to LayerIDs

2018-05-30 Thread Seth Hillbrand
Hi Jeff- Yes, you are right. That was meant to be temporary to track an issue I've been seeing with swapping layers while switching between GAL and Legacy but I accidentally pushed it with the zoom patch. That said, background layer is a color, and Jon added the correct color checks to

Re: [Kicad-developers] [PATCH] Large board speed

2018-05-29 Thread Seth Hillbrand
.​ -S Am Di., 29. Mai 2018 um 14:59 Uhr schrieb Seth Hillbrand < seth.hillbr...@gmail.com>: > Hi Jeff- > > By DRC, I meant the DRC problems/markers. The unconnected count, like the > status bar count, is based on the connectivity search that this patch > affects. > > A

Re: [Kicad-developers] [PATCH] Large board speed

2018-05-29 Thread Seth Hillbrand
DRC unconnected count (even > before any of Seth’s changes). > > On 29 May 2018, at 17:59, Seth Hillbrand wrote: > > Am Di., 29. Mai 2018 um 08:55 Uhr schrieb Wayne Stambaugh < > stambau...@gmail.com>: > >> On 5/28/2018 11:21 AM, Tomasz Wlostowski wrote: >> &

Re: [Kicad-developers] [PATCH] Large board speed

2018-05-29 Thread Seth Hillbrand
Am Di., 29. Mai 2018 um 08:55 Uhr schrieb Wayne Stambaugh < stambau...@gmail.com>: > On 5/28/2018 11:21 AM, Tomasz Wlostowski wrote: > > On 25/05/18 18:53, Seth Hillbrand wrote: > >> Hi Tom- > >> > >> For a particularly large board I'm working on (32

<    3   4   5   6   7   8   9   10   >