subject:"\[Kicad\-developers\] \[PATCH\] Crash Reporter"

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-08-05 Thread Nick Østergaard

Ok, thanks. Just a note, there are two packages for msys2
mingw-packages that provided.

I see you based your pkgbuild on the 3.0 one...

On Thu, 1 Aug 2019 at 17:01, Tomasz Wlostowski
 wrote:
>
> On 30/07/2019 20:03, Nick Østergaard wrote:
> > I get the same error. :(
> >
>
> Hi Nick,
>
> We had two problems:
> - wrong check macro (I removed it in the last commit from my branch)
> - wrong build of wx (must be configured with --enable-backtrace - fixed
> PKGBUILD in the attachment).
>
> Latest code here:
> https://github.com/twlostow/kicad-dev/tree/tom-crash-reporter-aug01
>
> Cheers,
> Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-08-01 Thread Tomasz Wlostowski

On 30/07/2019 20:03, Nick Østergaard wrote:
> I get the same error. :(
> 

Hi Nick,

We had two problems:
- wrong check macro (I removed it in the last commit from my branch)
- wrong build of wx (must be configured with --enable-backtrace - fixed
PKGBUILD in the attachment).

Latest code here:
https://github.com/twlostow/kicad-dev/tree/tom-crash-reporter-aug01

Cheers,
Tom

#
# Based on packages found at these URLs
# https://www.archlinux.org/packages/extra/i686/wxgtk-common/
# https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-wxWidgets
#
# Maintainer: Tim S 
#


# Packages that are assumed to be installed when building this package.
#   pacman -S --needed mingw-w64-i686-toolchain mingw-w64-x86_64-toolchain

_basename=wxWidgets
_realname=wxmsw
_wx_basever=3.1
# Example _wx_buildver value is "-rc"
_wx_buildver=

pkgbase=mingw-w64-${_basename}${_wx_basever}
pkgname="${MINGW_PACKAGE_PREFIX}-${_realname}${_wx_basever}"
pkgver=${_wx_basever}.2
pkgrel=1
pkgdesc="A C++ library that lets developers create applications for Windows, 
Linux and UNIX (mingw-w64)"
arch=('any')
url="http://wxwidgets.org;
license=('custom:wxWindows')
makedepends=(
  "make"
  "patch"
  "${MINGW_PACKAGE_PREFIX}-libpng"
  "${MINGW_PACKAGE_PREFIX}-libjpeg-turbo"
  "${MINGW_PACKAGE_PREFIX}-libtiff"
)
options=('strip' 'staticlibs' 'buildflags')
source=(
  
https://github.com/wxWidgets/wxWidgets/releases/download/v${pkgver}${_wx_buildver}/${_basename}-${pkgver}${_wx_buildver}.tar.bz2

  # This patch is a MSys2 run-time patch
  "001-wxWidgets-3.0.2-relocate-prefix-in-bin-wx-config.patch"

  "002-wxWidgets-3.0.3-make-abicheck-non-fatal.patch"

  # the wxTeam rejected this patch
  "005-wxWidgets-3.0.2-Remove-WX_LIBS_STATIC-from-m4.patch"

  011-wxWidgets-3.1.2-Enable-wxUSE_GRAPHICS_DIRECT2D.patch
)
sha256sums=('4cb8d23d70f9261debf7d6cfeca667fc0a7d2b6565adb8f1c484f9b674f1f27a'
'7c3b8f6ba275a448a5e82d64c4914acd5aefb8bbb952389688f3e7167a787c56'
'8e1eb9d6a13c7c52ffaec6093e40d1f3c397a220fd881274ce3ef54fc39525d9'
'6ae8ab869c091019f62a15de788a2b9c5d326bfac6be7f247e4c82426d41e4ef'
'a0079d43c0c0308060578318ee979af3ecc400cca537e9378dc9021fe4b5a371')
prepare() {
  cd "${srcdir}"/${_basename}-${pkgver}${_wx_buildver}

  # Fix MSys2 Run-Time wx-config bug.
  patch -p1 -i 
"${srcdir}"/001-wxWidgets-3.0.2-relocate-prefix-in-bin-wx-config.patch

  patch -p1 -i "${srcdir}"/002-wxWidgets-3.0.3-make-abicheck-non-fatal.patch

  # This patch is not really needed; but, WX_LIBS_STATIC does not work 
correctly under MSys2
  # Removed it to see if anything breaks or if anything is fixed.
  patch -p1 -i 
"${srcdir}"/005-wxWidgets-3.0.2-Remove-WX_LIBS_STATIC-from-m4.patch

  patch -p1 -i 
"${srcdir}"/011-wxWidgets-3.1.2-Enable-wxUSE_GRAPHICS_DIRECT2D.patch
}

build() {
  
  # Configure options added to support other software:
  #   --enable-graphics_ctx codelite
  #
  # Configure options added to check for build issues
  #   --disable-precomp-headers
  #
  # Configure options added to avoid possible future issues
  #   --with-cxx=14
  #   --enable-std_string
  #
  # Configure options added to avoid warnings:
  #   --with-regex=builtin
  #
  # Configure options known to cause build errors:
  #   --disable-regkeycompile error
  #
  # Configure options believed to reduce code size or build time:
  #   --without-opengl
  #   --without-subdirs
  #   --disable-webview
  #   --disable-mediactrl
  

  [[ -d "${srcdir}"/build-${CARCH}-shared ]] && rm -rf 
"${srcdir}"/build-${CARCH}-shared
  mkdir -p "${srcdir}"/build-${CARCH}-shared && cd 
"${srcdir}"/build-${CARCH}-shared

  ../${_basename}-${pkgver}${_wx_buildver}/configure \
--prefix=${MINGW_PREFIX} \
--host=${MINGW_CHOST} \
--target=${MINGW_CHOST} \
--build=${MINGW_CHOST} \
--enable-shared \
--enable-std_string \
--enable-iff \
--enable-permissive \
--enable-unicode \
--enable-graphics_ctx \
--enable-accessibility \
--enable-backtrace \
--disable-monolithic \
--disable-precomp-headers \
--with-msw \
--with-cxx=14 \
--with-opengl \
--with-libpng=sys \
--with-libjpeg=sys \
--with-libtiff=sys \
--with-regex=builtin

  make #VERBOSE=1


  [[ -d "${srcdir}"/build-${CARCH}-static ]] && rm -rf 
"${srcdir}"/build-${CARCH}-static
  mkdir -p "${srcdir}"/build-${CARCH}-static && cd 
"${srcdir}"/build-${CARCH}-static

  ../${_basename}-${pkgver}${_wx_buildver}/configure \
--prefix=${MINGW_PREFIX} \
--host=${MINGW_CHOST} \
--target=${MINGW_CHOST} \
--build=${MINGW_CHOST} \
--disable-shared \
--enable-std_string \
--enable-iff \
--enable-permissive \
--enable-backtrace \
--enable-unicode \
--enable-graphics_ctx \
--enable-accessibility \
--disable-monolithic \
--disable-precomp-headers \
--with-msw \
--with-cxx=14 \
--with-opengl \
--with-libpng=sys \

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Nick Østergaard

I get the same error. :(

On Tue, 30 Jul 2019 at 16:32, Tomasz Wlostowski
 wrote:
>
> On 30/07/2019 15:33, Nick Østergaard wrote:
> > It was built like this:
> > https://github.com/msys2/MINGW-packages/blob/c6dfad711f4d956a02e93026a0eb9a74ad6bfd65/mingw-w64-wxWidgets3.1/PKGBUILD
> >
>
> Try building wx with --enable-backtrace --enable-debugreport
>
> T.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Tomasz Wlostowski

On 30/07/2019 15:33, Nick Østergaard wrote:
> It was built like this:
> https://github.com/msys2/MINGW-packages/blob/c6dfad711f4d956a02e93026a0eb9a74ad6bfd65/mingw-w64-wxWidgets3.1/PKGBUILD
> 

Try building wx with --enable-backtrace --enable-debugreport

T.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Nick Østergaard

It was built like this:
https://github.com/msys2/MINGW-packages/blob/c6dfad711f4d956a02e93026a0eb9a74ad6bfd65/mingw-w64-wxWidgets3.1/PKGBUILD

On Tue, 30 Jul 2019 at 14:59, Tomasz Wlostowski
 wrote:
>
> On 30/07/2019 14:54, Nick Østergaard wrote:
> > Exacept when I try to build it against wx 3.1 I get errors like:
> >
> > debug_report.cpp:515:5: error: 'YAML_STACK_WALKER' was not declared in
> > this scope
> >
> > Building against 3.0 is ok, but it crashes when it is trying to upload
> > a bug report.
> >
> > I used -DwxWidgets_CONFIG_EXECUTABLE=${MINGW_PREFIX}/bin/wx-config-3.1
> > to select wx 3.1.
>
>
> Did you build wx with stack walker support?
>
> Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Tomasz Wlostowski

On 30/07/2019 14:54, Nick Østergaard wrote:
> Exacept when I try to build it against wx 3.1 I get errors like:
> 
> debug_report.cpp:515:5: error: 'YAML_STACK_WALKER' was not declared in
> this scope
> 
> Building against 3.0 is ok, but it crashes when it is trying to upload
> a bug report.
> 
> I used -DwxWidgets_CONFIG_EXECUTABLE=${MINGW_PREFIX}/bin/wx-config-3.1
> to select wx 3.1.


Did you build wx with stack walker support?

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-30 Thread Tomasz Wlostowski

On 29/07/2019 18:47, Nick Østergaard wrote:
> I rebased this for todays master and pushed it to:
> https://github.com/nickoe/kicad-source-mirror/tree/tom-crash-reporter-may27_rebased20190729
> 
> Diff view of changes:
> https://github.com/nickoe/kicad-source-mirror/compare/7b5b807...nickoe:tom-crash-reporter-may27_rebased20190729?expand=1
> 
> I don't think I let it follow the recent style in mater about the menu:
> https://github.com/nickoe/kicad-source-mirror/compare/7b5b807...nickoe:tom-crash-reporter-may27_rebased20190729?expand=1#diff-512ddae11b132baba0403a7df0fc215bR376
> 
> I did see it build on archlinux and it did report to launchpad with
> the menu entry to test the crash reporter.
> 
> I still need to test it on windows.

Hi Nick,

Thanks for rebasing & testing.

I did a Windows7 x64 build (with wx 3.1.1), works fine (including full
stack traces).

Cheers,
Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-29 Thread Nick Østergaard

I rebased this for todays master and pushed it to:
https://github.com/nickoe/kicad-source-mirror/tree/tom-crash-reporter-may27_rebased20190729

Diff view of changes:
https://github.com/nickoe/kicad-source-mirror/compare/7b5b807...nickoe:tom-crash-reporter-may27_rebased20190729?expand=1

I don't think I let it follow the recent style in mater about the menu:
https://github.com/nickoe/kicad-source-mirror/compare/7b5b807...nickoe:tom-crash-reporter-may27_rebased20190729?expand=1#diff-512ddae11b132baba0403a7df0fc215bR376

I did see it build on archlinux and it did report to launchpad with
the menu entry to test the crash reporter.

I still need to test it on windows.

On Tue, 16 Jul 2019 at 13:01, Nick Østergaard  wrote:
>
> It looks like some of the errors are related to the lexer stuff. Can
> you try to rebase your branch to latest master?
>
> On Tue, 16 Jul 2019 at 13:00, Nick Østergaard  wrote:
> >
> > @Tomasz Wlostowski  I am trying to build against wx3.1, but I get
> > build errors, please review the build log:
> >
> > https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/465/console
> >
> > On Tue, 16 Jul 2019 at 12:37, Nick Østergaard  wrote:
> > >
> > > Hmm, ok, I guess you mean the -may27 one.. it seem to have never commits.
> > >
> > > https://github.com/twlostow/kicad-dev/tree/tom-crash-reporter-may27
> > >
> > > On Tue, 16 Jul 2019 at 11:08, Tomasz Wlostowski
> > >  wrote:
> > > >
> > > > On 15/07/2019 14:43, Nick Østergaard wrote:
> > > > > Remind me, is this feature still in a seperate branch to master, or
> > > > > how is it enabled?
> > > >
> > > > IIRC it's still tom-crash-reporter on my github and it's enabled in
> > > > CMake config (KICAD_CRASH_REPORTER=yes).
> > > >
> > > > T.
> > > >
> > > > >
> > > > > On Thu, 11 Jul 2019 at 21:08, Nick Østergaard  
> > > > > wrote:
> > > > >>
> > > > >> @Tomasz Wlostowski  I just found that it looks like someone has
> > > > >> uploaded a wxwidgets 3.1 pkgbuild for the mingw-packages for msys2, I
> > > > >> could try to build and and rebuild your branch for windows.
> > > > >>
> > > > >> https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-wxWidgets3.1/PKGBUILD
> > > > >>
> > > > >> On Tue, 9 Jul 2019 at 14:09, Wayne Stambaugh  
> > > > >> wrote:
> > > > >>>
> > > > >>> Tom,
> > > > >>>
> > > > >>> On 7/9/19 2:41 AM, Tomasz Wlostowski wrote:
> > > >  On 06/07/2019 21:10, Ian McInerney wrote:
> > > > > Tom,
> > > > >
> > > > > Not to pile on the questions, but does the linux stack trace 
> > > > > support
> > > > > exist in the entire 3.0.x line, or how far back does it go? 
> > > > > Currently,
> > > > > the minimum version searched by cmake is 3.0.0, and some major 
> > > > > linux
> > > > > distros only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 
> > > > > to
> > > > > name a few).
> > > > 
> > > >  Hi,
> > > > 
> > > >  Under liunx stack trace works fine in 3.0.2. Under Windows it's not
> > > >  implemented at all (unless using a crazy hack 
> > > >  self-exception-raising
> > > >  hack that works only under MSVC).
> > > > 
> > > >  I can work this around by having our own Windows stack walker - 
> > > >  after
> > > >  all the whole purpose  of the crash reporter was easy debug 
> > > >  reports for
> > > >  Windows users. Under Linux everyone knows how to use a debugger,
> > > >  otherwise it's impossible to work ;-)
> > > > >>> I'm assuming that you mean that you are going to pull the
> > > > >>> wxDebugReporter code from the 3.1 branch of wxWidgets which can be
> > > > >>> removed once wxWidgets 3.2 becomes the default.  If it's any more 
> > > > >>> than
> > > > >>> that, I would rather wait until 3.2 is available.
> > > > >>>
> > > > 
> > > >  Tom
> > > > 
> > > > >>>
> > > > >>> ___
> > > > >>> Mailing list: https://launchpad.net/~kicad-developers
> > > > >>> Post to : kicad-developers@lists.launchpad.net
> > > > >>> Unsubscribe : https://launchpad.net/~kicad-developers
> > > > >>> More help   : https://help.launchpad.net/ListHelp
> > > >

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-16 Thread Nick Østergaard

It looks like some of the errors are related to the lexer stuff. Can
you try to rebase your branch to latest master?

On Tue, 16 Jul 2019 at 13:00, Nick Østergaard  wrote:
>
> @Tomasz Wlostowski  I am trying to build against wx3.1, but I get
> build errors, please review the build log:
>
> https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/465/console
>
> On Tue, 16 Jul 2019 at 12:37, Nick Østergaard  wrote:
> >
> > Hmm, ok, I guess you mean the -may27 one.. it seem to have never commits.
> >
> > https://github.com/twlostow/kicad-dev/tree/tom-crash-reporter-may27
> >
> > On Tue, 16 Jul 2019 at 11:08, Tomasz Wlostowski
> >  wrote:
> > >
> > > On 15/07/2019 14:43, Nick Østergaard wrote:
> > > > Remind me, is this feature still in a seperate branch to master, or
> > > > how is it enabled?
> > >
> > > IIRC it's still tom-crash-reporter on my github and it's enabled in
> > > CMake config (KICAD_CRASH_REPORTER=yes).
> > >
> > > T.
> > >
> > > >
> > > > On Thu, 11 Jul 2019 at 21:08, Nick Østergaard  wrote:
> > > >>
> > > >> @Tomasz Wlostowski  I just found that it looks like someone has
> > > >> uploaded a wxwidgets 3.1 pkgbuild for the mingw-packages for msys2, I
> > > >> could try to build and and rebuild your branch for windows.
> > > >>
> > > >> https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-wxWidgets3.1/PKGBUILD
> > > >>
> > > >> On Tue, 9 Jul 2019 at 14:09, Wayne Stambaugh  
> > > >> wrote:
> > > >>>
> > > >>> Tom,
> > > >>>
> > > >>> On 7/9/19 2:41 AM, Tomasz Wlostowski wrote:
> > >  On 06/07/2019 21:10, Ian McInerney wrote:
> > > > Tom,
> > > >
> > > > Not to pile on the questions, but does the linux stack trace support
> > > > exist in the entire 3.0.x line, or how far back does it go? 
> > > > Currently,
> > > > the minimum version searched by cmake is 3.0.0, and some major linux
> > > > distros only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 to
> > > > name a few).
> > > 
> > >  Hi,
> > > 
> > >  Under liunx stack trace works fine in 3.0.2. Under Windows it's not
> > >  implemented at all (unless using a crazy hack self-exception-raising
> > >  hack that works only under MSVC).
> > > 
> > >  I can work this around by having our own Windows stack walker - after
> > >  all the whole purpose  of the crash reporter was easy debug reports 
> > >  for
> > >  Windows users. Under Linux everyone knows how to use a debugger,
> > >  otherwise it's impossible to work ;-)
> > > >>> I'm assuming that you mean that you are going to pull the
> > > >>> wxDebugReporter code from the 3.1 branch of wxWidgets which can be
> > > >>> removed once wxWidgets 3.2 becomes the default.  If it's any more than
> > > >>> that, I would rather wait until 3.2 is available.
> > > >>>
> > > 
> > >  Tom
> > > 
> > > >>>
> > > >>> ___
> > > >>> Mailing list: https://launchpad.net/~kicad-developers
> > > >>> Post to : kicad-developers@lists.launchpad.net
> > > >>> Unsubscribe : https://launchpad.net/~kicad-developers
> > > >>> More help   : https://help.launchpad.net/ListHelp
> > >

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-16 Thread Nick Østergaard

@Tomasz Wlostowski  I am trying to build against wx3.1, but I get
build errors, please review the build log:

https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/465/console

On Tue, 16 Jul 2019 at 12:37, Nick Østergaard  wrote:
>
> Hmm, ok, I guess you mean the -may27 one.. it seem to have never commits.
>
> https://github.com/twlostow/kicad-dev/tree/tom-crash-reporter-may27
>
> On Tue, 16 Jul 2019 at 11:08, Tomasz Wlostowski
>  wrote:
> >
> > On 15/07/2019 14:43, Nick Østergaard wrote:
> > > Remind me, is this feature still in a seperate branch to master, or
> > > how is it enabled?
> >
> > IIRC it's still tom-crash-reporter on my github and it's enabled in
> > CMake config (KICAD_CRASH_REPORTER=yes).
> >
> > T.
> >
> > >
> > > On Thu, 11 Jul 2019 at 21:08, Nick Østergaard  wrote:
> > >>
> > >> @Tomasz Wlostowski  I just found that it looks like someone has
> > >> uploaded a wxwidgets 3.1 pkgbuild for the mingw-packages for msys2, I
> > >> could try to build and and rebuild your branch for windows.
> > >>
> > >> https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-wxWidgets3.1/PKGBUILD
> > >>
> > >> On Tue, 9 Jul 2019 at 14:09, Wayne Stambaugh  
> > >> wrote:
> > >>>
> > >>> Tom,
> > >>>
> > >>> On 7/9/19 2:41 AM, Tomasz Wlostowski wrote:
> >  On 06/07/2019 21:10, Ian McInerney wrote:
> > > Tom,
> > >
> > > Not to pile on the questions, but does the linux stack trace support
> > > exist in the entire 3.0.x line, or how far back does it go? Currently,
> > > the minimum version searched by cmake is 3.0.0, and some major linux
> > > distros only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 to
> > > name a few).
> > 
> >  Hi,
> > 
> >  Under liunx stack trace works fine in 3.0.2. Under Windows it's not
> >  implemented at all (unless using a crazy hack self-exception-raising
> >  hack that works only under MSVC).
> > 
> >  I can work this around by having our own Windows stack walker - after
> >  all the whole purpose  of the crash reporter was easy debug reports for
> >  Windows users. Under Linux everyone knows how to use a debugger,
> >  otherwise it's impossible to work ;-)
> > >>> I'm assuming that you mean that you are going to pull the
> > >>> wxDebugReporter code from the 3.1 branch of wxWidgets which can be
> > >>> removed once wxWidgets 3.2 becomes the default.  If it's any more than
> > >>> that, I would rather wait until 3.2 is available.
> > >>>
> > 
> >  Tom
> > 
> > >>>
> > >>> ___
> > >>> Mailing list: https://launchpad.net/~kicad-developers
> > >>> Post to : kicad-developers@lists.launchpad.net
> > >>> Unsubscribe : https://launchpad.net/~kicad-developers
> > >>> More help   : https://help.launchpad.net/ListHelp
> >

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-16 Thread Nick Østergaard

Hmm, ok, I guess you mean the -may27 one.. it seem to have never commits.

https://github.com/twlostow/kicad-dev/tree/tom-crash-reporter-may27

On Tue, 16 Jul 2019 at 11:08, Tomasz Wlostowski
 wrote:
>
> On 15/07/2019 14:43, Nick Østergaard wrote:
> > Remind me, is this feature still in a seperate branch to master, or
> > how is it enabled?
>
> IIRC it's still tom-crash-reporter on my github and it's enabled in
> CMake config (KICAD_CRASH_REPORTER=yes).
>
> T.
>
> >
> > On Thu, 11 Jul 2019 at 21:08, Nick Østergaard  wrote:
> >>
> >> @Tomasz Wlostowski  I just found that it looks like someone has
> >> uploaded a wxwidgets 3.1 pkgbuild for the mingw-packages for msys2, I
> >> could try to build and and rebuild your branch for windows.
> >>
> >> https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-wxWidgets3.1/PKGBUILD
> >>
> >> On Tue, 9 Jul 2019 at 14:09, Wayne Stambaugh  wrote:
> >>>
> >>> Tom,
> >>>
> >>> On 7/9/19 2:41 AM, Tomasz Wlostowski wrote:
>  On 06/07/2019 21:10, Ian McInerney wrote:
> > Tom,
> >
> > Not to pile on the questions, but does the linux stack trace support
> > exist in the entire 3.0.x line, or how far back does it go? Currently,
> > the minimum version searched by cmake is 3.0.0, and some major linux
> > distros only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 to
> > name a few).
> 
>  Hi,
> 
>  Under liunx stack trace works fine in 3.0.2. Under Windows it's not
>  implemented at all (unless using a crazy hack self-exception-raising
>  hack that works only under MSVC).
> 
>  I can work this around by having our own Windows stack walker - after
>  all the whole purpose  of the crash reporter was easy debug reports for
>  Windows users. Under Linux everyone knows how to use a debugger,
>  otherwise it's impossible to work ;-)
> >>> I'm assuming that you mean that you are going to pull the
> >>> wxDebugReporter code from the 3.1 branch of wxWidgets which can be
> >>> removed once wxWidgets 3.2 becomes the default.  If it's any more than
> >>> that, I would rather wait until 3.2 is available.
> >>>
> 
>  Tom
> 
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : kicad-developers@lists.launchpad.net
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-16 Thread Tomasz Wlostowski

On 15/07/2019 14:43, Nick Østergaard wrote:
> Remind me, is this feature still in a seperate branch to master, or
> how is it enabled?

IIRC it's still tom-crash-reporter on my github and it's enabled in
CMake config (KICAD_CRASH_REPORTER=yes).

T.

> 
> On Thu, 11 Jul 2019 at 21:08, Nick Østergaard  wrote:
>>
>> @Tomasz Wlostowski  I just found that it looks like someone has
>> uploaded a wxwidgets 3.1 pkgbuild for the mingw-packages for msys2, I
>> could try to build and and rebuild your branch for windows.
>>
>> https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-wxWidgets3.1/PKGBUILD
>>
>> On Tue, 9 Jul 2019 at 14:09, Wayne Stambaugh  wrote:
>>>
>>> Tom,
>>>
>>> On 7/9/19 2:41 AM, Tomasz Wlostowski wrote:
 On 06/07/2019 21:10, Ian McInerney wrote:
> Tom,
>
> Not to pile on the questions, but does the linux stack trace support
> exist in the entire 3.0.x line, or how far back does it go? Currently,
> the minimum version searched by cmake is 3.0.0, and some major linux
> distros only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 to
> name a few).

 Hi,

 Under liunx stack trace works fine in 3.0.2. Under Windows it's not
 implemented at all (unless using a crazy hack self-exception-raising
 hack that works only under MSVC).

 I can work this around by having our own Windows stack walker - after
 all the whole purpose  of the crash reporter was easy debug reports for
 Windows users. Under Linux everyone knows how to use a debugger,
 otherwise it's impossible to work ;-)
>>> I'm assuming that you mean that you are going to pull the
>>> wxDebugReporter code from the 3.1 branch of wxWidgets which can be
>>> removed once wxWidgets 3.2 becomes the default.  If it's any more than
>>> that, I would rather wait until 3.2 is available.
>>>

 Tom

>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-15 Thread Nick Østergaard

Remind me, is this feature still in a seperate branch to master, or
how is it enabled?

On Thu, 11 Jul 2019 at 21:08, Nick Østergaard  wrote:
>
> @Tomasz Wlostowski  I just found that it looks like someone has
> uploaded a wxwidgets 3.1 pkgbuild for the mingw-packages for msys2, I
> could try to build and and rebuild your branch for windows.
>
> https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-wxWidgets3.1/PKGBUILD
>
> On Tue, 9 Jul 2019 at 14:09, Wayne Stambaugh  wrote:
> >
> > Tom,
> >
> > On 7/9/19 2:41 AM, Tomasz Wlostowski wrote:
> > > On 06/07/2019 21:10, Ian McInerney wrote:
> > >> Tom,
> > >>
> > >> Not to pile on the questions, but does the linux stack trace support
> > >> exist in the entire 3.0.x line, or how far back does it go? Currently,
> > >> the minimum version searched by cmake is 3.0.0, and some major linux
> > >> distros only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 to
> > >> name a few).
> > >
> > > Hi,
> > >
> > > Under liunx stack trace works fine in 3.0.2. Under Windows it's not
> > > implemented at all (unless using a crazy hack self-exception-raising
> > > hack that works only under MSVC).
> > >
> > > I can work this around by having our own Windows stack walker - after
> > > all the whole purpose  of the crash reporter was easy debug reports for
> > > Windows users. Under Linux everyone knows how to use a debugger,
> > > otherwise it's impossible to work ;-)
> > I'm assuming that you mean that you are going to pull the
> > wxDebugReporter code from the 3.1 branch of wxWidgets which can be
> > removed once wxWidgets 3.2 becomes the default.  If it's any more than
> > that, I would rather wait until 3.2 is available.
> >
> > >
> > > Tom
> > >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-11 Thread Nick Østergaard

@Tomasz Wlostowski  I just found that it looks like someone has
uploaded a wxwidgets 3.1 pkgbuild for the mingw-packages for msys2, I
could try to build and and rebuild your branch for windows.

https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-wxWidgets3.1/PKGBUILD

On Tue, 9 Jul 2019 at 14:09, Wayne Stambaugh  wrote:
>
> Tom,
>
> On 7/9/19 2:41 AM, Tomasz Wlostowski wrote:
> > On 06/07/2019 21:10, Ian McInerney wrote:
> >> Tom,
> >>
> >> Not to pile on the questions, but does the linux stack trace support
> >> exist in the entire 3.0.x line, or how far back does it go? Currently,
> >> the minimum version searched by cmake is 3.0.0, and some major linux
> >> distros only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 to
> >> name a few).
> >
> > Hi,
> >
> > Under liunx stack trace works fine in 3.0.2. Under Windows it's not
> > implemented at all (unless using a crazy hack self-exception-raising
> > hack that works only under MSVC).
> >
> > I can work this around by having our own Windows stack walker - after
> > all the whole purpose  of the crash reporter was easy debug reports for
> > Windows users. Under Linux everyone knows how to use a debugger,
> > otherwise it's impossible to work ;-)
> I'm assuming that you mean that you are going to pull the
> wxDebugReporter code from the 3.1 branch of wxWidgets which can be
> removed once wxWidgets 3.2 becomes the default.  If it's any more than
> that, I would rather wait until 3.2 is available.
>
> >
> > Tom
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-09 Thread Wayne Stambaugh

Tom,

On 7/9/19 2:41 AM, Tomasz Wlostowski wrote:
> On 06/07/2019 21:10, Ian McInerney wrote:
>> Tom,
>>
>> Not to pile on the questions, but does the linux stack trace support
>> exist in the entire 3.0.x line, or how far back does it go? Currently,
>> the minimum version searched by cmake is 3.0.0, and some major linux
>> distros only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 to
>> name a few).
> 
> Hi,
> 
> Under liunx stack trace works fine in 3.0.2. Under Windows it's not
> implemented at all (unless using a crazy hack self-exception-raising
> hack that works only under MSVC).
> 
> I can work this around by having our own Windows stack walker - after
> all the whole purpose  of the crash reporter was easy debug reports for
> Windows users. Under Linux everyone knows how to use a debugger,
> otherwise it's impossible to work ;-)
I'm assuming that you mean that you are going to pull the
wxDebugReporter code from the 3.1 branch of wxWidgets which can be
removed once wxWidgets 3.2 becomes the default.  If it's any more than
that, I would rather wait until 3.2 is available.

> 
> Tom
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-06 Thread Ian McInerney

Tom,

Not to pile on the questions, but does the linux stack trace support exist
in the entire 3.0.x line, or how far back does it go? Currently, the
minimum version searched by cmake is 3.0.0, and some major linux distros
only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 to name a few).

-Ian

On Sat, Jul 6, 2019 at 8:57 PM Tomasz Wlostowski 
wrote:

> On 06/07/2019 09:04, Carsten Schoenert wrote:
> > Hi,
> >
> > Am 05.07.19 um 23:28 schrieb Ian McInerney:
> >> 3.1.x is essentially only available on the lesser-known distros and as
> >> additional packages for OpenSUSE. Aside from that, most distros run
> >> anything between 3.0.2 and 3.0.4. (see
> >> here: https://repology.org/project/wxwidgets/versions).
>
> Hi,
>
> wx 3.0.4 under Linux has stack trace support, so we don't need 3.1 for
> the crash reporter to work under Linux. wx 3.0.x under MSYS doesn't. I
> have no idea if it's a matter of build settings or just unimplemented
> feature, I'll have a look at this later in the eveing.
>
> Tom
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-06 Thread Tomasz Wlostowski

On 06/07/2019 09:04, Carsten Schoenert wrote:
> Hi,
> 
> Am 05.07.19 um 23:28 schrieb Ian McInerney:
>> 3.1.x is essentially only available on the lesser-known distros and as
>> additional packages for OpenSUSE. Aside from that, most distros run
>> anything between 3.0.2 and 3.0.4. (see
>> here: https://repology.org/project/wxwidgets/versions).

Hi,

wx 3.0.4 under Linux has stack trace support, so we don't need 3.1 for
the crash reporter to work under Linux. wx 3.0.x under MSYS doesn't. I
have no idea if it's a matter of build settings or just unimplemented
feature, I'll have a look at this later in the eveing.

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-06 Thread Carsten Schoenert

Hi,

Am 05.07.19 um 23:28 schrieb Ian McInerney:
> 3.1.x is essentially only available on the lesser-known distros and as
> additional packages for OpenSUSE. Aside from that, most distros run
> anything between 3.0.2 and 3.0.4. (see
> here: https://repology.org/project/wxwidgets/versions).

well, and that's for a simple reason Wayne has already written.

wxwidgets 3.0.x is the current version series marked as stable with no
API changes between releases.

And 3.1.x is the current development version of wxwidgets *with*
possible internal and external API modifications that make it hard for
distros to keep all depending packages in sync, it nearly impossible. So
no version 3.1.x is packaged in Debian at least for that reason. Not
even in experimental.

Once the API is set to frozen a new stable series of wxwidgets 3.2.x
will get released. Given the progress the wxwidgets development is
taking nobody can say a targeted date for a new stable release of wxwidgets.

-- 
Regards
Carsten Schoenert

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-05 Thread Ian McInerney

3.1.x is essentially only available on the lesser-known distros and as
additional packages for OpenSUSE. Aside from that, most distros run
anything between 3.0.2 and 3.0.4. (see here:
https://repology.org/project/wxwidgets/versions).

-Ian



On Fri, Jul 5, 2019 at 7:52 PM Wayne Stambaugh  wrote:

> Tom,
>
> On 7/4/19 8:54 AM, Tomasz Wlostowski wrote:
> > On 01/07/2019 23:49, Nick Østergaard wrote:
> >> Hello Tomasz
> >>
> >> Do you have any comments on the wxwidgets version?
> >
> > Hi Nick,
> >
> > I have 3.1.1 in my MSYS environment, probably manually built.
> >
> > We have two options:
> > - ask MSYS folks to update wxWidgets in the package repository,
> > - factor out stack trace implementation from newer wx version and
> > maintain it within kicad tree...
> >
> > Cheers,
> > Tom
> >
>
> AFAIK 3.1.1 (actually 3.1.2 is the latest development release) isn't
> readily available on most linux distros.  Do we really want to ship
> windows builds with 3.1.2 and linux builds with 3.0.4?  What does this
> mean in terms of crash reporter support not to mention any bugs
> introduced by the 3.1 branch of wxWidgets.  As much as I would hate to
> do it, we may have no choice but to factor out wxCrashReporter from the
> development branch of wxWidgets if we want to support it across all
> platforms.  Does wxCrashReporter in 3.0.4 have good enough linux support
> that it would make sense to create our own PKGBUILD for wxWidgets 3.1.2
> on msys2?
>
> Cheers,
>
> Wayne
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-05 Thread Wayne Stambaugh

Tom,

On 7/4/19 8:54 AM, Tomasz Wlostowski wrote:
> On 01/07/2019 23:49, Nick Østergaard wrote:
>> Hello Tomasz
>>
>> Do you have any comments on the wxwidgets version?
> 
> Hi Nick,
> 
> I have 3.1.1 in my MSYS environment, probably manually built.
> 
> We have two options:
> - ask MSYS folks to update wxWidgets in the package repository,
> - factor out stack trace implementation from newer wx version and
> maintain it within kicad tree...
> 
> Cheers,
> Tom
> 

AFAIK 3.1.1 (actually 3.1.2 is the latest development release) isn't
readily available on most linux distros.  Do we really want to ship
windows builds with 3.1.2 and linux builds with 3.0.4?  What does this
mean in terms of crash reporter support not to mention any bugs
introduced by the 3.1 branch of wxWidgets.  As much as I would hate to
do it, we may have no choice but to factor out wxCrashReporter from the
development branch of wxWidgets if we want to support it across all
platforms.  Does wxCrashReporter in 3.0.4 have good enough linux support
that it would make sense to create our own PKGBUILD for wxWidgets 3.1.2
on msys2?

Cheers,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-04 Thread Tomasz Wlostowski

On 01/07/2019 23:49, Nick Østergaard wrote:
> Hello Tomasz
> 
> Do you have any comments on the wxwidgets version?

Hi Nick,

I have 3.1.1 in my MSYS environment, probably manually built.

We have two options:
- ask MSYS folks to update wxWidgets in the package repository,
- factor out stack trace implementation from newer wx version and
maintain it within kicad tree...

Cheers,
Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-07-01 Thread Nick Østergaard

Hello Tomasz

Do you have any comments on the wxwidgets version?

It looks like 3.0.4 of wxwidgets is the latest version packaged in
msys2 as of today.

On Wed, 12 Jun 2019 at 23:58, Nick Østergaard  wrote:
>
> It looks like you mis-cited me there. That was Wayne that wrote that,
> I don't klnow about the details here.
>
> Anyway, the packages are shown on:
> https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/ws/pkglist.txt/*view*/
>
> mingw-w64-x86_64-wxWidgets 3.0.4-2
>
> On Wed, 12 Jun 2019 at 14:10, Tomasz Wlostowski
>  wrote:
> >
> > On 11/06/2019 22:29, Nick Østergaard wrote:
> > > Too bad the gcc windows
> > > build crash report doesn't have a stack trace.  Maybe MSVC builds would
> > > have more debug info.
> >
> > Hi Nick,
> >
> > My build (wx 3.1.1) under MSYS has stack traces. Which version of
> > wxWidgets did you use?
> >
> > Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-12 Thread Nick Østergaard

It looks like you mis-cited me there. That was Wayne that wrote that,
I don't klnow about the details here.

Anyway, the packages are shown on:
https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/ws/pkglist.txt/*view*/

mingw-w64-x86_64-wxWidgets 3.0.4-2

On Wed, 12 Jun 2019 at 14:10, Tomasz Wlostowski
 wrote:
>
> On 11/06/2019 22:29, Nick Østergaard wrote:
> > Too bad the gcc windows
> > build crash report doesn't have a stack trace.  Maybe MSVC builds would
> > have more debug info.
>
> Hi Nick,
>
> My build (wx 3.1.1) under MSYS has stack traces. Which version of
> wxWidgets did you use?
>
> Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-12 Thread Wayne Stambaugh

On 6/12/19 8:10 AM, Tomasz Wlostowski wrote:
> On 11/06/2019 22:29, Nick Østergaard wrote:
>> Too bad the gcc windows
>> build crash report doesn't have a stack trace.  Maybe MSVC builds would
>> have more debug info.
> 
> Hi Nick,
> 
> My build (wx 3.1.1) under MSYS has stack traces. Which version of
> wxWidgets did you use?
> 
> Tom
> 

3.0.4 which is the default package on windows with msys2.  It could be a
wxWidgets build configuration issue.  I don't know if any special config
option needs to be enabled to support stack traces.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-12 Thread Tomasz Wlostowski

On 11/06/2019 22:29, Nick Østergaard wrote:
> Too bad the gcc windows
> build crash report doesn't have a stack trace.  Maybe MSVC builds would
> have more debug info.

Hi Nick,

My build (wx 3.1.1) under MSYS has stack traces. Which version of
wxWidgets did you use?

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-11 Thread Nick Østergaard

Yes, that was the same commit I tested as mentioned earlier. Although
somehow added a "not" in the original message :)

On Tue, 11 Jun 2019 at 00:52, Wayne Stambaugh  wrote:
>
> Did you test the latest commit 2745a95b6b02c3864d6594503cc21619691cdd94?
>
> On 6/10/19 6:02 PM, Nick Østergaard wrote:
> > It didn't seem to work for the use case I described on windows last week.
> >
> > On Mon, 10 Jun 2019 at 23:51, Wayne Stambaugh  wrote:
> >>
> >> Hey Tom,
> >>
> >> On 6/4/2019 12:31 PM, Tomasz Wlostowski wrote:
> >>> On 04/06/2019 17:11, Tomasz Wlostowski wrote:
> >>>
>  Hi Wayne,
> 
>  It looks like I screwed up the exception handler under KiCad windows
>  shell. Will fix soon.
> >>>
> >>> Fixed in my github branch.
> >>>
> >>> T.
> >>>
> >>
> >> I just finished testing this on windows (32 and 64 bit) and it appears
> >> to work fine when launched from KiCad and stand alone mode.  I only
> >> tested it using your provided force crash menu entry so I don't know if
> >> it will work with a crash other than that.  Too bad the gcc windows
> >> build crash report doesn't have a stack trace.  Maybe MSVC builds would
> >> have more debug info.  It looks like it's ready to be merged for further
> >> testing.
> >>
> >> Cheers,
> >>
> >> Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-10 Thread Wayne Stambaugh

Did you test the latest commit 2745a95b6b02c3864d6594503cc21619691cdd94?

On 6/10/19 6:02 PM, Nick Østergaard wrote:
> It didn't seem to work for the use case I described on windows last week.
> 
> On Mon, 10 Jun 2019 at 23:51, Wayne Stambaugh  wrote:
>>
>> Hey Tom,
>>
>> On 6/4/2019 12:31 PM, Tomasz Wlostowski wrote:
>>> On 04/06/2019 17:11, Tomasz Wlostowski wrote:
>>>
 Hi Wayne,

 It looks like I screwed up the exception handler under KiCad windows
 shell. Will fix soon.
>>>
>>> Fixed in my github branch.
>>>
>>> T.
>>>
>>
>> I just finished testing this on windows (32 and 64 bit) and it appears
>> to work fine when launched from KiCad and stand alone mode.  I only
>> tested it using your provided force crash menu entry so I don't know if
>> it will work with a crash other than that.  Too bad the gcc windows
>> build crash report doesn't have a stack trace.  Maybe MSVC builds would
>> have more debug info.  It looks like it's ready to be merged for further
>> testing.
>>
>> Cheers,
>>
>> Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-10 Thread Nick Østergaard

It didn't seem to work for the use case I described on windows last week.

On Mon, 10 Jun 2019 at 23:51, Wayne Stambaugh  wrote:
>
> Hey Tom,
>
> On 6/4/2019 12:31 PM, Tomasz Wlostowski wrote:
> > On 04/06/2019 17:11, Tomasz Wlostowski wrote:
> >
> >> Hi Wayne,
> >>
> >> It looks like I screwed up the exception handler under KiCad windows
> >> shell. Will fix soon.
> >
> > Fixed in my github branch.
> >
> > T.
> >
>
> I just finished testing this on windows (32 and 64 bit) and it appears
> to work fine when launched from KiCad and stand alone mode.  I only
> tested it using your provided force crash menu entry so I don't know if
> it will work with a crash other than that.  Too bad the gcc windows
> build crash report doesn't have a stack trace.  Maybe MSVC builds would
> have more debug info.  It looks like it's ready to be merged for further
> testing.
>
> Cheers,
>
> Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-10 Thread Wayne Stambaugh

Hey Tom,

On 6/4/2019 12:31 PM, Tomasz Wlostowski wrote:
> On 04/06/2019 17:11, Tomasz Wlostowski wrote:
> 
>> Hi Wayne,
>>
>> It looks like I screwed up the exception handler under KiCad windows
>> shell. Will fix soon.
> 
> Fixed in my github branch.
> 
> T.
> 

I just finished testing this on windows (32 and 64 bit) and it appears
to work fine when launched from KiCad and stand alone mode.  I only
tested it using your provided force crash menu entry so I don't know if
it will work with a crash other than that.  Too bad the gcc windows
build crash report doesn't have a stack trace.  Maybe MSVC builds would
have more debug info.  It looks like it's ready to be merged for further
testing.

Cheers,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-05 Thread Nick Østergaard

You can testrun it on windows from:

https://kicad-downloads.s3.cern.ch/windows/testing/patched/kicad-patched-371-5.1.0-770-g8bf750311-x86_64.exe

On Wed, 5 Jun 2019 at 08:17, Eeli Kaikkonen  wrote:
>
> I'm trying to compile the reporter branch on Kubuntu. The official master 
> branch compiles fine. But with this branch I get a bunch of linking errors:
>
> debug_report.cpp:(.text._ZNSt6thread11_State_implINS_8_InvokerISt5tupleIJZN19DIALOG_CRASH_REPORT12OnSendReportER14wxCommandEventEUlvE_E6_M_runEv[_ZNSt6thread11_State_implINS_8_InvokerISt5tupleIJZN19DIALOG_CRASH_REPORT12OnSendReportER14wxCommandEventEUlvE_E6_M_runEv]+0x266):
>  undefined reference to `KICAD_CURL_EASY::~KICAD_CURL_EASY()'
> collect2: error: ld returned 1 exit status
>
> I created a new build dir so the old files shouldn't be a problem.
>
> I'm really waiting this for Windows nightly builds.
>
> Eeli Kaikkonen
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-05 Thread Eeli Kaikkonen

I'm trying to compile the reporter branch on Kubuntu. The official master
branch compiles fine. But with this branch I get a bunch of linking errors:

debug_report.cpp:(.text._ZNSt6thread11_State_implINS_8_InvokerISt5tupleIJZN19DIALOG_CRASH_REPORT12OnSendReportER14wxCommandEventEUlvE_E6_M_runEv[_ZNSt6thread11_State_implINS_8_InvokerISt5tupleIJZN19DIALOG_CRASH_REPORT12OnSendReportER14wxCommandEventEUlvE_E6_M_runEv]+0x266):
undefined reference to `KICAD_CURL_EASY::~KICAD_CURL_EASY()'
collect2: error: ld returned 1 exit status

I created a new build dir so the old files shouldn't be a problem.

I'm really waiting this for Windows nightly builds.

Eeli Kaikkonen
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard

I just tried to trigger a crash via the help menu and I see a fine
dialog, but that one I don't see for a real crash.

On Wed, 5 Jun 2019 at 00:12, Nick Østergaard  wrote:
>
> I mean: I am really on 2745a95b6
>
> On Wed, 5 Jun 2019 at 00:11, Nick Østergaard  wrote:
> >
> > Hello
> >
> > I just checkout out the crash reporter from Tom's branch. I am not on:
> > 2745a95b6 (HEAD, tom/tom-crash-reporter-may27) crash_reporter:
> > correctly install Windows exception handler under Kicad shell
> >
> > I found a place in eeschema where it crashes. Specifically:
> > 1. Open KiCad
> > 2. Load the sallen_key demo simulation project
> > 3. Start Eeschema
> > 4. File -> Export Netlist...
> > 5. Go to the Spice tab
> > 6. Click "Run Simulator" (Simulator command is empty)
> > 7. Crash here, but on the crash reporter branch it just freezes and
> > never completes. I did not see a new report being added to the link
> > sent by Maciej earlier.
> >
> > I am doing anything wrong? I am testing on archlinux.
> >
> > Nick
> >
> > On Tue, 4 Jun 2019 at 22:32, Wayne Stambaugh  wrote:
> > >
> > > On 6/4/19 12:31 PM, Tomasz Wlostowski wrote:
> > > > On 04/06/2019 17:11, Tomasz Wlostowski wrote:
> > > >
> > > >> Hi Wayne,
> > > >>
> > > >> It looks like I screwed up the exception handler under KiCad windows
> > > >> shell. Will fix soon.
> > > >
> > > > Fixed in my github branch.
> > > >
> > > > T.
> > > >
> > >
> > > As soon as I get home on Sunday, I will test it on windows.
> > >
> > > Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard

I mean: I am really on 2745a95b6

On Wed, 5 Jun 2019 at 00:11, Nick Østergaard  wrote:
>
> Hello
>
> I just checkout out the crash reporter from Tom's branch. I am not on:
> 2745a95b6 (HEAD, tom/tom-crash-reporter-may27) crash_reporter:
> correctly install Windows exception handler under Kicad shell
>
> I found a place in eeschema where it crashes. Specifically:
> 1. Open KiCad
> 2. Load the sallen_key demo simulation project
> 3. Start Eeschema
> 4. File -> Export Netlist...
> 5. Go to the Spice tab
> 6. Click "Run Simulator" (Simulator command is empty)
> 7. Crash here, but on the crash reporter branch it just freezes and
> never completes. I did not see a new report being added to the link
> sent by Maciej earlier.
>
> I am doing anything wrong? I am testing on archlinux.
>
> Nick
>
> On Tue, 4 Jun 2019 at 22:32, Wayne Stambaugh  wrote:
> >
> > On 6/4/19 12:31 PM, Tomasz Wlostowski wrote:
> > > On 04/06/2019 17:11, Tomasz Wlostowski wrote:
> > >
> > >> Hi Wayne,
> > >>
> > >> It looks like I screwed up the exception handler under KiCad windows
> > >> shell. Will fix soon.
> > >
> > > Fixed in my github branch.
> > >
> > > T.
> > >
> >
> > As soon as I get home on Sunday, I will test it on windows.
> >
> > Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Nick Østergaard

Hello

I just checkout out the crash reporter from Tom's branch. I am not on:
2745a95b6 (HEAD, tom/tom-crash-reporter-may27) crash_reporter:
correctly install Windows exception handler under Kicad shell

I found a place in eeschema where it crashes. Specifically:
1. Open KiCad
2. Load the sallen_key demo simulation project
3. Start Eeschema
4. File -> Export Netlist...
5. Go to the Spice tab
6. Click "Run Simulator" (Simulator command is empty)
7. Crash here, but on the crash reporter branch it just freezes and
never completes. I did not see a new report being added to the link
sent by Maciej earlier.

I am doing anything wrong? I am testing on archlinux.

Nick

On Tue, 4 Jun 2019 at 22:32, Wayne Stambaugh  wrote:
>
> On 6/4/19 12:31 PM, Tomasz Wlostowski wrote:
> > On 04/06/2019 17:11, Tomasz Wlostowski wrote:
> >
> >> Hi Wayne,
> >>
> >> It looks like I screwed up the exception handler under KiCad windows
> >> shell. Will fix soon.
> >
> > Fixed in my github branch.
> >
> > T.
> >
>
> As soon as I get home on Sunday, I will test it on windows.
>
> Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Wayne Stambaugh

On 6/4/19 12:31 PM, Tomasz Wlostowski wrote:
> On 04/06/2019 17:11, Tomasz Wlostowski wrote:
> 
>> Hi Wayne,
>>
>> It looks like I screwed up the exception handler under KiCad windows
>> shell. Will fix soon.
> 
> Fixed in my github branch.
> 
> T.
> 

As soon as I get home on Sunday, I will test it on windows.

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Tomasz Wlostowski

On 04/06/2019 17:11, Tomasz Wlostowski wrote:

> Hi Wayne,
> 
> It looks like I screwed up the exception handler under KiCad windows
> shell. Will fix soon.

Fixed in my github branch.

T.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-04 Thread Tomasz Wlostowski

On 03/06/2019 14:42, Wayne Stambaugh wrote:
> On 5/31/19 4:23 PM, Tomasz Wlostowski wrote:
>> On 30/05/2019 21:12, Wayne Stambaugh wrote:
>>> Nothing was displayed.  I was running from the project manager.  I even
>>> crashed the project manager.  I'm using msys2 to create mingw32 and
>>> mingw64 debug builds of KiCad.  I'm using wxWidgets 3.0.4 (not a debug
>>> build).  I did not check to see if the msys2 wxWidgets package builds
>>> are configured with wxDebugReport enabled so maybe that was the issue.
>>> I'll check the next time I'm in windows.  However, your debug reporter
>>> branch built fine so I suspect this was not the issue.
>>
>> Hi Wayne,
>>
>> Ddoes any window pop up when you trigger the crash from pcbnew running
>> in standalone mode? The only other difference I see is my wxWidgets
>> version is 3.1.1.
>>
>> Tom
>>
> 
> Tom,
> 
> I didn't test in the stand alone mode.  I'm traveling this week so I
> wont be able to test with windows again until I get home next weekend.
> As soon as I test the stand alone mode, I will let you know if it worked
> any differently than running from KiCad.
> 
Hi Wayne,

It looks like I screwed up the exception handler under KiCad windows
shell. Will fix soon.

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-03 Thread Wayne Stambaugh

On 5/31/19 4:23 PM, Tomasz Wlostowski wrote:
> On 30/05/2019 21:12, Wayne Stambaugh wrote:
>> Nothing was displayed.  I was running from the project manager.  I even
>> crashed the project manager.  I'm using msys2 to create mingw32 and
>> mingw64 debug builds of KiCad.  I'm using wxWidgets 3.0.4 (not a debug
>> build).  I did not check to see if the msys2 wxWidgets package builds
>> are configured with wxDebugReport enabled so maybe that was the issue.
>> I'll check the next time I'm in windows.  However, your debug reporter
>> branch built fine so I suspect this was not the issue.
> 
> Hi Wayne,
> 
> Ddoes any window pop up when you trigger the crash from pcbnew running
> in standalone mode? The only other difference I see is my wxWidgets
> version is 3.1.1.
> 
> Tom
> 

Tom,

I didn't test in the stand alone mode.  I'm traveling this week so I
wont be able to test with windows again until I get home next weekend.
As soon as I test the stand alone mode, I will let you know if it worked
any differently than running from KiCad.

Cheers,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-31 Thread Tomasz Wlostowski

On 30/05/2019 21:12, Wayne Stambaugh wrote:
> Nothing was displayed.  I was running from the project manager.  I even
> crashed the project manager.  I'm using msys2 to create mingw32 and
> mingw64 debug builds of KiCad.  I'm using wxWidgets 3.0.4 (not a debug
> build).  I did not check to see if the msys2 wxWidgets package builds
> are configured with wxDebugReport enabled so maybe that was the issue.
> I'll check the next time I'm in windows.  However, your debug reporter
> branch built fine so I suspect this was not the issue.

Hi Wayne,

Ddoes any window pop up when you trigger the crash from pcbnew running
in standalone mode? The only other difference I see is my wxWidgets
version is 3.1.1.

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-30 Thread Wayne Stambaugh

On 5/30/19 2:49 PM, Tomasz Wlostowski wrote:
> On 30/05/2019 16:46, Wayne Stambaugh wrote:
>> Hey Tom,
>>
>> On 5/29/2019 7:59 PM, Tomasz Wlostowski wrote:
>>> On 30/05/2019 00:35, Wayne Stambaugh wrote:
 A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up
 to date.

 A note to the lead dev team, please do not push your personal
 development branches to the main kicad repo.  Thanks.

>>>
>>> Hi Wayne,
>>>
>>> I hope I didn't push anything personal to the repo on Launchpad (if so,
>>> it could have happened by accident).
>>
>> No problem.  I see that your already removed it from the main repo.  Thanks.
>>
>>>
>>> Just in case, I attached the crash reporter as patches.
>>
>> I finally got the crash reporter to build on windows.  Just out of
>> curiosity, does the crash reporter not show anything to the user?  When
>> I force a crash using the menu entry, I don't see anything indicating
>> that a crash report was generated or where the crash information might
>> be saved.  Are my expectations out of line here or is there something
>> wrong with the crash reporter on windows builds.  I haven't tested this
>> on linux yet.  I should get to that later today.
>>
> 
> Hi Wayne,
> 
> It should show a big 'We're sorry, Kicad just crashed' window. Do you
> run KiCad standalone or from the project manager? What is your build
> configuration under Windows?
> 
> Tom
> 

Nothing was displayed.  I was running from the project manager.  I even
crashed the project manager.  I'm using msys2 to create mingw32 and
mingw64 debug builds of KiCad.  I'm using wxWidgets 3.0.4 (not a debug
build).  I did not check to see if the msys2 wxWidgets package builds
are configured with wxDebugReport enabled so maybe that was the issue.
I'll check the next time I'm in windows.  However, your debug reporter
branch built fine so I suspect this was not the issue.

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-30 Thread Tomasz Wlostowski

On 30/05/2019 16:46, Wayne Stambaugh wrote:
> Hey Tom,
> 
> On 5/29/2019 7:59 PM, Tomasz Wlostowski wrote:
>> On 30/05/2019 00:35, Wayne Stambaugh wrote:
>>> A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up
>>> to date.
>>>
>>> A note to the lead dev team, please do not push your personal
>>> development branches to the main kicad repo.  Thanks.
>>>
>>
>> Hi Wayne,
>>
>> I hope I didn't push anything personal to the repo on Launchpad (if so,
>> it could have happened by accident).
> 
> No problem.  I see that your already removed it from the main repo.  Thanks.
> 
>>
>> Just in case, I attached the crash reporter as patches.
> 
> I finally got the crash reporter to build on windows.  Just out of
> curiosity, does the crash reporter not show anything to the user?  When
> I force a crash using the menu entry, I don't see anything indicating
> that a crash report was generated or where the crash information might
> be saved.  Are my expectations out of line here or is there something
> wrong with the crash reporter on windows builds.  I haven't tested this
> on linux yet.  I should get to that later today.
> 

Hi Wayne,

It should show a big 'We're sorry, Kicad just crashed' window. Do you
run KiCad standalone or from the project manager? What is your build
configuration under Windows?

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-30 Thread Wayne Stambaugh

Hey Tom,

On 5/29/2019 7:59 PM, Tomasz Wlostowski wrote:
> On 30/05/2019 00:35, Wayne Stambaugh wrote:
>> A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up
>> to date.
>>
>> A note to the lead dev team, please do not push your personal
>> development branches to the main kicad repo.  Thanks.
>>
> 
> Hi Wayne,
> 
> I hope I didn't push anything personal to the repo on Launchpad (if so,
> it could have happened by accident).

No problem.  I see that your already removed it from the main repo.  Thanks.

> 
> Just in case, I attached the crash reporter as patches.

I finally got the crash reporter to build on windows.  Just out of
curiosity, does the crash reporter not show anything to the user?  When
I force a crash using the menu entry, I don't see anything indicating
that a crash report was generated or where the crash information might
be saved.  Are my expectations out of line here or is there something
wrong with the crash reporter on windows builds.  I haven't tested this
on linux yet.  I should get to that later today.

Wayne

> 
> Tom
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Seth Hillbrand


On 2019-05-29 05:47, Maciej Suminski wrote:

If everything works as expected, then you should be able to see your
reports in my test project bug tracker [1]. The crash reporter should
receive link to the new bug report in the HTTP response, so I guess it
could be shown to the user.

Once we are confident with the crash reporter, I will modify the HTTP
request handler to create bug reports directly in the KiCad bug 
tracker.


Cheers,
Orson

1.
https://bugs.launchpad.net/kicad-git-test/+bugs?field.tag=crash-reporter=-id=0



Hi Orson-

Still can't get the server to respond.  I captured the response data in 
KiCad:





500 Internal Server Error

Internal Server Error
The server encountered an internal error or
misconfiguration and was unable to complete
your request.
Please contact the server administrator at
 r...@orson.net.pl to inform them of the time this error occurred,
 and the actions you performed just before this error.
More information about this error may be available
in the server error log.




The response when using curl on the commandline works fine and it logs 
the bug report.


-Seth

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Tomasz Wlostowski

On 30/05/2019 00:35, Wayne Stambaugh wrote:
> A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up
> to date.
> 
> A note to the lead dev team, please do not push your personal
> development branches to the main kicad repo.  Thanks.
> 
It looks I'm the bad boy ;-) Just removed the accidentally pushed
Launchpad crash-reporter branch. Sorry for the confusion.

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Seth Hillbrand


Hi Wayne-

There are two similar branches there.  I was testing 
tom-crash-reporter-may27 (not tom-crash-reporter).  The line numbers in 
your error don't seem to match up with the ones I see.


-Seth

On 2019-05-29 18:35, Wayne Stambaugh wrote:

A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up
to date.

A note to the lead dev team, please do not push your personal
development branches to the main kicad repo.  Thanks.

Wayne

On 5/29/2019 5:32 PM, Nick Østergaard wrote:

Are you sure you did pull his latest changes?

It worked fine when I built it yesterday.

https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/369/

I just triggered a new build from his branch on github.

A sidenote: Could we delete the branch from the official github on
launchpad? And also the eemodern branch? I think they are confusing,
lets just have feature branches in personal repos.

On Wed, 29 May 2019 at 22:11, Wayne Stambaugh  
wrote:


Hey Tom,

On 5/29/2019 9:56 AM, Tomasz Wlostowski wrote:

On 29/05/2019 06:07, Seth Hillbrand wrote:

On 2019-05-28 12:13, Tomasz Wlostowski wrote:


Done (tom-crash-reporter-may27 on my Github)!

Tom


Hi Tom-

This looks very nice.  I like the implementation a lot!

Here are a couple minor bits:

1) The force crash dialog says "Clicking on OK will crash KiCad" 
but the

buttons say "Yes/No"
2) The crash report doesn't seem to pick up my build version
information.  It says:

KiCad crash report, version 1.0
--

application: kicad
version: , release build

3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
4) There's an untranslated string in OnSendReport ("Error sending 
cebug

report.")[sic]


Hi Seth,

Just pushed a fix for these. Thanks for testing!

Tom



I had no luck building this on windows both 32 and 64 bit builds.  
I'm

getting two build errors:

The first build error is not related to the debug reporting but this
error (and warning) is:

E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
function 'const wxString formatHex(uint64_t)':
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:150:27:
warning: format '%p' expects argument of type 'void*', but argument 4
has type 'size_t' {aka 'unsigned int'} [-Wformat=]
  150 | snprintf(tmp, 1024, "%p", (size_t) addr);
  |  ~^   ~
  |   |   |
  |   |   size_t {aka unsigned int}
  |   void*
  |  %d
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
member function 'void DEBUG_REPORT::buildVersionInfo(wxString&)':
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:277:61:
error: 'OCC_VERSION_COMPLETE' was not declared in this scope
  277 | aMsg << indent4 << "opencascade-community-edition: " <<
OCC_VERSION_COMPLETE << eol;
  |
^~~~
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
member function 'bool 
DEBUG_REPORT::AddContext(wxDebugReport::Context)':

E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:481:44:
error: expected '}' at end of input
  481 | buildExceptionContextInfo( exceptInfo );
  |^
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:469:1:
note: to match this '{'
  469 | {
  | ^
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:481:44:
warning: no return statement in function returning non-void 
[-Wreturn-type]

  481 | buildExceptionContextInfo( exceptInfo );
  |^
make[2]: *** [common/CMakeFiles/common.dir/build.make:1214:
common/CMakeFiles/common.dir/debug_report.cpp.obj] Error 1
make[2]: *** Waiting for unfinished jobs
make[1]: *** [CMakeFiles/Makefile2:264:
common/CMakeFiles/common.dir/all] Error 2
make: *** [Makefile:141: all] Error 2


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Wayne Stambaugh

A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up
to date.

A note to the lead dev team, please do not push your personal
development branches to the main kicad repo.  Thanks.

Wayne

On 5/29/2019 5:32 PM, Nick Østergaard wrote:
> Are you sure you did pull his latest changes?
> 
> It worked fine when I built it yesterday.
> 
> https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/369/
> 
> I just triggered a new build from his branch on github.
> 
> A sidenote: Could we delete the branch from the official github on
> launchpad? And also the eemodern branch? I think they are confusing,
> lets just have feature branches in personal repos.
> 
> On Wed, 29 May 2019 at 22:11, Wayne Stambaugh  wrote:
>>
>> Hey Tom,
>>
>> On 5/29/2019 9:56 AM, Tomasz Wlostowski wrote:
>>> On 29/05/2019 06:07, Seth Hillbrand wrote:
 On 2019-05-28 12:13, Tomasz Wlostowski wrote:
>
> Done (tom-crash-reporter-may27 on my Github)!
>
> Tom

 Hi Tom-

 This looks very nice.  I like the implementation a lot!

 Here are a couple minor bits:

 1) The force crash dialog says "Clicking on OK will crash KiCad" but the
 buttons say "Yes/No"
 2) The crash report doesn't seem to pick up my build version
 information.  It says:

 KiCad crash report, version 1.0
 --

 application: kicad
 version: , release build

 3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
 4) There's an untranslated string in OnSendReport ("Error sending cebug
 report.")[sic]

>>> Hi Seth,
>>>
>>> Just pushed a fix for these. Thanks for testing!
>>>
>>> Tom
>>>
>>
>> I had no luck building this on windows both 32 and 64 bit builds.  I'm
>> getting two build errors:
>>
>> The first build error is not related to the debug reporting but this
>> error (and warning) is:
>>
>> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
>> function 'const wxString formatHex(uint64_t)':
>> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:150:27:
>> warning: format '%p' expects argument of type 'void*', but argument 4
>> has type 'size_t' {aka 'unsigned int'} [-Wformat=]
>>   150 | snprintf(tmp, 1024, "%p", (size_t) addr);
>>   |  ~^   ~
>>   |   |   |
>>   |   |   size_t {aka unsigned int}
>>   |   void*
>>   |  %d
>> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
>> member function 'void DEBUG_REPORT::buildVersionInfo(wxString&)':
>> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:277:61:
>> error: 'OCC_VERSION_COMPLETE' was not declared in this scope
>>   277 | aMsg << indent4 << "opencascade-community-edition: " <<
>> OCC_VERSION_COMPLETE << eol;
>>   |
>> ^~~~
>> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
>> member function 'bool DEBUG_REPORT::AddContext(wxDebugReport::Context)':
>> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:481:44:
>> error: expected '}' at end of input
>>   481 | buildExceptionContextInfo( exceptInfo );
>>   |^
>> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:469:1:
>> note: to match this '{'
>>   469 | {
>>   | ^
>> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:481:44:
>> warning: no return statement in function returning non-void [-Wreturn-type]
>>   481 | buildExceptionContextInfo( exceptInfo );
>>   |^
>> make[2]: *** [common/CMakeFiles/common.dir/build.make:1214:
>> common/CMakeFiles/common.dir/debug_report.cpp.obj] Error 1
>> make[2]: *** Waiting for unfinished jobs
>> make[1]: *** [CMakeFiles/Makefile2:264:
>> common/CMakeFiles/common.dir/all] Error 2
>> make: *** [Makefile:141: all] Error 2

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Nick Østergaard

Are you sure you did pull his latest changes?

It worked fine when I built it yesterday.

https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/369/

I just triggered a new build from his branch on github.

A sidenote: Could we delete the branch from the official github on
launchpad? And also the eemodern branch? I think they are confusing,
lets just have feature branches in personal repos.

On Wed, 29 May 2019 at 22:11, Wayne Stambaugh  wrote:
>
> Hey Tom,
>
> On 5/29/2019 9:56 AM, Tomasz Wlostowski wrote:
> > On 29/05/2019 06:07, Seth Hillbrand wrote:
> >> On 2019-05-28 12:13, Tomasz Wlostowski wrote:
> >>>
> >>> Done (tom-crash-reporter-may27 on my Github)!
> >>>
> >>> Tom
> >>
> >> Hi Tom-
> >>
> >> This looks very nice.  I like the implementation a lot!
> >>
> >> Here are a couple minor bits:
> >>
> >> 1) The force crash dialog says "Clicking on OK will crash KiCad" but the
> >> buttons say "Yes/No"
> >> 2) The crash report doesn't seem to pick up my build version
> >> information.  It says:
> >>
> >> KiCad crash report, version 1.0
> >> --
> >>
> >> application: kicad
> >> version: , release build
> >>
> >> 3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
> >> 4) There's an untranslated string in OnSendReport ("Error sending cebug
> >> report.")[sic]
> >>
> > Hi Seth,
> >
> > Just pushed a fix for these. Thanks for testing!
> >
> > Tom
> >
>
> I had no luck building this on windows both 32 and 64 bit builds.  I'm
> getting two build errors:
>
> The first build error is not related to the debug reporting but this
> error (and warning) is:
>
> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
> function 'const wxString formatHex(uint64_t)':
> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:150:27:
> warning: format '%p' expects argument of type 'void*', but argument 4
> has type 'size_t' {aka 'unsigned int'} [-Wformat=]
>   150 | snprintf(tmp, 1024, "%p", (size_t) addr);
>   |  ~^   ~
>   |   |   |
>   |   |   size_t {aka unsigned int}
>   |   void*
>   |  %d
> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
> member function 'void DEBUG_REPORT::buildVersionInfo(wxString&)':
> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:277:61:
> error: 'OCC_VERSION_COMPLETE' was not declared in this scope
>   277 | aMsg << indent4 << "opencascade-community-edition: " <<
> OCC_VERSION_COMPLETE << eol;
>   |
> ^~~~
> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
> member function 'bool DEBUG_REPORT::AddContext(wxDebugReport::Context)':
> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:481:44:
> error: expected '}' at end of input
>   481 | buildExceptionContextInfo( exceptInfo );
>   |^
> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:469:1:
> note: to match this '{'
>   469 | {
>   | ^
> E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:481:44:
> warning: no return statement in function returning non-void [-Wreturn-type]
>   481 | buildExceptionContextInfo( exceptInfo );
>   |^
> make[2]: *** [common/CMakeFiles/common.dir/build.make:1214:
> common/CMakeFiles/common.dir/debug_report.cpp.obj] Error 1
> make[2]: *** Waiting for unfinished jobs
> make[1]: *** [CMakeFiles/Makefile2:264:
> common/CMakeFiles/common.dir/all] Error 2
> make: *** [Makefile:141: all] Error 2

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Wayne Stambaugh

Hey Tom,

On 5/29/2019 9:56 AM, Tomasz Wlostowski wrote:
> On 29/05/2019 06:07, Seth Hillbrand wrote:
>> On 2019-05-28 12:13, Tomasz Wlostowski wrote:
>>>
>>> Done (tom-crash-reporter-may27 on my Github)!
>>>
>>> Tom
>>
>> Hi Tom-
>>
>> This looks very nice.  I like the implementation a lot!
>>
>> Here are a couple minor bits:
>>
>> 1) The force crash dialog says "Clicking on OK will crash KiCad" but the
>> buttons say "Yes/No"
>> 2) The crash report doesn't seem to pick up my build version
>> information.  It says:
>>
>> KiCad crash report, version 1.0
>> --
>>
>> application: kicad
>> version: , release build
>>
>> 3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
>> 4) There's an untranslated string in OnSendReport ("Error sending cebug
>> report.")[sic]
>>
> Hi Seth,
> 
> Just pushed a fix for these. Thanks for testing!
> 
> Tom
> 

I had no luck building this on windows both 32 and 64 bit builds.  I'm
getting two build errors:

The first build error is not related to the debug reporting but this
error (and warning) is:

E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
function 'const wxString formatHex(uint64_t)':
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:150:27:
warning: format '%p' expects argument of type 'void*', but argument 4
has type 'size_t' {aka 'unsigned int'} [-Wformat=]
  150 | snprintf(tmp, 1024, "%p", (size_t) addr);
  |  ~^   ~
  |   |   |
  |   |   size_t {aka unsigned int}
  |   void*
  |  %d
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
member function 'void DEBUG_REPORT::buildVersionInfo(wxString&)':
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:277:61:
error: 'OCC_VERSION_COMPLETE' was not declared in this scope
  277 | aMsg << indent4 << "opencascade-community-edition: " <<
OCC_VERSION_COMPLETE << eol;
  |
^~~~
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
member function 'bool DEBUG_REPORT::AddContext(wxDebugReport::Context)':
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:481:44:
error: expected '}' at end of input
  481 | buildExceptionContextInfo( exceptInfo );
  |^
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:469:1:
note: to match this '{'
  469 | {
  | ^
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp:481:44:
warning: no return statement in function returning non-void [-Wreturn-type]
  481 | buildExceptionContextInfo( exceptInfo );
  |^
make[2]: *** [common/CMakeFiles/common.dir/build.make:1214:
common/CMakeFiles/common.dir/debug_report.cpp.obj] Error 1
make[2]: *** Waiting for unfinished jobs
make[1]: *** [CMakeFiles/Makefile2:264:
common/CMakeFiles/common.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Tomasz Wlostowski

On 29/05/2019 06:07, Seth Hillbrand wrote:
> On 2019-05-28 12:13, Tomasz Wlostowski wrote:
>>
>> Done (tom-crash-reporter-may27 on my Github)!
>>
>> Tom
> 
> Hi Tom-
> 
> This looks very nice.  I like the implementation a lot!
> 
> Here are a couple minor bits:
> 
> 1) The force crash dialog says "Clicking on OK will crash KiCad" but the
> buttons say "Yes/No"
> 2) The crash report doesn't seem to pick up my build version
> information.  It says:
> 
> KiCad crash report, version 1.0
> --
> 
> application: kicad
> version: , release build
> 
> 3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
> 4) There's an untranslated string in OnSendReport ("Error sending cebug
> report.")[sic]
> 
Hi Seth,

Just pushed a fix for these. Thanks for testing!

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Wayne Stambaugh

Thanks Frank!

On 5/29/2019 9:22 AM, Frank Severinsen wrote:
> Hi Wayne
> 
> Im guessing this one
> https://github.com/twlostow/kicad-dev/tree/tom-crash-reporter-may27
> 
> 
> Den 29. maj 2019 kl. 15.00.19 +02.00, skrev Wayne Stambaugh
> :
>> Tom,
>>
>> On 5/28/2019 12:13 PM, Tomasz Wlostowski wrote:
>>
>> On 27/05/2019 17:39, Seth Hillbrand wrote:
>>
>> On 2019-05-02 17:41, Tomasz Wlostowski wrote:
>>
>> On 02/05/2019 07:06, Wayne Stambaugh wrote:
>>
>>
>> By chance did you build with OCC instead of OCE which
>> is what I am
>> using?  Please fix this when you get a chance, I would
>> like to get this
>> merged but I need to be able to test.
>>
>> Why did your remove the GDK_* and GTK_* environment
>> variables from
>> APP_KICAD ctor?  Wont this break the compatibility
>> support we currently
>> have?
>>
>> I noticed quite a bit of trailing whitespace in
>> patches 5 and 10 so that
>> will need to be cleaned up.
>>
>> Please send me the link to your remote branch for
>> this.  It's easier for
>> me to just pull a branch into my repo than apply a
>> large patch set using
>> `git am`.
>>
>>
>> Hi Wayne,
>>
>> Probably I screwed something up while rebasing the code on
>> top of fresh
>> master. I'll check/fix the errors in the evening.
>>
>> Greetings from CO,
>> Tom
>>
>>
>> Ping!
>>
>>
>> Done (tom-crash-reporter-may27 on my Github)!
>>
>> Tom
>>
>>
>> What is your github user name? I'm have trouble finding your crash
>> reporter repo to test.
>>
>> Thanks,
>>
>> Wayne
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Frank Severinsen

Hi Wayne

Im guessing this one



Den 29. maj 2019 kl. 15.00.19 +02.00, skrev Wayne Stambaugh 
:

> Tom,
> 
> On 5/28/2019 12:13 PM, Tomasz Wlostowski wrote:
> 
> > On 27/05/2019 17:39, Seth Hillbrand wrote:
> > 
> > > On 2019-05-02 17:41, Tomasz Wlostowski wrote:
> > > 
> > > > On 02/05/2019 07:06, Wayne Stambaugh wrote:
> > > > 
> > > > > 
> > > > > By chance did you build with OCC instead of OCE which is what I am
> > > > > using? Please fix this when you get a chance, I would like to get this
> > > > > merged but I need to be able to test.
> > > > > 
> > > > > Why did your remove the GDK_* and GTK_* environment variables from
> > > > > APP_KICAD ctor? Wont this break the compatibility support we currently
> > > > > have?
> > > > > 
> > > > > I noticed quite a bit of trailing whitespace in patches 5 and 10 so 
> > > > > that
> > > > > will need to be cleaned up.
> > > > > 
> > > > > Please send me the link to your remote branch for this. It's easier 
> > > > > for
> > > > > me to just pull a branch into my repo than apply a large patch set 
> > > > > using
> > > > > `git am`.
> > > > > 
> > > > Hi Wayne,
> > > > 
> > > > Probably I screwed something up while rebasing the code on top of fresh
> > > > master. I'll check/fix the errors in the evening.
> > > > 
> > > > Greetings from CO,
> > > > Tom
> > > > 
> > > Ping!
> > > 
> > Done (tom-crash-reporter-may27 on my Github)!
> > 
> > Tom
> > 
> > 
> What is your github user name? I'm have trouble finding your crash
> reporter repo to test.
> 
> Thanks,
> 
> Wayne
> 
> ___
> Mailing list: 
> Post to : 
> Unsubscribe : 
> More help : 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Wayne Stambaugh

Tom,

On 5/28/2019 12:13 PM, Tomasz Wlostowski wrote:
> On 27/05/2019 17:39, Seth Hillbrand wrote:
>> On 2019-05-02 17:41, Tomasz Wlostowski wrote:
>>> On 02/05/2019 07:06, Wayne Stambaugh wrote:

 By chance did you build with OCC instead of OCE which is what I am
 using?  Please fix this when you get a chance, I would like to get this
 merged but I need to be able to test.

 Why did your remove the GDK_* and GTK_* environment variables from
 APP_KICAD ctor?  Wont this break the compatibility support we currently
 have?

 I noticed quite a bit of trailing whitespace in patches 5 and 10 so that
 will need to be cleaned up.

 Please send me the link to your remote branch for this.  It's easier for
 me to just pull a branch into my repo than apply a large patch set using
 `git am`.
>>>
>>> Hi Wayne,
>>>
>>> Probably I screwed something up while rebasing the code on top of fresh
>>> master. I'll check/fix the errors in the evening.
>>>
>>> Greetings from CO,
>>> Tom
>>
>> Ping!
> 
> Done (tom-crash-reporter-may27 on my Github)!
> 
> Tom
> 

What is your github user name?  I'm have trouble finding your crash
reporter repo to test.

Thanks,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Seth Hillbrand


That's interesting. I don't see it there yet.

Does your interface log the connections?  I'll send another today and 
check for it again.


-Seth

On 2019-05-29 05:47, Maciej Suminski wrote:

If everything works as expected, then you should be able to see your
reports in my test project bug tracker [1]. The crash reporter should
receive link to the new bug report in the HTTP response, so I guess it
could be shown to the user.

Once we are confident with the crash reporter, I will modify the HTTP
request handler to create bug reports directly in the KiCad bug 
tracker.


Cheers,
Orson

1.
https://bugs.launchpad.net/kicad-git-test/+bugs?field.tag=crash-reporter=-id=0

On 5/29/19 6:07 AM, Seth Hillbrand wrote:

On 2019-05-28 12:13, Tomasz Wlostowski wrote:


Done (tom-crash-reporter-may27 on my Github)!

Tom


Hi Tom-

This looks very nice.  I like the implementation a lot!

Here are a couple minor bits:

1) The force crash dialog says "Clicking on OK will crash KiCad" but 
the

buttons say "Yes/No"
2) The crash report doesn't seem to pick up my build version
information.  It says:

KiCad crash report, version 1.0
--

application: kicad
version: , release build

3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
4) There's an untranslated string in OnSendReport ("Error sending 
cebug

report.")[sic]


No showstopper issues from my testing here.  I'd like to implement a
configurable destination address (maybe preferences or environmental
variable) but that can wait until after it's merged.

Thanks Tom (and Thomas) for an excellent addition!

Best-
Seth

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-29 Thread Maciej Suminski

If everything works as expected, then you should be able to see your
reports in my test project bug tracker [1]. The crash reporter should
receive link to the new bug report in the HTTP response, so I guess it
could be shown to the user.

Once we are confident with the crash reporter, I will modify the HTTP
request handler to create bug reports directly in the KiCad bug tracker.

Cheers,
Orson

1.
https://bugs.launchpad.net/kicad-git-test/+bugs?field.tag=crash-reporter=-id=0

On 5/29/19 6:07 AM, Seth Hillbrand wrote:
> On 2019-05-28 12:13, Tomasz Wlostowski wrote:
>>
>> Done (tom-crash-reporter-may27 on my Github)!
>>
>> Tom
> 
> Hi Tom-
> 
> This looks very nice.  I like the implementation a lot!
> 
> Here are a couple minor bits:
> 
> 1) The force crash dialog says "Clicking on OK will crash KiCad" but the
> buttons say "Yes/No"
> 2) The crash report doesn't seem to pick up my build version
> information.  It says:
> 
> KiCad crash report, version 1.0
> --
> 
> application: kicad
> version: , release build
> 
> 3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
> 4) There's an untranslated string in OnSendReport ("Error sending cebug
> report.")[sic]
> 
> 
> No showstopper issues from my testing here.  I'd like to implement a
> configurable destination address (maybe preferences or environmental
> variable) but that can wait until after it's merged.
> 
> Thanks Tom (and Thomas) for an excellent addition!
> 
> Best-
> Seth
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-28 Thread Seth Hillbrand


On 2019-05-28 12:13, Tomasz Wlostowski wrote:


Done (tom-crash-reporter-may27 on my Github)!

Tom


Hi Tom-

This looks very nice.  I like the implementation a lot!

Here are a couple minor bits:

1) The force crash dialog says "Clicking on OK will crash KiCad" but the 
buttons say "Yes/No"
2) The crash report doesn't seem to pick up my build version 
information.  It says:


KiCad crash report, version 1.0
--

application: kicad
version: , release build

3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
4) There's an untranslated string in OnSendReport ("Error sending cebug 
report.")[sic]



No showstopper issues from my testing here.  I'd like to implement a 
configurable destination address (maybe preferences or environmental 
variable) but that can wait until after it's merged.


Thanks Tom (and Thomas) for an excellent addition!

Best-
Seth

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-28 Thread Tomasz Wlostowski

On 27/05/2019 17:39, Seth Hillbrand wrote:
> On 2019-05-02 17:41, Tomasz Wlostowski wrote:
>> On 02/05/2019 07:06, Wayne Stambaugh wrote:
>>>
>>> By chance did you build with OCC instead of OCE which is what I am
>>> using?  Please fix this when you get a chance, I would like to get this
>>> merged but I need to be able to test.
>>>
>>> Why did your remove the GDK_* and GTK_* environment variables from
>>> APP_KICAD ctor?  Wont this break the compatibility support we currently
>>> have?
>>>
>>> I noticed quite a bit of trailing whitespace in patches 5 and 10 so that
>>> will need to be cleaned up.
>>>
>>> Please send me the link to your remote branch for this.  It's easier for
>>> me to just pull a branch into my repo than apply a large patch set using
>>> `git am`.
>>
>> Hi Wayne,
>>
>> Probably I screwed something up while rebasing the code on top of fresh
>> master. I'll check/fix the errors in the evening.
>>
>> Greetings from CO,
>> Tom
> 
> Ping!

Done (tom-crash-reporter-may27 on my Github)!

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-27 Thread Tomasz Wlostowski

On 27/05/2019 17:39, Seth Hillbrand wrote:
> On 2019-05-02 17:41, Tomasz Wlostowski wrote:
>> On 02/05/2019 07:06, Wayne Stambaugh wrote:
>>>
>>> By chance did you build with OCC instead of OCE which is what I am
>>> using?  Please fix this when you get a chance, I would like to get this
>>> merged but I need to be able to test.
>>>
>>> Why did your remove the GDK_* and GTK_* environment variables from
>>> APP_KICAD ctor?  Wont this break the compatibility support we currently
>>> have?
>>>
>>> I noticed quite a bit of trailing whitespace in patches 5 and 10 so that
>>> will need to be cleaned up.
>>>
>>> Please send me the link to your remote branch for this.  It's easier for
>>> me to just pull a branch into my repo than apply a large patch set using
>>> `git am`.
>>
>> Hi Wayne,
>>
>> Probably I screwed something up while rebasing the code on top of fresh
>> master. I'll check/fix the errors in the evening.
>>
>> Greetings from CO,
>> Tom
> 
> Ping!

Hi Seth,

Rebasing it on the latest master right now. I'm still getting some
Windows build issues, hope to sort them out by tomorrow.

T.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-27 Thread Seth Hillbrand


On 2019-05-02 17:41, Tomasz Wlostowski wrote:

On 02/05/2019 07:06, Wayne Stambaugh wrote:


By chance did you build with OCC instead of OCE which is what I am
using?  Please fix this when you get a chance, I would like to get 
this

merged but I need to be able to test.

Why did your remove the GDK_* and GTK_* environment variables from
APP_KICAD ctor?  Wont this break the compatibility support we 
currently

have?

I noticed quite a bit of trailing whitespace in patches 5 and 10 so 
that

will need to be cleaned up.

Please send me the link to your remote branch for this.  It's easier 
for
me to just pull a branch into my repo than apply a large patch set 
using

`git am`.


Hi Wayne,

Probably I screwed something up while rebasing the code on top of fresh
master. I'll check/fix the errors in the evening.

Greetings from CO,
Tom


Ping!

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-02 Thread Tomasz Wlostowski

On 02/05/2019 07:06, Wayne Stambaugh wrote:
> Hey Tom,
> 
> I finally got around to testing this.  I could not get it to build on
> windows or linux.  I'm getting the following compiler error on both 32
> and 64 bit windows and linux builds:
> 
> E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp: In
> member function 'void DEBUG_REPORT::buildVersionInfo(wxString&)':
> E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp:292:61:
> error: 'OCC_VERSION_COMPLETE' was not declared in this scope
>  aMsg << indent4 << "opencascade-community-edition: " <<
> OCC_VERSION_COMPLETE << eol;
> 
> ^~~~
> [ 43%] Building CXX object common/CMakeFiles/common.dir/eagle_parser.cpp.obj
> E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp:292:61:
> note: suggested alternative: 'STG_E_INCOMPLETE'
>  aMsg << indent4 << "opencascade-community-edition: " <<
> OCC_VERSION_COMPLETE << eol;
> 
> ^~~~
> 
> STG_E_INCOMPLETE
> 
> By chance did you build with OCC instead of OCE which is what I am
> using?  Please fix this when you get a chance, I would like to get this
> merged but I need to be able to test.
> 
> Why did your remove the GDK_* and GTK_* environment variables from
> APP_KICAD ctor?  Wont this break the compatibility support we currently
> have?
> 
> I noticed quite a bit of trailing whitespace in patches 5 and 10 so that
> will need to be cleaned up.
> 
> Please send me the link to your remote branch for this.  It's easier for
> me to just pull a branch into my repo than apply a large patch set using
> `git am`.

Hi Wayne,

Probably I screwed something up while rebasing the code on top of fresh
master. I'll check/fix the errors in the evening.

Greetings from CO,
Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-05-02 Thread Wayne Stambaugh

Hey Tom,

I finally got around to testing this.  I could not get it to build on
windows or linux.  I'm getting the following compiler error on both 32
and 64 bit windows and linux builds:

E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp: In
member function 'void DEBUG_REPORT::buildVersionInfo(wxString&)':
E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp:292:61:
error: 'OCC_VERSION_COMPLETE' was not declared in this scope
 aMsg << indent4 << "opencascade-community-edition: " <<
OCC_VERSION_COMPLETE << eol;

^~~~
[ 43%] Building CXX object common/CMakeFiles/common.dir/eagle_parser.cpp.obj
E:/msys64/home/Wayne/src/kicad-lp-clone/common/debug_report.cpp:292:61:
note: suggested alternative: 'STG_E_INCOMPLETE'
 aMsg << indent4 << "opencascade-community-edition: " <<
OCC_VERSION_COMPLETE << eol;

^~~~

STG_E_INCOMPLETE

By chance did you build with OCC instead of OCE which is what I am
using?  Please fix this when you get a chance, I would like to get this
merged but I need to be able to test.

Why did your remove the GDK_* and GTK_* environment variables from
APP_KICAD ctor?  Wont this break the compatibility support we currently
have?

I noticed quite a bit of trailing whitespace in patches 5 and 10 so that
will need to be cleaned up.

Please send me the link to your remote branch for this.  It's easier for
me to just pull a branch into my repo than apply a large patch set using
`git am`.

Thanks,

Wayne

On 4/14/2019 6:50 PM, Tomasz Wlostowski wrote:
> Dear all,
> 
> The attached patchset introduces a builtin crash reporter for Kicad -
> that is a window that pops up in case of a segmentation fault/other
> serious error, kindly apologizes to the user and lets him/her submit
> (anonymously) a bug report to us. It's loosely based on wxDebugReport,
> with a lot of new code (i.e. stack walker for windows or more meaningful
> report format...).
> 
> This is particularly targeted at Windows/OSX users, since getting a
> useful stack trace on these systems is considerably more difficult (at
> least for non-programmers) than on (L)Unixes.
> 
> I invite you to test it, in case recent KiCad nightlies have become too
> stable, you can always simulate a crash through 'Help->Simulate Kicad
> Crash'.
> 
> Cheers,
> Tom
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Carsten Schoenert

Hello,

Am 16.04.19 um 23:25 schrieb Mark Roszko:
> Just to throw it out there
> 
> Did you consider at all at using something off the shelf such as
> Breakpad which both Mozilla and Chrome use?
> https://wiki.mozilla.org/Breakpad 
> https://github.com/google/breakpad

this has also some downsides.
The breakpad thing is nice for companies and projects that do provide
ready to use binary packages no matter for Windows, Linux or MacOS
platforms, just because they already know addresses from the used
symbols and functions from the generated binaries. The backtraces are
small and quite really anonymous and will mostly just hold signatures
and hashes.

But for all packages from the various Linux distributions you would need
to know some internals from the build of the binaries and the packages
later. You would also need a possibilities where the package creater
could upload all these data plus a framework as a helper for doing this all.

I've tried to get this all together for the Thunderbird package in
Debian but due the complexity and the amount of work I haven't finished
anything since almost two years.

Not that the breakpad package is bad thing, no it's not! And I haven't
looked into any implementation details from Tom. But for now I wouldn't
hardly focus on this. And there wont be the one and only solution in the
end I guess. But you need to start somewhere.

-- 
Regards
Carsten Schoenert

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Tomasz Wlostowski

On 16/04/2019 23:25, Mark Roszko wrote:
> Just to throw it out there
> 
> Did you consider at all at using something off the shelf such as
> Breakpad which both Mozilla and Chrome use?
> https://wiki.mozilla.org/Breakpad 
> https://github.com/google/breakpad

Hi Mark,

I took some inspiration from Mozilla (mainly the 'apologies' text ;-),
but never had a serious look at Breakpad. I'm worried how many external
dependencies it would bring (both on the software packaging and server
side). Has anybody here used it?

> 
> There's then some off the shelf software potentially for processing
> Breakpad reports such as this service:
> https://help.backtrace.io/pricing-data-protection-privacy-and-terms/pricing-and-tiers/backtrace-for-open-source
>  
For the moment, the reporter uses a simple YAML-based format that is
both human- and machine-readable. As such it's IMHO already quite
useful, especially for tracking down Windows bugs (have you ever used
GDB under Windows? :D)

> 
> 
> Also do the data reports avoid identifying info such as usernames which
> might fall under GDPR? Not to mention we'll need a privacy notice added
> in somewhere anyway for collecting data.

The user can always review the report text and (s)he's informed about
this. No data is sent automatically. The report doesn't contain the
username unless there's some DLLs/executables linked to KiCad existing
in the home directory. No other personal data is collected (unless paths
to system libraries/CPU register values/stack trace are considered
personal data).

Cheers,
Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Tomasz Wlostowski

On 16/04/2019 22:52, Seth Hillbrand wrote:
> Am 2019-04-14 18:50, schrieb Tomasz Wlostowski:
>> Dear all,
>>
>> The attached patchset introduces a builtin crash reporter for Kicad -
>> that is a window that pops up in case of a segmentation fault/other
>> serious error, kindly apologizes to the user and lets him/her submit
>> (anonymously) a bug report to us. It's loosely based on wxDebugReport,
>> with a lot of new code (i.e. stack walker for windows or more meaningful
>> report format...).
>>
>> This is particularly targeted at Windows/OSX users, since getting a
>> useful stack trace on these systems is considerably more difficult (at
>> least for non-programmers) than on (L)Unixes.
>>
>> I invite you to test it, in case recent KiCad nightlies have become too
>> stable, you can always simulate a crash through 'Help->Simulate Kicad
>> Crash'.
>>
>> Cheers,
>> Tom
> 
> 
> Hi Tom-
> 
> I'm very happy to see these patches and am excited to try them out! 
> Unfortunately, like others, I won't have time to really poke at this
> until after KiCon.  But if others are comfortable with it, please don't
> wait for me.

Thanks Seth, no rush. See you in Chicago :)

> 
> One addition that would be nice is making the destination URL and
> enabling/disabling of the reporter advanced config settings instead of
> defines.

Good idea. I can add this.

Tom

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Mark Roszko

Just to throw it out there

Did you consider at all at using something off the shelf such as Breakpad
which both Mozilla and Chrome use?
https://wiki.mozilla.org/Breakpad
https://github.com/google/breakpad

There's then some off the shelf software potentially for processing
Breakpad reports such as this service:
https://help.backtrace.io/pricing-data-protection-privacy-and-terms/pricing-and-tiers/backtrace-for-open-source



Also do the data reports avoid identifying info such as usernames which
might fall under GDPR? Not to mention we'll need a privacy notice added in
somewhere anyway for collecting data.


On Sun, Apr 14, 2019 at 6:50 PM Tomasz Wlostowski 
wrote:

> Dear all,
>
> The attached patchset introduces a builtin crash reporter for Kicad -
> that is a window that pops up in case of a segmentation fault/other
> serious error, kindly apologizes to the user and lets him/her submit
> (anonymously) a bug report to us. It's loosely based on wxDebugReport,
> with a lot of new code (i.e. stack walker for windows or more meaningful
> report format...).
>
> This is particularly targeted at Windows/OSX users, since getting a
> useful stack trace on these systems is considerably more difficult (at
> least for non-programmers) than on (L)Unixes.
>
> I invite you to test it, in case recent KiCad nightlies have become too
> stable, you can always simulate a crash through 'Help->Simulate Kicad
> Crash'.
>
> Cheers,
> Tom
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


-- 
Mark
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Wayne Stambaugh

Tom,

On 4/16/19 4:52 PM, Seth Hillbrand wrote:
> Am 2019-04-14 18:50, schrieb Tomasz Wlostowski:
>> Dear all,
>>
>> The attached patchset introduces a builtin crash reporter for Kicad -
>> that is a window that pops up in case of a segmentation fault/other
>> serious error, kindly apologizes to the user and lets him/her submit
>> (anonymously) a bug report to us. It's loosely based on wxDebugReport,
>> with a lot of new code (i.e. stack walker for windows or more meaningful
>> report format...).
>>
>> This is particularly targeted at Windows/OSX users, since getting a
>> useful stack trace on these systems is considerably more difficult (at
>> least for non-programmers) than on (L)Unixes.
>>
>> I invite you to test it, in case recent KiCad nightlies have become too
>> stable, you can always simulate a crash through 'Help->Simulate Kicad
>> Crash'.
>>
>> Cheers,
>> Tom
> 
> 
> Hi Tom-
> 
> I'm very happy to see these patches and am excited to try them out! 
> Unfortunately, like others, I won't have time to really poke at this
> until after KiCon.  But if others are comfortable with it, please don't
> wait for me.
> 
> One addition that would be nice is making the destination URL and
> enabling/disabling of the reporter advanced config settings instead of
> defines.
> 
> Best-
> Seth
> 

I'm in the same boat as Seth.  I will do my best to look at it as soon
as possible but I've got a lot going on between now and KiCon so it may
not happen until afterwards.

Cheers,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-04-16 Thread Seth Hillbrand


Am 2019-04-14 18:50, schrieb Tomasz Wlostowski:

Dear all,

The attached patchset introduces a builtin crash reporter for Kicad -
that is a window that pops up in case of a segmentation fault/other
serious error, kindly apologizes to the user and lets him/her submit
(anonymously) a bug report to us. It's loosely based on wxDebugReport,
with a lot of new code (i.e. stack walker for windows or more 
meaningful

report format...).

This is particularly targeted at Windows/OSX users, since getting a
useful stack trace on these systems is considerably more difficult (at
least for non-programmers) than on (L)Unixes.

I invite you to test it, in case recent KiCad nightlies have become too
stable, you can always simulate a crash through 'Help->Simulate Kicad
Crash'.

Cheers,
Tom



Hi Tom-

I'm very happy to see these patches and am excited to try them out!  
Unfortunately, like others, I won't have time to really poke at this 
until after KiCon.  But if others are comfortable with it, please don't 
wait for me.


One addition that would be nice is making the destination URL and 
enabling/disabling of the reporter advanced config settings instead of 
defines.


Best-
Seth

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

66 matches

Mail list logo